naiveai: if you want to switch the plugins you'll have to port the entire project :P
2018-01-16 01608, 2018
naiveai
Leo_Verto: yeah, I've been trying to find an alternative approach
2018-01-16 01615, 2018
Leo_Verto
but yeah, I definitely want to do that at some point in the future, probably after the current refactoring/throwing old stuff out spree though
2018-01-16 01635, 2018
naiveai
Leo_Verto: encoding is the main problem - I can't match 👍 in a regex
2018-01-16 01621, 2018
Leo_Verto
naiveai: again, scope creep, stick to what we've discussed for now
2018-01-16 01652, 2018
naiveai
Leo_Verto: i don't really think it's scope creep since you did say we should be able to handle unicode
2018-01-16 01630, 2018
naiveai
I have a flexible enough design that I can add any arbritary character as a for/against, so I need that to work with unicode
2018-01-16 01637, 2018
Leo_Verto
unicode in vote name/options, yes, but you're adding another voting alias :P
2018-01-16 01623, 2018
Leo_Verto
I really just want to get 1.0 of this done, you can implement all the other stuff afterwards
2018-01-16 01648, 2018
naiveai
ok, lemme try just a little other things and then go on to tests, which shouldn't take that long
2018-01-16 01601, 2018
sampsyo has quit
2018-01-16 01624, 2018
antlarr2 is now known as antlarr
2018-01-16 01629, 2018
sampsyo joined the channel
2018-01-16 01615, 2018
KassOtsimine joined the channel
2018-01-16 01650, 2018
Gore|unemployed is now known as Gore|HasStoppedW
2018-01-16 01601, 2018
Gore|HasStoppedW is now known as Gore|unemployed
2018-01-16 01613, 2018
Hszzzzz has quit
2018-01-16 01643, 2018
UmkaDK joined the channel
2018-01-16 01635, 2018
UmkaDK has quit
2018-01-16 01617, 2018
UmkaDK joined the channel
2018-01-16 01609, 2018
Nyanko-sensei joined the channel
2018-01-16 01611, 2018
github joined the channel
2018-01-16 01611, 2018
github
[musicbrainz-server] samj1912 opened pull request #601: Revert "Fix SEARCH_X_ACCEL_REDIRECT to work with solr" (master...revert-600-solr) https://git.io/vNlGQ
2018-01-16 01611, 2018
github has left the channel
2018-01-16 01621, 2018
D4RK-PH0ENiX has quit
2018-01-16 01615, 2018
github joined the channel
2018-01-16 01615, 2018
github
[listenbrainz-server] mzfr opened pull request #336: Fixed bad URL in Docs [LB-280] (master...LB-280) https://git.io/vNlZs
2018-01-16 01615, 2018
github has left the channel
2018-01-16 01645, 2018
heyoni joined the channel
2018-01-16 01641, 2018
UmkaDK_ joined the channel
2018-01-16 01650, 2018
UmkaDK has quit
2018-01-16 01612, 2018
D4RK-PH0ENiX joined the channel
2018-01-16 01613, 2018
xps2 joined the channel
2018-01-16 01635, 2018
Nyanko-sensei has quit
2018-01-16 01632, 2018
naiveai
Leo_Verto: you remember the thing with the em-dash I talked about earlier? it works if I do it in the channel with `honcho start`, but not while running a test
2018-01-16 01646, 2018
naiveai
presumably because the implementation of DummyApp is different in some way
2018-01-16 01658, 2018
naiveai
Leo_Verto: for the moment I'm giving up on handling anything unicode at all
naiveai: ah yeah, botbot_shell has practically no unicode support but that's a limitation of a python 2 internal
2018-01-16 01632, 2018
Leo_Verto
naiveai: that test looks okay to me, although I kinda feel like our current way of testing plugins could be generally improved quite a bit
2018-01-16 01652, 2018
Leo_Verto
but yeah, not worse than the tests I've written :P
2018-01-16 01657, 2018
naiveai
yeah, to have it in some easy to write interactive mode
2018-01-16 01603, 2018
naiveai
but for now, it looks ok
2018-01-16 01606, 2018
Leo_Verto
I'd like to somewhat automate testing in the future, e.g. provide the command structure and automagically test different combinations of unicode, whitespace, etc.
2018-01-16 01611, 2018
naiveai
Leo_Verto: also, where should I call flushall() on fakeredis? if one of my tests fails before the !endvote is called then it seems fakeredis still has the data stored
2018-01-16 01642, 2018
Leo_Verto
a new test function should start with a clean fakeredis
2018-01-16 01629, 2018
naiveai
huh
2018-01-16 01606, 2018
naiveai
it doesn't seem to be to be the case when I'm running
2018-01-16 01646, 2018
yvanzo
Rotab: This is a small bug which is triggered when an edit is ninjaed in between 2am and the time subscriptions are processed.
2018-01-16 01616, 2018
naiveai
if I comment out the !endvote in one of my tests, the next test's !startvote complains that a vote is already running
2018-01-16 01635, 2018
naiveai
Leo_Verto: is this a bug on the plugin side?
2018-01-16 01626, 2018
naiveai
Freso: not sure what you mean by keeping the namespace contained in your comment on OTHER-321
naiveai: Instead of taking up "_{startvote,endvote,countvote,vote,…}" you only take up "_{vote}" in BB's command namespace.
2018-01-16 01621, 2018
naiveai
I don't see how that's particularly a bad thing, given that those names are extremely unlikely to correspond to anything else
2018-01-16 01641, 2018
Freso
"extremely unlike" ≠ impossible :)
2018-01-16 01602, 2018
naiveai
so should I rewrite it now?
2018-01-16 01611, 2018
naiveai
Leo_Verto: what do you think?
2018-01-16 01625, 2018
Leo_Verto
I haven't talked about that because I have mixed feelings
2018-01-16 01650, 2018
Leo_Verto
with !vote <cmd> you wouldn't have to worry about whether it's !countvote or !countvotes, it'd obviously be !vote count
2018-01-16 01657, 2018
naiveai
aliases
2018-01-16 01611, 2018
naiveai
I'll make countvote the same thing as countvotes
2018-01-16 01637, 2018
Leo_Verto
however from (albeit limited) experience, it seems less technical users don't "get" the !vote <cmd> syntax and would prefer a single command in some cases
2018-01-16 01647, 2018
Leo_Verto
although "less technical users" really isn't a problem here
2018-01-16 01624, 2018
Leo_Verto
how much of what you've done would you have to tear up to make the change?
2018-01-16 01600, 2018
Leo_Verto
essentially this would mean moving everything to a single "listens_to_command" except for the shorthands, wouldn't it?
2018-01-16 01644, 2018
naiveai
I'd have to change the vote command regex to something like "(count|start|end)(?P<args>.*)", then parse those args dyamically to correspond to the command, and then call the method corresponding to it.
2018-01-16 01618, 2018
naiveai
(I think I've made it clear that I heavily, heavily dislike this idea btw)
2018-01-16 01614, 2018
Leo_Verto
Freso: are you okay with keeping it the way it's currently implemented? we can always change it later if it causes too much trouble
2018-01-16 01628, 2018
Freso
Yeah, sure.
2018-01-16 01645, 2018
naiveai
It's not like world-changinly hard, but it does require a fair amount of restructuring and rethinking
2018-01-16 01612, 2018
naiveai
it'll push back this to like, today-end at best and tomorrow at worst
2018-01-16 01640, 2018
KassOtsimine has quit
2018-01-16 01613, 2018
KassOtsimine joined the channel
2018-01-16 01629, 2018
naiveai
so, right now I'm not doing this, since I want to make some changes to the plugin anyway, we can discuss this in more depth later, when people have used it and I'll then act on the consensus
2018-01-16 01619, 2018
Leo_Verto
sure, focus on getting the tests and help for 1.0 done so I can accept a PR :P
2018-01-16 01649, 2018
phw joined the channel
2018-01-16 01653, 2018
phw has quit
2018-01-16 01637, 2018
phw joined the channel
2018-01-16 01620, 2018
phw is now known as outsidecontext
2018-01-16 01610, 2018
outsidecontext has quit
2018-01-16 01625, 2018
phw joined the channel
2018-01-16 01657, 2018
phw is now known as outsidecontext
2018-01-16 01639, 2018
outsidecontext has quit
2018-01-16 01654, 2018
outsidecontext joined the channel
2018-01-16 01633, 2018
Leo_Verto
naiveai: I'll be on the road for most of the evening, I'll try to check in inbetween
hey everyone, I'm submitting some listens to the listenbrainz API and somehow the additional_information.track_id and additional_information.release_id values are not taken into account (the track name and album name are not clickable in my profile)
