#metabrainz

naiveai: if you want to switch the plugins you'll have to port the entire project :P

Leo_Verto: yeah, I've been trying to find an alternative approach

but yeah, I definitely want to do that at some point in the future, probably after the current refactoring/throwing old stuff out spree though

Leo_Verto: encoding is the main problem - I can't match 👍 in a regex

naiveai: again, scope creep, stick to what we've discussed for now

Leo_Verto: i don't really think it's scope creep since you did say we should be able to handle unicode

I have a flexible enough design that I can add any arbritary character as a for/against, so I need that to work with unicode

unicode in vote name/options, yes, but you're adding another voting alias :P

I really just want to get 1.0 of this done, you can implement all the other stuff afterwards

ok, lemme try just a little other things and then go on to tests, which shouldn't take that long

[musicbrainz-server] samj1912 opened pull request #601: Revert "Fix SEARCH_X_ACCEL_REDIRECT to work with solr" (master...revert-600-solr) https://git.io/vNlGQ

[listenbrainz-server] mzfr opened pull request #336: Fixed bad URL in Docs [LB-280] (master...LB-280) https://git.io/vNlZs

Leo_Verto: you remember the thing with the em-dash I talked about earlier? it works if I do it in the channel with `honcho start`, but not while running a test

presumably because the implementation of DummyApp is different in some way

Leo_Verto: for the moment I'm giving up on handling anything unicode at all

bitmap: No worries. :)

Leo_Verto: Is this good structure for a test? https://gist.github.com/naiveaiguy/565e4f17b238...

what's the deal with duplicate "Edits for your subscriptions" musicbrainz emails? i got the same one today as yesterday

[picard-plugins] MetaTunes reopened pull request #139: v0.9 of Classical Extras (1.0...1.0) https://git.io/vNWwZ

Rotab: about subscribed entities?

+which

yvanzo: https://musicbrainz.org/artist/5b48a7c8-b450-4b... & https://musicbrainz.org/artist/98dcfec0-0f20-4a...

naiveai: ah yeah, botbot_shell has practically no unicode support but that's a limitation of a python 2 internal

naiveai: that test looks okay to me, although I kinda feel like our current way of testing plugins could be generally improved quite a bit

but yeah, not worse than the tests I've written :P

yeah, to have it in some easy to write interactive mode

but for now, it looks ok

I'd like to somewhat automate testing in the future, e.g. provide the command structure and automagically test different combinations of unicode, whitespace, etc.

Leo_Verto: also, where should I call flushall() on fakeredis? if one of my tests fails before the !endvote is called then it seems fakeredis still has the data stored

a new test function should start with a clean fakeredis

huh

it doesn't seem to be to be the case when I'm running

Rotab: This is a small bug which is triggered when an edit is ninjaed in between 2am and the time subscriptions are processed.

if I comment out the !endvote in one of my tests, the next test's !startvote complains that a vote is already running

Leo_Verto: is this a bug on the plugin side?

Freso: not sure what you mean by keeping the namespace contained in your comment on OTHER-321

OTHER-321: BrainzBot Plugin for Counting Votes. https://tickets.metabrainz.org/browse/OTHER-321

yvanzo: ah, alright :)

naiveai: Instead of taking up "_{startvote,endvote,countvote,vote,…}" you only take up "_{vote}" in BB's command namespace.

I don't see how that's particularly a bad thing, given that those names are extremely unlikely to correspond to anything else

"extremely unlike" ≠ impossible :)

so should I rewrite it now?

Leo_Verto: what do you think?

I haven't talked about that because I have mixed feelings

with !vote <cmd> you wouldn't have to worry about whether it's !countvote or !countvotes, it'd obviously be !vote count

aliases

I'll make countvote the same thing as countvotes

however from (albeit limited) experience, it seems less technical users don't "get" the !vote <cmd> syntax and would prefer a single command in some cases

although "less technical users" really isn't a problem here

how much of what you've done would you have to tear up to make the change?

essentially this would mean moving everything to a single "listens_to_command" except for the shorthands, wouldn't it?

I'd have to change the vote command regex to something like "(count|start|end)(?P<args>.*)", then parse those args dyamically to correspond to the command, and then call the method corresponding to it.

(I think I've made it clear that I heavily, heavily dislike this idea btw)

Freso: are you okay with keeping it the way it's currently implemented? we can always change it later if it causes too much trouble

Yeah, sure.

It's not like world-changinly hard, but it does require a fair amount of restructuring and rethinking

it'll push back this to like, today-end at best and tomorrow at worst

so, right now I'm not doing this, since I want to make some changes to the plugin anyway, we can discuss this in more depth later, when people have used it and I'll then act on the consensus

sure, focus on getting the tests and help for 1.0 done so I can accept a PR :P

naiveai: I'll be on the road for most of the evening, I'll try to check in inbetween

np

Leo_Verto, Freso: https://github.com/metabrainz/brainzbot-plugins.... Through a happy accident, as I just realized, the issue is OTHER-321, and the PR is #10. :D

OTHER-321: BrainzBot Plugin for Counting Votes. https://tickets.metabrainz.org/browse/OTHER-321

hey everyone, I'm submitting some listens to the listenbrainz API and somehow the additional_information.track_id and additional_information.release_id values are not taken into account (the track name and album name are not clickable in my profile)

taken from here https://listenbrainz.readthedocs.io/en/latest/d...

[picard-plugins] MetaTunes closed pull request #139: v0.9 of Classical Extras (1.0...1.0) https://git.io/vNWwZ

scope creep, but yea yo ushould be able to handle 👍 it's like, freso terminology <3

but yea.. no biggie :)

[picard-plugins] MetaTunes opened pull request #140: Classical Extras v0.9 (2nd attempt) (1.0...1.0) https://git.io/vNlil

KassOtsimine: trust me, I tried a lot. I honestly 100% can't figure out how to do it. it'll probably come as a later expansion

yea. don't worry about it. I wasn't beeing too serious :)

really wish my connection would improve soon

Paid DLC!

fixed the issue with submitting to the listenbrainz api, I was sending track_id instead of recording_id

reosarevok: ?

The later expansion :D

to what??

"KassOtsimine: trust me, I tried a lot. I honestly 100% can't figure out how to do it. it'll probably come as a later expansion"

(made it to Lapland. No reindeer so far but there's a doggo)

doggos!

aahh

what sort of dog?

No idea. A sort :D

No pictures just yet, he's in the main house of the complex

And there's quiite a lot of snow

:D