9:04 AM
samj1912
but it just doesn't make sense to have so many related global variables and not put them under a class
2018-01-28 02834, 2018
9:04 AM
zas
i was pondering on having a defaultdict with a namedtuple (since all those globals are defaultdict with shared keys)
2018-01-28 02857, 2018
9:04 AM
samj1912
hmm, I was thinking of having a rate control class per api_helper
2018-01-28 02801, 2018
9:05 AM
samj1912
since it makes sense
2018-01-28 02817, 2018
9:05 AM
samj1912
not sure really
2018-01-28 02823, 2018
9:05 AM
zas
so convert to class and instancy ?
2018-01-28 02835, 2018
9:05 AM
samj1912
and we still dont handle ratecontrol when different methods have different rate limits
2018-01-28 02802, 2018
9:06 AM
samj1912
zas: yes, it will also allow us to configure rate control easily for auth-api with better rate limits
2018-01-28 02826, 2018
9:06 AM
zas
ok, i'll first rename (again) ;)
2018-01-28 02828, 2018
9:06 AM
samj1912
let me know what you think
2018-01-28 02840, 2018
9:06 AM
samj1912
lol, just rebase :P
2018-01-28 02812, 2018
9:07 AM
zas
well, current use doesn't require a class, but i think it'd be useful to have usual class/instances too
2018-01-28 02838, 2018
9:22 AM
CardinalWolseley joined the channel
2018-01-28 02854, 2018
9:26 AM
CardinalWolseley has quit
2018-01-28 02811, 2018
9:36 AM
github joined the channel
2018-01-28 02811, 2018
9:36 AM
github
[picard] samj1912 opened pull request #816: Optimize imports and follow PEP-8 (master...pep8imp)
https://git.io/vNDBT
2018-01-28 02811, 2018
9:36 AM
github has left the channel
2018-01-28 02815, 2018
9:39 AM
HSOWA
Freso! I got a very mean message from sigyn :C
2018-01-28 02845, 2018
9:44 AM
D4RK-PH0ENiX joined the channel
2018-01-28 02825, 2018
9:45 AM
d4rkie has quit
2018-01-28 02813, 2018
9:48 AM
zas
alastairp: spike load is high, not sure what is going on, have a look please
2018-01-28 02848, 2018
9:48 AM
HSOWA
this isn't cool
2018-01-28 02833, 2018
9:52 AM
Sophist-UK joined the channel
2018-01-28 02803, 2018
10:09 AM
CardinalWolseley joined the channel
2018-01-28 02813, 2018
10:09 AM
d4rkie joined the channel
2018-01-28 02805, 2018
10:10 AM
D4RK-PH0ENiX has quit
2018-01-28 02848, 2018
10:13 AM
CardinalWolseley has quit
2018-01-28 02800, 2018
10:27 AM
github joined the channel
2018-01-28 02800, 2018
10:27 AM
github
[listenbrainz-server] paramsingh opened pull request #340: LB-285: Improve logging in listens dumps for user (master...LB-285)
https://git.io/vND0C
2018-01-28 02800, 2018
10:27 AM
github has left the channel
2018-01-28 02822, 2018
10:29 AM
samj1912
zas: is there something weird with the way your editor inserts spaces after `#` in comments
2018-01-28 02833, 2018
10:29 AM
samj1912
pylint refuses to recognise them as a space
2018-01-28 02855, 2018
10:33 AM
CardinalWolseley joined the channel
2018-01-28 02805, 2018
10:38 AM
CardinalWolseley has quit
2018-01-28 02811, 2018
10:47 AM
samj1912
zas: the spaces inserted in comments by your editor are `\xC2\xA0` instead of the usual `\x20`
2018-01-28 02819, 2018
10:47 AM
samj1912
can you check what's up
2018-01-28 02849, 2018
10:48 AM
samj1912
2018-01-28 02830, 2018
10:57 AM
D4RK-PH0ENiX joined the channel
2018-01-28 02812, 2018
10:59 AM
d4rkie has quit
2018-01-28 02840, 2018
11:00 AM
D4RK-PH0ENiX has quit
2018-01-28 02811, 2018
11:01 AM
D4RK-PH0ENiX joined the channel
2018-01-28 02856, 2018
11:05 AM
D4RK-PH0ENiX has quit
2018-01-28 02808, 2018
11:11 AM
iliekcomputers
alastairp: but the export would already be done inside the containers in docker
2018-01-28 02824, 2018
11:12 AM
iliekcomputers
so the command prefix is just `flask`, instead of `python manage.py`
2018-01-28 02855, 2018
11:12 AM
D4RK-PH0ENiX joined the channel
2018-01-28 02810, 2018
11:33 AM
RashiSah[m]
alastairp: evaluate.py showing "no pending datasets", even though status is "running" on local server. why is it so?
2018-01-28 02803, 2018
11:34 AM
alastairp
RashiSah[m]: it has to be in state 'pending' for evaluate.py to process it
2018-01-28 02843, 2018
11:34 AM
alastairp
zas: postgres using a lot of CPU, but otherwise not a lot that I can see
2018-01-28 02856, 2018
11:34 AM
alastairp
not sure why. we have a huge database now, it's getting a bit out of hand I think
2018-01-28 02828, 2018
11:35 AM
alastairp
iliekcomputers: yeah, that's true
2018-01-28 02847, 2018
11:35 AM
alastairp
perhaps it's the idea of the 'flask' prefix, even for pure AB processing scripts that makes me feel weird
2018-01-28 02824, 2018
11:39 AM
CardinalWolseley joined the channel
2018-01-28 02820, 2018
11:43 AM
alastairp
iliekcomputers: any preference for separating AB commands behind an 'ab' command class?
2018-01-28 02843, 2018
11:43 AM
alastairp
and other tools (hl extractor, dataset evaluator) behind another commndclass? or part of 'ab'?
2018-01-28 02854, 2018
11:43 AM
CardinalWolseley has quit
2018-01-28 02811, 2018
11:56 AM
dpsak[m] joined the channel
2018-01-28 02852, 2018
12:01 PM
outsidecontext joined the channel
2018-01-28 02830, 2018
12:15 PM
zas
samj1912: i doubt that's my editor (vim), can you point me at code having those ?
2018-01-28 02847, 2018
12:15 PM
samj1912
zas: I recently corrected it in my latest commit
2018-01-28 02853, 2018
12:15 PM
samj1912
for eg. see picard/disc.py
2018-01-28 02802, 2018
12:16 PM
samj1912
the attribution text with your name
2018-01-28 02807, 2018
12:16 PM
zas
i just did a test, and clearly there's no such character inserted
2018-01-28 02849, 2018
12:16 PM
samj1912
2018-01-28 02802, 2018
12:17 PM
samj1912
weird, this particular line on my pc treats it as a nbsp
2018-01-28 02825, 2018
12:19 PM
CardinalWolseley joined the channel
2018-01-28 02837, 2018
12:19 PM
zas
yes, it was in a commit 5 years ago, may be something by this time, but atm i don't think my editor is inserting those characters, i'll recheck
2018-01-28 02815, 2018
12:20 PM
zas
we should search/replace all those ofc
2018-01-28 02847, 2018
12:20 PM
samj1912
I did
2018-01-28 02801, 2018
12:21 PM
samj1912
2018-01-28 02832, 2018
12:21 PM
zas
i saw, but it is a bit huge to find all replacements
2018-01-28 02856, 2018
12:21 PM
samj1912
I mean, I made all the replacements
2018-01-28 02832, 2018
12:22 PM
zas
did you change the script generating picard/const/attributes.py ?
2018-01-28 02838, 2018
12:23 PM
CardinalWolseley has quit
2018-01-28 02801, 2018
12:24 PM
suriv joined the channel
2018-01-28 02826, 2018
12:28 PM
zas
samj1912: did you use autopep8 to ensure things you changed are preserved ?
2018-01-28 02845, 2018
12:28 PM
samj1912
preserved as in?
2018-01-28 02803, 2018
12:29 PM
samj1912
and no I did not change the scripts generating the files
2018-01-28 02817, 2018
12:29 PM
samj1912
I should
2018-01-28 02808, 2018
12:34 PM
samj1912
zas: I was finally able to use pyinstaller :D \o/
2018-01-28 02812, 2018
12:34 PM
samj1912
it works on linux
2018-01-28 02818, 2018
12:34 PM
samj1912
trying to port it to windows now
2018-01-28 02837, 2018
12:35 PM
github joined the channel
2018-01-28 02837, 2018
12:35 PM
github
[picard] samj1912 opened pull request #817: [WIP] Use pyinstaller to package builds (master...pyinstaller)
https://git.io/vND2W
2018-01-28 02837, 2018
12:35 PM
github has left the channel
2018-01-28 02837, 2018
12:56 PM
github joined the channel
2018-01-28 02837, 2018
12:56 PM
github
[picard] yagyanshbhatia opened pull request #818: PICARD-1067: Visual bug after un-checking an installed plugin (master...PICARD-1067)
https://git.io/vND2h
2018-01-28 02837, 2018
12:56 PM
github has left the channel
2018-01-28 02806, 2018
12:58 PM
mzfr joined the channel
2018-01-28 02826, 2018
12:58 PM
samj1912
2018-01-28 02835, 2018
12:58 PM
samj1912
now lets test if it is actually working
2018-01-28 02840, 2018
12:58 PM
samj1912
anyone on windows here?
2018-01-28 02850, 2018
13:02 PM
zas
not me ;)
2018-01-28 02850, 2018
13:07 PM
zas
2018-01-28 02810, 2018
13:08 PM
zas
may be renamed it to ScriptSyntaxError and get rid of that
2018-01-28 02812, 2018
13:10 PM
vishalchoudhary[
samj1912: can test on Windows, have Windows on my spare laptop
2018-01-28 02831, 2018
13:10 PM
samj1912
vishalchoudhary[: nvm
2018-01-28 02837, 2018
13:10 PM
samj1912
borrowed one from my friend
2018-01-28 02855, 2018
13:11 PM
vishalchoudhary[
samj1912: ok let me know if you need next time.
2018-01-28 02814, 2018
13:12 PM
naiveai joined the channel
2018-01-28 02828, 2018
13:12 PM
naiveai
well, that's my nanodegree finally wrapped up
2018-01-28 02805, 2018
13:25 PM
CardinalWolseley joined the channel
2018-01-28 02836, 2018
13:29 PM
CardinalWolseley has quit
2018-01-28 02821, 2018
13:52 PM
Zastai joined the channel
2018-01-28 02814, 2018
13:58 PM
CardinalWolseley joined the channel
2018-01-28 02840, 2018
14:02 PM
CardinalWolseley has quit
2018-01-28 02800, 2018
14:06 PM
outsidecontext has quit
2018-01-28 02830, 2018
14:06 PM
outsidecontext joined the channel
2018-01-28 02801, 2018
14:16 PM
outsidecontext has quit
2018-01-28 02844, 2018
14:16 PM
Zastai
does/will LB care about the user agent on WS requests (for rate limiting ec) the way MB does? (mainly so I know whether my C# API should require/allow one to be set)
2018-01-28 02806, 2018
14:20 PM
CardinalWolseley joined the channel
2018-01-28 02825, 2018
14:31 PM
samj1912
Sigh zas this whole packaging business is a hell hole :/
2018-01-28 02836, 2018
14:31 PM
samj1912
Random window dll dependencies
2018-01-28 02806, 2018
14:32 PM
samj1912
Would be nice if someone could help us with this
2018-01-28 02835, 2018
14:32 PM
SothoTalKer
picard on windows?
2018-01-28 02858, 2018
14:33 PM
samj1912
Yeah it works on pip
2018-01-28 02812, 2018
14:34 PM
samj1912
But trying to package it... Sigh
2018-01-28 02830, 2018
14:34 PM
CardinalWolseley has quit
2018-01-28 02858, 2018
14:35 PM
samj1912
Oh wait, I finally succeeded \o/
2018-01-28 02844, 2018
14:39 PM
SothoTalKer
glad i could help :]
2018-01-28 02844, 2018
14:42 PM
github joined the channel
2018-01-28 02844, 2018
14:42 PM
github
[picard-website] mineo opened pull request #109: Remove mention of picard_dev (master...no-picard-dev)
https://git.io/vNDKY
2018-01-28 02844, 2018
14:42 PM
github has left the channel
2018-01-28 02844, 2018
14:46 PM
SothoTalKer
if you have a non-pip build ready i can test it
2018-01-28 02832, 2018
14:56 PM
samj1912
SothoTalker pushed the latest changes
2018-01-28 02843, 2018
14:56 PM
samj1912
Will update appveyor in a while
2018-01-28 02823, 2018
15:10 PM
drsaunders joined the channel
2018-01-28 02831, 2018
15:13 PM
HSOWA has quit
2018-01-28 02819, 2018
15:14 PM
KassOtsimine joined the channel
2018-01-28 02822, 2018
15:50 PM
CardinalWolseley joined the channel
2018-01-28 02802, 2018
16:17 PM
Zastai has quit
2018-01-28 02829, 2018
16:51 PM
RashiSah[m]
2018-01-28 02813, 2018
17:00 PM
github joined the channel
2018-01-28 02813, 2018
17:00 PM
github
[listenbrainz-server] paramsingh opened pull request #341: LB-270: Add documentation about ListenBrainz data dumps (master...listen-dumps-docs)
https://git.io/vNDDd
2018-01-28 02813, 2018
17:00 PM
github has left the channel
2018-01-28 02850, 2018
17:07 PM
yvanzo joined the channel
2018-01-28 02808, 2018
17:10 PM
rsh joined the channel
2018-01-28 02857, 2018
17:18 PM
samj1912
2018-01-28 02859, 2018
17:18 PM
samj1912
try this
2018-01-28 02856, 2018
17:19 PM
rsh7[m] joined the channel
2018-01-28 02842, 2018
17:20 PM
rsh has left the channel
2018-01-28 02846, 2018
17:25 PM
SothoTalKer
samj1912: i will. does it use a different config location/name than 1.4.2? :)
2018-01-28 02807, 2018
17:26 PM
samj1912
SothoTalKer: hmm, it doesn't seem to be working
2018-01-28 02807, 2018
17:26 PM
samj1912
1 min
2018-01-28 02815, 2018
17:28 PM
SothoTalKer
sure (:
2018-01-28 02836, 2018
17:45 PM
mzfr has quit
2018-01-28 02859, 2018
18:03 PM
SothoTalKer
samj1912: that's a long minute, hehe
2018-01-28 02810, 2018
18:04 PM
samj1912
SothoTalKer: I can build it on my pc
2018-01-28 02817, 2018
18:04 PM
samj1912
but the appveyor build doesnt run
2018-01-28 02825, 2018
18:04 PM
samj1912
it crashes immediately
2018-01-28 02831, 2018
18:04 PM
samj1912
trying to debug it
