#metabrainz

Alright, vishichoudhary_, go. :p

Hi everyone

Okay, ferbncode?

haruute[m]: spellew just said he doesn't have an update. :)

me or ferbncode?

vishichoudhary_: You.

Ok , was looking for some bugs in picard.

Added some keyboard shortcut keys in picard

ferbncode will go after. (And is last one up, so if anyone else wants to give reviews (dpmittal or rsh7[m] maybe?), now is the time to let me know.)

apart from that read about picard coverart part

that's it

ferbncode, go

Hi o/

may I?

This week, I created a PR (https://github.com/metabrainz/critiquebrainz/pu...) in CB for creating db tables in test container before the tests run. This would prevent tests failing due to code running while running and setting up the test app (as in https://github.com/metabrainz/critiquebrainz/pu...). Will try to improve this by adding test.sh (like in LB, AB), so that there is no need to remove containers explicitly.

ferbncode, you go first

fin!

dpmittal: go! :)

I was not so active these days but I was setting up CB locally and will start contributing again soon...

That's it :P

Alright!

That's everyone for reviews! Thanks everyone!

Theveryone!

hi! I have worked on some open issues, and working on a new one

Oh.

hii again

chhavi_: After rsh7[m] :p

Freso: should I go?

aah okay.

AWAY, yes

(no, stay, we like you)

/kick reosarevok

reosarevok: who will make you banners? :p

Well, Freso will ban me, almost the same

rsh7[m]: Got more? :)

!m rsh7[m] for making alastairp work, in any case

You're doing good work, rsh7[m] for making alastairp work, in any case!

I guess that was all from rsh7[m] maybe.

So chhavi_, take it away. Sorry about the interruption.

np :)

So some of our ideas on GSoC page require a UX component. Yvanzo has linked them, I have left some initial comments/mockups. It will be nice if we can have feedback on them. Will help someone be more productive with their proposal/coding time.

Freso: yeah done!

Here's one.

MBS-9613: Redesign of "All Edits" Page

rsh7[m]: Cool, thanks! :)

And the other is the setlist editor.

MBS-9533: Adding a "Setlist"

That would be all Freso :)

Cool.

Leo_Verto: syswiki for community-run services!

I'm doing a fresh install of BrainzBot and samj asked me to document it, where should I do that? The syswiki seems like the obvious place but I don't (and definitely shouldn't) have access to it. This seems like it'd affect all projects run by non-MeB employees (e.g. also BookBrainz). Should this kind of info go into the project repositories? The wiki? I'd love to just have a central place for storing and finding that kind of info.

bitmap, yvanzo, ruaok, samj1912: Ping ^ I guess.

Oh, and zas.

also is there any monitoring stuff that we should plan to integrate?

I'd say having the install documentation in the project repos make sense

same thoughts

Leo_Verto: yes, please document in-repo

ferbncode[m]: Thanks to your help I was able to set up CB locally but I am unable to import CB database.. When I was following the docs It said to use the python3 manage.py export importer command... but after using it I got this error https://pastebin.com/LCZTaadJ

dpmittal_: post-meeting pls ;)

dpmittal_: Please, after the meeting.

+1

(for doc in the repo)

Ahh, Sorry

install yes, but I was more thinking along the lines of deployed services on specific vms

e.g. users, directories, upstart/systemd services

should that also go in-repo?

if there's nothing secret, yes

Everything except credentials.

Leo_Verto: it would be nice to move to docker

okay, great, that answers my question

if that is at all possible :P

Leo_Verto I think having a prod dir with docs would be good

yeah, that too :P

Leo_Verto: So fin?

My turn !!!!!!!!!!!!!

yep

Huh maybe my message was too late here, nvm

kartikeyaSh_ircc: Okay, go. :)

Then we close after kartikeyaSh_ircc's review.

This week I created 3 tickets(LB 308,309,310) and created 3 PR's on LB (LB-148,308,309). these deal with Last.fm compatible API. I need to discuss some problems that i'm facing then continue further work.

LB-148: Add integration tests to api_compat feature https://tickets.metabrainz.org/browse/LB-148

kartikeyaSh_ircc: Got more?

Freso: No that's it

!m kartikeyaSh_ircc

You're doing good work, kartikeyaSh_ircc!

kartikeyaSh_ircc: let's discuss tomorrow

:)

iliekcomputers: okay

kartikeyaSh_ircc: Alright, be sure to say "fin" or "done" or something when you're done, so we know you're done and can move on. :)

kartikeyaSh_ircc: Also, we usually do reviews at the beginning of the meeting, so if you can, try and be around that time next time. :)

kartikeyaSh_ircc: Either way, thanks!

I would also like to take part in the meeting today (For Reviews)

And with that!

Freso: I'll remember that from next time

Oh.

akhilesh: Alright, go.

Then we'll close after akhilesh, maybe…

kartikeyaSh_ircc: 👍 :)

I worked for bookbrainz, and I Sent this PR (https://github.com/bookbrainz/bookbrainz-site/p...) for improving search Results

akhilesh: Fin?

yes

akhilesh: Alright, be sure to say "fin" or "done" or something when you're done, so we know you're done and can move on.

Also, try and be around for the beginning of the meeting next time, so we can do all the reviews together.

Anyway.

Thanks for all the reviews and everyone's time!

</BANG>

ok Thanks

OTHEr-77

OTHER-77

Thanks Freso

OTHER-77: Unify all markup syntax to simple markdown syntax https://tickets.metabrainz.org/browse/OTHER-77

:o

Freso thanks for your patience and awesomeness :D

chhavi_: :$

Freso: It is actually a prerequisite for some Design changes such as MBS-9533 chhavi_ mentionned earlier.

MBS-9533: Adding a "Setlist" https://tickets.metabrainz.org/browse/MBS-9533

zas: is a page in the brainzbot readthedocs okay for you?

Unify all the things. Except Spain and Catalonia

I think so, if brainzbot has already one, better keep infos together

reosarevok: did you invent the event setlist syntax from scratch, or has it any legacy motivation (from last.fm or anything else)?

I think it was a bit related to setlist.fm maybe? But it's shit, so you can change it

bitmap: I was having some trouble fixing a ws/js test

It confuses people anyway :)

It’s an opportunity to add new features at the same time.

samj1912: did you add any new keys to existing TO_JSON subroutines? or remove keys

looks like there are some failures related to 'is_special_purpose'

yeah

I did add a key

although I fixed it in a new commit

I am still getting an error locally

(you have to click on 'View as plain text' in the side to see the actual errors

)

hmm, not sure yet, but actually I would implement that in JavaScript instead

okay

12:02 AM <reosarevok> !m rsh7[m] for making alastairp work, in any case

in general I would not serialize anything from a method, I would port the method to JS (though there may be exceptions)

I do that too sometimes ;)