#metabrainz

/

      • ohrstrom has quit
      • 2018-02-13 04410, 2018

      • vedantc98
        I was wondering if I could get started with a first bug in Picard
      • 2018-02-13 04429, 2018

      • yagyanshbhatia[m
        Have you read the docs? If yes,
      • 2018-02-13 04429, 2018

      • yagyanshbhatia[m
      • 2018-02-13 04430, 2018

      • yagyanshbhatia[m
        Get started with these :)
      • 2018-02-13 04401, 2018

      • vedantc98
        Thanks, I'll take a look
      • 2018-02-13 04416, 2018

      • UmkaDK_ joined the channel
      • 2018-02-13 04416, 2018

      • UmkaDK_ has quit
      • 2018-02-13 04401, 2018

      • UmkaDK_ joined the channel
      • 2018-02-13 04401, 2018

      • UmkaDK__ joined the channel
      • 2018-02-13 04402, 2018

      • UmkaDK has quit
      • 2018-02-13 04402, 2018

      • UmkaDK__ has quit
      • 2018-02-13 04408, 2018

      • UmkaDK___ joined the channel
      • 2018-02-13 04404, 2018

      • UmkaDK joined the channel
      • 2018-02-13 04436, 2018

      • Slurpee joined the channel
      • 2018-02-13 04436, 2018

      • Slurpee has quit
      • 2018-02-13 04436, 2018

      • Slurpee joined the channel
      • 2018-02-13 04435, 2018

      • UmkaDK_ has quit
      • 2018-02-13 04427, 2018

      • UmkaDK___ has quit
      • 2018-02-13 04404, 2018

      • alastairp
        bitmap: yvanzo: does release_group and release_group_meta share the same PK?
      • 2018-02-13 04418, 2018

      • vedantc98 has quit
      • 2018-02-13 04448, 2018

      • vedantc98 joined the channel
      • 2018-02-13 04447, 2018

      • vedantc98 has quit
      • 2018-02-13 04423, 2018

      • bogdanteleaga has quit
      • 2018-02-13 04429, 2018

      • vedantc98 joined the channel
      • 2018-02-13 04418, 2018

      • yvanzo
        alastairp: yes
      • 2018-02-13 04446, 2018

      • alastairp
        cool, thanks
      • 2018-02-13 04450, 2018

      • alastairp does experiments
      • 2018-02-13 04401, 2018

      • ohrstrom joined the channel
      • 2018-02-13 04413, 2018

      • ohrstrom has quit
      • 2018-02-13 04401, 2018

      • drsaunders has quit
      • 2018-02-13 04457, 2018

      • CardinalWolseley joined the channel
      • 2018-02-13 04446, 2018

      • vedantc98 has quit
      • 2018-02-13 04411, 2018

      • vedantc98 joined the channel
      • 2018-02-13 04450, 2018

      • github joined the channel
      • 2018-02-13 04450, 2018

      • github
        [picard] samj1912 opened pull request #839: Remove unnecessary code and use pathlib to figure out logger name (master...simple_logging) https://git.io/vAOFD
      • 2018-02-13 04450, 2018

      • github has left the channel
      • 2018-02-13 04410, 2018

      • github joined the channel
      • 2018-02-13 04410, 2018

      • github
        [picard] zas opened pull request #840: PICARD-1192: set QTextDocumentWriter format to plaintext, and allow any filename (master...fix_log_saveas) https://git.io/vAONl
      • 2018-02-13 04410, 2018

      • github has left the channel
      • 2018-02-13 04430, 2018

      • github joined the channel
      • 2018-02-13 04431, 2018

      • github
        [picard] zas closed pull request #837: PICARD-1192: Add .txt extension in path if no extension is there (master...PICARD-1192) https://git.io/vAYfk
      • 2018-02-13 04431, 2018

      • github has left the channel
      • 2018-02-13 04418, 2018

      • vedantc98[m] joined the channel
      • 2018-02-13 04455, 2018

      • KassOtsimine
      • 2018-02-13 04408, 2018

      • KassOtsimine
        yes!
      • 2018-02-13 04424, 2018

      • KassOtsimine
        lmao at michael z land and koji kondo being tops
      • 2018-02-13 04445, 2018

      • KassOtsimine
        queen needs to pass deep purple, but after that everything is good in the world
      • 2018-02-13 04447, 2018

      • KassOtsimine
        ack, i'm going to import the last bit of stuff but after that there will be no more imports from last.fm from me for a while since that machine is ded T__T so until i figure out to get a lb importion going... we needs more plug-ins to various players, itunes, etc..
      • 2018-02-13 04458, 2018

      • KassOtsimine
        toh of course the only other machien there is the dreaded 10.7 :///
      • 2018-02-13 04407, 2018

      • KassOtsimine
        from the fire and into the fryingpan?
      • 2018-02-13 04409, 2018

      • reosarevok
        ruaok: did you get the forward email I just sent into spam or inbox? (I got the original into spam, wondering if forwarding helps at all or they stay in spam too)
      • 2018-02-13 04408, 2018

      • ruaok
        got it in inbox.
      • 2018-02-13 04439, 2018

      • ruaok
        you know the std response for this type of email, yes?
      • 2018-02-13 04404, 2018

      • reosarevok
        I know there's one but I forgot which it was (think it's the first this year?), hence the forwarding. But good to know that works
      • 2018-02-13 04443, 2018

      • ferbncode[m]
        dpmittal: I think once the cron jobs are back on CB, the dumps will be updated for import. Till then, I suggest you to create own reviews. Also, make sure to run the import command with python3
      • 2018-02-13 04445, 2018

      • reosarevok
      • 2018-02-13 04423, 2018

      • KassOtsimine
        lol std responce?
      • 2018-02-13 04427, 2018

      • KassOtsimine
        uff da
      • 2018-02-13 04459, 2018

      • KassOtsimine
        "ListenBrainz Beta (lemmy) is requesting permission to:" :D
      • 2018-02-13 04420, 2018

      • reosarevok
        KassOtsimine: I think he means standard, although answering "gonorrhea" would be fun.
      • 2018-02-13 04421, 2018

      • dpmittal
        ferbncode[m]: I ran the import command using python3 only... Well I'll write my own reviews for testing purposes.. Till then I was wondering that the docs of CB needs to be updated as its very confusing
      • 2018-02-13 04432, 2018

      • KassOtsimine
        lemmy \o/
      • 2018-02-13 04446, 2018

      • KassOtsimine
        reosarevok: :D
      • 2018-02-13 04436, 2018

      • dpmittal
        ferbncode[m]: So should I make a ticket and then create a PR or directly make a PR updating the docs(installation part only)?
      • 2018-02-13 04446, 2018

      • ferbncode[m]
        dpmittal: I think it's better to create a ticket and then send a PR. :)
      • 2018-02-13 04410, 2018

      • KassOtsimine
        ruaok: import on beta.lb.org doesn't work for me, import on lb.org does
      • 2018-02-13 04441, 2018

      • github joined the channel
      • 2018-02-13 04441, 2018

      • github
        [critiquebrainz] Prakriti-nith opened pull request #179: CB-253: Change moderator(s) to administrator(s) (master...administrator) https://git.io/vA3Jk
      • 2018-02-13 04441, 2018

      • github has left the channel
      • 2018-02-13 04456, 2018

      • github joined the channel
      • 2018-02-13 04456, 2018

      • github
        [critiquebrainz] paramsingh closed pull request #176: Change schema version to 8 (master...schema_version) https://git.io/vAm2r
      • 2018-02-13 04456, 2018

      • github has left the channel
      • 2018-02-13 04424, 2018

      • github joined the channel
      • 2018-02-13 04424, 2018

      • github
        [critiquebrainz] paramsingh closed pull request #174: CB-276: Initialize db and create tables in test container before running tests (master...createdbintests) https://git.io/vAtbl
      • 2018-02-13 04424, 2018

      • github has left the channel
      • 2018-02-13 04445, 2018

      • iliekcomputers
        KassOtsimine: that is a known bug, I'm working on it. LB-307
      • 2018-02-13 04445, 2018

      • BrainzBot
        LB-307: last.fm import on beta fails https://tickets.metabrainz.org/browse/LB-307
      • 2018-02-13 04457, 2018

      • iliekcomputers
        thanks for reporting and testing tho :)
      • 2018-02-13 04452, 2018

      • dpmittal
        ferbncode[m]: Ok then I'll create a ticket and then send the PR and if I'll need some help I'll ping you.. Thanks for helping :)
      • 2018-02-13 04422, 2018

      • ruaok
        reosarevok: yes, please. support@ is not the right place to get started.
      • 2018-02-13 04442, 2018

      • iliekcomputers
        ferbncode[m]: we have three PRs for CB-253 rn
      • 2018-02-13 04442, 2018

      • BrainzBot
        CB-253: "Admin" and "moderator" are used interchangeably in the codebase https://tickets.metabrainz.org/browse/CB-253
      • 2018-02-13 04449, 2018

      • iliekcomputers
        I'm not sure what is the way forward here
      • 2018-02-13 04456, 2018

      • iliekcomputers
        do they duplicate work?
      • 2018-02-13 04403, 2018

      • github joined the channel
      • 2018-02-13 04403, 2018

      • github
        [critiquebrainz] paramsingh closed pull request #169: CB-239: Reference review style guide when writing a review (master...reference-styleguide) https://git.io/vbaxz
      • 2018-02-13 04403, 2018

      • github has left the channel
      • 2018-02-13 04413, 2018

      • iliekcomputers
        oh man we have 4 PRs for CB-253
      • 2018-02-13 04413, 2018

      • BrainzBot
        CB-253: "Admin" and "moderator" are used interchangeably in the codebase https://tickets.metabrainz.org/browse/CB-253
      • 2018-02-13 04405, 2018

      • vedantc98 has quit
      • 2018-02-13 04453, 2018

      • github joined the channel
      • 2018-02-13 04453, 2018

      • github
        [listenbrainz-server] paramsingh closed pull request #335: Switch redis cache and brainzutils.cache (GCI17) (master...master) https://git.io/vNcBP
      • 2018-02-13 04453, 2018

      • github has left the channel
      • 2018-02-13 04404, 2018

      • github joined the channel
      • 2018-02-13 04404, 2018

      • github
        [listenbrainz-server] paramsingh closed pull request #349: LB-303: Add instruction to add last.fm api key to custom_config.py to developement environment setup guide (master...LB-303) https://git.io/vNpsz
      • 2018-02-13 04404, 2018

      • github has left the channel
      • 2018-02-13 04417, 2018

      • dpmittal has quit
      • 2018-02-13 04447, 2018

      • Slurpee has quit
      • 2018-02-13 04442, 2018

      • kartikeyaSh_ircc joined the channel
      • 2018-02-13 04400, 2018

      • kartikeyaSh_ircc
        iliekcomputers: anything on LB-310?
      • 2018-02-13 04400, 2018

      • BrainzBot
        LB-310: API compat does not return error codes if invalid listens are submitted. https://tickets.metabrainz.org/browse/LB-310
      • 2018-02-13 04442, 2018

      • iliekcomputers
        kartikeyaSh_ircc: seems like a valid bug
      • 2018-02-13 04430, 2018

      • iliekcomputers
        I think some of the listen validation should be reused but the responses should be such that last.fm clients understand them.
      • 2018-02-13 04447, 2018

      • kartikeyaSh_ircc
        iliekcomputers: i was thinking that we can use a separate validate_listens method for it.
      • 2018-02-13 04428, 2018

      • iliekcomputers
        hmmm
      • 2018-02-13 04454, 2018

      • iliekcomputers
        or maybe add an argument to the current `validate_listens`
      • 2018-02-13 04410, 2018

      • iliekcomputers
        specifying which types of errors to return
      • 2018-02-13 04411, 2018

      • kartikeyaSh_ircc
        i was thinking that but then that MBID stuff came up
      • 2018-02-13 04418, 2018

      • kartikeyaSh_ircc
        what to do with such things
      • 2018-02-13 04420, 2018

      • kartikeyaSh_ircc
        ?
      • 2018-02-13 04449, 2018

      • iliekcomputers
        remind me, what was the MBID stuff exactly?
      • 2018-02-13 04429, 2018

      • kartikeyaSh_ircc
        that Last.fm don't validate MBID
      • 2018-02-13 04433, 2018

      • kartikeyaSh_ircc
        but LB does
      • 2018-02-13 04407, 2018

      • iliekcomputers
        hmm, does last.fm not have a generic "invalid data submitted" error code? the old lfm api did.
      • 2018-02-13 04424, 2018

      • kartikeyaSh_ircc
        but i think we can do that validation and just send error code 19 or something https://www.last.fm/api/errorcodes
      • 2018-02-13 04403, 2018

      • kartikeyaSh_ircc
        no invalid data submitted error is there
      • 2018-02-13 04408, 2018

      • kartikeyaSh_ircc
      • 2018-02-13 04437, 2018

      • iliekcomputers
        wouldn't adding it to the `ignored` parameter you reference in https://github.com/metabrainz/listenbrainz-server… here work?
      • 2018-02-13 04421, 2018

      • kartikeyaSh_ircc
        yeah i think that will work
      • 2018-02-13 04447, 2018

      • kartikeyaSh_ircc
        validate_listens errors are handled here https://github.com/metabrainz/listenbrainz-server…
      • 2018-02-13 04426, 2018

      • kartikeyaSh_ircc
        now we need 2 things one is the output format for the errors and second is errors codes and error messages should be same
      • 2018-02-13 04433, 2018

      • kartikeyaSh_ircc
        different*
      • 2018-02-13 04428, 2018

      • kartikeyaSh_ircc
        so i'm not able to find a way to specify error format in the above method
      • 2018-02-13 04446, 2018

      • iliekcomputers
        api_compat does it's error raising itself using https://github.com/metabrainz/listenbrainz-server…
      • 2018-02-13 04417, 2018

      • iliekcomputers
      • 2018-02-13 04447, 2018

      • kartikeyaSh_ircc
        but the validate_listens method is for LB which doesnot handle errors using this
      • 2018-02-13 04445, 2018

      • kartikeyaSh_ircc
        so we will need to add output_format parameter and some parameter to show that api_compat is being used to submit listens
      • 2018-02-13 04449, 2018

      • kartikeyaSh_ircc
      • 2018-02-13 04427, 2018

      • kartikeyaSh_ircc
        and about the MBID stuff we can't add that to ignored parameter. cz that parameter also has codes which don't include anything for invalid MBID
      • 2018-02-13 04417, 2018

      • iliekcomputers
        link to codes?
      • 2018-02-13 04433, 2018

      • kartikeyaSh_ircc
      • 2018-02-13 04452, 2018

      • kartikeyaSh_ircc
        Hover over the underlined tags and attributes to get detailed information.
      • 2018-02-13 04442, 2018

      • iliekcomputers
        hmm, I think artist was ignored would be okay for now?
      • 2018-02-13 04405, 2018

      • iliekcomputers
        artist was ignored (code 0) for invalid artist id
      • 2018-02-13 04417, 2018

      • iliekcomputers
        track was ignored for invalid recording id or release id
      • 2018-02-13 04419, 2018

      • iliekcomputers
        ?
      • 2018-02-13 04424, 2018

      • kartikeyaSh_ircc
      • 2018-02-13 04453, 2018

      • kartikeyaSh_ircc
        read filtering requests
      • 2018-02-13 04437, 2018

      • iliekcomputers
        >A scrobble or Now Playing request may be ignored if we detect bad meta data.
      • 2018-02-13 04444, 2018

      • iliekcomputers
        sounds exactly like our use case
      • 2018-02-13 04410, 2018

      • kartikeyaSh_ircc
        they ignore for bad metadata and raise errors if metadata is incorrect
      • 2018-02-13 04439, 2018

      • Slurpee joined the channel
      • 2018-02-13 04439, 2018

      • Slurpee has quit
      • 2018-02-13 04439, 2018

      • Slurpee joined the channel
      • 2018-02-13 04459, 2018

      • iliekcomputers
        yeah, so we should do the same
      • 2018-02-13 04425, 2018

      • kartikeyaSh_ircc
        so http status should be 400 for invalid MBID and we should display something like error code 1 (This error does not exist) in the response
      • 2018-02-13 04430, 2018

      • kartikeyaSh_ircc
        ?
      • 2018-02-13 04404, 2018

      • iliekcomputers
        the LB api should return http status 400 as it does rn
      • 2018-02-13 04421, 2018

      • iliekcomputers
        while api_compat should return 200 with the invalid listen ignored