One of GSoC 2018 ideas for MB is about editing interface for event setlist. Actually, it will probably impact its storage and its display too. Event setlists are stored as constrained text with a unique syntax that can easily be replaced with Markdown. (I wrote a 1:1 equivalence proposition already.)
2018-02-19 05028, 2018
yvanzo
This is why I looked into OTHER-77. Additionally, naiveaiguy, Daniel V. and Enjeck C. attached preliminary comparisons between some Markdown flavours during GCI contest.
2018-02-19 05005, 2018
yvanzo
Having a derivative of CommonMark similar to GitHub Flavoured Markdown (GFM) seems to be the way to go.
only thing i care about is that old edit notes are carried over logically
2018-02-19 05009, 2018
CatQuest
and that the new universal markup's markup is actually written anywher you'd use it
2018-02-19 05012, 2018
yvanzo
I would like Python foes to look into these extensions if possible.
2018-02-19 05024, 2018
CatQuest
Python foes? :D
2018-02-19 05055, 2018
yvanzo
Python coders sorry ^^
2018-02-19 05010, 2018
CatQuest
no I like foes better :D
2018-02-19 05034, 2018
bukwurm joined the channel
2018-02-19 05050, 2018
zas
currently we have edit #123456 autolink that isn't localized, if we go for an unified markup i hope this will be fixed somehow
2018-02-19 05000, 2018
Freso
yvanzo: Anything else?
2018-02-19 05041, 2018
yvanzo
For example, CB supports CommonMark’s links with angle brackets, not plain auto links (that is GFM extension).
2018-02-19 05031, 2018
yvanzo
zas: yes :)
2018-02-19 05039, 2018
yvanzo
Freso: no!
2018-02-19 05043, 2018
Freso
yvanzo: Alright!
2018-02-19 05043, 2018
Freso
chhavi_ / samj1912: Design system POC!
2018-02-19 05053, 2018
chhavi_
helo again :)
2018-02-19 05059, 2018
chhavi_
So, those of you who are just catching up, I will quickly sum up the story so far :)
2018-02-19 05059, 2018
reosarevok
I hope it's not a piece of crap
2018-02-19 05018, 2018
chhavi_
For the redesign of MusicBrainz, we have decided to follow a component driven development. Just a fancy word for dividing the interface into parts, and build those parts. Those parts that can be reused, modified, tested individually.
2018-02-19 05027, 2018
chhavi_
We have been toying with the idea of whether we want to write our own React-components, or use react bootstrap. Yet to reach a conclusion on that one.
2018-02-19 05041, 2018
chhavi_
The other challenges that are there are, how do we maintain a sync between how it looks in mockups vs how it looks in code, describing properties/ behavior of a component, testing those components in an isolated environment, documentation.
2018-02-19 05049, 2018
chhavi_
React-storybook is something that is being used heavily for the above mentioned.
2018-02-19 05012, 2018
chhavi_
So, I tried setting up a mini version of it for us. Used react-bootstrap and css from our lobes theme. Thanks Leo_Verto for that one!
chhavi_ checks if it is working. It is thankfully! :p
2018-02-19 05050, 2018
chhavi_
It just has buttons, but imagine it being extended to all the other components as well.
2018-02-19 05005, 2018
chhavi_
This also solves the issue of waiting for our port to React to test out components. And easier for code noobs like me to test the components, make sure they are in sync with the design, etc etc!
2018-02-19 05020, 2018
spellew has quit
2018-02-19 05024, 2018
ruaok
brilliant!
2018-02-19 05029, 2018
samj1912
and also other things like testing, documentations and how to use components :)
2018-02-19 05033, 2018
chhavi_
If you find it hard to imagine, here is one of the good ones out there.
There is still work in it. Like modifying the css to match our mockups, new components that aren't there in react-bootstrap, etc. Will keep workin on it.
2018-02-19 05018, 2018
ruaok
looks promising, chhavi_!
2018-02-19 05021, 2018
chhavi_
That will be all Freso
2018-02-19 05028, 2018
Freso
Alright then!
2018-02-19 05035, 2018
Freso
Thank you all for your time!
2018-02-19 05035, 2018
reosarevok
yvanzo: you're our Jira workflow fixer now, right? Can you make me a Blocked status for style tickets?
2018-02-19 05043, 2018
Freso
</BANG>
2018-02-19 05053, 2018
chhavi_
ruaok: sure :D also, a design walkthrough is due again, whenever you are free this week :)
2018-02-19 05056, 2018
reosarevok
Oh, sorry. Forgot to wait for the bang :D
2018-02-19 05011, 2018
manofcode[m] joined the channel
2018-02-19 05025, 2018
reosarevok
yvanzo: As in "needs to wait for linked ticket to be resolved", for things like the attributes or like medium format attributes
currently I just helped chhavi_ plug-in lobes into react-bootstrap
2018-02-19 05025, 2018
yvanzo
chhavi_: IMHO, “system” can probably be dropped, just like there is no “software” at the end of “MusicBrainz Server”.
2018-02-19 05026, 2018
surtin has quit
2018-02-19 05034, 2018
samj1912
it worked as easily as I thought it would :P
2018-02-19 05003, 2018
yvanzo
\o/
2018-02-19 05024, 2018
yvanzo
!m samj1912
2018-02-19 05024, 2018
BrainzBot
You're doing good work, samj1912!
2018-02-19 05056, 2018
yvanzo
reosarevok: that is actually the meaning of “Impl…” status.
2018-02-19 05013, 2018
reosarevok
yvanzo: not really IMO
2018-02-19 05028, 2018
reosarevok
That's "yes, this should be added, I've added an implementation ticket"
2018-02-19 05047, 2018
chhavi_
yvanzo: so we call it MBS-design?
2018-02-19 05048, 2018
yvanzo nods
2018-02-19 05003, 2018
samj1912
well its MeBD no?
2018-02-19 05004, 2018
reosarevok
This is "this should not be even discussed until code has been written that makes it doable: then we can decide if this specific thing makes sense"
2018-02-19 05007, 2018
samj1912
not just MBS?
2018-02-19 05026, 2018
reosarevok
(say: "someone wants an attribute, we can wait until it's possible to add, and then discuss it")
2018-02-19 05023, 2018
samj1912
yvanzo: bitmap any reason why our react code doesn't hot reload?
2018-02-19 05026, 2018
yvanzo
chhavi_, samj1912: It is for *Brainz projects, not specifically for MetaBrainz website either.
2018-02-19 05047, 2018
samj1912
thus metabrainz, no?
2018-02-19 05001, 2018
yvanzo
samj1912: that’s an issue of our Perl plugin for React.
2018-02-19 05017, 2018
samj1912
is that fixable? :P
2018-02-19 05033, 2018
samj1912
it becomes a PITA while dev.
2018-02-19 05022, 2018
yvanzo
Yes, it is our own code, that is fixable :)
2018-02-19 05044, 2018
reosarevok
yvanzo: basically "depends on" vs "resolved by"
2018-02-19 05023, 2018
reosarevok
(I can already add "depends on", but that doesn't get them out my "open tickets" queue! :D )
2018-02-19 05054, 2018
yvanzo
chhavi_, samj1912: Our Bootstrap theme is called Lobes. What about Hairstyle ;) or DesignBrainz?
2018-02-19 05059, 2018
Kxze joined the channel
2018-02-19 05024, 2018
Kxze has quit
2018-02-19 05039, 2018
samj1912
DesignBrainz sounds nice :P
2018-02-19 05040, 2018
Wizzup has quit
2018-02-19 05045, 2018
Freso
reosarevok: But it would continue to be an open ticket until the MBS issue is resolved regardless.
2018-02-19 05005, 2018
Freso
Unless you have a custom query that only looks for certain/specific statuses.
2018-02-19 05026, 2018
surtin joined the channel
2018-02-19 05052, 2018
yvanzo
Acronym could be DeB as we owe it a better UX. :)
2018-02-19 05019, 2018
Wizzup joined the channel
2018-02-19 05022, 2018
CatQuest
as for colour schemes. this could? make it possible for people to create their own themes (should they want white text on black& grey for example) ?
2018-02-19 05029, 2018
Wizzup_ joined the channel
2018-02-19 05037, 2018
CatQuest
yvanzo: that sounds neat!
2018-02-19 05024, 2018
CatQuest
for things like annotations that can be edited it's not as big a deal as for edit notes. there had been some changes which made an old way of doing it oboslete and broken :D
2018-02-19 05027, 2018
reosarevok
Freso: if I only link it as depends on, yes, that's why I asked yvanzo for a separate status :)
2018-02-19 05026, 2018
CatQuest
+1 DesignBrainz
2018-02-19 05027, 2018
CatQuest
:D
2018-02-19 05021, 2018
Wizzup_ has quit
2018-02-19 05026, 2018
Wizzup has quit
2018-02-19 05037, 2018
Wizzup joined the channel
2018-02-19 05052, 2018
Freso
reosarevok: And a separate status would (and should) still consider the ticket as open, is what I am saying.
2018-02-19 05010, 2018
github joined the channel
2018-02-19 05010, 2018
github
[critiquebrainz] paramsingh closed pull request #159: CB-268: Update review only if contents are edited (master...cb-268/new-revision) https://git.io/v5D9F
2018-02-19 05010, 2018
github has left the channel
2018-02-19 05019, 2018
Freso
reosarevok: Sorry, never mind me, Jira uses resolution and unresolved. I'm mixing up issue tracker lingos.
2018-02-19 05024, 2018
Freso should go to sleep
2018-02-19 05013, 2018
UmkaDK has quit
2018-02-19 05036, 2018
dpmittal
iliekcomputers: ping
2018-02-19 05013, 2018
CatQuest
I'd appreciate if someone could test pinging my name a littel
