samj1912: lgtm other than the one comment I just left I think
samj1912
Cool
dragonzeron has quit
fhe joined the channel
bitmap
(plus the other one comment I just left)
samj1912
bitmap: how do I enable i18n on my local setup?
I don't have the drop-down on the top right.
bitmap
I think the instructions under 'Translations' in INSTALL.md should work
although you don't need transifex
make -C po deploy; and set MB_LANGUAGES
on ubuntu I think you do need those language packs
github joined the channel
github
[listenbrainz-server] Uditgulati opened pull request #368: LB-322: Add import and sign in buttons to error pages (master...LB-322) https://git.io/vA6lL
github has left the channel
samj1912
bitmap: updated, one thing I noticed if lp_* functions are passed undef, it throws an error, can it silently just output a blank string or return undef too instead?
also, it would be nice to write a couple of wrappers around l* functions as we discussed
including support for template strings if its possible
bitmap
hm, well returning a blank string could work for lp_attributes (and other domains extracted from the db), though for l() throwing an exception makes sense since it's a bug in the code
though I guess it wouldn't hurt to change all of them, if you don't see any output it should be clear something is wrong
samj1912
it shows an error screen and an exception with jed
ill make a small PR for this behaviour atleast
bitmap
how do you propose template strings are supposed to work with gettext?
if you're generating a translated string dynamically, you're doing something wrong
samj1912
hmm, but its useful in some cases like multiline strings without \
hmm, but yeah, not sure how to extract dynamic strings
bitmap
yeah, that's about the only use they have there, although we need to write our own extractor before we can put newlines in strings anyway
similar to po/extract_pot_templates which extracts strings from .tt for us and collapses whitespace
for the .js we just use xgettext which is a bit more primitive
ruaok: re blogpost, aside from a typo here and there (which I've fixed), the only thing that comes to mind that we haven't mentioned is the bigquery-writer batch submitting listens feature (although it isn't user facing, so we don't want to mention it maybe)
samj1912
bitmap: ^^
bitmap
as long as it doesn't choke on jsx/our other es.$version additions and collapses newlines/spaces
samj1912
hmm, let me see if that works
CatQuest has quit
CatQuest joined the channel
CatQuest has quit
CatQuest joined the channel
uditgulati0[m]
iliekcomputers: how can I check that error is 500 in flask template?
iliekcomputers: thanks for the review on the blog post. I'll add the bg stuff to it. it is worth mentioning.
oh and Mooooin!
iliekcomputers
moin!
back in BCN?
ruaok
reosarevok or anyone, actually: do you know of a currently working site that uses our data to make a spammy site with ads and/or malware?
iliekcomputers: yes. its a balmy 3C here. I walked home from the bus without a jacket it was so nice, compared to zurich. :)
iliekcomputers
if you find 3C balmy, you'll boil in Delhi :D
it is 25C here rn :P
ruaok
compared to the -9C that I left in Zürich, 3C was really pleasant. :)
but yes, 25C is going to be a bit of a shock. :)
iliekcomputers
:)
ruaok: the good food here will make up for it :)
ruaok
sooo happy about that.
iliekcomputers
i have a place with the most delicious biryani in mind ;)
jwf
Save some for me :P
ruaok
hey jwf, long time no see. :)
jwf waves
jwf
Sorry I haven't been around as much. Started a new job in January and it's taken a big bite out of my time. :-(
ruaok
no worries.
jobs are good.
github joined the channel
github
[listenbrainz-server] mayhem closed pull request #366: Tune crontab to be easy to grasp for humans (master...crontab-tuning) https://git.io/vAoJr
github has left the channel
iliekcomputers
they pay for the food :)
(and the drinks)
ruaok
and internet. :
github joined the channel
github
[listenbrainz-server] mayhem closed pull request #365: Modify test_user.py to check for not calculated artist_count in user.py (master...user_test) https://git.io/vAa6k
github has left the channel
ruaok
:)
github joined the channel
github
[listenbrainz-server] mayhem closed pull request #367: Merge production into master before beta release (master...merge-branch) https://git.io/vAKoq
github has left the channel
adhawkins
Morning all. Anyone here who knows about the coverart backend?
"Download Musicbrainz Test Artist It Is Time file type: mp3 - download Musicbrainz Test Artist It Is Time bitrate: 320 kbps Full Album Kualitas HD" (https://www.mp3i.me › Music)
They have a Test Artist album in fucking HD. Wow! :D