#metabrainz

[picard] sambhav closed pull request #875: PICARD-1220: Add keyboard shortcut to delete scripts. (master...PICARD-1220) https://git.io/vAjry

metabrainz/picard#3345 (master - deee1d0 : Vishal Choudhary): The build passed.

Change view : https://github.com/metabrainz/picard/compare/f8...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

metabrainz/picard#3345 (master - deee1d0 : Vishal Choudhary): The build passed.

Change view : https://github.com/metabrainz/picard/compare/f8...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

bitmap: done with the review comments and rebase

ok, it's late here but I'll actually test it tomorrow (I was just reading the code)

cool o/

I did not know about the component_props thing in stash

I think ill make a PR to remove some other un-necessary uses of that

instrument types and all

or will you be doing that with the webpack PR?

yeah. I only knew about it because I added it hehe

probably nothing that isn't already in the PR, so feel free

there are some really weird whitelisted stash keys :P, probably because people did not know about the component_props thing

bitmap: should I also make a PR adding some basic common guidelines on how to convert TT to react in HACKING.md

it would be much easier to have some collective documentation about this

well, the component_props thing was added not too long ago

I meant even for new comers/when we decide to crowd source out port. It took me quite a bit of time initially and digging through past PRs to figure out how to do it

yeah, that would be excellent

I can help contribute to that if you want to write an initial thing

cool

should I add it to HACKING.md or something else?

HACKING.md makes sense

cool

whitelisting a stash key could make sense if you're using React.embed and embedding the same component multiple times in the page and it has to access the same data over and over (like say, $c.user)

for entry/page components I think there's no reason not to use component_props

[musicbrainz-server] sambhav opened pull request #626: Move componenet props from stash stash.component_props (master...portstash) https://git.io/vxeUl

bitmap: can you commit the chromedriver update to master?

[musicbrainz-server] sambhav opened pull request #627: Bump chromedriver to 2.36 (master...sambhav-patch-1) https://git.io/vxeTS

[musicbrainz-server] sambhav opened pull request #628: Add guidelines and instructions for porting to React (master...reactdocs) https://git.io/vxeki

this is going to be one fun/tiring month :P

oh ouch. :)

I have only half those. :)

Hi, where is the training and testing data for the AcousticBrainz Essentia models stored? Thanks :-)

bukwurm_, akhilesh: sorry for the delay in looking at your stuff, will probably be tonight or tomorrow GMT now

Bit busy this weekend visiting family

Has anyone read https://arxiv.org/abs/1803.00832 yet?

LordSputnik: No problem! Thanks for attention :)

Hi samj1912 zas ,

I did a lot of research on the current Picard plugin system, specially i18n , gettext, hooks, how Picard, PW, plugin repo work together, but wasn't able to get a clear picture how things are working :(

Can you suggest any source or point to an example or something? Or help me in any other way?

yagyanshbhatia[m: we discussed about it a while back. https://chatlogs.metabrainz.org/brainzbot/metab...

zas caa certificate expired?

Or not. Some weird notifications going on in telegram

nope, something weird in alerts

iliekcomputers: https://twitter.com/DrSynAck/status/97244142548...

should we add client intregration as a project on LB for GSoC? add foobar, vlc,etc

Could be a good idea

Although I'm not sure how easy it would be to mentor

I could mentor that...

samj1912: fixed, i upgrade the check_ssl_cert script used by nagios

Cool

bitmap: if you are up can you merge the chrome driver pr, every other PR is now failing

Hi, where is the training and testing data for the AcousticBrainz Essentia models stored? Thanks :-)

[picard] rdswift opened pull request #876: PICARD-1045 Add update checking framework (master...check-updates) https://git.io/vxez1

if you would like to continue on that, can you make a PR to PW to add an api that sends back version info as json?

it should be fairly easy to code and you can simply add a key in config file to allow us to maintain versions

I would like it to have 3 keys - stable, beta and dev

and allow people to opt into which version updates they'd like with stable being the default

zas: thoughts on this ^

I'm not familiar at all with the PW stuff, but I can take a look. Will have to figure out which URLs to use for the beta and dev downloads.

rdswift: you can have a single API return a json object with the keys stable, beta and dev

and then parse the json in picard

just add a function here - https://github.com/metabrainz/picard-website/bl...

Sounds easy enough. ;-)

yup :P

all you need to do is fetch app.config['picard_version'] or something similar and return it as a json obj

and we can simply maintain a json obj in config.py with 3 keys, each specifying the value of the latest version for each type

then we can do a simple version comparison in picard

I think there is already code for that

should make the picard side code extremely simple

its a very surprising co-incident that you made that PR :P, I was thinking about doing it myself last night

thanks for saving me some time :D