rsh7: docker-compose -f test/docker-compose.py2.yml up --build
2018-05-15 13559, 2018
UmkaDK has quit
2018-05-15 13531, 2018
rsh7
thanks kartikeyaSh!
2018-05-15 13544, 2018
Leo__Verto joined the channel
2018-05-15 13502, 2018
bukwurm has quit
2018-05-15 13512, 2018
Leo__Verto has quit
2018-05-15 13547, 2018
Leo__Verto joined the channel
2018-05-15 13557, 2018
iliekcomputers
ruaok: pong if you're still around.
2018-05-15 13508, 2018
github joined the channel
2018-05-15 13508, 2018
github
[brainzutils-python] rsh7 opened pull request #15: BU-13: Use direct MB database access for artist entity (master...artist_entity) https://git.io/vp5yd
2018-05-15 13508, 2018
github has left the channel
2018-05-15 13505, 2018
HSOWA has quit
2018-05-15 13536, 2018
Guest60633 joined the channel
2018-05-15 13557, 2018
HSOWA joined the channel
2018-05-15 13557, 2018
HSOWA has quit
2018-05-15 13557, 2018
HSOWA joined the channel
2018-05-15 13529, 2018
djwhitey_ joined the channel
2018-05-15 13539, 2018
Guest60633 has quit
2018-05-15 13527, 2018
djwhitey has quit
2018-05-15 13551, 2018
Leo__Verto has quit
2018-05-15 13552, 2018
bukwurm joined the channel
2018-05-15 13525, 2018
Freso
ruaok: Just got around to checking bank now, sorry: 50 SEK (pretty much 5€) is what my bank charges to receive US money.
Today I wrote some basic set up knex functions to add, delete imports. Next thing is entitytype_data addition (with programmatic constraints).
2018-05-15 13534, 2018
bukwurm
The producer object is basically all the information it can collect from the dumps, I worked on it a little.
2018-05-15 13555, 2018
bukwurm
Hopefully will have something concrete to show in a couple of hours.
2018-05-15 13529, 2018
bukwurm
Just wrapping it all up.
2018-05-15 13554, 2018
LordSputnik
bukwurm: is the plan still to have an edition_import_data without the publication field?
2018-05-15 13526, 2018
bukwurm
LordSputnik: Yeah, I am planning to make it null programatically as of now.
2018-05-15 13517, 2018
LordSputnik
Oh, not a separate table?
2018-05-15 13532, 2018
bukwurm
No
2018-05-15 13524, 2018
LordSputnik
I'm not sure I like changing the constraint there
2018-05-15 13535, 2018
bukwurm
LordSputnik: Ok
2018-05-15 13555, 2018
Leo__Verto joined the channel
2018-05-15 13512, 2018
LordSputnik
The issue is that all edition entities must have publications
2018-05-15 13530, 2018
bukwurm
LordSputnik: If we go with another table specifically for editions, almost the entire structure would be same as that of edition_data
2018-05-15 13537, 2018
LordSputnik
And it's best to represent that at the database level - as low level as we can
2018-05-15 13554, 2018
LordSputnik
bukwurm: true, but that's not a problem really
2018-05-15 13512, 2018
LordSputnik
They're representing different things
2018-05-15 13530, 2018
bukwurm
LordSputnik: Another solution could be to make parent publication upgradation compulsory before upgradation of an edition.
2018-05-15 13547, 2018
bukwurm
In case it's not been upgraded yet.
2018-05-15 13512, 2018
bukwurm
Add another column in the edition_data table to act as a flag if it's import or entity
2018-05-15 13527, 2018
bukwurm
Add another column to store the import_id
2018-05-15 13550, 2018
LordSputnik
I don't think that you need the import id in the table do you?
2018-05-15 13526, 2018
LordSputnik
You could do a check to say if it's not an import, publication can't be null - and then use a flag like you say
2018-05-15 13526, 2018
KubaM joined the channel
2018-05-15 13539, 2018
LordSputnik
I think that the separate table is simpler though
2018-05-15 13500, 2018
LordSputnik
But I'll leave it up to you - it's easy to change later
2018-05-15 13536, 2018
bukwurm
LordSputnik: Ok, I'll think about the pros and cons and let you know what I think.
2018-05-15 13504, 2018
LordSputnik
Yeah maybe there's some guidance online
2018-05-15 13545, 2018
LordSputnik
Anything else you'd like to bring up for today? I might see if I can do a small commit to data-js now
2018-05-15 13528, 2018
bukwurm
So I am putting on hold for knex functions for addition of edition imports as of now, will focus on other types right now. And the producer-consumer objects and actions definition is up for tomorrows review.
2018-05-15 13506, 2018
bukwurm
LordSputnik: Give me a couple of hours, I'll clean up the code for data-js and make a PR.
2018-05-15 13553, 2018
bukwurm
It's logically all linked so I want to make sure that there are no subsequent silly additions and deletions to the basic skeleton later.
2018-05-15 13557, 2018
bukwurm
LordSputnik: I think I need to make a flow-chart or something to describe the flow of proper logic which adding an import.
2018-05-15 13509, 2018
bukwurm
*which === while
2018-05-15 13512, 2018
LordSputnik
Ok, that sounds like a good idea
2018-05-15 13519, 2018
KubaM has quit
2018-05-15 13530, 2018
LordSputnik
Have you used dot/graphviz before? Might be useful for that
2018-05-15 13556, 2018
bukwurm
LordSputnik: I haven't used them.
2018-05-15 13508, 2018
bukwurm
I have used dia however for some college lab.
2018-05-15 13554, 2018
LordSputnik
I love graphviz, have found it very useful for lots of things
2018-05-15 13510, 2018
LordSputnik
Feel free to use whatever you're comfortable with :)
2018-05-15 13529, 2018
bukwurm
LordSputnik: Ok, I love trying out new tools.
2018-05-15 13539, 2018
bukwurm
I'll surely look into it.
2018-05-15 13540, 2018
bukwurm
:)
2018-05-15 13544, 2018
bukwurm
LordSputnik: Nothing else from my side today. I hope to open a PR on bb-sql today/tomorrow with all changes as we discussed yesterday.
2018-05-15 13545, 2018
bukwurm
And also, a some what detailed description about actions and objects surrounding producer and consumers (point 2 in the weekly target)
2018-05-15 13528, 2018
bukwurm
today/tomorrow.
2018-05-15 13553, 2018
LordSputnik
Thank you :)
2018-05-15 13507, 2018
LordSputnik
I'll have a read through the plan tomorrow morning (my time)
