11:26 AM
zas
isn't this search query handled by queen's solr ?
2018-05-19 13923, 2018
11:26 AM
samj1912
zas: iirc you set some nginx limits on solr
2018-05-19 13939, 2018
11:26 AM
samj1912
I can perform those queries if I login to the admin panel on queen's solr
2018-05-19 13921, 2018
11:27 AM
zas
but in this case, that's the backend returning a 500, i wonder if it even ends on solr
2018-05-19 13938, 2018
11:30 AM
zas
ok, it does it seems
2018-05-19 13924, 2018
11:31 AM
KassOtsimine
noo don't skip instruments lol
2018-05-19 13911, 2018
11:33 AM
KassOtsimine
hi samj1912 i'm here now!
2018-05-19 13915, 2018
11:33 AM
KassOtsimine
was reaading scrollback
2018-05-19 13901, 2018
11:34 AM
KassOtsimine
i deff wanna improve instruments search!
2018-05-19 13916, 2018
11:34 AM
KassOtsimine
sorry for being afk, was playing botw all yesterday :x
2018-05-19 13917, 2018
11:35 AM
zas
samj1912: i did a tcp packet capture, and it seems to me that's solr which is truncating the json output, leading to a 500 (because json is invalid)
2018-05-19 13954, 2018
11:37 AM
samj1912
weird
2018-05-19 13959, 2018
11:37 AM
samj1912
it shouldn't be doing that
2018-05-19 13941, 2018
11:40 AM
zas
i'll redo the capture may be i didn't capture everything
2018-05-19 13949, 2018
11:41 AM
KassOtsimine
D: u mad at me :(
2018-05-19 13922, 2018
11:42 AM
reosarevok
KassOtsimine: I don't think anyone is mad at you, we skipped them temporarily specifically to look into it when you're around :)
2018-05-19 13928, 2018
11:42 AM
HSOWA joined the channel
2018-05-19 13933, 2018
11:42 AM
reosarevok
(but something seems to be broken now, so I guess we need to wait a bit more :) )
2018-05-19 13939, 2018
11:42 AM
HSOWA
great and now my client crashed
2018-05-19 13957, 2018
11:42 AM
HSOWA
meh any link to the chatlogs
2018-05-19 13901, 2018
11:43 AM
HSOWA
?
2018-05-19 13918, 2018
11:43 AM
reosarevok
2018-05-19 13922, 2018
11:43 AM
reosarevok
Or something specific?
2018-05-19 13924, 2018
11:43 AM
HSOWA
cheers
2018-05-19 13929, 2018
11:43 AM
samj1912
HSOWA: hey, wasn't mad :P, just was helping zas and Leo_Verto with solr debugging
2018-05-19 13933, 2018
11:43 AM
HSOWA
my connection has been shit for a while :D
2018-05-19 13938, 2018
11:43 AM
HSOWA
👍
2018-05-19 13945, 2018
11:43 AM
samj1912
ill get back to you in a bit when I start doing instruments :)
2018-05-19 13950, 2018
11:43 AM
HSOWA
:DDDD
2018-05-19 13925, 2018
11:44 AM
HSOWA
but when is the areas search fix going on prod?
2018-05-19 13928, 2018
11:44 AM
HSOWA
or eve nbeta?
2018-05-19 13932, 2018
11:44 AM
HSOWA
i hope asap
2018-05-19 13949, 2018
11:44 AM
HSOWA
i don't even care about feature aprity. i ant this asafp
2018-05-19 13910, 2018
11:45 AM
HSOWA
i don't even care about feature parity. i want this asafp
2018-05-19 13920, 2018
11:45 AM
samj1912
lol :P
2018-05-19 13932, 2018
11:45 AM
samj1912
HSOWA: there are some other things we need to take care of
2018-05-19 13937, 2018
11:45 AM
HSOWA
ahha
2018-05-19 13948, 2018
11:45 AM
HSOWA
also yo u can still call me catcat or catquest here
2018-05-19 13949, 2018
11:45 AM
HSOWA
:D
2018-05-19 13908, 2018
11:46 AM
zas
samj1912: capture was incomplete, solr seems to answer correctly but mb website fails to handle it
2018-05-19 13926, 2018
11:46 AM
samj1912
seems like it
2018-05-19 13944, 2018
11:46 AM
samj1912
is it unable to parse a large json string?
2018-05-19 13946, 2018
11:46 AM
KassOtsimine has quit
2018-05-19 13915, 2018
11:47 AM
zas
yvanzo, bitmap ^^
2018-05-19 13927, 2018
11:47 AM
ruaok
how large?
2018-05-19 13942, 2018
11:47 AM
zas
this one is about 90kb (a bit less)
2018-05-19 13913, 2018
11:48 AM
zas
2018-05-19 13936, 2018
11:48 AM
zas
wiresharked decoded tcp stream
2018-05-19 13936, 2018
11:48 AM
HSOWA
or wait no. i forget this thing has a broken highlisht. if i select *any* words to highligt on it highlight on EVERYmessage
2018-05-19 13922, 2018
11:49 AM
ruaok
90kb should be zero problem at all.
2018-05-19 13942, 2018
11:49 AM
zas
but perhaps that's a json parsing issue, not related to the size
2018-05-19 13900, 2018
11:51 AM
ruaok
malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "GET /solr/recording/...") at /usr/local/bin/json_pp line 44.
2018-05-19 13943, 2018
11:51 AM
ruaok
ah, there is crap around it.
2018-05-19 13949, 2018
11:51 AM
zas
where did you get this log line ?
2018-05-19 13957, 2018
11:51 AM
ruaok
seems to parse fine.
2018-05-19 13912, 2018
11:52 AM
zas
hmm, the capture file is ascii, but content has utf8
2018-05-19 13913, 2018
11:52 AM
ruaok
json_pp on the command line, feeding it the whole file, which is not right. ignore that
2018-05-19 13904, 2018
11:53 AM
ruaok
json lint thinks its fine too.
2018-05-19 13918, 2018
11:53 AM
zas
2018-05-19 13929, 2018
11:53 AM
ruaok
2018-05-19 13947, 2018
11:53 AM
Leo_Verto
what's up with "{"artist":{"id":"622a275f-659f-4dc6-9964-0d33c34a786e","name":"Michel Fugain","sort-name":"Fugain, Michel","aliases":[{"sort-name":"...........................","name":"...........................","locale":null,"type":null,"primary":null,"begin-date":null,"end-date":null}"?
2018-05-19 13911, 2018
11:54 AM
Leo_Verto
are those just japanese characters not being rendered?
2018-05-19 13937, 2018
11:54 AM
zas
i see them
2018-05-19 13951, 2018
11:54 AM
zas
sort-name":"Fugain, Michel","aliases":[{"sort-name":"ミッシェル・フガン","name":"ミッシェル・フガン",
2018-05-19 13900, 2018
11:55 AM
Leo_Verto
2018-05-19 13913, 2018
11:55 AM
Leo_Verto
ah okay, just an ascii issue then
2018-05-19 13917, 2018
11:55 AM
ruaok
does this happen with all requests or just some?
2018-05-19 13923, 2018
11:55 AM
samj1912
just some
2018-05-19 13934, 2018
11:55 AM
samj1912
this is my first time encountering this
2018-05-19 13936, 2018
11:55 AM
ruaok
it might be an encoding issue.
2018-05-19 13949, 2018
11:55 AM
zas
there's no encoding header at all in the answer
2018-05-19 13952, 2018
11:55 AM
ruaok
where the json is valid, but the utf8 is not.
2018-05-19 13925, 2018
11:57 AM
Leo_Verto
seems like the searches fail if they're similar enough to "viva la"
2018-05-19 13942, 2018
11:57 AM
HSOWA
samj1912: i'm in the same room doing the dishes. when you are ready, just highlight me with HSOWA :D
2018-05-19 13951, 2018
11:57 AM
zas
likely because they contain same results
2018-05-19 13903, 2018
11:58 AM
Leo_Verto
"testing viva la" works but "aaaaaaaaa viva la" doesn't
2018-05-19 13923, 2018
11:58 AM
Leo_Verto
this means there's bad data somewhere, right?
2018-05-19 13936, 2018
11:58 AM
zas
what is happening to this json answer after solr returned it ?
2018-05-19 13922, 2018
11:59 AM
ruaok
they get parsed, and transformed into HTML or XML or a different JSON format.
2018-05-19 13928, 2018
11:59 AM
samj1912
HSOWA: okay :)
2018-05-19 13936, 2018
12:01 PM
github joined the channel
2018-05-19 13936, 2018
12:01 PM
github
[sir] samj1912 opened pull request #79: Improve query efficiency when calculating ref_counts (master...count)
https://git.io/vppNk
2018-05-19 13936, 2018
12:01 PM
github has left the channel
2018-05-19 13926, 2018
12:08 PM
beqn has quit
2018-05-19 13949, 2018
12:11 PM
samj1912
HSOWA: hey
2018-05-19 13958, 2018
12:11 PM
HSOWA
hi1
2018-05-19 13905, 2018
12:12 PM
samj1912
lets do instruments now :)
2018-05-19 13922, 2018
12:12 PM
HSOWA
i didn't get to finsih the fdishes, but <ny excuse not to do them :D
2018-05-19 13930, 2018
12:12 PM
HSOWA
any*
2018-05-19 13933, 2018
12:12 PM
samj1912
lol :P
2018-05-19 13947, 2018
12:12 PM
samj1912
so yeah, you know how to test it right?
2018-05-19 13957, 2018
12:12 PM
samj1912
can you try out some queries and see how it performs?
2018-05-19 13959, 2018
12:12 PM
HSOWA
test it on test
2018-05-19 13908, 2018
12:13 PM
samj1912
yup, with advanced mode on
2018-05-19 13917, 2018
12:13 PM
HSOWA
question: what about inline search?
2018-05-19 13939, 2018
12:13 PM
samj1912
inline search?
2018-05-19 13945, 2018
12:13 PM
samj1912
2018-05-19 13948, 2018
12:13 PM
HSOWA
2018-05-19 13956, 2018
12:13 PM
HSOWA
yes yes i know aoutthat
2018-05-19 13920, 2018
12:14 PM
HSOWA
my main concern is making usre people don't select "guitar family and viol family" when they want guitars and viol(da gamba)
2018-05-19 13921, 2018
12:14 PM
samj1912
I have no idea how that works
2018-05-19 13929, 2018
12:14 PM
HSOWA
lets find out!
2018-05-19 13933, 2018
12:14 PM
Leo_Verto
samj1912: I like how "eletric guitar" appears before regular guitar
2018-05-19 13940, 2018
12:14 PM
HSOWA
hmmm
2018-05-19 13948, 2018
12:14 PM
samj1912
Leo_Verto: I dont think that should happen :P
2018-05-19 13953, 2018
12:14 PM
HSOWA
indeed
2018-05-19 13913, 2018
12:15 PM
Leo_Verto
I feel like for instruments, exact name matches should be prioritized
2018-05-19 13920, 2018
12:15 PM
HSOWA
samj1912: can you make it so that anything with the *name* "family" goees last ?
2018-05-19 13939, 2018
12:15 PM
samj1912
as in?
2018-05-19 13940, 2018
12:15 PM
HSOWA
Leo_Verto: kindly butt out for a while (come in later pls :D)
2018-05-19 13951, 2018
12:15 PM
HSOWA
2018-05-19 13954, 2018
12:15 PM
HSOWA
samj1912:
2018-05-19 13922, 2018
12:16 PM
ZaphodBeeblebrox has quit
2018-05-19 13925, 2018
12:16 PM
HSOWA
anything iwth "family" in thr name should (ideally) show last in the list of anything searched
2018-05-19 13946, 2018
12:16 PM
reosarevok
(or anything with the "family" instrument type, I guess)
2018-05-19 13956, 2018
12:16 PM
HSOWA
yes that too
2018-05-19 13957, 2018
12:16 PM
ZaphodBeeblebrox joined the channel
2018-05-19 13957, 2018
12:16 PM
ZaphodBeeblebrox has quit
2018-05-19 13957, 2018
12:16 PM
ZaphodBeeblebrox joined the channel
2018-05-19 13901, 2018
12:17 PM
Leo_Verto
should it show at all?
2018-05-19 13912, 2018
12:17 PM
HSOWA
weeel
2018-05-19 13918, 2018
12:17 PM
reosarevok
Well it should show in inline search when catcat is adding relationships at least
2018-05-19 13928, 2018
12:17 PM
HSOWA
indeed :D
2018-05-19 13928, 2018
12:17 PM
reosarevok
I guess
2018-05-19 13933, 2018
12:17 PM
reosarevok
Otherwise it's hard to use :D
2018-05-19 13936, 2018
12:17 PM
samj1912
reosarevok: I am not at all sure how inline search is currently hooked
2018-05-19 13946, 2018
12:17 PM
HSOWA
but i can also search for "viol family"
2018-05-19 13957, 2018
12:17 PM
HSOWA
inline is my main concern
2018-05-19 13907, 2018
12:18 PM
HSOWA
*most* do not use the regular search for instrument use
2018-05-19 13909, 2018
12:18 PM
drsaunder has quit
2018-05-19 13912, 2018
12:18 PM
HSOWA
thy use inline for adding rels
2018-05-19 13918, 2018
12:18 PM
samj1912
2018-05-19 13925, 2018
12:18 PM
samj1912
well it seems to do that currently as well
2018-05-19 13926, 2018
12:18 PM
HSOWA
2018-05-19 13901, 2018
12:19 PM
reosarevok
HSOWA: ? the actual viola is super low, that is bad :p
2018-05-19 13901, 2018
12:19 PM
HSOWA
for inline seaerch too :O
2018-05-19 13905, 2018
12:19 PM
HSOWA
on test atleast
2018-05-19 13931, 2018
12:19 PM
HSOWA
we don't want viola to show up when searching for viol do we? for search "violla" wwe want it to be first
2018-05-19 13944, 2018
12:19 PM
reosarevok
But that's a "viola" search!
2018-05-19 13951, 2018
12:19 PM
HSOWA
erh "viola"
2018-05-19 13956, 2018
12:19 PM
HSOWA
oh duh
2018-05-19 13900, 2018
12:20 PM
HSOWA
yes that's bad bad
2018-05-19 13910, 2018
12:20 PM
reosarevok
2018-05-19 13918, 2018
12:20 PM
reosarevok
(other than violin family, but)
2018-05-19 13934, 2018
12:20 PM
HSOWA
yea. and honestly viola da gamba should show first, but :D
2018-05-19 13938, 2018
12:20 PM
samj1912
alias comment description iid instrument^2 ngram tag type
2018-05-19 13943, 2018
12:20 PM
samj1912
these are the current boosts
2018-05-19 13952, 2018
12:20 PM
samj1912
should I increase alias?
2018-05-19 13957, 2018
12:20 PM
HSOWA
you can lover the description and annotations
2018-05-19 13902, 2018
12:21 PM
samj1912
and do you want any particular type boosts?
