yvanzo: I think the difference between unknown barcode and known no barcode is whether it's NULL or an empty string? (Though I'm not sure which is which.)
hmm, thats interesting. So the preffered release formats is only used when looking up and not while scanning?
2018-06-03 15431, 2018
flormynight
is that expected behavior?
2018-06-03 15416, 2018
github joined the channel
2018-06-03 15416, 2018
github
[musicbrainz-server] yvanzo opened pull request #677: Tooling: Normalize external links to https & Set default blog link (master...tooling-https-blog) https://git.io/vhlJJ
2018-06-03 15416, 2018
github has left the channel
2018-06-03 15446, 2018
outsidecontext joined the channel
2018-06-03 15411, 2018
yvanzo
Freso, zas: “Bandcamp httpsification” is going on and will probably complete within 3 days using the script in gh:MBS#677.
picard-1122 isnt really a bug at all. it works as intended, you just need to lookup instead of scan with the acousticid
2018-06-03 15408, 2018
flormynight
is there a way for the preffered release types to work even with an acousticid?
2018-06-03 15439, 2018
flormynight
oh wait
2018-06-03 15441, 2018
flormynight
hmm
2018-06-03 15458, 2018
flormynight
it doesnt include the secondary types
2018-06-03 15441, 2018
flormynight
okay
2018-06-03 15453, 2018
github joined the channel
2018-06-03 15453, 2018
github
[picard] StasisInterrupted opened pull request #899: PICARD-1122: Preffered release type settings are exclusive and should be inclusive (master...picard-1122) https://git.io/vhlUo
2018-06-03 15453, 2018
github has left the channel
2018-06-03 15455, 2018
flormynight
so can someone tell me why release types arent available when doing fingerprint lookup vs doing?
2018-06-03 15420, 2018
Nyanko-sensei has quit
2018-06-03 15447, 2018
D4RK-PH0ENiX joined the channel
2018-06-03 15407, 2018
D4RK-PH0ENiX has quit
2018-06-03 15436, 2018
D4RK-PH0ENiX joined the channel
2018-06-03 15415, 2018
D4RK-PH0ENiX has quit
2018-06-03 15453, 2018
reosarevok
samj1912 or zas ^
2018-06-03 15456, 2018
D4RK-PH0ENiX joined the channel
2018-06-03 15420, 2018
Nyanko-sensei joined the channel
2018-06-03 15429, 2018
Nyanko-sensei has quit
2018-06-03 15457, 2018
Nyanko-sensei joined the channel
2018-06-03 15405, 2018
D4RK-PH0ENiX has quit
2018-06-03 15421, 2018
Nyanko-sensei has quit
2018-06-03 15431, 2018
D4RK-PH0ENiX joined the channel
2018-06-03 15441, 2018
Slurpee joined the channel
2018-06-03 15452, 2018
flormynight has quit
2018-06-03 15445, 2018
LordSputnik
bukwurm: could we move our meeting an hour earlier or later today?
2018-06-03 15445, 2018
bukwurm
LordSputnik: Ok. Earlier would be great for me, but late would work too
2018-06-03 15411, 2018
LordSputnik
Ok, about 50 minutes' time?
2018-06-03 15428, 2018
LordSputnik
Err *half an hour
2018-06-03 15431, 2018
LordSputnik
I misread the time
2018-06-03 15419, 2018
AfroThundr joined the channel
2018-06-03 15430, 2018
bukwurm_
LordSputnik: Ok
2018-06-03 15433, 2018
LordSputnik
bukwurm_: be with you in a few minutes
2018-06-03 15449, 2018
bukwurm
LordSputnik: 👍
2018-06-03 15422, 2018
LordSputnik
bukwurm: ok, here now
2018-06-03 15434, 2018
bukwurm
LordSputnik: Hi
2018-06-03 15435, 2018
LordSputnik
What topics would you like to talk about today? :)
2018-06-03 15412, 2018
bukwurm
LordSputnik: I worked and committed all of the infrastructure related code of bookbrainz-import today
2018-06-03 15456, 2018
bukwurm
I'll be fixing doc and performance may be, but major part is done.
2018-06-03 15450, 2018
LordSputnik
Ok, I saw that you opened up a lot of PRs
2018-06-03 15418, 2018
bukwurm
LordSputnik: One change - I have shifted all the configuration to a file, whose key is to be mentioned via command line.
2018-06-03 15433, 2018
LordSputnik
I'll try to review those in the next few hours or some time to tomorrow
2018-06-03 15452, 2018
bukwurm
For example, `./producer.js --dump editions`
2018-06-03 15454, 2018
bukwurm
If the producer.js is inside the OL folder, it will automatically look for configuration in the config.openLibrary.editions object inside the config/config.json file
2018-06-03 15428, 2018
LordSputnik
OK, will need to look into that in more detail
2018-06-03 15432, 2018
LordSputnik
But sounds sensible
2018-06-03 15442, 2018
bukwurm
LordSputnik: Ok
2018-06-03 15407, 2018
bukwurm
The first phase was supposed to be hard, and it absolutely is.
2018-06-03 15449, 2018
bukwurm
I'll try to finish up the bb-data part tomorrow and day after tomorrow.
2018-06-03 15409, 2018
LordSputnik
bukwurm: it would have been nicer to have a steady flow of pull requests submitted for the import code rather than 7 all at once
2018-06-03 15420, 2018
bukwurm
LordSputnik: I understand.
2018-06-03 15432, 2018
bukwurm
I was worried about the same too.
2018-06-03 15435, 2018
LordSputnik
You seem to have separated commits out well so it shouldn't be too hard to review
2018-06-03 15455, 2018
bukwurm
I'll make sure to definitely do that from now on.
2018-06-03 15459, 2018
LordSputnik
But just try to make PRs more spread out over the course of the week - hopefully they'll get reviewed faster then too
2018-06-03 15433, 2018
bukwurm
LordSputnik: The problem was, there was a lot of architecture design and code restructuring (almost every single day).
2018-06-03 15401, 2018
bukwurm
So I was always unsure if this would actually be the final design.
2018-06-03 15404, 2018
LordSputnik
OK, I get that problem too
2018-06-03 15448, 2018
LordSputnik
I'm aiming to start committing what I have early on, since you can always commit to change it
2018-06-03 15403, 2018
bukwurm
LordSputnik: ok
2018-06-03 15411, 2018
LordSputnik
It doesn't matter if the initial design is rubbish, nobody is judging you :)
2018-06-03 15438, 2018
bukwurm
LordSputnik: Good thing is, the final API reference is more or less fixed now.
2018-06-03 15456, 2018
LordSputnik
Another benefit is that it starts the feedback loop more quickly, and I might have some ideas that could save you an iteration or two of re-designing
2018-06-03 15401, 2018
LordSputnik
That's good
2018-06-03 15418, 2018
bukwurm
I have used async.js for scheduling async tasks to limit number of async tasks.
2018-06-03 15434, 2018
LordSputnik
So do the producer and consumer work at the moment? What bits of the functionality are implemented?
2018-06-03 15437, 2018
bukwurm
It's easy to understand and goes with the master-worker paradigm too.
2018-06-03 15411, 2018
bukwurm
Another alternative I seriously thought over and left for the moment was Bluebird's promise.map async limit.
2018-06-03 15434, 2018
bukwurm
If you think it would be better than the present design, I can change it later.
