#metabrainz

LordSputnik: pong

How's it going?

Ehh... kinda slow.

Oh, anything the matter?

I was travelling, so wasn't able to work much.

I'll try to make some good PRs by this Sunday before our meeting.

Ok

Will there be some data-js stuff?

Atleast aim to send in full working bbi and bbd

Yeah, I'll try to send it in.

zas, are you talking about disk space as in logs?

Ok, thanks

Anything you'd like to discuss?

I will decrease log verbosity tomorrow

LordSputnik: Nothing much to discuss right now. I'll bring up whatever I have on Sunday :)

LordSputnik: One thing that I wished to know though

In validation code on bbs, I can't find any mapping for _IdentifierType

What do you mean by mapping?

It's not defined anywhere?

LordSputnik: Yeah, I mean how is data mapped from the string on the UI to numerical values

Oh, I'll have a look at that and get back to you in the next few hours

Especially for IdentifierType mapping, when I print on console, it gives undefined.

LordSputnik: Ok

If I remember correctly, on the client side it just checks that the type id is a valid number, but in the server validation it also checks that the id is actually in the database

Right now, I am doing an SQL query and mapping all the data to JS objects

LordSputnik: So it does it by running it against db or is there some mapping within the codebase?

No it checks in the db

LordSputnik: Ok, so will it be fine if I manually map it within the code for bbi?

Else I'll look deeper in to bbs and replicate how it's done there :)

bukwurm: yeah you'll need to just fetch the types from the db to check that

LordSputnik: Would hard coding it do, or should I fetch it each time from the db?

LordSputnik: In helpers/entityRouteUtils.js

And in function validateForm definition for validators/work?publisher?publication?editor?creator.js

And validators/helpers:

I think IdentifierType are missing here as arguments.

Hmm ok, I'll have a look

samj1912: that's not only logs, but space used by sir data + pg data

hey all. it's been a while

it has. hi!

hey! Im at google this summer and the OS team is touring the country advertising GSoC and GCi. Will be good to see the team again. They're wondering if any past mentors/students want to give a presentation on their org/past student work, would you guys want me to say anything?

gcilou_: how cool we are? :p

lol that works

zas, sir does not use any data?

Are you talking about the old docker solr volume?

I found out, and removed this old volume

I thought it was related to sir, but that was just a leftover using 40gb

Cool, so we can keep sir on queen right?