#metabrainz

rsh7: ping https://www.irccloud.com/pastebin/1eNsACVu/

iliekcomputers: I am not even able to evaluate, i am getting a failed error all the time

failed error where?

anyways, are you running it from master branch?

yes, latest master

wait, sending you an error snippet

okay, i ran another evaluation and it seems to be doing stuff now?

it says evaluation completed now

okay, it is working normally for you then I guess.

I am getting this -

dataset_evaluator_1 | 2018-09-05 16:01:13,625 - INFO - Processing job ec3c053f-3c55-4d04-aa95-2d2d9e15fa86...

dataset_evaluator_1 | 2018-09-05 16:01:14,015 - INFO - Generating filelist.yaml and copying low-level data for evaluation...

dataset_evaluator_1 | 2018-09-05 16:01:14,190 - INFO - Evaluation job ec3c053f-3c55-4d04-aa95-2d2d9e15fa86 has failed!

dataset_evaluator_1 | 2018-09-05 16:01:14,242 - INFO -

dataset_evaluator_1 | 2018-09-05 16:01:14,248 - INFO - No pending datasets. Sleeping 30 seconds.

weird.

did you look into the code and see when we print that "failed!" message?

Freso: can't the githubbot just lurk in the channel?

iliekcomputers: yeah, https://github.com/metabrainz/acousticbrainz-se...

add a `raise` there to see what the `DatabaseException` is about

okay

metabrainz/picard#3696 (master - 72e12ab : Philipp Wolfer): The build passed.

Change view : https://github.com/metabrainz/picard/compare/7e...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

Freso: It has always been set to "message_without_join": "0" https://gist.github.com/yvanzo/46cb5ae85a0a816a...

metabrainz/picard#3696 (master - 72e12ab : Philipp Wolfer): The build passed.

Change view : https://github.com/metabrainz/picard/compare/7e...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

Freso: I did some attempts with BrainzGit from 23, Aug to Aug, 30; and today.

Freso: you know I think I would like an Alot of Research

a little one. to use as a little image :D

reosarevok: about MBS-9804 the date columns need to be added there https://github.com/metabrainz/musicbrainz-serve...

MBS-9804: Label dates do not appear on direct search https://tickets.metabrainz.org/browse/MBS-9804

Freso: https://tickets.metabrainz.org/browse/OTHER-332

OTHER-332: Replace GitHub IRC notifications service

rsh7: any updates?

gcilou: hi!

Hey :)

hei gcilou !!

bitmap: oh, duh. I guess I might as well do that myself then

Unless you're already doing it :)

helooo reosaurwok

now I'm thinking of a wok made with veggies and dinosaurs

Hey

Poor dinosaurs

:DDDD

aww

dinosaurs basically = birds so....

hi gcilou !

Hey ruaok :)

delicious chickendinosaurwok!!!

yvanzo, yeah, building that into BrainzBot may be a bit hard as the whole thing is designed as a unidirectional pipeline from bot > redis > plugins

but I can look into it

bitmap: what would you use as a key here? For the ACs. I'm not sure I have a great choice

but the entire spam situation got my matrix account kicked yay

reosarevok: I would just use the loop index (it makes no difference since it's a static page)

map index I mean, it's the second argument to the map callback

Huh. I only have one argument? :D

do I just give it a second argument and use that or?

yeah, to the function passed to map

if you have x => change it to (x, i) =>

Ok :)

Heh

[ { language_id: 120, work_id: 13221522, language: { name: 'English', entityType: 'language', id: 120 } } ]

No iso codes there currently. Which makes me wonder, why do we use the iso codes there anyway? (of course, we also don't have the translated names there, so)

Also bitmap: have you written anything for link_iswc yet, or should I just do it myself? :)

lemme see

ah we already have root/static/scripts/common/components/CodeLink.js for that

used for ISRCs too

Ok :) What about the languages? I'm not fully sure how to even load the codes etc for them :/

Oh, wait. Language TO_JSON, probs :D

Will look there

Wait, that doesn't even exist

maybe I have code for that too

or if you need to display the translated language name, you can copy languages.js from https://github.com/metabrainz/musicbrainz-serve... and use l_languages(language.name)

I need both, so thanks :)

Purrfect!

And now for something completely different - remind me how to amend previous commits with your suggestions in the PR? :)

note the commit you want to amend, do git rebase -i $commit^, and change the first column for that commit to 'e' for edit

after you make the necessary changes, git add the changed files and git rebase --continue

bitmap: for the instrument thing, are you thinking of something like this?

yeah, you don't really need the conditional since the html will just be empty in that case

I was getting an Error: No translation key found. otherwise though

ah, you're right

instrument thing

?

what are you doooing?

CatQuest: updating the instrument search results to React. So, nothing visible

(if I don't mess up)

:P

and aww

Well, maybe a tiny increase in loading speed of the search? :D

But like, tiny

Y U do dis? T__T

Because if they're all done, yvanzo said we can get an "all" search :p

i thought the point was react was better, faster, stronger.. last thing

(ok, not only that, but that'd be neat)

Well, it is, I just don't think the instrument search load was particularly slow

so why increase in loading?

duh

decrease :D

Sorry

oh

duh

now i get it

:D

increase in the speed

Decrease in the time

Whatevers :D

sorry cannot parse that as anything but "increase = longer" :D

ya, u wasn't :P

\m/ BrainZ \m/

bitmap: what's the reason for us to have separate inline-results-release.tt and the like?

reosarevok: separate from where?

results-release is basically just a wrapper with [% INCLUDE 'search/lib/inline-results-release.tt' %]

oh, hmm

they are also used by root/taglookup/results.tt

but I guess only certain types

We only have that for recording and release

(also why I haven't touched them yet :p )

artist, recording, release

But artist is already made

Which I guess means "do it the standard way and leave this behind for taglookup" or?

(since AFAICT that's what happened with artist)

yeah, that makes sense

taglookup won't be too hard to convert in any case but we can leave the inline files it needs for now

bitmap: any suggestions for [%- IF c.try_get_session('tport') -%] <th>[% l('Tagger') %]</th> [%- END %] on recording?

It's always been a bit weird for me that this affects search result display in this way tbh :/

the equivalent check in JS would be $c.session && $c.session.tport, and there's a TaggerIcon component already if you need that

Also, <th class="t pos">[% l('Track') %]</th> - is there a way to send a class for a column of PaginatedSearchResults? I guess not currently. Should I add one?

hmm, I guess so

Also II, is there a way to add *optional* columns? (for the Tagger thing)