#metabrainz

the release_name isn't in the metadata, even though we have a release_msid. :(

and we dont have an endpoint for looking up any msids that are not for recordings.

That's weird.

LB-389: The JSON export data does not contain release_name

we should try and fix that one sooner than later.

ruaok: oh, did you submit the release name

it seems submitted yes.

Messybrainz currently has a release msid for "" too apparently

what is the ID?

(which makes sense)

one sec

iliekcomputers: I'm back.

ruaok: it's different

so then it should have data submitted.

but I can't see why the release name would not be returned from the listenstore.

are we storing it? O_O

yes

it is in the db

"atlantic ballroom"?

yep

phew

hmm, now i wonder why we don't return it in the api :? https://www.irccloud.com/pastebin/jLIwrJ3b/

exactly.

and the JSON export function seems to use the same code.

i think it's a bug here: https://github.com/metabrainz/listenbrainz-serv...

missing after line 155, no

?

yeah, looks like it.

feel like doing a hotfix?

we have tests for release msid but not for release name :/

lol

ruaok: i'm off for dinner in like 10 mins, i'll do it after.

superb. :)

iliekcomputers: Regarding your suggestion, the get_data() function in our case has it's own context manager. So now, the connection will be closed by get_data() function. And thus the connection object will be unavailable for further execution.

code_master5: remove the with clause in the get_data fn and use the connection passed.

code_master5: just do it for all of them that need to do their work in the transaction.

Licensing question: I'm writing up a GCI task for students to come up with other fields to add to entities. I'm looking for a way to express that we do'nt want to touch any copyrighted material. Please help correct/complete:

"Keep in mind that any information added to BookBrainz must be in the public domain or a Creative Commons CC0 license"

(For BookBrainz, I forgot to mention)

Mr_Monkey: give examples of stuff that we don't want to add

Covers, content, whatever

reosarevok: I wanted to keep the door open for them to learn about CC licenses too, but I guess that would be the easy solution.

iliekcomputers: let me know when you have a PR to review. should be fast. :)

ruaok: yes, as soon as possible :)

iliekcomputers: https://github.com/metabrainz/critiquebrainz/pu... PR for creating JSON Dumps in a transaction. 😅

reosarevok: almost ready, just need to finish a few more macros

Ok :)

Mr_Monkey: well, it's not exactly about CC though, is it? We might have a CC cover or even CC content, we still can't store it!

reosarevok: Correct. I amended the task, thanks for the nudge

I would actually love it if we could store it :P But that would mean policing that *only* CC content was uploaded, so :(

ruaok: https://github.com/metabrainz/listenbrainz-serv...

hello it is I. CC

(this is the part wher I'd od osme silly reo-picture thing but alas i cannot)

We can't upload you to BB, CC

sadface

rsh7: hi, ping if you wanna add some gci tasks today, i'll be here for the next few hours.

code_master5: tests seem to be failing, you should take a look.

Mr_Monkey: you've done excellent work with the bb starter guide thing 👍

also, i'm not entirely happy with the `if else` blocks. :|

I have a couple more things i asked in that gdoc whne you have time for it also

Project bookbrainz-site build #1796: passed in 4 min 58 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

iliekcomputers: Regarding the tests, there are some pylint warnings. I'm not their author. I can't understand! Please help..

code_master5: yikes. i think that is a known bug. https://tickets.metabrainz.org/projects/CB/issu...

CB-311: With latest master, the pylint tests are failing

code_master5: if you want, you can fix them in a different PR :)

iliekcomputers: OK. What about the if else ?

I made a comment on github

iliekcomputers: OK.

:)

iliekcomputers: hey!

rsh7: hey! :)

outsidecontext: Ping? Want to help me troubleshoot a picard-git AUR package makepkg issue?

Yeh, i am here for some time. I have added a task yesterday & we have 3 now in total

rsh7: thanks!

rsh7: do we have more AB tasks we can add?

I think we should finish AB before we get to LB and CB

(and BrainzUtils)

give me a minute. finding my laptop

ok.

yvanzo: It would be great if you could start funnelling your triaged tickets into GCI tasks. :)

iliekcomputers: I'm taking a quick look at AB's goodfirstbugs now

Wizzup… is not here. :|

i'm sort of runnig out of ideas for tasks :(

i had one for adding an event. reo did a great write up of it

iliekcomputers: Just take a look here - https://tickets.metabrainz.org/browse/AB-319?jq...

AB-319: Remove usage of jsonify in webserver.views.datasets

I am not sure if this should be a gci task or not.

>However there are certain problems to doing this directly.

wow lol

i need to write better tickets

:p

rsh7: i think this one is a bit too under-described rn

let's leave it for now. I'll try to come back to it later

alright

I don't think there are more gci tasks in AB now except the one we discussed to add as a gci task when we met alastair

which one was that?

rsh7: if you convert gaia to python3, we could probably port AB to python3 this gci

>>which one was that?

updating/fixing website pages

iliekcomputers: seems good

weren't we discussing about keeping gaia with python2 and later removing its use by adopting new ML structure?

rsh7: do you remember what exactly needed fixing?

I can't recall exactly

rsh7: yeah, but i don't think that'll work, it would require keeping 2 different docker images for AB

which is not something I want to do.

maybe Freso does? :)

iliekcomputers: 2 different docker images for which case?

if we keep gaia python 2 and move AB to python3, we'd need two different docker images

I don't remember, no. alastairp would be my best bet for who remembers. Does it say in the summit note document?

iliekcomputers: oh yeah! okay, we should add port AB to python3 as a task then

only after someone has ported gaia :)

How big is gaia? Could it be done for GCI?

Freso: in short term: https://twitter.com/AcousticBrainz/status/10475...

Freso: i'm not sure, i don't think any of the mentors have the expertise to mentor porting gaia to py3

iliekcomputers: okay, I can work on porting gaia to python3

rsh7: great!

rsh7: ❤️

:)

But then, if you can work on it… maybe you could also do that in a mentor capacity. 😇

Anyway, seems like you got it covered. Ping me when you have tasks that need reviewing so they can get published.

ok

Freso: okay!

rsh7: if you're still here, do you think we should do LB or CB first?

(if that's all we have for AB rn)

iliekcomputers, rsh7: Be sure to keep up with Hangouts. :)

iliekcomputers: those 3 tasks should be okay for publish?

iliekcomputers: yeah, I'm here. rn even I don't think of any task for AB