11:54 AM
ruaok
the release_name isn't in the metadata, even though we have a release_msid. :(
2018-10-18 29130, 2018
11:57 AM
ruaok
and we dont have an endpoint for looking up any msids that are not for recordings.
2018-10-18 29130, 2018
11:57 AM
iliekcomputers
That's weird.
2018-10-18 29104, 2018
11:59 AM
ruaok
2018-10-18 29104, 2018
11:59 AM
BrainzBot
LB-389: The JSON export data does not contain release_name
2018-10-18 29109, 2018
11:59 AM
ruaok
we should try and fix that one sooner than later.
2018-10-18 29124, 2018
12:01 PM
iliekcomputers
2018-10-18 29148, 2018
12:01 PM
iliekcomputers
ruaok: oh, did you submit the release name
2018-10-18 29108, 2018
12:02 PM
ruaok
it seems submitted yes.
2018-10-18 29118, 2018
12:02 PM
iliekcomputers
Messybrainz currently has a release msid for "" too apparently
2018-10-18 29135, 2018
12:02 PM
ruaok
what is the ID?
2018-10-18 29151, 2018
12:02 PM
ruaok
(which makes sense)
2018-10-18 29158, 2018
12:03 PM
iliekcomputers
one sec
2018-10-18 29121, 2018
12:05 PM
code_master5
iliekcomputers: I'm back.
2018-10-18 29155, 2018
12:05 PM
iliekcomputers
ruaok: it's different
2018-10-18 29105, 2018
12:06 PM
ruaok
so then it should have data submitted.
2018-10-18 29118, 2018
12:06 PM
ruaok
but I can't see why the release name would not be returned from the listenstore.
2018-10-18 29102, 2018
12:07 PM
ruaok
are we storing it? O_O
2018-10-18 29141, 2018
12:07 PM
iliekcomputers
yes
2018-10-18 29143, 2018
12:07 PM
iliekcomputers
it is in the db
2018-10-18 29149, 2018
12:07 PM
iliekcomputers
"atlantic ballroom"?
2018-10-18 29154, 2018
12:07 PM
ruaok
yep
2018-10-18 29114, 2018
12:08 PM
iliekcomputers
2018-10-18 29124, 2018
12:08 PM
iliekcomputers
2018-10-18 29132, 2018
12:08 PM
ruaok
phew
2018-10-18 29145, 2018
12:09 PM
iliekcomputers
2018-10-18 29115, 2018
12:11 PM
ruaok
exactly.
2018-10-18 29126, 2018
12:11 PM
ruaok
and the JSON export function seems to use the same code.
2018-10-18 29139, 2018
12:17 PM
iliekcomputers
2018-10-18 29108, 2018
12:18 PM
ruaok
missing after line 155, no
2018-10-18 29109, 2018
12:18 PM
ruaok
?
2018-10-18 29130, 2018
12:18 PM
iliekcomputers
yeah, looks like it.
2018-10-18 29140, 2018
12:18 PM
ruaok
feel like doing a hotfix?
2018-10-18 29142, 2018
12:18 PM
iliekcomputers
we have tests for release msid but not for release name :/
2018-10-18 29149, 2018
12:18 PM
ruaok
lol
2018-10-18 29119, 2018
12:19 PM
iliekcomputers
ruaok: i'm off for dinner in like 10 mins, i'll do it after.
2018-10-18 29125, 2018
12:19 PM
ruaok
superb. :)
2018-10-18 29141, 2018
12:19 PM
iliekcomputers
2018-10-18 29144, 2018
12:20 PM
code_master5
iliekcomputers: Regarding your suggestion, the get_data() function in our case has it's own context manager. So now, the connection will be closed by get_data() function. And thus the connection object will be unavailable for further execution.
2018-10-18 29115, 2018
12:21 PM
iliekcomputers
code_master5: remove the with clause in the get_data fn and use the connection passed.
2018-10-18 29111, 2018
12:23 PM
code_master5
iliekcomputers: What about other functions that require the support for new connection?
2018-10-18 29155, 2018
12:23 PM
iliekcomputers
code_master5: just do it for all of them that need to do their work in the transaction.
2018-10-18 29137, 2018
12:40 PM
Leo_Verto has quit
2018-10-18 29150, 2018
12:46 PM
Leo_Verto joined the channel
2018-10-18 29100, 2018
13:22 PM
Mr_Monkey
Licensing question: I'm writing up a GCI task for students to come up with other fields to add to entities. I'm looking for a way to express that we do'nt want to touch any copyrighted material. Please help correct/complete:
2018-10-18 29106, 2018
13:22 PM
Mr_Monkey
"Keep in mind that any information added to BookBrainz must be in the public domain or a Creative Commons CC0 license"
2018-10-18 29118, 2018
13:23 PM
Mr_Monkey
(For BookBrainz, I forgot to mention)
2018-10-18 29109, 2018
13:31 PM
UmkaDK has quit
2018-10-18 29140, 2018
13:33 PM
UmkaDK joined the channel
2018-10-18 29115, 2018
13:40 PM
kartikeyaSh joined the channel
2018-10-18 29151, 2018
13:43 PM
ferbncode joined the channel
2018-10-18 29148, 2018
13:48 PM
reosarevok
Mr_Monkey: give examples of stuff that we don't want to add
2018-10-18 29155, 2018
13:48 PM
reosarevok
Covers, content, whatever
2018-10-18 29149, 2018
13:49 PM
Mr_Monkey
reosarevok: I wanted to keep the door open for them to learn about CC licenses too, but I guess that would be the easy solution.
2018-10-18 29142, 2018
13:52 PM
ruaok has quit
2018-10-18 29152, 2018
13:53 PM
ruaok joined the channel
2018-10-18 29157, 2018
14:07 PM
ruaok
iliekcomputers: let me know when you have a PR to review. should be fast. :)
2018-10-18 29140, 2018
14:11 PM
iliekcomputers
ruaok: yes, as soon as possible :)
2018-10-18 29123, 2018
14:37 PM
code_master5
2018-10-18 29131, 2018
14:56 PM
Sophist-UK has quit
2018-10-18 29137, 2018
14:56 PM
Sophist_UK joined the channel
2018-10-18 29138, 2018
15:01 PM
Sophist-UK joined the channel
2018-10-18 29151, 2018
15:03 PM
Sophist_UK has quit
2018-10-18 29114, 2018
15:30 PM
bitmap
reosarevok: almost ready, just need to finish a few more macros
2018-10-18 29103, 2018
16:13 PM
reosarevok
Ok :)
2018-10-18 29138, 2018
16:13 PM
reosarevok
Mr_Monkey: well, it's not exactly about CC though, is it? We might have a CC cover or even CC content, we still can't store it!
2018-10-18 29154, 2018
16:19 PM
culinko joined the channel
2018-10-18 29142, 2018
16:25 PM
Mr_Monkey
reosarevok: Correct. I amended the task, thanks for the nudge
2018-10-18 29138, 2018
16:26 PM
reosarevok
I would actually love it if we could store it :P But that would mean policing that *only* CC content was uploaded, so :(
2018-10-18 29112, 2018
16:29 PM
iliekcomputers
2018-10-18 29146, 2018
16:31 PM
Gazooo joined the channel
2018-10-18 29125, 2018
16:37 PM
CatQuest
hello it is I. CC
2018-10-18 29159, 2018
16:37 PM
CatQuest
(this is the part wher I'd od osme silly reo-picture thing but alas i cannot)
2018-10-18 29143, 2018
16:38 PM
reosarevok
We can't upload you to BB, CC
2018-10-18 29138, 2018
16:39 PM
CatQuest
sadface
2018-10-18 29154, 2018
16:39 PM
iliekcomputers
rsh7: hi, ping if you wanna add some gci tasks today, i'll be here for the next few hours.
2018-10-18 29134, 2018
16:40 PM
iliekcomputers
code_master5: tests seem to be failing, you should take a look.
2018-10-18 29121, 2018
16:41 PM
CatQuest
Mr_Monkey: you've done excellent work with the bb starter guide thing 👍
2018-10-18 29136, 2018
16:41 PM
iliekcomputers
also, i'm not entirely happy with the `if else` blocks. :|
2018-10-18 29139, 2018
16:41 PM
CatQuest
I have a couple more things i asked in that gdoc whne you have time for it also
2018-10-18 29100, 2018
16:42 PM
travis-ci joined the channel
2018-10-18 29101, 2018
16:42 PM
travis-ci
2018-10-18 29101, 2018
16:42 PM
travis-ci has left the channel
2018-10-18 29132, 2018
16:46 PM
code_master5
iliekcomputers: Regarding the tests, there are some pylint warnings. I'm not their author. I can't understand! Please help..
2018-10-18 29154, 2018
16:47 PM
iliekcomputers
2018-10-18 29155, 2018
16:47 PM
BrainzBot
CB-311: With latest master, the pylint tests are failing
2018-10-18 29132, 2018
16:48 PM
iliekcomputers
code_master5: if you want, you can fix them in a different PR :)
2018-10-18 29158, 2018
16:48 PM
code_master5
iliekcomputers: OK. What about the if else ?
2018-10-18 29110, 2018
16:49 PM
iliekcomputers
I made a comment on github
2018-10-18 29117, 2018
16:49 PM
code_master5
iliekcomputers: OK.
2018-10-18 29124, 2018
16:49 PM
iliekcomputers
:)
2018-10-18 29159, 2018
16:59 PM
rsh7
iliekcomputers: hey!
2018-10-18 29111, 2018
17:00 PM
iliekcomputers
rsh7: hey! :)
2018-10-18 29130, 2018
17:00 PM
Freso
outsidecontext: Ping? Want to help me troubleshoot a picard-git AUR package makepkg issue?
2018-10-18 29157, 2018
17:00 PM
rsh7
Yeh, i am here for some time. I have added a task yesterday & we have 3 now in total
2018-10-18 29117, 2018
17:01 PM
iliekcomputers
rsh7: thanks!
2018-10-18 29138, 2018
17:01 PM
iliekcomputers
rsh7: do we have more AB tasks we can add?
2018-10-18 29153, 2018
17:01 PM
iliekcomputers
I think we should finish AB before we get to LB and CB
2018-10-18 29159, 2018
17:01 PM
iliekcomputers
(and BrainzUtils)
2018-10-18 29122, 2018
17:03 PM
rsh7
give me a minute. finding my laptop
2018-10-18 29135, 2018
17:03 PM
iliekcomputers
ok.
2018-10-18 29142, 2018
17:13 PM
Freso
yvanzo: It would be great if you could start funnelling your triaged tickets into GCI tasks. :)
2018-10-18 29132, 2018
17:16 PM
rsh7
iliekcomputers: I'm taking a quick look at AB's goodfirstbugs now
2018-10-18 29109, 2018
17:17 PM
Freso
Wizzup… is not here. :|
2018-10-18 29140, 2018
17:17 PM
CatQuest
i'm sort of runnig out of ideas for tasks :(
2018-10-18 29155, 2018
17:17 PM
CatQuest
i had one for adding an event. reo did a great write up of it
2018-10-18 29149, 2018
17:23 PM
rsh7
2018-10-18 29149, 2018
17:23 PM
BrainzBot
AB-319: Remove usage of jsonify in webserver.views.datasets
2018-10-18 29159, 2018
17:23 PM
rsh7
I am not sure if this should be a gci task or not.
2018-10-18 29107, 2018
17:25 PM
iliekcomputers
>However there are certain problems to doing this directly.
2018-10-18 29109, 2018
17:25 PM
iliekcomputers
wow lol
2018-10-18 29114, 2018
17:25 PM
iliekcomputers
i need to write better tickets
2018-10-18 29154, 2018
17:25 PM
rsh7
:p
2018-10-18 29105, 2018
17:29 PM
iliekcomputers
rsh7: i think this one is a bit too under-described rn
2018-10-18 29120, 2018
17:29 PM
iliekcomputers
let's leave it for now. I'll try to come back to it later
2018-10-18 29146, 2018
17:30 PM
rsh7
alright
2018-10-18 29107, 2018
17:32 PM
rsh7
I don't think there are more gci tasks in AB now except the one we discussed to add as a gci task when we met alastair
2018-10-18 29116, 2018
17:33 PM
iliekcomputers
which one was that?
2018-10-18 29138, 2018
17:33 PM
iliekcomputers
rsh7: if you convert gaia to python3, we could probably port AB to python3 this gci
2018-10-18 29135, 2018
17:35 PM
rsh7
>>which one was that?
2018-10-18 29145, 2018
17:35 PM
rsh7
updating/fixing website pages
2018-10-18 29106, 2018
17:36 PM
rsh7
iliekcomputers: seems good
2018-10-18 29116, 2018
17:37 PM
rsh7
weren't we discussing about keeping gaia with python2 and later removing its use by adopting new ML structure?
2018-10-18 29116, 2018
17:37 PM
iliekcomputers
rsh7: do you remember what exactly needed fixing?
2018-10-18 29133, 2018
17:37 PM
rsh7
I can't recall exactly
2018-10-18 29141, 2018
17:37 PM
iliekcomputers
rsh7: yeah, but i don't think that'll work, it would require keeping 2 different docker images for AB
2018-10-18 29147, 2018
17:37 PM
iliekcomputers
which is not something I want to do.
2018-10-18 29102, 2018
17:38 PM
rsh7
maybe Freso does? :)
2018-10-18 29133, 2018
17:38 PM
rsh7
iliekcomputers: 2 different docker images for which case?
2018-10-18 29100, 2018
17:39 PM
iliekcomputers
if we keep gaia python 2 and move AB to python3, we'd need two different docker images
2018-10-18 29158, 2018
17:39 PM
kartikeyaSh has quit
2018-10-18 29111, 2018
17:40 PM
Freso
I don't remember, no. alastairp would be my best bet for who remembers. Does it say in the summit note document?
2018-10-18 29115, 2018
17:42 PM
rsh7
iliekcomputers: oh yeah! okay, we should add port AB to python3 as a task then
2018-10-18 29143, 2018
17:42 PM
iliekcomputers
only after someone has ported gaia :)
2018-10-18 29159, 2018
17:43 PM
Freso
How big is gaia? Could it be done for GCI?
2018-10-18 29124, 2018
17:44 PM
rsh7
2018-10-18 29146, 2018
17:44 PM
iliekcomputers
Freso: i'm not sure, i don't think any of the mentors have the expertise to mentor porting gaia to py3
2018-10-18 29147, 2018
17:44 PM
rsh7
iliekcomputers: okay, I can work on porting gaia to python3
2018-10-18 29103, 2018
17:45 PM
iliekcomputers
rsh7: great!
2018-10-18 29121, 2018
17:45 PM
Freso
rsh7: ❤️
2018-10-18 29140, 2018
17:45 PM
rsh7
:)
2018-10-18 29148, 2018
17:45 PM
Freso
But then, if you can work on it… maybe you could also do that in a mentor capacity. 😇
2018-10-18 29126, 2018
17:46 PM
Freso
Anyway, seems like you got it covered. Ping me when you have tasks that need reviewing so they can get published.
2018-10-18 29116, 2018
17:47 PM
iliekcomputers
ok
2018-10-18 29138, 2018
17:47 PM
rsh7
Freso: okay!
2018-10-18 29154, 2018
17:47 PM
iliekcomputers
rsh7: if you're still here, do you think we should do LB or CB first?
2018-10-18 29155, 2018
17:47 PM
iliekcomputers
(if that's all we have for AB rn)
2018-10-18 29128, 2018
17:48 PM
Freso
iliekcomputers, rsh7: Be sure to keep up with Hangouts. :)
2018-10-18 29133, 2018
17:48 PM
rsh7
iliekcomputers: those 3 tasks should be okay for publish?
2018-10-18 29114, 2018
17:49 PM
rsh7
iliekcomputers: yeah, I'm here. rn even I don't think of any task for AB
