if you're here, maybe we can spend some time on the PR you're working on.
2018-10-30 30344, 2018
iliekcomputers
did you by any means get the chance to setup a local dev environment?
2018-10-30 30359, 2018
chhavi_
iliekcomputers: I knew I had a point. 😂
2018-10-30 30317, 2018
iliekcomputers
chhavi_: :)
2018-10-30 30349, 2018
ruaok
yvanzo: thanks. I'll try this a bit later.
2018-10-30 30352, 2018
ruaok
zas: thanks.
2018-10-30 30309, 2018
iliekcomputers
ruaok: i'll deploy the rabbitmq thing. should fix a lot of sentry errors.
2018-10-30 30321, 2018
ruaok
great.
2018-10-30 30351, 2018
github joined the channel
2018-10-30 30351, 2018
github
[listenbrainz-server] paramsingh closed pull request #445: Remove pika pool and use own connection pooling (production...muh-rabbitmq-pool) https://git.io/fx78P
2018-10-30 30351, 2018
github has left the channel
2018-10-30 30326, 2018
ruaok
iliekcomputers: did you just log into the LB twitter account?
2018-10-30 30330, 2018
iliekcomputers
yes.
2018-10-30 30334, 2018
ruaok
ok.
2018-10-30 30348, 2018
ruaok
I got one of those "OMFG someone is using your account emails".
2018-10-30 30321, 2018
iliekcomputers
yeah, i figured. I was gonna ask if I should tweet about each release from now on.
2018-10-30 30329, 2018
ruaok
please do.
2018-10-30 30337, 2018
iliekcomputers
great.
2018-10-30 30339, 2018
ruaok
I tweeted the blog post from earlier.
2018-10-30 30343, 2018
CatQuest
// Remove pika pool and use own connection pooling//
2018-10-30 30344, 2018
CatQuest
ok I suggest calling that chu-pool .. just sayin' :D
2018-10-30 30308, 2018
iliekcomputers
CatQuest: i don't get it.
2018-10-30 30311, 2018
iliekcomputers
ruaok: yes, i see.
2018-10-30 30316, 2018
CatQuest
pika-pool?
2018-10-30 30321, 2018
CatQuest
chu-pool?
2018-10-30 30339, 2018
iliekcomputers
what's a chu?
2018-10-30 30345, 2018
CatQuest
pika.. chu
2018-10-30 30349, 2018
iliekcomputers
oh
2018-10-30 30353, 2018
CatQuest
yes :D
2018-10-30 30353, 2018
iliekcomputers dum dum
2018-10-30 30306, 2018
CatQuest
nah, :D
2018-10-30 30308, 2018
reosarevok
Opinion time!
2018-10-30 30313, 2018
CatQuest
hi reosarevok !
2018-10-30 30323, 2018
reosarevok
Do we add GENRE or something for genre requests, or deal with them through STYLE for now
2018-10-30 30332, 2018
CatQuest
+1 for GENRE
2018-10-30 30333, 2018
reosarevok
It's going to be me either way :D But maybe GENRE is cleaner
2018-10-30 30339, 2018
CatQuest
esp sicne it'll be it's own thingi n the future
2018-10-30 30343, 2018
reosarevok
Freso: thoughts?
2018-10-30 30331, 2018
Freso
Maybe a single STYLE ticket for people to write in missing ones for now?
2018-10-30 30349, 2018
Freso
Could even be MBS, since it's really MBS code changes to add (or remove) genres.
2018-10-30 30303, 2018
CatQuest
¯\_(ツ)_/¯ what's easiest for reo to act on
2018-10-30 30327, 2018
Freso
Once it's its own thing, we could make its own thing for them, depending on how they become their own thing.
2018-10-30 30310, 2018
Freso
As I understand it, the next step is to move from a hardcoded list to having the list in the database, in which case it's clearly a STYLE thing, so maybe just use STYLE for now?
It just feels like it maybe makes more sense to have GENRE already now than try to find and move all the relevant STYLE tickets later
2018-10-30 30344, 2018
CatQuest
oh about the POST or whatever remembered text field thing...
2018-10-30 30350, 2018
reosarevok
(or worse, leave them behind and be inconsistent)
2018-10-30 30303, 2018
CatQuest
will that be fixored before it's in prod?
2018-10-30 30315, 2018
reosarevok
I definitely do not want one single STYLE ticket, because then that can never be closed :p
2018-10-30 30315, 2018
CatQuest
yea i feel GENRE wil lbe sort of "future proofing" ?
2018-10-30 30325, 2018
outsidecontext_ has quit
2018-10-30 30336, 2018
Freso
Or it could be premature optimisation.
2018-10-30 30317, 2018
CatQuest
i guess it'd be easier to move fro mgenre to style later though...
2018-10-30 30318, 2018
reosarevok
Why, you expect we'll not add genres in the future anymore? :/
2018-10-30 30325, 2018
Freso
"try to find […] all the relevant STYLE tickets later" Add a category or label for genres and use that. Then they're all already grouped together if we decide to make a separate project for them later.
2018-10-30 30337, 2018
CatQuest
as far as I understand it. with the caveat that I don't know code at all 😅
2018-10-30 30337, 2018
CatQuest
is that it'll be its own entity, and work not too dissimmilar ot instruments today
2018-10-30 30353, 2018
reosarevok
I'm just confused what would come later that would make a difference to whether GENRE makes sense or not
2018-10-30 30357, 2018
Freso
I want to see it be its own entity before I believe it. :)
2018-10-30 30305, 2018
CatQuest
¬¬
2018-10-30 30310, 2018
reosarevok
Either it does make sense, because we want people requesting them, or it doesn't, because we don't, no?
2018-10-30 30320, 2018
reosarevok
And since we do want people requesting them...
2018-10-30 30323, 2018
reosarevok shrugs
2018-10-30 30341, 2018
Freso
No, we can want people requesting genres under STYLE or anything else.
2018-10-30 30300, 2018
CatQuest
seems to me that's not what reo wants though :o
2018-10-30 30300, 2018
Freso
We don't have an MBSBUGS projects because we want people to report bugs with MBS.
2018-10-30 30317, 2018
Freso
We do want people to report bugs, but under project of MBS.
2018-10-30 30334, 2018
reosarevok
Sure, but having them as style seems to be coupling them with style while I intended them to work like instruments or areas
2018-10-30 30338, 2018
Freso
As I see it right now, genres are a subset of style, and thus should be filed under STYLE.
2018-10-30 30301, 2018
Freso
Do they work like instruments and areas right now?