People request them and one person adds them, so yeah, pretty much?
2018-10-30 30334, 2018
Freso
CatQuest: That's why I also said that MBS could be a viable project for them for now. :)
2018-10-30 30343, 2018
CatQuest
¯\_(ツ)_/¯
2018-10-30 30351, 2018
CatQuest butts out
2018-10-30 30358, 2018
Freso
But since there are at least tangible plans of moving the list into the db, I'm also fine with it being under STYLE.
2018-10-30 30314, 2018
Freso
Genre entities seem to me to be a bit further in the future.
2018-10-30 30314, 2018
CatQuest
but there are tangible plans to moving thme to their own entity too
2018-10-30 30352, 2018
reosarevok
I don't think there's any need for them to be their own entity before they can have their own project
2018-10-30 30355, 2018
Freso
Next schema change? Or the one after? Or the one after that?
2018-10-30 30301, 2018
reosarevok
But maybe I'm wrong :D
2018-10-30 30337, 2018
CatQuest
well I guessalso making it GENRE will make people autoamtically chose that whne asking or genres too, instead of choosing style, maybe mbs becasue they don't know
2018-10-30 30340, 2018
ferbncode has quit
2018-10-30 30306, 2018
CatQuest
or or (what's the code for search?)
2018-10-30 30326, 2018
Freso
I don't think it makes sense to have a "GENRE" project until we are able to give them aliases, links, etc. If it's just adding to/from a list (hardcoded or in db), then I'd say STYLE.
2018-10-30 30337, 2018
Freso goes to get food and go home now
2018-10-30 30346, 2018
Slurpee joined the channel
2018-10-30 30346, 2018
Slurpee has quit
2018-10-30 30346, 2018
Slurpee joined the channel
2018-10-30 30324, 2018
github joined the channel
2018-10-30 30324, 2018
github
[picard-plugins] abhi-ohri opened pull request #174: Handle exceptions with in Tonal Rhythm Plugin (2.0...patch-1) https://git.io/fxdow
2018-10-30 30324, 2018
github has left the channel
2018-10-30 30317, 2018
github joined the channel
2018-10-30 30317, 2018
github
[listenbrainz-server] paramsingh opened pull request #446: Merge production into master (master...merge-branch) https://git.io/fxdKN
2018-10-30 30317, 2018
github has left the channel
2018-10-30 30352, 2018
michelv has quit
2018-10-30 30321, 2018
ruaok
iliekcomputers: ^^
2018-10-30 30336, 2018
ruaok
I'm not sure that it makes sense to submit PRs for production<->master merges.
2018-10-30 30309, 2018
ruaok
it is all code that has been reviewed before and the tests should catch merge errors.
2018-10-30 30328, 2018
ruaok
it is really hard to actually try and review these. I think you should skip them, if tests pass.
2018-10-30 30332, 2018
iliekcomputers
alright, just thought PRs made sure everyone knew when merges took place.
2018-10-30 30304, 2018
iliekcomputers
But that can be done via irc
2018-10-30 30308, 2018
ruaok
ok, if you want to keep a record of the merges, then go ahead.
2018-10-30 30324, 2018
ruaok
just merge it afterwards without waiting for a review. :)
2018-10-30 30334, 2018
iliekcomputers
Yeah, sounds like a good plan
2018-10-30 30309, 2018
ruaok
feel free to merge after fixing tests.
2018-10-30 30350, 2018
UmkaDK has quit
2018-10-30 30337, 2018
github joined the channel
2018-10-30 30337, 2018
github
[brainzutils-python] PROTechThor opened pull request #23: Create function_documentation.rst (master...PROTechThor-function-documentation) https://git.io/fxdyL
