you have the right idea putting it under Controller, only problem is Controller::Artist wouldn't affect other types of entities
2018-11-02 30633, 2018
thefar8 joined the channel
2018-11-02 30646, 2018
bitmap
`method _load` in lib/MusicBrainz/Server/Controller/Role/Load.pm is a good spot, I think. there you have the $id from the URL, and you can compare it with the id on $entity to see if it's different and perform the redirect
2018-11-02 30652, 2018
bitmap
let me know if you have trouble with that!
2018-11-02 30610, 2018
bitmap
for core entities $id will be an mbid, which you want to compare against $entity->gid
[picard] virusMac opened pull request #1024: PICARD-1325: Allow disabling new version update checking for packagers (master...PICARD-1325) https://git.io/fxx1d
zas: do we have a standard way in which we deal with services that always daemonize inside of containers?
2018-11-02 30614, 2018
ruaok
to build out the spark cluster, we need to have the hadoop file system and there are two services needed for this. but the daemonize and I can't monitor them via runit
2018-11-02 30650, 2018
zas
There's no way to prevent it?
2018-11-02 30624, 2018
ruaok
none that I see in the version we use.
2018-11-02 30646, 2018
ruaok
I see one in a later version, but I don't feel like opening that can of worms right this second.
2018-11-02 30600, 2018
ruaok
(can of worms being how the nodes coordinate with each other)
2018-11-02 30623, 2018
thefar8 joined the channel
2018-11-02 30632, 2018
zas
So I guess you don't have much choice, just use a wrapper script to supervise those
2018-11-02 30649, 2018
ruaok
do we have one laying around I can re-use?
2018-11-02 30646, 2018
zas
Not sure, as most can run in foreground
2018-11-02 30629, 2018
zas
what you could do is a simple script, running the daemon, checking if it still runs in a loop (with sleep) using its pid or smt like that, not ideal though, it defeats the purpose of runit
2018-11-02 30653, 2018
ruaok
yea, I was hoping we'd have some code for that already.
2018-11-02 30638, 2018
zas
well, most services can actually run in foreground, and http://smarden.org/runit/faq.html#create explicitely says "Note that for the use with runit, service daemons must not put themself into the background, but must run in the foreground."
2018-11-02 30608, 2018
ruaok
yes, I understand that.
2018-11-02 30612, 2018
zas
so the case was avoided i think (bitmap? yvanzo?)
2018-11-02 30615, 2018
zas
that said, you can "fake" it using a wrapper, catching signals and sending them to the daemon
[critiquebrainz] code-master5 opened pull request #222: CB-322: Display error if unable to create spotify mapping (master...spotify-add-error) https://git.io/fxpJl
2018-11-02 30614, 2018
github has left the channel
2018-11-02 30608, 2018
outsidecontext joined the channel
2018-11-02 30612, 2018
iliekcomputers
ruaok: do you get an ISE on current_status page?
2018-11-02 30626, 2018
CatQuest has quit
2018-11-02 30600, 2018
CatQuest joined the channel
2018-11-02 30600, 2018
CatQuest has quit
2018-11-02 30600, 2018
CatQuest joined the channel
2018-11-02 30647, 2018
CatQuest has quit
2018-11-02 30641, 2018
ruaok
ah, thanks Freso
2018-11-02 30600, 2018
ruaok
iliekcomputers: no, still shows -1 on the production.
2018-11-02 30610, 2018
ruaok
same on beta.
2018-11-02 30651, 2018
iliekcomputers
i see, just checking. i was wondering why it didn't ISE.
2018-11-02 30612, 2018
iliekcomputers
ruaok: I'm here when you wanna talk about LB.
2018-11-02 30645, 2018
ruaok
lets take a moment to update trello, shall we?
2018-11-02 30654, 2018
ruaok
"Verify that data in new LB dataset is consistent"
2018-11-02 30658, 2018
ruaok
good enough for now?
2018-11-02 30608, 2018
iliekcomputers
+1
2018-11-02 30631, 2018
iliekcomputers
cleanup is ongoing. will probably be an ongoing process.
2018-11-02 30649, 2018
iliekcomputers
there are a few rabbitmq connection closures i'm looking into
2018-11-02 30656, 2018
ruaok
ok, sounds good.
2018-11-02 30600, 2018
ruaok
I'm still working on the spark cluster creation scripts.
2018-11-02 30634, 2018
ruaok
things are complicated as you might imagine -- I think I have a setup that creates HDFS/Yarn containers.
2018-11-02 30617, 2018
ruaok
it is still pretty rough, but I dont want to spend more time on dealing with it, since I dont know if this will work or we will want to continue this approach.
2018-11-02 30630, 2018
iliekcomputers
cluster creation scripts mean scripts we put number of nodes, addresses etc in and it brings the cluster up?
2018-11-02 30637, 2018
ruaok
yes.
2018-11-02 30649, 2018
ruaok
might be more manual at first, but same difference.
2018-11-02 30600, 2018
ruaok
I'd say let me keep at that.
2018-11-02 30623, 2018
iliekcomputers
ok, are they on github?
2018-11-02 30627, 2018
ruaok
I think you should just to the next list and figure out how to load a data dump and then how to stream new listens.
I need to integrate this repo into the LB playground stuff.
2018-11-02 30600, 2018
ruaok
I also don't know yet how to tell Spark that there is a yarn cluster it should use.
2018-11-02 30602, 2018
iliekcomputers
ok.
2018-11-02 30636, 2018
iliekcomputers
that might a part of the pyspark script we'd run
2018-11-02 30643, 2018
ruaok
should we say that the deadline for one week from today is to have a proof of concept version of loading LB data and a clear idea of how streaming should work?
2018-11-02 30659, 2018
ruaok
yeah, possibly. not sure yet.
2018-11-02 30601, 2018
iliekcomputers
sounds good.
2018-11-02 30647, 2018
ruaok
ok, trello updated. let me know if anything else needs tweaking
2018-11-02 30604, 2018
iliekcomputers
looks good to me for this week.
2018-11-02 30658, 2018
outsidecontext has quit
2018-11-02 30630, 2018
code_master5
iliekcomputers: Wanted to ask something regarding the error if unable to create spotify mapping.
2018-11-02 30649, 2018
code_master5
iliekcomputers: currently, in both the cases (success or error), it redirects to the page showing list of mappings. I think it should redirect to entity page in case error occurs.
2018-11-02 30624, 2018
iliekcomputers
code_master5: do you have an example of the list of mappings page?
here, it could not add mapping, but still redirected to page where list of mappings are there.
2018-11-02 30606, 2018
thefar8 has quit
2018-11-02 30607, 2018
iliekcomputers
code_master5: should still go to the mappings page
2018-11-02 30612, 2018
iliekcomputers
imo
2018-11-02 30620, 2018
code_master5
iliekcomputers: I just realized that there is a button `Add new mapping` in mappings list page. So it should be fine in that case.
2018-11-02 30645, 2018
iliekcomputers
great
2018-11-02 30617, 2018
thefar8 joined the channel
2018-11-02 30650, 2018
CatQuest has quit
2018-11-02 30623, 2018
CatQuest joined the channel
2018-11-02 30617, 2018
CatQuest has quit
2018-11-02 30619, 2018
github joined the channel
2018-11-02 30619, 2018
github
[listenbrainz-server] paramsingh closed pull request #450: Use new rabbitmq connection pooler in the current-status view (production...queue-vals) https://git.io/fxpLg
2018-11-02 30619, 2018
github has left the channel
2018-11-02 30653, 2018
CatQuest joined the channel
2018-11-02 30612, 2018
CatQuest has quit
2018-11-02 30647, 2018
CatQuest joined the channel
2018-11-02 30647, 2018
CatQuest has quit
2018-11-02 30647, 2018
CatQuest joined the channel
2018-11-02 30642, 2018
github joined the channel
2018-11-02 30642, 2018
github
[listenbrainz-server] paramsingh opened pull request #451: Merging production into master (master...merge-branch) https://git.io/fxpGQ
