11:06 AM
CatQuest
i mena. uh yo uhave a link to the thing to propose.. it's jsut style but it has some extra things?
11:06 AM
alastairp
reosarevok: right, not saying that "it has to be a tag"
11:06 AM
reosarevok
Should add something there about adding more
11:06 AM
alastairp
but "it has to be understandable as a genre but already used in MB"
11:06 AM
reosarevok
CatQuest: yes, just style with Genres as the component
11:07 AM
CatQuest
you had this "usl with the title fileld in as "genre name here" or osmething
11:07 AM
reosarevok
11:07 AM
CatQuest
url
11:07 AM
alastairp
(in that case, CatQuest's kawaii metal perhaps only just scrapes in, as it's only a tag for an artist)
11:07 AM
CatQuest
like we did with the gci task that time
11:07 AM
alastairp: that's... not tru?
11:07 AM
reosarevok
Yeah, I don't think I can pre-select a component. I tried, but
11:07 AM
CatQuest
it' a genre
11:07 AM
reosarevok
CatQuest: in MB at the moment, I imagine
11:07 AM
CatQuest
actulaly that page *should* yes
11:08 AM
reosarevok
alastairp: I'd say "either that or is on WP as a genre"
11:08 AM
I mean, if trigger-happy enwiki people haven't removed it yet, it must have some support :p
11:08 AM
alastairp
absolutely
11:08 AM
CatQuest
alastairp: rather thna that it shoud lbe used *outside* of mb imho
11:08 AM
alastairp searches wikipedia for "is a genre"
11:09 AM
alastairp
CatQuest: that's a good point, but should we add genres which are accepted out of MB, but which are not used as any tag in MB?
11:09 AM
CatQuest
11:10 AM
alastairp: i don't see why not?
11:10 AM
people hacent tagged everything
11:10 AM
haven't*
11:11 AM
iliekcomputers
ruaok: i restarted the master services on rec-master.lb and it seems to have broken something. we should catch up on the ports and the small things I've found out. I'm gonna be afk for the next few hours but after that, if you get the time.
11:11 AM
CatQuest
(for example. I only learned 3-4 days ago that "Kawaii metal" was a *thing* and that there were more than babymetal about it)
11:11 AM
now tat I know. i fully intent ot tag BM with it :D
11:12 AM
reosarevok: STYLE-1092
11:12 AM
BrainzBot
11:13 AM
ruaok
iliekcomputers: ok, sounds good. Something is definitely brittle...
11:17 AM
CatQuest
there. way more things tagged with "Kawaii metal" :D
11:18 AM
alastairp
CatQuest: isn't subjectivity great??? :)
11:18 AM
CatQuest
my favourite name is "Necronomidol"
11:18 AM
hey you are perfectly velcome to like, vote down the things
11:18 AM
even if like wikipedia is my source :D
11:19 AM
but genres are like, just your opinion, man
11:20 AM
reosarevok
Well, they're the opinion of a social mass or something
11:20 AM
But, yeah :D
11:20 AM
CatQuest
11:21 AM
antara has quit
12:00 PM
ferbncode joined the channel
12:03 PM
george
Did someone claim the MusicBrainz track length task?
12:04 PM
yvanzo
Yes.
12:06 PM
D4RK-PH0ENiX has quit
12:11 PM
george
Cool cool
12:13 PM
yvanzo
No worry, there still is an unpublished task to be unveiled for MBS, and some more to be added.
12:15 PM
There currently are at least 4 coding tasks available for MBS.
12:23 PM
george
Sounds good :)
12:30 PM
discopatrick joined the channel
12:36 PM
D4RK-PH0ENiX joined the channel
12:37 PM
ruaok
reosarevok: do you know what is up with the "musicbrainz security breach" email to support @?
12:51 PM
reosarevok
ruaok: No fucking clue
12:51 PM
Was planning to check that properly a bit later today
12:52 PM
ruaok
ok, sounds like a bug rather than a security issue. if is it a security issue, I would think its on their end.
12:59 PM
reosarevok
Yeah, I suspect that's the case
13:43 PM
thefar8 joined the channel
13:54 PM
code_master5 joined the channel
14:14 PM
Lotheric_ joined the channel
14:17 PM
Lotheric has quit
14:28 PM
github joined the channel
14:28 PM
github
[picard] phw closed pull request #1037: PICARD-1414: Fix info dialog crash on non-str album errors (master...PICARD-1050-fix-info-dialog-crash)
https://git.io/fpONK
14:28 PM
github has left the channel
14:29 PM
c1e0 joined the channel
14:32 PM
adhawkins has quit
14:32 PM
adhawkins joined the channel
14:33 PM
adhawkins has quit
14:34 PM
adhawkins joined the channel
14:42 PM
travis-ci joined the channel
14:42 PM
travis-ci
metabrainz/picard#4055 (master - 7bd1c3a : Philipp Wolfer): The build passed.
14:42 PM
14:42 PM
14:42 PM
travis-ci has left the channel
14:49 PM
outsidecontext has quit
15:16 PM
culinko has quit
15:24 PM
antara joined the channel
15:28 PM
c1e0 has quit
15:42 PM
antara has quit
16:07 PM
iliekcomputers
ruaok: hi
16:08 PM
i'm here for the next few hours.
16:25 PM
cats has quit
16:30 PM
cats joined the channel
16:50 PM
travis-ci joined the channel
16:50 PM
travis-ci
16:50 PM
travis-ci has left the channel
16:53 PM
alastairp
16:59 PM
code_master5
16:59 PM
BrainzBot
CB-324: 'View older revisions' link is not displayed properly
17:00 PM
code_master5
iliekcomputers: should we just move 'View older revisions' link to a new row?
17:02 PM
iliekcomputers
code_master5: +1
17:03 PM
travis-ci joined the channel
17:03 PM
travis-ci
17:03 PM
travis-ci has left the channel
17:47 PM
Dr-Flay joined the channel
18:00 PM
michelv has quit
18:00 PM
github joined the channel
18:00 PM
github
[critiquebrainz] code-master5 opened pull request #225: CB-324: Correctly display older revisions link (master...older-revision-link)
https://git.io/fp3VW
18:00 PM
github has left the channel
18:04 PM
yvanzo
alastairp: would be neat, reported as OTHER-332
18:04 PM
BrainzBot
18:10 PM
c1e0 joined the channel
18:57 PM
reosarevok
yvanzo: "Preferably put this localizable string on a single line, to anticipate migration to React."
18:57 PM
I thought too long lines were bad practice :) I certainly don't mind tho
18:57 PM
Will change
18:58 PM
Should all be changed now
18:59 PM
yvanzo
reosarevok: I agree, that's bad practice, the l10n toolchain needs improving, but til then...
18:59 PM
reosarevok
Ok :)
18:59 PM
Does it understand properly when you have multiline JS strings like Stuff \ more stuff?
19:01 PM
yvanzo
IIRC it introduces spurious line break.
19:02 PM
reosarevok
Sigh
19:12 PM
thefar8 has quit
19:23 PM
c1e0 has quit
19:31 PM
alastairp
yvanzo: 👍, needs a server to run it on though
19:32 PM
but if it's faster than GH hook and allows us to auth a user to freesound that works well with our channel mode
19:32 PM
and potentially gives us the chance to send even more stuff to irc :-P
20:03 PM
george
bitmap: thanks for the approval :))
20:03 PM
bitmap
:)
20:03 PM
thanks for the PR!
20:06 PM
discopatrick has quit
20:12 PM
reosarevok
bitmap: did you see my tageditor comments?
20:13 PM
bitmap
yeah, meant to follow up on that
20:13 PM
you said the MainTagEditor doesn't submit at all? locally or in prod?
20:13 PM
code_master5 has quit
20:17 PM
it works for me locally
20:17 PM
reosarevok
locally, when trying to convert to react. So wondering what the hell I must have done
20:18 PM
bitmap
not sure what you meant by no loopparity since it does use it in the file
20:19 PM
reosarevok
Well, I have this
20:19 PM
20:20 PM
When logged out, TagsComponent nicely displays with the right style etc. When logged in, MainTagEditor shows all white with no loopparity stuff, and I'm trying to figure out why
20:21 PM
(also yeah, trying to submit tags does nothing either)
20:23 PM
(wondering also why the sidebar component uses the stash bits, because my understanding is we should avoid those and send props)
20:24 PM
(so whether I should keep reusing the stash or try and use props :) )
20:35 PM
reosarevok wonders if bitmap just fainted because I got the dumbs too much :D
20:44 PM
meek
20:44 PM
"Attackers on
ia601506.us.archive.org may trick you into doing something dangerous like installing software or revealing your personal information (for example, passwords, phone numbers, or credit cards)."
20:45 PM
bright red screen
20:45 PM
won't let me access the site
20:45 PM
reosarevok
meek: known. Nothing we can do :( Something in the same Internet Archive server where our cover art is has been detected by Google as fishy
20:45 PM
We need to wait until they solve the mess
20:45 PM
meek
gotcha thanks
20:46 PM
reosarevok
The images themselves are fine, so you should be able to just find the small print somewhere of "let me in anyway"
20:46 PM
meek
yeah I clicked through, just wasn't sure if it was known or not - accessed yesterday with no problem
20:48 PM
reosarevok
It comes and goes, depending on what server is serving the front covers displayed
20:49 PM
antfoo joined the channel
20:53 PM
bitmap
reosarevok: lol sorry, back now
20:54 PM
is your branch pushed somewhere I can take a look?
20:57 PM
stuff should generally be passed as props, yes
20:58 PM
reosarevok
Sure
20:59 PM
20:59 PM
(I've been trying things out, so it might be a bit messy now)