Not sure if this output doesn't map properly to our tests or I just can't read it yet, but I have no idea where to look for "50 not ok" on the file - what's 50? :D
2018-11-20 32432, 2018
Cyna has quit
2018-11-20 32442, 2018
bukwurm has quit
2018-11-20 32447, 2018
yvanzo
reosarevok: not sure what 50 refers to but you have to update t/script/DumpJSON.t which has tags only not genres
2018-11-20 32447, 2018
code_master5 joined the channel
2018-11-20 32402, 2018
reosarevok
Ok, I'll look at that (but still would love to understand how this shit works on jenkins at some point :D )
2018-11-20 32457, 2018
yvanzo
From what I’ve found, 50 might stands for test ran from the line 161 of DumpJSON.t.
2018-11-20 32415, 2018
antara has quit
2018-11-20 32459, 2018
thefar8 joined the channel
2018-11-20 32405, 2018
Leo_Verto
CatQuest, in German we use "Spanish" instead :P
2018-11-20 32425, 2018
Mr_Monkey
Leo_Verto, CatQuest : In french, something I don't understand would be "du Chinois".
2018-11-20 32411, 2018
c1e0 joined the channel
2018-11-20 32454, 2018
reosarevok
yvanzo: lol, I added genres to stuff and now I have more errors
2018-11-20 32402, 2018
reosarevok
(and I can't test this locally, it seems, it just fails)
2018-11-20 32417, 2018
c1e0 has quit
2018-11-20 32422, 2018
yvanzo
reosarevok: you should update tested code too, that is everything about Dump under lib/MusicBrainz/Script/ :)
2018-11-20 32441, 2018
c1e0 joined the channel
2018-11-20 32439, 2018
CallerNo6 has quit
2018-11-20 32418, 2018
Hello29 joined the channel
2018-11-20 32435, 2018
Hello29 has quit
2018-11-20 32433, 2018
code_master5
Anyone? I'm just ...
2018-11-20 32406, 2018
reosarevok
code_master5: ? :)
2018-11-20 32416, 2018
code_master5
alone!
2018-11-20 32421, 2018
code_master5
reosarevok: Sorry.
2018-11-20 32405, 2018
c1e0 has quit
2018-11-20 32416, 2018
iliekcomputers
Proxy.listenbrainz wasn't returning data for some reason, restarted container fixed.
2018-11-20 32451, 2018
iliekcomputers
code_master5: hi! =)
2018-11-20 32407, 2018
Mr_Monkey
code_master5: I agree, it's pretty quiet out here…
2018-11-20 32436, 2018
thefar8 has quit
2018-11-20 32459, 2018
c1e0 joined the channel
2018-11-20 32451, 2018
CatQuest
Leo_Verto, Mr_Monkey: and I belive the chinese say something like "it's heavenly script"
2018-11-20 32415, 2018
Mr_Monkey
That's great !
2018-11-20 32455, 2018
CatQuest
george: hi!
2018-11-20 32426, 2018
george
CatQuest: Hello :)
2018-11-20 32456, 2018
CatQuest
well what can I say, like the others saying, you do great work!
2018-11-20 32456, 2018
CatQuest
(I only wish you'd picked a less ambigious instrument for me ot decide on :D)
2018-11-20 32443, 2018
CatQuest
it's really interesting ,but also balances on the nife-edge of the "novelty" clause :D
2018-11-20 32443, 2018
CatQuest
knife*
2018-11-20 32424, 2018
george
Thank you!! I had quite a hard time finding an instrument not already in musicbrainz tbh
2018-11-20 32424, 2018
george
No worries, I'm happy to research another this evening just to be safe
2018-11-20 32459, 2018
CatQuest
heh. I'm asking with reo (the other mentor) about this. in any case i hope you'll do more instrument tasks evne still :)
2018-11-20 32428, 2018
CatQuest
if you're looking for instruments to add tickets for there is actually a ticket with some suggstions.. let me see
(I'm trying to convince you to claim more "instrument" tasks after this one, if it's not obvious ;))
2018-11-20 32458, 2018
george
Haha I'm definitely planning to :)
2018-11-20 32404, 2018
CatQuest
:D
2018-11-20 32439, 2018
iliekcomputers
zas: can you look at what's happening with proxy.listenbrainz.org on lemmy once? requests don't actually seem to reach the container, i had restarted it, which fixed it for a while but the error is back.
CatQuest: I’ve submitted one of the ones from the list that you sent anyways 👍
2018-11-20 32439, 2018
rdswift
Yeah, it's one I requested. No problem with taking so long. I just want to finalize the instrument credits on the release whenever a decision is made whether or not this should be added.
2018-11-20 32442, 2018
CatQuest
the version is up for after this one
2018-11-20 32437, 2018
rdswift
I'm not in any real rush. Just thought I heard that people were running out of instruments to reasearch. Quite possible I misunderstood, because I just skimmed the conversation quickly.
2018-11-20 32446, 2018
CatQuest
heh
2018-11-20 32412, 2018
CatQuest
ohnestly there are *so* many instruments we still don't have. also there are many isntrments to still research. that one, https://tickets.metabrainz.org/browse/INST-183 for example. etc many things
2018-11-20 32412, 2018
BrainzBot
INST-183: Player Piano
2018-11-20 32405, 2018
CatQuest
george: that ticket can be a subticket! (I don't know if you have the availablility to "convert to sub-task" here so i'll do it)
2018-11-20 32434, 2018
george
Great, thanks!
2018-11-20 32434, 2018
rdswift
Oh yeah, I remember that I owe you some things on this. I have to get away for an hour or so for some lab tests, but will try to get you my thoughts after that.
2018-11-20 32445, 2018
CatQuest
cheers!
2018-11-20 32449, 2018
CatQuest
(to both of you ;))
2018-11-20 32453, 2018
zas
iliekcomputers: i didn't set up this stuff, why do you ask me ? ;)
from listenbrainz-api-compat-prod container on lemmy
2018-11-20 32444, 2018
zas
btw is listenbrainz-api-compat-nginx using an hardcoded ip/port ?
2018-11-20 32437, 2018
zas
i restarted both containers, and it seems to be back
2018-11-20 32400, 2018
zas
iliekcomputers: but people who actually set up those services have to look what was the issue
2018-11-20 32423, 2018
michelv joined the channel
2018-11-20 32430, 2018
zas
Freso: discourse upgrade procedure was fixed, i deployed it.
2018-11-20 32418, 2018
CatQuest
for a sec i read "I destroyed it" :D
2018-11-20 32447, 2018
spuniun has quit
2018-11-20 32454, 2018
c1e0
CatQuest: Me too! :D
2018-11-20 32402, 2018
CatQuest
:D
2018-11-20 32449, 2018
zas
well, that was 2 days ago ;)
2018-11-20 32410, 2018
CatQuest
you destroyed it two days ago? :O
2018-11-20 32411, 2018
CatQuest
:D
2018-11-20 32423, 2018
spuniun joined the channel
2018-11-20 32447, 2018
Mineo
I intermittently saw some protocol errors from firefox/curl instead of the usual "you've reached a sleepy server" message during the upgrade. was that intentional?
2018-11-20 32441, 2018
CatQuest
i love he "sleepy server" thing. but i wnat the sleepy cat one
2018-11-20 32435, 2018
creature_ joined the channel
2018-11-20 32422, 2018
creature has quit
2018-11-20 32428, 2018
creature_ is now known as creature
2018-11-20 32438, 2018
creature has quit
2018-11-20 32438, 2018
creature joined the channel
2018-11-20 32403, 2018
c1e0 has quit
2018-11-20 32417, 2018
code_master5 has quit
2018-11-20 32453, 2018
michelv has quit
2018-11-20 32407, 2018
rdswift
CatQuest, my opinions regrading Player Piano... First, it is a piano (upright piano are the only ones I've seen). It is played as a piano -- you press the keys, they activate the hammers which strike the strings, thus creating the sound.
2018-11-20 32420, 2018
rdswift
The only difference with a player piano is that there is an additional mechanism installed to press the keys based upon a set program (the paper roll fed through the mechanism).
2018-11-20 32439, 2018
rdswift
If it's the "player piano" portion of the instrument we're talking about, it isn't played so much as it's actually programmed.
2018-11-20 32455, 2018
rdswift
I can't immediately think of another instrument to use as an analogy.
2018-11-20 32447, 2018
rdswift
You can program a drum track, but it doesn't actually play a drumset by striking the drums, symbols, etc with drumsticks to create the sound. It's all done electronically.
