#metabrainz

/

      • travis-ci joined the channel
      • 2018-11-28 33216, 2018

      • travis-ci
        Project bookbrainz-site build #1926: passed in 4 min 33 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2018-11-28 33216, 2018

      • travis-ci has left the channel
      • 2018-11-28 33217, 2018

      • michelv_ joined the channel
      • 2018-11-28 33241, 2018

      • c1e0 has quit
      • 2018-11-28 33218, 2018

      • ruaok
        docker-compose -f docker/docker-compose.yml -p bookbrainz run bookbrainz-site scripts/create-db.sh
      • 2018-11-28 33259, 2018

      • ruaok
        docker-compose -f docker/docker-compose.yml -p bookbrainz run bookbrainz-site scripts/download-import-dump.s
      • 2018-11-28 33235, 2018

      • Dr-Flay joined the channel
      • 2018-11-28 33226, 2018

      • github joined the channel
      • 2018-11-28 33226, 2018

      • github
        [picard-plugins] phw closed pull request #184: Work & Movement (2.0...workandmovement) https://git.io/fpuuC
      • 2018-11-28 33226, 2018

      • github has left the channel
      • 2018-11-28 33200, 2018

      • github joined the channel
      • 2018-11-28 33200, 2018

      • github
        [picard] phw closed pull request #1055: PICARD-1428: Fix deleting tags only in original file metadata (master...PICARD-1428-fix-removing-original-tag) https://git.io/fp2P4
      • 2018-11-28 33200, 2018

      • github has left the channel
      • 2018-11-28 33235, 2018

      • github joined the channel
      • 2018-11-28 33236, 2018

      • github
        [picard] phw closed pull request #1054: When deleting tags also consider renamed tags (master...fix-delete-renamed-tags) https://git.io/fp28n
      • 2018-11-28 33236, 2018

      • github has left the channel
      • 2018-11-28 33219, 2018

      • outsidecontext has quit
      • 2018-11-28 33223, 2018

      • travis-ci joined the channel
      • 2018-11-28 33224, 2018

      • travis-ci
        Project bookbrainz-site build #1927: passed in 5 min 43 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2018-11-28 33224, 2018

      • travis-ci has left the channel
      • 2018-11-28 33227, 2018

      • travis-ci joined the channel
      • 2018-11-28 33228, 2018

      • travis-ci
        metabrainz/picard#4113 (master - da9cdbd : Philipp Wolfer): The build passed.
      • 2018-11-28 33228, 2018

      • travis-ci
      • 2018-11-28 33228, 2018

      • travis-ci
      • 2018-11-28 33228, 2018

      • travis-ci has left the channel
      • 2018-11-28 33217, 2018

      • travis-ci joined the channel
      • 2018-11-28 33218, 2018

      • travis-ci
        metabrainz/picard#4114 (master - 48b2dde : Philipp Wolfer): The build passed.
      • 2018-11-28 33219, 2018

      • travis-ci
      • 2018-11-28 33219, 2018

      • travis-ci
      • 2018-11-28 33219, 2018

      • travis-ci has left the channel
      • 2018-11-28 33248, 2018

      • Dr-Flay has left the channel
      • 2018-11-28 33212, 2018

      • travis-ci joined the channel
      • 2018-11-28 33213, 2018

      • travis-ci
        Project bookbrainz-site build #1928: passed in 5 min 14 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2018-11-28 33213, 2018

      • travis-ci has left the channel
      • 2018-11-28 33202, 2018

      • CatQuest
        reeeeeeeeeeeeeee
      • 2018-11-28 33204, 2018

      • CatQuest
        (osarevok)
      • 2018-11-28 33217, 2018

      • michelv_ has quit
      • 2018-11-28 33257, 2018

      • Mr_Monkey
        Leftmost: it turns out that with an eye on bringing BB into the MB architecture in 2019, it might be a problem that BB moves to Portgres 10.
      • 2018-11-28 33257, 2018

      • Mr_Monkey
        What are the issues that you are running into for the BB schema changes? Is it only renaming the enum values?
      • 2018-11-28 33257, 2018

      • Mr_Monkey
        And follow up question for everybody around: does anyone have a trick to rename enum values in postgres 9.5 ? :)
      • 2018-11-28 33255, 2018

      • Mr_Monkey
        (I know we all collectively agreed there was no reason why not to move BB to psql 10, but apparently we had a collective brainfart, sorry)
      • 2018-11-28 33235, 2018

      • Leftmost
        Yeah, that occurred to me. The enum rename is the only real issue. There are tricks to cast to a new enum, but they all seem to rely on text values, which doesn't actually help.
      • 2018-11-28 33202, 2018

      • Mr_Monkey
        I think our three options right now are
      • 2018-11-28 33202, 2018

      • Mr_Monkey
        1) Find a way to do the migration using v9.6 — suggestions welcome
      • 2018-11-28 33202, 2018

      • Mr_Monkey
        2) Leave the enums as-is until MeB moves to v10
      • 2018-11-28 33202, 2018

      • Mr_Monkey
        3) Use a postgres container separate from MeB
      • 2018-11-28 33202, 2018

      • Mr_Monkey
        #3 is the one I abhorre most, and I would consider it a blocker to reaching our MVP.
      • 2018-11-28 33202, 2018

      • Mr_Monkey
        Let's see if anyone has suggestions for #1, and if not, see how we can live with #2
      • 2018-11-28 33256, 2018

      • ruaok
        enums are not really a good enough reason to cause the pain to wait for PG 10.
      • 2018-11-28 33222, 2018

      • ruaok
        let's find another way of solving this problem for now -- once we get to 10, then we can fix the enums properly.
      • 2018-11-28 33251, 2018

      • Mr_Monkey
        ruaok: By waiting for PG 10, I mean keeping the enum labels as-is instead of renaming them (Creator->Author for example)
      • 2018-11-28 33253, 2018

      • Leo_Verto
        would using a newer version of the same container be an option?
      • 2018-11-28 33213, 2018

      • Leo_Verto
        i.e. use a VAR for the postgres version and select that at container build time, then tag the container appropriately
      • 2018-11-28 33255, 2018

      • CatQuest
        [20:38] <Mr_Monkey> 2) Leave the enums as-is until MeB moves to v10
      • 2018-11-28 33256, 2018

      • CatQuest
        completely dumb non-coder user here
      • 2018-11-28 33256, 2018

      • CatQuest
        but that's my opinion? (fwiw)
      • 2018-11-28 33226, 2018

      • CatQuest
        the other two jsut seems like way too much hassle
      • 2018-11-28 33229, 2018

      • Mr_Monkey
        Leftmost knows what he's talking about, and I don't really, but if I'm not mistaken, the result would be that our website and ORM usean entity name that is different from the schema name. Ugly.
      • 2018-11-28 33252, 2018

      • Mr_Monkey
        But not a blocker, I suppose.
      • 2018-11-28 33245, 2018

      • CatQuest
        when is meb going to PG 10?
      • 2018-11-28 33208, 2018

      • Mr_Monkey
        CatQuest: I think that's a discussion for next Monday :)
      • 2018-11-28 33237, 2018

      • george
        Hey CatQuest! Just wondering whether you’ve hade the time to take a glance at my inst requests?
      • 2018-11-28 33239, 2018

      • CatQuest
        yea exactly. just wondered if the eta is sometime early first quarter 19 or halfway through, it's fine to wait on bb
      • 2018-11-28 33246, 2018

      • CatQuest
        erh it's fine for bb to wait
      • 2018-11-28 33249, 2018

      • Leftmost
        The enum rename isn't, I suppose, a blocker to schema change, as it won't have a user-facing effect.
      • 2018-11-28 33257, 2018

      • CatQuest
        george: hola! i am literally going trough those now :D
      • 2018-11-28 33208, 2018

      • Leftmost
        It just makes the schema change incomplete.
      • 2018-11-28 33246, 2018

      • CatQuest
        Leftmost: sounds unsatesfying. but as long as it doenst casue a problem later with scema change..
      • 2018-11-28 33208, 2018

      • CatQuest
        but then again, we should find out if it *will* becasue this sounds liek the kidn of thing that could casue a massive problem once it's time to update
      • 2018-11-28 33244, 2018

      • george
        CatQuest: Oh, that’s great 😄
      • 2018-11-28 33247, 2018

      • Mr_Monkey
        Leftmost: would something like this work? https://blog.yo1.dog/updating-enum-values-in-post…
      • 2018-11-28 33251, 2018

      • CatQuest
        george: actually there was another student who did that exact instrument (krap)
      • 2018-11-28 33252, 2018

      • CatQuest
        however there is a problem that it seems that isntrument is 3 instruments in one! so
      • 2018-11-28 33252, 2018

      • CatQuest
        we (me and reo) asked the other tudent to make some more ticets (and they said they'd do another task for 2 such) *however*
      • 2018-11-28 33252, 2018

      • CatQuest
        it'd be easiest if you coudl work together with this tudent, and you could split the 3 instruments between you to work on
      • 2018-11-28 33209, 2018

      • george
        ah okay i see
      • 2018-11-28 33214, 2018

      • george
        Is this student on the irc?
      • 2018-11-28 33226, 2018

      • CatQuest
        sometimes i've seen them. newbiecoder
      • 2018-11-28 33249, 2018

      • george
        Hmm, do you know how I might be able to get in contact?
      • 2018-11-28 33219, 2018

      • CatQuest
        https://tickets.metabrainz.org/browse/INST-750 is their ticket, so probably it coudl be throught there or trough irc
      • 2018-11-28 33219, 2018

      • BrainzBot
        INST-750: Krap-An instrument from Cambodia and Thailand
      • 2018-11-28 33254, 2018

      • CatQuest
        this has been doen itno the krap koo
      • 2018-11-28 33202, 2018

      • Leftmost
        Mr_Monkey, it won't, for a couple reasons.
      • 2018-11-28 33229, 2018

      • george
        For now, I’ll do a different instrument, but I’ll work with this student for those instruments on the side over the next couple of weeks (if that’s okay?)
      • 2018-11-28 33235, 2018

      • CatQuest
        so the other two are remaining krap puang and another for krap saepa.
      • 2018-11-28 33242, 2018

      • CatQuest
        that's totlaly ok
      • 2018-11-28 33257, 2018

      • CatQuest
        let's loo kat the work you've doen now (I also have a couple other tasks to look at)
      • 2018-11-28 33206, 2018

      • CatQuest
        oh george don't edit the "create clapper-tree" (INST-630) or other inst ticket unless i say it's ok, it's confusing for me :D
      • 2018-11-28 33206, 2018

      • BrainzBot
      • 2018-11-28 33229, 2018

      • CatQuest
        (linking and making subtickets is fine)
      • 2018-11-28 33202, 2018

      • george
        Sure thing, that makes sense
      • 2018-11-28 33248, 2018

      • CatQuest
        right. so this is what I'll do. can i sak you to make one other instrument ticket (since technically the other student made that instrument) and then hopwfulyl the two of you can work on the "krap" :D together
      • 2018-11-28 33214, 2018

      • CatQuest
        (like, lummi stikc is fine ;))
      • 2018-11-28 33243, 2018

      • CatQuest
        and I'll explain it to thme as well and approve both your tasks
      • 2018-11-28 33205, 2018

      • CatQuest
        and then you can go and do another thing
      • 2018-11-28 33211, 2018

      • CatQuest
        sound good?
      • 2018-11-28 33234, 2018

      • CatQuest
        oh yes "For now, I’ll do a different instrument, but I’ll work with this student for those instruments on the side over the next couple of weeks (if that’s okay?)"
      • 2018-11-28 33235, 2018

      • CatQuest
        yes that's great!
      • 2018-11-28 33249, 2018

      • george
        Perfect! I'll start researching a new instrument now then :)
      • 2018-11-28 33206, 2018

      • CatQuest
        (there are more on that clapper tree (hint hint) ) ;)
      • 2018-11-28 33221, 2018

      • george
        Lummi sticks it is then 👌
      • 2018-11-28 33243, 2018

      • CatQuest
        :D
      • 2018-11-28 33220, 2018

      • Leo_Verto
      • 2018-11-28 33220, 2018

      • ruaok
        interesting. :)
      • 2018-11-28 33242, 2018

      • ruaok
        we should bisect that. what is the lowest version that will work?
      • 2018-11-28 33202, 2018

      • ruaok
        probably 9.5, come to think of it.
      • 2018-11-28 33206, 2018

      • Leo_Verto
        technically whatever version both the lowest here https://hub.docker.com/r/library/postgres/tags/ and the lowest available postgresql-server-dev package would work
      • 2018-11-28 33213, 2018

      • Leo_Verto
        I need to go now, I can answer further questions later
      • 2018-11-28 33242, 2018

      • dk joined the channel
      • 2018-11-28 33235, 2018

      • c1e0 joined the channel
      • 2018-11-28 33217, 2018

      • dk has quit
      • 2018-11-28 33245, 2018

      • CatQuest
        george: I'm going to "RMW" the ticket, and oyu cna re-submit it once you've doen that other instrument. it's late her and i need to sleep also. so I'll look at it in the morning :)
      • 2018-11-28 33214, 2018

      • george
        Sounds like a plan
      • 2018-11-28 33219, 2018

      • CatQuest
        👍 you're doing great work (I suspect you're getting sick of hearing this :P)
      • 2018-11-28 33224, 2018

      • george
        thanks, i'm happy to help where i can :)
      • 2018-11-28 33238, 2018

      • CatQuest
        that's the spirit! :D
      • 2018-11-28 33231, 2018

      • CatQuest
        ok everyone. good night :D
      • 2018-11-28 33237, 2018

      • CatQuest
        💤
      • 2018-11-28 33244, 2018

      • c1e0 has quit
      • 2018-11-28 33202, 2018

      • rdswift has quit
      • 2018-11-28 33246, 2018

      • dolina has quit
      • 2018-11-28 33202, 2018

      • rdswift joined the channel
      • 2018-11-28 33239, 2018

      • dolina joined the channel
      • 2018-11-28 33240, 2018

      • jwf has quit
      • 2018-11-28 33236, 2018

      • jwf joined the channel
      • 2018-11-28 33244, 2018

      • george
        night!