0:20 AM
Lotheric has quit
2018-12-03 33720, 2018
0:21 AM
D4RK-PH0ENiX has quit
2018-12-03 33727, 2018
0:40 AM
D4RK-PH0ENiX joined the channel
2018-12-03 33743, 2018
0:55 AM
protiumoxide joined the channel
2018-12-03 33756, 2018
0:59 AM
deuteriumoxide has quit
2018-12-03 33749, 2018
1:01 AM
Nyanko-sensei joined the channel
2018-12-03 33735, 2018
1:02 AM
Lotheric joined the channel
2018-12-03 33752, 2018
1:03 AM
D4RK-PH0ENiX has quit
2018-12-03 33755, 2018
1:03 AM
deuteriumoxide joined the channel
2018-12-03 33720, 2018
1:07 AM
protiumoxide has quit
2018-12-03 33713, 2018
1:16 AM
modwizcode joined the channel
2018-12-03 33711, 2018
1:18 AM
deuteriumoxide has quit
2018-12-03 33748, 2018
1:36 AM
Nyanko-sensei has quit
2018-12-03 33723, 2018
1:37 AM
D4RK-PH0ENiX joined the channel
2018-12-03 33703, 2018
1:54 AM
deuteriumoxide joined the channel
2018-12-03 33701, 2018
3:15 AM
Leo_Verto_ joined the channel
2018-12-03 33722, 2018
3:17 AM
Leo_Verto has quit
2018-12-03 33722, 2018
3:17 AM
Leo_Verto_ is now known as Leo_Verto
2018-12-03 33727, 2018
3:23 AM
deuteriumoxide has quit
2018-12-03 33757, 2018
3:46 AM
deuteriumoxide joined the channel
2018-12-03 33713, 2018
4:44 AM
protiumoxide joined the channel
2018-12-03 33747, 2018
4:47 AM
deuteriumoxide has quit
2018-12-03 33741, 2018
4:51 AM
protiumoxide has quit
2018-12-03 33749, 2018
4:51 AM
protiumoxide joined the channel
2018-12-03 33722, 2018
4:57 AM
thefar8[m]
bookbrainz down?
2018-12-03 33748, 2018
5:02 AM
thefar8[m]
nvm
2018-12-03 33745, 2018
6:23 AM
outsidecontext joined the channel
2018-12-03 33747, 2018
6:24 AM
protiumoxide has quit
2018-12-03 33750, 2018
6:31 AM
michelv joined the channel
2018-12-03 33737, 2018
6:39 AM
bukwurm joined the channel
2018-12-03 33700, 2018
7:03 AM
c1e0 joined the channel
2018-12-03 33738, 2018
8:02 AM
bitmap
reosarevok: can you paste the flow error you had with the subHeading? (sorry for the delay >_<)
2018-12-03 33757, 2018
8:18 AM
yvanzo
mo''in'
2018-12-03 33733, 2018
8:31 AM
c1e0 has quit
2018-12-03 33724, 2018
8:37 AM
c1e0 joined the channel
2018-12-03 33746, 2018
8:59 AM
reosarevok
bitmap: still around?
2018-12-03 33732, 2018
9:05 AM
michelv_ joined the channel
2018-12-03 33714, 2018
9:09 AM
michelv has quit
2018-12-03 33711, 2018
9:21 AM
protiumoxide joined the channel
2018-12-03 33728, 2018
9:25 AM
protiumoxide has quit
2018-12-03 33759, 2018
9:36 AM
c1e0_ joined the channel
2018-12-03 33717, 2018
9:37 AM
c1e0 has quit
2018-12-03 33750, 2018
9:38 AM
code_master5 joined the channel
2018-12-03 33726, 2018
9:53 AM
Mr_Monkey
Moin moin
2018-12-03 33758, 2018
9:53 AM
reosarevok
moin monkey
2018-12-03 33702, 2018
9:54 AM
reosarevok
bitmap: in any case
2018-12-03 33705, 2018
9:54 AM
reosarevok
2018-12-03 33706, 2018
9:54 AM
code_master5
Mr_Monkey: moin!
2018-12-03 33742, 2018
9:55 AM
reosarevok
Alternatively:
2018-12-03 33745, 2018
9:55 AM
reosarevok
2018-12-03 33735, 2018
9:57 AM
george
Hey reosarevok, for MBS-9907, would you rather just the "Place" and "Area" columns, or the "Place", "Address" and "Area" columns?
2018-12-03 33736, 2018
9:57 AM
BrainzBot
2018-12-03 33701, 2018
9:58 AM
reosarevok
All 3 make sense to me I think - since often the address gives additional useful info that complements the area one
2018-12-03 33713, 2018
9:58 AM
george
Cool thanks
2018-12-03 33700, 2018
10:01 AM
yvanzo
reosarevok: with flow 0.87.0?
2018-12-03 33720, 2018
10:01 AM
yvanzo
Oh sorry, different issue.
2018-12-03 33713, 2018
10:02 AM
yvanzo
About SubHeader, as I pointed out, SubHeader signature should be changed to accept Node.React (for subHeading) too.
2018-12-03 33744, 2018
10:03 AM
reosarevok
Oh. Duh. Yeah, that works :D
2018-12-03 33747, 2018
10:03 AM
reosarevok
Thanks yvanzo
2018-12-03 33748, 2018
10:03 AM
reosarevok
Thanzo
2018-12-03 33706, 2018
10:04 AM
reosarevok
bitmap: nevermind, yvanzo had told me how to fix it but I forgot he had
2018-12-03 33743, 2018
10:04 AM
reosarevok
yvanzo: have we merged any new reports yet btw?
2018-12-03 33743, 2018
10:04 AM
yvanzo
Oops, React.Node, but you got it right :)
2018-12-03 33700, 2018
10:05 AM
reosarevok
(should start converting them to React too :p )
2018-12-03 33741, 2018
10:05 AM
yvanzo
reosarevok: taht was one reason not to pick report migration to React for now: there are some GCI tasks about adding report
2018-12-03 33711, 2018
10:06 AM
reosarevok
Sure, but converting one or two reports should take 5 minutes now the components are there
2018-12-03 33722, 2018
10:06 AM
reosarevok
So I'm happy to do that later on
2018-12-03 33758, 2018
10:07 AM
yvanzo
To answer your first question: no new report has been merged yet. (I did not merge george's PR because of upcoming improvements.)
2018-12-03 33711, 2018
10:08 AM
reosarevok
Ok :)
2018-12-03 33739, 2018
10:16 AM
michelv_ is now known as michelv
2018-12-03 33739, 2018
10:39 AM
Mr_Monkey
2018-12-03 33727, 2018
10:42 AM
ruaok
commented.
2018-12-03 33702, 2018
10:45 AM
Mr_Monkey
ruaok: Thanks.
2018-12-03 33702, 2018
10:45 AM
Mr_Monkey
2018-12-03 33740, 2018
10:47 AM
ruaok
sure. that would remove one of the (weak) objections.
2018-12-03 33752, 2018
10:50 AM
ruaok
yvanzo, zas,Freso: invoices please!
2018-12-03 33742, 2018
11:22 AM
george
reosarevok: columns updated👍
2018-12-03 33738, 2018
11:32 AM
travis-ci joined the channel
2018-12-03 33739, 2018
11:32 AM
travis-ci
2018-12-03 33739, 2018
11:32 AM
travis-ci has left the channel
2018-12-03 33758, 2018
11:35 AM
reosarevok
george: running on your server to check?
2018-12-03 33717, 2018
11:36 AM
george
2018-12-03 33732, 2018
11:38 AM
george
I was thinking of using descriptive_link for the places, but i'm not sure how to go about selecting the entity
2018-12-03 33702, 2018
11:41 AM
reosarevok
You should link the area, not print it :)
2018-12-03 33714, 2018
11:41 AM
reosarevok
(thought that was what the code was doing but wanted to make sure)
2018-12-03 33727, 2018
11:41 AM
george
Oh yea i meant for the areas*
2018-12-03 33751, 2018
11:41 AM
Lotheric_ joined the channel
2018-12-03 33750, 2018
11:42 AM
george
The problem that I'm facing is that descriptive_link() takes in an entity as its parameter, but the sql query is just selecting values
2018-12-03 33706, 2018
11:43 AM
reosarevok
Can't you access place.area?
2018-12-03 33744, 2018
11:43 AM
reosarevok
2018-12-03 33758, 2018
11:43 AM
reosarevok
Unless I'm misreading this, because I'm still not that great at Perl myself :p
2018-12-03 33759, 2018
11:44 AM
reosarevok
I think you should at least be able to access place.address without having to do anything else
2018-12-03 33711, 2018
11:45 AM
reosarevok
You *might* need to load the areas for the places if they're not loaded automatically, but check first :)
2018-12-03 33715, 2018
11:45 AM
Lotheric has quit
2018-12-03 33709, 2018
11:46 AM
george
Doesn't seem like place.area exists :(
2018-12-03 33747, 2018
11:49 AM
reosarevok
2018-12-03 33714, 2018
11:50 AM
reosarevok
You could try to do $c->model('Area')->load($place); (or the like) in PlaceReport
2018-12-03 33728, 2018
11:50 AM
reosarevok
That'll load it for every place report, but I don't think that is a big problem
2018-12-03 33742, 2018
11:51 AM
reosarevok
Maybe yvanzo or bitmap will scream at me that it is a big problem, but in that case they'll also suggest a better way, so :D
2018-12-03 33759, 2018
11:52 AM
george
I've found that in EventReport.pm, `$self->c->model('Event')->load_areas(values %$events);` is run at one point, which may be relevant?
2018-12-03 33718, 2018
11:55 AM
reosarevok
Yeah, that's probably a good thing to work from :)
2018-12-03 33735, 2018
11:55 AM
reosarevok
But I don't think Place has load_areas
2018-12-03 33751, 2018
11:55 AM
reosarevok
(because it only has one anyway - for events it goes through relationships and it is more complicated)
2018-12-03 33711, 2018
11:56 AM
reosarevok
So maybe $self->c->model('Area')->load(the appropriate thing here)
2018-12-03 33723, 2018
11:56 AM
reosarevok
Play with it a bit, see what you get
2018-12-03 33718, 2018
11:58 AM
yvanzo
updating test.mb.o
2018-12-03 33759, 2018
12:01 PM
D4RK-PH0ENiX has quit
2018-12-03 33719, 2018
12:05 PM
george
reosarevok: All working!! Thanks for the help 😄
2018-12-03 33759, 2018
12:08 PM
reosarevok
You can also stop taking those fields from the SQL query at all, if you haven't, since you're getting them from the place now
2018-12-03 33701, 2018
12:11 PM
george
It's strange that some entries are displaying as "[removed]" on the list 🤔
2018-12-03 33752, 2018
12:11 PM
george
Ahh nvm i think its where there aren't any areas.
2018-12-03 33720, 2018
12:13 PM
travis-ci joined the channel
2018-12-03 33721, 2018
12:13 PM
travis-ci
2018-12-03 33721, 2018
12:13 PM
travis-ci has left the channel
2018-12-03 33741, 2018
12:13 PM
reosarevok
Only send the area to show if there's an area, then :)
2018-12-03 33702, 2018
12:15 PM
reosarevok
place.area ? show area : '' or whatever. I would say see how search results do it, but they use React now. You could check how they used to be though ;)
2018-12-03 33708, 2018
12:15 PM
reosarevok
(should be easy to find history in github)
2018-12-03 33749, 2018
12:17 PM
Lotheric_ has quit
2018-12-03 33704, 2018
12:18 PM
travis-ci joined the channel
2018-12-03 33705, 2018
12:18 PM
travis-ci
2018-12-03 33705, 2018
12:18 PM
travis-ci has left the channel
2018-12-03 33715, 2018
12:18 PM
george
Thanks, found it!
2018-12-03 33755, 2018
12:19 PM
Lotheric joined the channel
2018-12-03 33731, 2018
12:20 PM
ruaok
ok, everyone has been paid. Everyone should have money no later than tomorrow, more likely today.
2018-12-03 33704, 2018
12:21 PM
ruaok
zas: got anything on 2017 traffic?
2018-12-03 33707, 2018
12:23 PM
ruaok
2018-12-03 33715, 2018
12:24 PM
CatCat
AAAHHH
2018-12-03 33741, 2018
12:26 PM
CatCat
2018-12-03 33756, 2018
12:26 PM
Mr_Monkey reads joke, goes supernova
2018-12-03 33737, 2018
12:27 PM
CatCat
"Barnard's star is both very close to the sun (as these things go) and moving now at a speed of more than 140 km/s toward the Sun. It will make its closest approach to the Sun in approximately 10,000 years, at a distance of about 3.75 light-years."
2018-12-03 33741, 2018
12:28 PM
reosarevok
.... Now I got it :D
2018-12-03 33750, 2018
12:28 PM
reosarevok
I saw it last time and didn't get the ratings connection at all
2018-12-03 33704, 2018
12:34 PM
D4RK-PH0ENiX joined the channel
2018-12-03 33719, 2018
12:38 PM
code_master5 has quit
2018-12-03 33713, 2018
12:39 PM
ruaok
2018-12-03 33747, 2018
12:45 PM
travis-ci joined the channel
2018-12-03 33748, 2018
12:45 PM
travis-ci
2018-12-03 33748, 2018
12:45 PM
travis-ci has left the channel
2018-12-03 33711, 2018
12:47 PM
Protab joined the channel
2018-12-03 33711, 2018
12:47 PM
Rotab has quit
2018-12-03 33705, 2018
12:54 PM
reosarevok
george: you could also use address from the place instead of loading it from the item, no?
2018-12-03 33736, 2018
13:03 PM
Mr_Monkey
chhavi_: Are you around?
2018-12-03 33744, 2018
13:03 PM
travis-ci joined the channel
2018-12-03 33745, 2018
13:03 PM
travis-ci
2018-12-03 33745, 2018
13:03 PM
travis-ci has left the channel
2018-12-03 33733, 2018
13:16 PM
chhavi_
Mr_Monkey: alright if we talk in about an hour? Getting back home!
2018-12-03 33747, 2018
13:16 PM
Mr_Monkey
chhavi_: No rush !
2018-12-03 33748, 2018
13:20 PM
george
reosarevok Sure thing
2018-12-03 33700, 2018
13:38 PM
Protab is now known as Rotab
2018-12-03 33720, 2018
13:46 PM
michelv
george: looking good :)
