So.. one more issue from my side and we're good to go for the next CB release!
2018-12-03 33759, 2018
code_master5
Done!
2018-12-03 33702, 2018
code_master5
Who's next?
2018-12-03 33703, 2018
Freso
🙌
2018-12-03 33705, 2018
Freso
!m code_master5
2018-12-03 33705, 2018
BrainzBot
You're doing good work, code_master5!
2018-12-03 33707, 2018
Freso
I'm next!
2018-12-03 33714, 2018
code_master5
Freso: Thanks!
2018-12-03 33733, 2018
Freso
Thank you everyone for reviews. No more people are up for reviews tonight, so we're moving on to the rest of the agenda items. First up:
2018-12-03 33738, 2018
Freso
Freso: Google Code-in
2018-12-03 33745, 2018
Freso
Mostly just a heads-up/announcement:
2018-12-03 33745, 2018
Freso
This is the last week for students to claim tasks in Google Code-in. Next Monday students will have two days to finish up any tasks, and then from Wednesday next week, we mentors have to pick the winners and finalists.
2018-12-03 33745, 2018
Freso
As in previous years, we have one task we'd like all students to do before the contest ends:
Any students reading here, please try and fit this task into your schedule. Shouldn't take more than 10-ish minutes, probably. :)
2018-12-03 33746, 2018
Freso
Finally: Good luck for the last stretch to all our students, and thanks for all your hard work so far!
2018-12-03 33755, 2018
Freso
fin.
2018-12-03 33757, 2018
Freso
ruaok: private data in BB dumps
2018-12-03 33709, 2018
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | Meeting agenda: private data in BB dumps (ruaok), Upgrade MB to Postgres 10? (ruaok), kinda-sorta libellous tags (reo)
2018-12-03 33727, 2018
george
👍👍👍
2018-12-03 33729, 2018
ruaok
as I examined the BB data dumping code, I noticed that the database is dumped with the exception of some usage stats tables.
2018-12-03 33739, 2018
ruaok
those don't belong in PG, but that wasn't the issue.
2018-12-03 33700, 2018
ruaok
BB tracks user birthdates, makes them public on the use profile page and then includes them in the dump.
2018-12-03 33720, 2018
ruaok
since all the info is public, the dumps don't really create a problem.
2018-12-03 33744, 2018
ruaok
but we collect birthdates which MB does as well. and MB shows only age, not birthdate to other users.
2018-12-03 33757, 2018
ruaok
any thoughts on what we should do?
2018-12-03 33705, 2018
ruaok
I'm for nuking birthdates very soon.
2018-12-03 33715, 2018
Leo_Verto
this sounds like it's a pretty big GDPR violation, sharing PID with basically every third party that downloads the dumps
2018-12-03 33721, 2018
ruaok
and then finding a way to fetch this data (or just age) from MB so we don't duplicate the data.
2018-12-03 33730, 2018
Mr_Monkey
How easy is it to get the age from MB profile?
2018-12-03 33734, 2018
Freso
Leo_Verto: Only if they've entered it into their public profile themselves.
2018-12-03 33750, 2018
Freso
The bigger issue, IMHO, is that it apparently isn't possible to delete it again.
2018-12-03 33757, 2018
ruaok
Leo_Verto: I dunno if it is or not.
2018-12-03 33704, 2018
Leo_Verto
Yes but even then they need to explicitly consent to that data being shared.
2018-12-03 33708, 2018
ruaok
yes.
2018-12-03 33718, 2018
ruaok
and there was ZERO talk about GDPR related thinking on the DOB stuff.
2018-12-03 33731, 2018
ruaok
can we just nuke it and be done?
2018-12-03 33735, 2018
bitmap
I don't see any reason for us to store DOB
2018-12-03 33735, 2018
ruaok
who strongly objects to this?
2018-12-03 33745, 2018
CatCat
what is DOB?
2018-12-03 33746, 2018
iliekcomputers
+1 to nuking.
2018-12-03 33748, 2018
reosarevok
Date of birth
2018-12-03 33749, 2018
ruaok
date of birth.
2018-12-03 33752, 2018
michelv joined the channel
2018-12-03 33753, 2018
reosarevok
I think having user age is great
2018-12-03 33701, 2018
reosarevok
For users who are willing to share that info
2018-12-03 33702, 2018
ruaok
reosarevok: +1 to that. and we already have that in MB.
2018-12-03 33703, 2018
Freso
Yeah.
2018-12-03 33707, 2018
CatCat
but yea date of birth . age is fine from mb
2018-12-03 33708, 2018
ruaok
let's not duplicate data.
2018-12-03 33712, 2018
reosarevok
If we can take it from MB, good
2018-12-03 33718, 2018
CatCat
yes
2018-12-03 33719, 2018
Freso
I do agree that we should try and centralise the user data somewhat.
2018-12-03 33726, 2018
CatCat
what is PID?
2018-12-03 33727, 2018
ruaok
ok, I hear no objections.
2018-12-03 33730, 2018
Freso
So I'm happy with dropping area, gender, and dob from BB.
2018-12-03 33732, 2018
reosarevok
I mean, we should have one MeB profile, that's the main issue :p
2018-12-03 33736, 2018
ruaok
Mr_Monkey: please expedite nuking DOB from BB.
2018-12-03 33739, 2018
Mr_Monkey
Does anyone know if it can be retreived from the MB profile?
2018-12-03 33740, 2018
CatCat
+1 reosarevok
2018-12-03 33743, 2018
reosarevok
In the meantime, can we actually get it from MB?
2018-12-03 33745, 2018
ruaok
Mr_Monkey: not yet.
2018-12-03 33759, 2018
ruaok
but we can make reosarevok code us an internal API endpoint. :)
2018-12-03 33759, 2018
reosarevok
Because we shouldn't just drop it from BB if we have no clear plans how to get it back, that seems backwards
2018-12-03 33704, 2018
reosarevok
Drop it from the dumps instead
2018-12-03 33722, 2018
ruaok
I have a clear plan to get rid of a possible GDPR violation.
2018-12-03 33722, 2018
Freso
reosarevok: It's still (potentially) duplicated information.
2018-12-03 33729, 2018
CatCat
true
2018-12-03 33736, 2018
ruaok
and that should and does overrule everything else, reosarevok.
2018-12-03 33736, 2018
iliekcomputers
if it is a GDPR violation, we should remove it everywhere.
2018-12-03 33742, 2018
reosarevok sighs
2018-12-03 33742, 2018
CatCat
but tere are proably also peopel who have fileld out the bb ting but not the mb thing
2018-12-03 33748, 2018
Freso
And as ruaok says, the fewer places we have such potentially sensitive information, the better.
2018-12-03 33748, 2018
iliekcomputers
considering getting it back should be pretty easy anyways.
2018-12-03 33759, 2018
reosarevok
Whatever, get rid of it
2018-12-03 33700, 2018
ruaok
the current implementation is a GDPR issue, if not a violation.
2018-12-03 33705, 2018
ruaok
Mr_Monkey: bake it so.
2018-12-03 33706, 2018
reosarevok
Sure, because it's in the dumps
2018-12-03 33708, 2018
ruaok
onward.
2018-12-03 33708, 2018
reosarevok
Which is stupid
2018-12-03 33710, 2018
reosarevok
But whatever
2018-12-03 33715, 2018
reosarevok
Your choice
2018-12-03 33715, 2018
reosarevok
Next
2018-12-03 33716, 2018
ruaok
postgres 10.
2018-12-03 33720, 2018
Freso
reosarevok: It's also displayed on their public profile.
2018-12-03 33733, 2018
ruaok
there is a requirement in BB to use PG 10.
2018-12-03 33742, 2018
reosarevok
Freso: obviously, because they entered it? Anyway, I'm not going to argue about this, the decision is made
2018-12-03 33709, 2018
ruaok
but that prevents us from moving BB to our infrastructure because in production we run 9.x. 9.5, right?
2018-12-03 33720, 2018
bitmap
yep
2018-12-03 33725, 2018
ruaok
so, I am strongly urging Mr_Monkey to find a workaround for the need of PG10.
2018-12-03 33738, 2018
ruaok
but, we should consider when we're going to upgrade ourselves.
2018-12-03 33739, 2018
iliekcomputers
you can just use the pg10 instance on frank ?
2018-12-03 33741, 2018
Leo_Verto
Are you planning on using the same PG servers for MB and BB?
2018-12-03 33741, 2018
CatCat
how fast can mb get to PG 10 tho
2018-12-03 33703, 2018
ruaok
iliekcomputers: Leo_Verto: I would like to use only one set of DB servers if at all possible.
2018-12-03 33708, 2018
iliekcomputers
but idk, maybe we wanna keep the data consolidated, all other projects (except for AB) have data on bowie.
2018-12-03 33709, 2018
ruaok
AB it isn't possible.
2018-12-03 33716, 2018
iliekcomputers
yeah, makes sense.
2018-12-03 33720, 2018
ruaok
but iliekcomputers that is a decent compromise if we MUST got to PG10.
2018-12-03 33730, 2018
ruaok
but pg10 is a single point of failure.
2018-12-03 33732, 2018
CatCat
I'd instead try to work towards MB PG 10
2018-12-03 33737, 2018
ruaok
more so than queen/bowie.
2018-12-03 33756, 2018
ruaok
bitmap: what do you think of planning to do a PG upgrade in the fall?
2018-12-03 33759, 2018
CatCat
or atleast. like have an eta
2018-12-03 33714, 2018
ruaok
no schema change release, but a migration to PG10 and give people 6 months notice.
2018-12-03 33715, 2018
bitmap
MB already works run with pg 10 (though we should test replication/dumping more)
2018-12-03 33715, 2018
CatCat
can BB wait unti lthne?
2018-12-03 33720, 2018
bitmap
that would be great
2018-12-03 33740, 2018
ruaok
ok, this is mostly dealing with the coorindation of everyone downstream.
2018-12-03 33746, 2018
yvanzo
CatCat: you're welcome to do so ;)
2018-12-03 33750, 2018
ruaok
ok, lets put that into the plans then.
2018-12-03 33703, 2018
Freso
fin?
2018-12-03 33703, 2018
iliekcomputers
everyone downstream will have to move to pg10 too, right?
2018-12-03 33706, 2018
ruaok
I'll kick the process off and we should plan to make the move on Oct 15 (or close to it).
2018-12-03 33709, 2018
Mr_Monkey
For BB to wait means renaming entities on the ORM and web facing parts, but not renaming entities in the database, which would suck
2018-12-03 33711, 2018
ruaok
iliekcomputers: yes.
2018-12-03 33711, 2018
bitmap
pg11 would be even better :)
2018-12-03 33719, 2018
CatCat
yvanzo: huh?
2018-12-03 33720, 2018
ruaok
bitmap: ugh. hmmm.
2018-12-03 33724, 2018
iliekcomputers
is pg11 released yet?
2018-12-03 33729, 2018
ruaok
is there an ETA for pg11?
2018-12-03 33738, 2018
bitmap
it's released already, I thought?
2018-12-03 33744, 2018
Leo_Verto
it is
2018-12-03 33748, 2018
ruaok
oh. cool.
2018-12-03 33749, 2018
iliekcomputers
ugh, should have used it for frank then...
2018-12-03 33750, 2018
ruaok
might as well then.
2018-12-03 33753, 2018
ruaok
lol
2018-12-03 33700, 2018
ruaok
it should be nice and stable come fall.
2018-12-03 33702, 2018
ruaok
fin.
2018-12-03 33703, 2018
ruaok
thanks!
2018-12-03 33705, 2018
Freso
reo: kinda-sorta libellous tags
2018-12-03 33733, 2018
reosarevok
So
2018-12-03 33744, 2018
CatCat
hva skjer?
2018-12-03 33703, 2018
reosarevok
We got a case at support, a band who has been tagged as "nazi", "rac" and "twats"
2018-12-03 33742, 2018
reosarevok
It seems like there is a band of the same name which is *indeed* nazi and rac (and, I assume, also twats)
2018-12-03 33749, 2018
reosarevok
But that's not the one the tags ended up on
2018-12-03 33750, 2018
iliekcomputers
rac?
2018-12-03 33715, 2018
iliekcomputers
okie.
2018-12-03 33745, 2018
reosarevok
The band was asking us to remove the tags - they're now downvoted, but they still feel the fact someone can come to their page from the BBC and see a "nazi" tag, even if hidden, is damaging
2018-12-03 33706, 2018
ruaok
reosarevok: is there a threshold at which tags get hidden?
2018-12-03 33710, 2018
yvanzo
Freso: We keep improving!
2018-12-03 33711, 2018
reosarevok
ruaok: 0 or less votes
2018-12-03 33712, 2018
Freso
ruaok: 0
2018-12-03 33729, 2018
reosarevok
But you can still see them if you ask to, and they'll still be sent via the ws
