#metabrainz

/

      • D4RK-PH0ENiX has quit
      • 2018-12-04 33815, 2018

      • D4RK-PH0ENiX joined the channel
      • 2018-12-04 33801, 2018

      • creature has left the channel
      • 2018-12-04 33823, 2018

      • c1e0 joined the channel
      • 2018-12-04 33856, 2018

      • Leo_Verto_ joined the channel
      • 2018-12-04 33840, 2018

      • Leo_Verto has quit
      • 2018-12-04 33840, 2018

      • Leo_Verto_ is now known as Leo_Verto
      • 2018-12-04 33853, 2018

      • c1e0 has quit
      • 2018-12-04 33842, 2018

      • outsidecontext joined the channel
      • 2018-12-04 33856, 2018

      • yvanzo
        mo''in'
      • 2018-12-04 33825, 2018

      • yvanzo
        reosarevok: Do you prefer having both OSM & GMaps to search from place report?
      • 2018-12-04 33819, 2018

      • michelv joined the channel
      • 2018-12-04 33827, 2018

      • c1e0 joined the channel
      • 2018-12-04 33830, 2018

      • yvanzo
        bitmap, zas: for some reason, mb website refuses to die on bootsy.
      • 2018-12-04 33840, 2018

      • reosarevok
        yvanzo: I'm ok with just OSM if it's easy to find coordinates there
      • 2018-12-04 33854, 2018

      • reosarevok
        I haven't tried before, but I tried now and it seemed to be reasonably easy
      • 2018-12-04 33827, 2018

      • bukwurm joined the channel
      • 2018-12-04 33852, 2018

      • ruaok
        moooin!
      • 2018-12-04 33805, 2018

      • george
        Hey yvanzo, I think I’ve already made the requested change yesterday?
      • 2018-12-04 33813, 2018

      • george
        Ah i forgot to commit it
      • 2018-12-04 33805, 2018

      • zas
        yvanzo: what do you mean by "refuses to die" ? it was restarted 23 mins ago it seems
      • 2018-12-04 33811, 2018

      • yvanzo
        zas: yes, just got it right but it was stuck, see https://gist.github.com/yvanzo/8d2a693eef4f3fbc61…
      • 2018-12-04 33853, 2018

      • zas
        we can try to upgrade docker on this machine, i had such issue on another machine a while ago, with this docker version
      • 2018-12-04 33825, 2018

      • yvanzo
        (only docker rm -f actually stopped the container)
      • 2018-12-04 33801, 2018

      • zas
        i'll proceed to an upgrade on it, it has to be done on all machines anyway, there is no critical container on this one.
      • 2018-12-04 33821, 2018

      • yvanzo
        Ok, I’m done with updating mb containers on every machine.
      • 2018-12-04 33833, 2018

      • zas
        i upgraded to version 18.06.1~ce~3-0~ubuntu (18.09 doesn't work, there are issues with systemd i need to look into, we already met this issue, so i stick version to 18.06)
      • 2018-12-04 33825, 2018

      • zas
        i'll reboot bootsy soon
      • 2018-12-04 33826, 2018

      • zas
        yvanzo: done with bootsy
      • 2018-12-04 33830, 2018

      • yvanzo
        thanks!
      • 2018-12-04 33821, 2018

      • outsidecontext
        zas: hi, what do you think about how to proceed with the picard beta release?
      • 2018-12-04 33843, 2018

      • outsidecontext
        I am unfortunately pretty loaded with work today and tomorrow :(
      • 2018-12-04 33827, 2018

      • D4RK-PH0ENiX has quit
      • 2018-12-04 33825, 2018

      • zas
        We can tag beta, and I'll write a blog post about it to start with
      • 2018-12-04 33821, 2018

      • zas
        We need more people to test, and let some time for translators to work
      • 2018-12-04 33840, 2018

      • D4RK-PH0ENiX joined the channel
      • 2018-12-04 33803, 2018

      • yvanzo
        george: you may need --force option to push updated commit message.
      • 2018-12-04 33842, 2018

      • travis-ci joined the channel
      • 2018-12-04 33843, 2018

      • travis-ci
        metabrainz/picard#4143 (master - 1e8119f : Laurent Monin): The build passed.
      • 2018-12-04 33843, 2018

      • travis-ci
      • 2018-12-04 33843, 2018

      • travis-ci
      • 2018-12-04 33843, 2018

      • travis-ci has left the channel
      • 2018-12-04 33838, 2018

      • george
      • 2018-12-04 33853, 2018

      • yvanzo
        oh you're right, sorry
      • 2018-12-04 33827, 2018

      • Leo_Verto_ joined the channel
      • 2018-12-04 33826, 2018

      • Leo_Verto has quit
      • 2018-12-04 33827, 2018

      • Leo_Verto_ is now known as Leo_Verto
      • 2018-12-04 33800, 2018

      • travis-ci joined the channel
      • 2018-12-04 33801, 2018

      • travis-ci
        metabrainz/picard#4144 (release-2.1.0dev2 - 1e8119f : Laurent Monin): The build passed.
      • 2018-12-04 33801, 2018

      • travis-ci
      • 2018-12-04 33801, 2018

      • travis-ci
      • 2018-12-04 33801, 2018

      • travis-ci has left the channel
      • 2018-12-04 33800, 2018

      • zas
      • 2018-12-04 33820, 2018

      • vivek_kumar[m] joined the channel
      • 2018-12-04 33841, 2018

      • zas
        outsidecontext: we'll have to add matching packages to the website this afternoon, and publish it
      • 2018-12-04 33828, 2018

      • outsidecontext
        zas: oh, great. that list of changes got longer then I had anticipated :D
      • 2018-12-04 33842, 2018

      • zas
        outsidecontext: blame yourself ;)
      • 2018-12-04 33849, 2018

      • outsidecontext
        I see we should actually name the macos packages better, currently one cannot see which was build on which macos version. https://github.com/metabrainz/picard/releases
      • 2018-12-04 33814, 2018

      • outsidecontext
      • 2018-12-04 33800, 2018

      • outsidecontext
        I uploaded the windows binary to github
      • 2018-12-04 33833, 2018

      • code_master5 joined the channel
      • 2018-12-04 33853, 2018

      • Protab joined the channel
      • 2018-12-04 33853, 2018

      • Rotab has quit
      • 2018-12-04 33822, 2018

      • zas
        outsidecontext: i'm for merging https://github.com/metabrainz/picard-website/pull…, and updating download page with pre-release packages, what do you think ?
      • 2018-12-04 33857, 2018

      • Slurpee joined the channel
      • 2018-12-04 33819, 2018

      • outsidecontext
        Yes, I have been thinking about this as well. I was not sure if we should merge it now or only after final release, but probably it is good to have this online to point users to it
      • 2018-12-04 33850, 2018

      • outsidecontext
        The only thing missing there is that I wanted to have the new -P command line parameter documented, but we can do that later
      • 2018-12-04 33851, 2018

      • ruaok
        I love that you want to merge the thing that has the 'do not merge' label.
      • 2018-12-04 33857, 2018

      • zas
        yes, it doesn't make much difference, and users of 2.1.0dev2 will have the proper documentation
      • 2018-12-04 33806, 2018

      • zas
        ruaok: yes :)
      • 2018-12-04 33832, 2018

      • outsidecontext
        ruaok: :D I removed the label
      • 2018-12-04 33837, 2018

      • zas
        fixed ;)
      • 2018-12-04 33843, 2018

      • ruaok
        no fun.
      • 2018-12-04 33800, 2018

      • outsidecontext
        :p
      • 2018-12-04 33820, 2018

      • zas
        i'll merge, then we proceed to required updates (packages + -P option)
      • 2018-12-04 33837, 2018

      • outsidecontext
        ok
      • 2018-12-04 33825, 2018

      • outsidecontext
        zas: We currently don't have the command line options documented, but my thought was that it would be useful to be mentioned on the troubleshooting page
      • 2018-12-04 33841, 2018

      • github joined the channel
      • 2018-12-04 33841, 2018

      • github
        [picard-website] zas closed pull request #137: Picard 2.1.0 (master...picard-2.1.0) https://git.io/fptSm
      • 2018-12-04 33841, 2018

      • github has left the channel
      • 2018-12-04 33807, 2018

      • zas
        yes, especially the option to disable plugins, as they are the source of many issues reported recently
      • 2018-12-04 33838, 2018

      • outsidecontext
        exactly
      • 2018-12-04 33850, 2018

      • zas
        i'll update download page
      • 2018-12-04 33859, 2018

      • zas
        and add packages to ftp
      • 2018-12-04 33835, 2018

      • outsidecontext
        +1
      • 2018-12-04 33841, 2018

      • c1e0 has quit
      • 2018-12-04 33848, 2018

      • code_master5
        iliekcomputers: ping!
      • 2018-12-04 33812, 2018

      • ivnat joined the channel
      • 2018-12-04 33842, 2018

      • zas
        outsidecontext: we have to update some requirements for picard-website first, mainly flask and prolly transifex-client
      • 2018-12-04 33831, 2018

      • outsidecontext
        are we forced to do it? I know we should update, but I had hoped we could work with the existing setup for this release :(
      • 2018-12-04 33836, 2018

      • zas
        well, for flask that's a security update, and transifex-client should not cause any issue
      • 2018-12-04 33836, 2018

      • outsidecontext
        at least for this pre-release
      • 2018-12-04 33807, 2018

      • zas
        ah yes, but it has to be done anyway soon
      • 2018-12-04 33830, 2018

      • outsidecontext
        for flask we are way behind current version. I haven't tried updating it yet, but could very well cause some troubles
      • 2018-12-04 33827, 2018

      • zas
        the minimun required is 0.12.3 (for sec issue)
      • 2018-12-04 33836, 2018

      • zas
        we can at least try with this one
      • 2018-12-04 33845, 2018

      • outsidecontext
        but maybe we should just try, there aren't many pages and not much functionality on this website so we can easily verify if it works
      • 2018-12-04 33847, 2018

      • outsidecontext
        yes
      • 2018-12-04 33837, 2018

      • c1e0 joined the channel
      • 2018-12-04 33837, 2018

      • eggg[m] joined the channel
      • 2018-12-04 33824, 2018

      • reosarevok
        yvanzo: wat is going on with Jenkins on https://github.com/metabrainz/musicbrainz-server/… ?
      • 2018-12-04 33832, 2018

      • reosarevok
        "MusicBrianz Server [Master] Pending — Can't define which status to set"
      • 2018-12-04 33835, 2018

      • reosarevok
        Also, MusicBrianz :D
      • 2018-12-04 33854, 2018

      • yvanzo
        Do you have something against him? ;)
      • 2018-12-04 33817, 2018

      • yvanzo
        Build sometimes fails because of Redis store, it's transient error only.
      • 2018-12-04 33845, 2018

      • yvanzo
        I just pushed a typo fix to master, next build should be fine.
      • 2018-12-04 33826, 2018

      • reosarevok
        Re: "releases which have cover art in the Cover Art Archive" commit message
      • 2018-12-04 33854, 2018

      • reosarevok
        I thought you told me commit messages should be fit in a small amount of characters, yvanzo? :D
      • 2018-12-04 33838, 2018

      • reosarevok
        (that's why I had "Add report for CAA releases with no CAA types", I though more would be too long)
      • 2018-12-04 33816, 2018

      • reosarevok
        Pushed the fix with a nicer commit message then
      • 2018-12-04 33839, 2018

      • yvanzo
        taht's not an excuse to write gibberish, is it? ;)
      • 2018-12-04 33833, 2018

      • yvanzo
        reosarevok: you can wrap it where you want and continue it in the message body
      • 2018-12-04 33838, 2018

      • reosarevok
        Well, sure, but anything that is understandable goes over the limit
      • 2018-12-04 33847, 2018

      • reosarevok
        Pushed it anyway
      • 2018-12-04 33810, 2018

      • yvanzo
        also, the example "releases which have cover art in the Cover Art Archive" is taken from report description, with your own words, it is not a suggestion for commit message :p
      • 2018-12-04 33803, 2018

      • c1e0 has quit
      • 2018-12-04 33807, 2018

      • c1e0 joined the channel
      • 2018-12-04 33832, 2018

      • reosarevok
        c1e0: hi! Just answered the task / left a few notes
      • 2018-12-04 33841, 2018

      • reosarevok
        Feel free to ask if you have any doubts! :)
      • 2018-12-04 33819, 2018

      • c1e0
        reosarevok: Thank you. :)
      • 2018-12-04 33825, 2018

      • george
        Does anyone know why syncing my fork with the GitHub MusicBrainz repo might take the Head back to " Adding the first batch of genre requests"?
      • 2018-12-04 33837, 2018

      • george
      • 2018-12-04 33854, 2018

      • reosarevok
        Are you using production instead of master or something?
      • 2018-12-04 33835, 2018

      • george
        Not afaik
      • 2018-12-04 33837, 2018

      • george
        But GitHub seems to think that the two branches are synced
      • 2018-12-04 33825, 2018

      • reosarevok
        yvanzo: what do we use to sort tables?
      • 2018-12-04 33826, 2018

      • yvanzo
      • 2018-12-04 33826, 2018

      • BrainzBot
        MBS-157: Allow sorting tables
      • 2018-12-04 33850, 2018

      • reosarevok
      • 2018-12-04 33822, 2018

      • yvanzo
        reosarevok: About place report again, would you be interested in/agree with adding a search link to Google Maps too?
      • 2018-12-04 33842, 2018

      • reosarevok
        I would probably keep one for now
      • 2018-12-04 33851, 2018

      • reosarevok
        If people ask they also want Google Maps, then we can add it
      • 2018-12-04 33854, 2018

      • yvanzo
        It looks like this page uses https://github.com/Mottie/tablesorter
      • 2018-12-04 33810, 2018

      • yvanzo
        reosarevok: michelv just did ask in comment to MBS-9907 :)
      • 2018-12-04 33810, 2018

      • BrainzBot
        MBS-9907: New report: Places without coordinates https://tickets.metabrainz.org/browse/MBS-9907
      • 2018-12-04 33841, 2018

      • reosarevok
        Then I guess why not?
      • 2018-12-04 33809, 2018

      • reosarevok
        yvanzo: ok, I see the old .tt file had a <script> for tablesorter. How do I do the same on React? :)
      • 2018-12-04 33815, 2018

      • reosarevok
        Do we have an example in the codebase already?
      • 2018-12-04 33826, 2018

      • reosarevok
        Or I guess we could just leave it be until we have sorting for all
      • 2018-12-04 33828, 2018

      • reosarevok shrugs
      • 2018-12-04 33831, 2018

      • yvanzo
        reosarevok: yes, use componentDidMount.
      • 2018-12-04 33821, 2018

      • yvanzo
        at some point, we might be interested in using something like https://react-table.js.org
      • 2018-12-04 33809, 2018

      • c1e0
        reosarevok: Hi, you mentioned I should leave the recordings with videos. What about those with audios? Like this, for example: http://www.yingwang.de/work-by-ying/tiptotop/
      • 2018-12-04 33810, 2018

      • yvanzo
        (it's not the one you can make music with)
      • 2018-12-04 33829, 2018

      • reosarevok
        c1e0: I would not keep that because that audio is a 2:32 sample and we don't have clear credits for it. Is it "Solo: Isao Nakamura"? Probably, but it's not clearly specified that the audio is from that performance
      • 2018-12-04 33834, 2018

      • reosarevok
      • 2018-12-04 33802, 2018

      • reosarevok
        I don't really think that's a good idea tbh. If the system is broken then the system needs fixing, but we shouldn't have a ridiculously long string
      • 2018-12-04 33806, 2018

      • yvanzo
        george: make sure you fetch latest changes from metabrainz repo, then save your branch with git checkout release-label-master-v2 -b don-t-shoot; last try rebasing your branch onto master with git rebase release-label-master-v2 --onto metabrainz/master;
      • 2018-12-04 33831, 2018

      • yvanzo
        reosarevok: I agree, that's what gh:MBS#763 attempts to fix.
      • 2018-12-04 33832, 2018

      • BrainzBot