-
iliekcomputers
*i can
2019-01-18 01839, 2019
-
ruaok
"I understand the difference between a commercial and non-commercial integration" oh, I like that box!
2019-01-18 01845, 2019
-
ruaok
keys transmitted as per usual janky out of band method!
2019-01-18 01815, 2019
-
akhilesh
Mr_Monkey: oh Sorry!
2019-01-18 01827, 2019
-
akhilesh
2019-01-18 01838, 2019
-
Mr_Monkey
No, my bad akhilesh I only thought about it too late :)
2019-01-18 01847, 2019
-
Mr_Monkey
Yes, that's great
2019-01-18 01850, 2019
-
iliekcomputers
ruaok: got it.
2019-01-18 01855, 2019
-
akhilesh
Mr_Monkey: Ok, I will show you for all entities one by one. Please finalize those also
2019-01-18 01854, 2019
-
zas
2019-01-18 01851, 2019
-
Mr_Monkey
akhilesh: Sure thing. I'm off for now but will have a look this weekend.
2019-01-18 01853, 2019
-
Mr_Monkey
Maybe post the screenshots on the ticket, it'll be easier to see them all together
2019-01-18 01859, 2019
-
iliekcomputers
new beta containers for LB deployed.
2019-01-18 01802, 2019
-
iliekcomputers
and for CB.
2019-01-18 01854, 2019
-
akhilesh
Mr_Monkey: I posted the screenshots for the creator sort name. Could you see please?
2019-01-18 01857, 2019
-
ruaok
there are no new user facing features, right?
2019-01-18 01824, 2019
-
akhilesh
In the #BB-298
2019-01-18 01825, 2019
-
BrainzBot
2019-01-18 01836, 2019
-
iliekcomputers
ruaok: there are two new endpoints
2019-01-18 01842, 2019
-
iliekcomputers
for LB
2019-01-18 01848, 2019
-
ruaok
k
2019-01-18 01849, 2019
-
iliekcomputers
and a few user facing features for CB
2019-01-18 01801, 2019
-
iliekcomputers
(related to comments on reviews)
2019-01-18 01802, 2019
-
ruaok
just checking there are no new shiny buttons to push. :)
2019-01-18 01844, 2019
-
ruaok
its blank. though I am listening to music. that sync is on beta.lb, so why is it blank?
2019-01-18 01803, 2019
-
iliekcomputers
ruaok: now playing is a different listen type
2019-01-18 01821, 2019
-
ruaok
stored in redis, yes?
2019-01-18 01825, 2019
-
iliekcomputers
Your client doesn't seem to using it.
2019-01-18 01828, 2019
-
iliekcomputers
ruaok: yes
2019-01-18 01855, 2019
-
ruaok
oh boo. our spotify service doesn't support it.
2019-01-18 01811, 2019
-
iliekcomputers
Ticket :)
2019-01-18 01823, 2019
-
ruaok
2019-01-18 01823, 2019
-
BrainzBot
LB-414: Spotify listen recording service should sent "now listening" info
2019-01-18 01816, 2019
-
reosarevok
bitmap: so I guess I should be updating other PRs to also pass entity instead of releaseGroup, right?
2019-01-18 01822, 2019
-
reosarevok
(other RG related PRs)
2019-01-18 01841, 2019
-
reosarevok
(asking in case the aliasing thing does something about that, but I'm assuming not)
2019-01-18 01849, 2019
-
bitmap
yeah but we can merge this one first if it matters
2019-01-18 01801, 2019
-
Gazooo has quit
2019-01-18 01832, 2019
-
reosarevok
Not really, to me, just making sure
2019-01-18 01846, 2019
-
Gazooo joined the channel
2019-01-18 01802, 2019
-
reosarevok
bitmap: updated that PR
2019-01-18 01813, 2019
-
reosarevok
Also the aliases one, for the new change
2019-01-18 01838, 2019
-
Protab joined the channel
2019-01-18 01839, 2019
-
Rotab has quit
2019-01-18 01848, 2019
-
bitmap
when do you use the N/A gender btw? non-person characters? (didn't follow the discussion but I assume it doesn't mean agender)
2019-01-18 01842, 2019
-
reosarevok
Stuff like companies entered as Other
2019-01-18 01855, 2019
-
reosarevok
Possibly also characters for which gender doesn't apply at all, yes
2019-01-18 01806, 2019
-
reosarevok
bitmap: "/account/subscriptions/${entityType}/remove?id=${entity.id}" - huh, is $ then better than having ' + whatever + ' ?
2019-01-18 01814, 2019
-
reosarevok
I don't think I've ever used the $ thing :)
2019-01-18 01844, 2019
-
bitmap
not really better, but maybe easier to read in some cases where you have to quote/unquote a lot
2019-01-18 01805, 2019
-
bitmap
(to use ${} the string has to be inside `backticks`)
2019-01-18 01843, 2019
-
reosarevok
Backticks sound more confusing, I'll stick to + if that's ok :D
2019-01-18 01856, 2019
-
bitmap
sure :P
2019-01-18 01835, 2019
-
chirlu has quit
2019-01-18 01836, 2019
-
reosarevok
bitmap: waaait. Is there actually any reason to do all the N_ln thing?
2019-01-18 01846, 2019
-
reosarevok
Can't we just do There is currently {num} user subscribed to {entity}?
2019-01-18 01855, 2019
-
reosarevok
I mean, that's going to get replaced anyway...
2019-01-18 01838, 2019
-
bitmap
the string is? and not sure re what languages actual use the entity type for context
2019-01-18 01829, 2019
-
reosarevok
'There is currently {num} user subscribed to {artist}:',
2019-01-18 01829, 2019
-
reosarevok
'There are currently {num} users subscribed to {artist}:',
2019-01-18 01837, 2019
-
reosarevok
'There are currently no users subscribed to {artist}.
2019-01-18 01818, 2019
-
reosarevok
The construction is exactly the same, I'd be very surprised if different languages did it differently depending on if it's artist, series or label...
2019-01-18 01840, 2019
-
bitmap
probably true, not sure what you mean by "going to get replaced anyway" though
2019-01-18 01806, 2019
-
reosarevok
That it's not printed, it's just a variable name
2019-01-18 01829, 2019
-
reosarevok
So the printed / translated string is just the same, effectively
2019-01-18 01850, 2019
-
bitmap
ah right. (unless it's useful for context, but you're probably right that it's not very useful)
2019-01-18 01831, 2019
-
bitmap
can check git grep -3F 'user subscribed to' -- po/*.po I guess
2019-01-18 01819, 2019
-
bitmap
the only advantage to not changing the strings then is that we can keep the old translations
2019-01-18 01851, 2019
-
reosarevok
I know, but it seems like adding a relatively complicated code bit for that is a bit pointless
2019-01-18 01831, 2019
-
reosarevok
Finnish does currently do it as "Artist {artist} is being followed by {num} users" etc, but I don't think that's a necessary requirement of Finnish :)
2019-01-18 01858, 2019
-
reosarevok
Seems to be the only language that makes any difference at all
2019-01-18 01833, 2019
-
bitmap
german is slightly different for collection/series too, but yeah
2019-01-18 01847, 2019
-
reosarevok
I think we can change it, and if someone complains the translation doesn't work in their language we split it :)
2019-01-18 01808, 2019
-
bitmap
sounds good to me
2019-01-18 01839, 2019
-
reosarevok
Ok, sent
2019-01-18 01816, 2019
-
bitmap
cool, checking the tags one first
2019-01-18 01852, 2019
-
reosarevok
(I'm starting to think the layouts *themselves* could be turned into just one but :p)
2019-01-18 01849, 2019
-
bitmap
heh, I mean maybe
2019-01-18 01838, 2019
-
akhilesh has quit
2019-01-18 01815, 2019
-
code_master5 has quit
2019-01-18 01828, 2019
-
Dr-Flay joined the channel
2019-01-18 01838, 2019
-
rdswift has quit
2019-01-18 01858, 2019
-
Dr-Flay has left the channel
2019-01-18 01837, 2019
-
nawcom_ has quit
2019-01-18 01824, 2019
-
nawcom joined the channel
2019-01-18 01814, 2019
-
nawcom has quit
2019-01-18 01824, 2019
-
nawcom joined the channel
2019-01-18 01859, 2019
-
Protab is now known as Rotab
2019-01-18 01829, 2019
-
rdswift joined the channel
