#metabrainz

/

      • ruaok
        iliekcomputers: doesn't seem to work with the request context. nor gives it errors.
      • 2019-01-23 02353, 2019

      • iliekcomputers
      • 2019-01-23 02302, 2019

      • ruaok
        pristine_: yeah, we had to turn off the feature for what Mr_Monkey is working on.
      • 2019-01-23 02348, 2019

      • pristine_
        ruaok: oh. I can try to fix it.
      • 2019-01-23 02355, 2019

      • iliekcomputers
      • 2019-01-23 02311, 2019

      • Mr_Monkey
        pristine_: I think it's not a problem anymore
      • 2019-01-23 02331, 2019

      • pristine_
        Mr_Monkey: Okay :)
      • 2019-01-23 02335, 2019

      • Mr_Monkey
        But thanks :)
      • 2019-01-23 02336, 2019

      • ruaok
        maybe passing the sio object works?
      • 2019-01-23 02300, 2019

      • iliekcomputers
        ruaok: yep, trying that.
      • 2019-01-23 02309, 2019

      • pristine_
        Mr_Monkey: You're welcome :)
      • 2019-01-23 02300, 2019

      • kartikeyaSh joined the channel
      • 2019-01-23 02344, 2019

      • iliekcomputers
        can't seem to receive a message on the client...
      • 2019-01-23 02324, 2019

      • iliekcomputers restarts everything
      • 2019-01-23 02326, 2019

      • iliekcomputers
        nope no luck.
      • 2019-01-23 02333, 2019

      • iliekcomputers
        not sure if i'm doing something wrong.
      • 2019-01-23 02337, 2019

      • iliekcomputers
        let me push what I have so far.
      • 2019-01-23 02309, 2019

      • iliekcomputers
      • 2019-01-23 02306, 2019

      • ruaok
        do you need `with self.app.test_request_context('/'):` when you have a socketio object?
      • 2019-01-23 02323, 2019

      • ruaok
        try without.
      • 2019-01-23 02333, 2019

      • iliekcomputers
        ooh
      • 2019-01-23 02306, 2019

      • iliekcomputers
      • 2019-01-23 02315, 2019

      • iliekcomputers
        it is sending it _somewhere_
      • 2019-01-23 02319, 2019

      • github joined the channel
      • 2019-01-23 02319, 2019

      • github
        [listenbrainz-server] mayhem opened pull request #498: Make the spotify recorder a bit quieter (master...stfu-spotify-reader) https://git.io/fhVEA
      • 2019-01-23 02319, 2019

      • github has left the channel
      • 2019-01-23 02325, 2019

      • iliekcomputers
        i'm not sure if i'm handling it correctly.
      • 2019-01-23 02342, 2019

      • ruaok
        handling it correctly on client or server?
      • 2019-01-23 02349, 2019

      • iliekcomputers
        the js client.
      • 2019-01-23 02309, 2019

      • ruaok
        it used to work, but it might have changed now that we send them differently?
      • 2019-01-23 02343, 2019

      • iliekcomputers
      • 2019-01-23 02357, 2019

      • iliekcomputers
        this is another handler i added for "message" events
      • 2019-01-23 02329, 2019

      • ruaok
        so it kinda worked.
      • 2019-01-23 02342, 2019

      • ruaok
        did you get anything in the client as a response to sending that message?
      • 2019-01-23 02316, 2019

      • iliekcomputers
        with the latest code? no.
      • 2019-01-23 02322, 2019

      • kartikpandey2 joined the channel
      • 2019-01-23 02330, 2019

      • iliekcomputers
        i used to get stuff when I initially opened the PR.
      • 2019-01-23 02309, 2019

      • ruaok
        only with the new socket connection?
      • 2019-01-23 02319, 2019

      • michelv has quit
      • 2019-01-23 02320, 2019

      • iliekcomputers
      • 2019-01-23 02331, 2019

      • github joined the channel
      • 2019-01-23 02331, 2019

      • github
        [listenbrainz-server] mayhem closed pull request #498: Make the spotify recorder a bit quieter (master...stfu-spotify-reader) https://git.io/fhVEA
      • 2019-01-23 02331, 2019

      • github has left the channel
      • 2019-01-23 02355, 2019

      • ruaok
        zbuttram is the best username of the week!
      • 2019-01-23 02357, 2019

      • iliekcomputers
        dat branch name ;)
      • 2019-01-23 02303, 2019

      • iliekcomputers
      • 2019-01-23 02305, 2019

      • iliekcomputers
        this fixed it lol
      • 2019-01-23 02355, 2019

      • ruaok
        and now it works as expected, to the right endpoint and all?
      • 2019-01-23 02303, 2019

      • iliekcomputers
        yes.
      • 2019-01-23 02315, 2019

      • iliekcomputers doesn't like the monkey_patch in his coode
      • 2019-01-23 02322, 2019

      • ruaok
        🖐️
      • 2019-01-23 02335, 2019

      • ruaok
        this is a workaround, yes?
      • 2019-01-23 02302, 2019

      • iliekcomputers
        yes.
      • 2019-01-23 02316, 2019

      • ruaok
        put something on the calendar to check next month if we can get rid of it.
      • 2019-01-23 02322, 2019

      • ruaok
        but for now, let's finish this thing.
      • 2019-01-23 02338, 2019

      • ruaok
        push changes to your branch?
      • 2019-01-23 02342, 2019

      • iliekcomputers
        will open a ticket.
      • 2019-01-23 02349, 2019

      • ruaok
        then I'll merge into web-sockets
      • 2019-01-23 02346, 2019

      • ruaok
        on your PR you have `need to look into serialization / deserialization need.`
      • 2019-01-23 02303, 2019

      • ruaok
        not sure what that means. can I help resolve it?
      • 2019-01-23 02332, 2019

      • iliekcomputers
        so the data from rmq is a list of listens
      • 2019-01-23 02342, 2019

      • iliekcomputers
        with no guarantee of which user the listen belongs to
      • 2019-01-23 02308, 2019

      • iliekcomputers
        so we have to do a json.loads, get user, then json.dumps each listen again...
      • 2019-01-23 02355, 2019

      • ruaok
        sure we dont need to reserialize it just to read the user name, no?
      • 2019-01-23 02341, 2019

      • iliekcomputers
        the bigquery queue for unique listens sends all unique listens in batches.
      • 2019-01-23 02346, 2019

      • ruaok
        but passing both versions looks dumb in the code.
      • 2019-01-23 02304, 2019

      • ruaok
        oh.
      • 2019-01-23 02330, 2019

      • ruaok
        I had assumed that we'd be listening to that queue, not pre-influx one.
      • 2019-01-23 02342, 2019

      • ruaok
        but we need think about latency here. we want low latency...
      • 2019-01-23 02327, 2019

      • iliekcomputers
        how do we handle duplicates if we listen to the pre-influx queue.
      • 2019-01-23 02317, 2019

      • iliekcomputers
        i'd suggest just moving forward with the data for now, get some songs playing and then look into fixing this too?
      • 2019-01-23 02321, 2019

      • ruaok
        I dont think we should be listening to the pre-influx queue.
      • 2019-01-23 02333, 2019

      • iliekcomputers
        we aren't.
      • 2019-01-23 02333, 2019

      • ruaok
        yeah, agreed.
      • 2019-01-23 02339, 2019

      • ruaok
        ok.
      • 2019-01-23 02356, 2019

      • iliekcomputers
        another thing to manage is sessions.
      • 2019-01-23 02357, 2019

      • ruaok
        at some point zas will get angry with us for the resources that LB is using.
      • 2019-01-23 02300, 2019

      • ruaok
        then we can work on it.
      • 2019-01-23 02307, 2019

      • iliekcomputers
        ha! :D
      • 2019-01-23 02307, 2019

      • ruaok
        what kind of sessions?
      • 2019-01-23 02308, 2019

      • iliekcomputers
        nice
      • 2019-01-23 02327, 2019

      • iliekcomputers
        like if I open of my own user pages, it adds them both to the room
      • 2019-01-23 02338, 2019

      • iliekcomputers
        *if I open two of my own user pages
      • 2019-01-23 02319, 2019

      • ruaok
        lets get this merged and deployed on beta.
      • 2019-01-23 02327, 2019

      • ruaok
        then we can see if this is a problem or not.
      • 2019-01-23 02337, 2019

      • iliekcomputers
        ok.
      • 2019-01-23 02348, 2019

      • iliekcomputers
        https://github.com/metabrainz/listenbrainz-server… do you want to change anything here?
      • 2019-01-23 02314, 2019

      • ruaok
        all good. should I merge?
      • 2019-01-23 02319, 2019

      • iliekcomputers
        yeah, sure.
      • 2019-01-23 02322, 2019

      • ruaok
        (int web-sockets)
      • 2019-01-23 02335, 2019

      • kartikpandey2
        Mr_Monkey are you working on issue 313 .?
      • 2019-01-23 02305, 2019

      • kartikpandey2
        if not shall I take this issue .?
      • 2019-01-23 02356, 2019

      • Mr_Monkey
        kartikpandey2: If you're comfortable with SQL, you can have a look at BB-320 which is the subtask that needs doing.
      • 2019-01-23 02356, 2019

      • BrainzBot
        BB-320: Drop editors' date of birth from database https://tickets.metabrainz.org/browse/BB-320
      • 2019-01-23 02357, 2019

      • ruaok
        ok, merged, iliekcomputers
      • 2019-01-23 02332, 2019

      • Mr_Monkey
        You'll have to have a good look at how things are done in the sql folder in the repo
      • 2019-01-23 02310, 2019

      • dolina joined the channel
      • 2019-01-23 02335, 2019

      • akhilesh
        Mr_Monkey: Will you review my PRs today?
      • 2019-01-23 02347, 2019

      • kartikpandey2
        Mr_Monkey: Ok, I would love to take a shot, If I will not able to understand sql code I will reassign to you.
      • 2019-01-23 02331, 2019

      • Mr_Monkey
        kartikpandey2: If you're not familiar with SQL? I'd rather you have a go at another ticket. It's quite critical.
      • 2019-01-23 02354, 2019

      • Mr_Monkey
        akhilesh: Probably not today, I'm getting to the end of the day. But for sure tomorrow. Thanks for your patience
      • 2019-01-23 02348, 2019

      • kartikpandey2
        I know basic sql but I have not worked on sql.
      • 2019-01-23 02337, 2019

      • kartikpandey2
        btw why we choose sql, I believe nosql database would be more suitable for our need
      • 2019-01-23 02353, 2019

      • iliekcomputers
        ruaok: do you wanna deploy this ?
      • 2019-01-23 02353, 2019

      • reosarevok
        Because we like real databases :D
      • 2019-01-23 02358, 2019

      • iliekcomputers
        reosarevok: :D
      • 2019-01-23 02311, 2019

      • iliekcomputers
        reosarevok: we should use excel! :D
      • 2019-01-23 02319, 2019

      • iliekcomputers runs
      • 2019-01-23 02323, 2019

      • reosarevok
        ruaok: ^ is that joke a fireable offence?
      • 2019-01-23 02327, 2019

      • reosarevok
        Mr_Monkey: I'm happy to drop stuff for you, if needed
      • 2019-01-23 02349, 2019

      • ruaok
        I'm off to prepare for zas' arrival in bcn.
      • 2019-01-23 02351, 2019

      • reosarevok
        (I'm not sure I have access though)
      • 2019-01-23 02353, 2019

      • kartikpandey2
        as we can easily scale using nosql database like mongodb
      • 2019-01-23 02300, 2019

      • ruaok
        If you can, please do.
      • 2019-01-23 02312, 2019

      • iliekcomputers
        kartikpandey2: we've had a great experience with postgres
      • 2019-01-23 02323, 2019

      • ruaok
        Still, is it ready without Mr_Monkey 's stuff?
      • 2019-01-23 02324, 2019

      • iliekcomputers
        and moving would be a non-trivial amount of work.
      • 2019-01-23 02333, 2019

      • akhilesh
        Mr_Monkey: No worry, Review when you have time. Thanks :)
      • 2019-01-23 02336, 2019

      • Mr_Monkey
        reosarevok: would you be willing to review kartikpandey2's work on that ticket?
      • 2019-01-23 02345, 2019

      • iliekcomputers
        ruaok: it would just log new listens to the console, so not sure if worth it.
      • 2019-01-23 02315, 2019

      • iliekcomputers
        probably not worth it yet, tbh.
      • 2019-01-23 02318, 2019

      • Mr_Monkey
        IMO not very much
      • 2019-01-23 02322, 2019

      • iliekcomputers
        I'll do some prep for deploying.
      • 2019-01-23 02328, 2019

      • Mr_Monkey
        Sorry for the delays :)
      • 2019-01-23 02335, 2019

      • iliekcomputers
        no worries at all.
      • 2019-01-23 02347, 2019

      • reosarevok
        Mr_Monkey: if all that needs doing is dropping a psql column, it doesn't need much review - ALTER TABLE user DROP COLUMN dob; or whatever
      • 2019-01-23 02346, 2019

      • kartikpandey2
        iliekcomputers: Ok, but I still think if our database gets big we will have problems to maintain that
      • 2019-01-23 02305, 2019

      • iliekcomputers
        kartikpandey2: we have TBs of data in postgres rn :)
      • 2019-01-23 02318, 2019

      • kartikpandey2
        iliekcomputers: Oh, great I use to think sql database can't handle large data.
      • 2019-01-23 02310, 2019

      • kartikpandey2
        but now It feels i was wrong lol xD
      • 2019-01-23 02312, 2019

      • iliekcomputers
        kartikpandey2: postgres is pretty cool! :)
      • 2019-01-23 02302, 2019

      • kartikpandey2
        ok ;)
      • 2019-01-23 02301, 2019

      • CardinalWolseley joined the channel
      • 2019-01-23 02355, 2019

      • ruaok
        `Sorry for the delays :)` beggars shall not be choosers.
      • 2019-01-23 02323, 2019

      • iliekcomputers
        Lolol
      • 2019-01-23 02328, 2019

      • ruaok
        iliekcomputers: I told Mr_Monkey that when BB gets close to moving to hetzer, that you and I would retaliate his good deeds and work out how to host BB on docker/hetzner.
      • 2019-01-23 02350, 2019

      • iliekcomputers
        Yes, for sure.
      • 2019-01-23 02304, 2019

      • ruaok
        I figure between you and I and what is already in place we can knock it out quick...
      • 2019-01-23 02313, 2019

      • ruaok
        for some value of "quick".
      • 2019-01-23 02335, 2019

      • kartikpandey2 has quit
      • 2019-01-23 02357, 2019

      • michelv joined the channel
      • 2019-01-23 02348, 2019

      • lks joined the channel
      • 2019-01-23 02354, 2019

      • lks has quit
      • 2019-01-23 02343, 2019

      • alastairp
        ruaok: ping, around?
      • 2019-01-23 02300, 2019

      • michelv has quit
      • 2019-01-23 02345, 2019

      • kartikeyaSh has quit
      • 2019-01-23 02310, 2019

      • dolina has quit
      • 2019-01-23 02317, 2019

      • dolina joined the channel
      • 2019-01-23 02345, 2019

      • kartikeyaSh joined the channel
      • 2019-01-23 02309, 2019

      • ayerhart has quit