why'd you remove the currently-playing permission?
2019-01-24 02423, 2019
code_master5 joined the channel
2019-01-24 02402, 2019
ruaok
if I did it, then it was a merge conflict, sorry.
2019-01-24 02419, 2019
ruaok
please add it back in, that would cover the error.
2019-01-24 02425, 2019
ruaok
also, please add a check/test for this.
2019-01-24 02429, 2019
iliekcomputers
oh, no worries. I think that might be the reason for the error.
2019-01-24 02432, 2019
iliekcomputers
yes, sure.
2019-01-24 02447, 2019
code_master5
iliekcomputers: I guess blocked user shouldn't be allowed to comment. Right? 🤔
2019-01-24 02459, 2019
code_master5
on reviews?
2019-01-24 02410, 2019
iliekcomputers
blocked users can't make reviews right?
2019-01-24 02417, 2019
code_master5
iliekcomputers: Yeah!
2019-01-24 02425, 2019
iliekcomputers
then, yea.
2019-01-24 02431, 2019
iliekcomputers
shouldn't be able to comment either.
2019-01-24 02409, 2019
code_master5
I thought so too! But then I thought .. like.. poor blocked users! 🤣
2019-01-24 02422, 2019
ruaok
wooo, I haz listens!
2019-01-24 02429, 2019
ruaok
I still have a couple of other things to resolve in my setup, but they seem pretty simple.
2019-01-24 02457, 2019
ruaok
we will need to rejigger some bits of spotify UI -- the spotify integration now takes on a new and more complex meaning.
2019-01-24 02412, 2019
ruaok
e.g. right now we link and force users to record listens in order to play on the listen page.
2019-01-24 02427, 2019
ruaok
that isn't cool -- the user should be able to choose either or, or both.
2019-01-24 02439, 2019
ruaok
but that is for the afternoon. i can do stuff like that, no problem.
2019-01-24 02403, 2019
iliekcomputers
want me to work on anything in the meanwhile?
2019-01-24 02429, 2019
ruaok
if you have nothing to do, think about what I just said above.
2019-01-24 02457, 2019
ruaok
we need to move the "link spotify" feature out of the realm of "import" and more into "something to use with LB".
2019-01-24 02412, 2019
ruaok
makes sense?
2019-01-24 02417, 2019
iliekcomputers
yeah.
2019-01-24 02408, 2019
iliekcomputers
we should take permissions accordingly as well.
2019-01-24 02402, 2019
iliekcomputers
if the user doesn't want import, we shouldn't ask for permission to see their recently played
2019-01-24 02448, 2019
code_master5
iliekcomputers: One thing is bugging me for quite some time! Suppose a user deletes his/her review. What happens to the comments on that review? Should they also be deleted?
soooo, when we link the user's spotify account, do we give them a list of features they can opt in too?
2019-01-24 02433, 2019
ruaok
why is it active_section now?
2019-01-24 02444, 2019
ruaok
Mr_Monkey: ^^
2019-01-24 02401, 2019
iliekcomputers
ruaok: I think that makes it easier to understand
2019-01-24 02413, 2019
ruaok
ah, I see. I certainly didn't get it at first. :)
2019-01-24 02416, 2019
ruaok
thanks for fixing.
2019-01-24 02445, 2019
ruaok
wrt to `soooo, when we link the user's spotify account, do we give them a list of features they can opt in too?`
2019-01-24 02412, 2019
ruaok
Mr_Monkey said that we need to have all those perms to just play full length tracks from spotify
2019-01-24 02431, 2019
ruaok
so, there are two classes of perms then: listen & record.
2019-01-24 02419, 2019
ruaok
so we should enable people to chose either or both sets.
2019-01-24 02435, 2019
iliekcomputers
sounds good to me.
2019-01-24 02452, 2019
ruaok
that said, we're complicating the spotify setup that we were hoping to release.
2019-01-24 02412, 2019
ruaok
I wonder if it makes sense to hold off on that -- I don't like the idea of pushing a release and then changing things right away.
2019-01-24 02431, 2019
ruaok
AAAAAND... people may need to tweak their perms for the next release and re-connect.
2019-01-24 02437, 2019
ruaok
thoughts, iliekcomputers?
2019-01-24 02454, 2019
iliekcomputers
asking people to reauth two times isn't really ideal imo
2019-01-24 02440, 2019
iliekcomputers
we can hold off on the release. (although we'll probably need a long test cycle for this feature too)
2019-01-24 02427, 2019
iliekcomputers
why do we need birthdate and email?
2019-01-24 02452, 2019
Mr_Monkey
iliekcomputers: Somehow, Spotify needs it to verify if the user is a free or premium account
2019-01-24 02458, 2019
Mr_Monkey
…
2019-01-24 02405, 2019
iliekcomputers
:|
2019-01-24 02407, 2019
ruaok
I don't think it needs to be soo long. The listen recording is the thing that was tricky to get right. I think we're good on that.
2019-01-24 02421, 2019
ruaok
a week might suffice.
2019-01-24 02409, 2019
iliekcomputers
ruaok: yea, the play feature isn't data critical, so it _should_ be okay even if we find bugs there. (but we'll try to not have bugs :D)
2019-01-24 02412, 2019
iliekcomputers
sounds good to me.
2019-01-24 02439, 2019
ruaok
so, for the perms nonsense, we should add a note: "In order to play full length tracks, spotify requires a permission to ask for your birthday. We're not going to look at the data -- see the code here: ,<link to code>. Sorry, but this is not our choice. Proceed or Cancel"
2019-01-24 02453, 2019
ruaok
iliekcomputers: great.
2019-01-24 02416, 2019
ruaok
but lets see if we can put these features to bed today.
2019-01-24 02436, 2019
Mr_Monkey
Let me double check the perms.
2019-01-24 02441, 2019
ruaok visualizes Mr_Monkey tucking the feature in and gentle kissing it on the firehead
