can be tune to backup (or exclude) whatever you want
2019-01-28 02813, 2019
Slurpee has quit
2019-01-28 02830, 2019
pristine_
ruaok: could we talk about spark contributions after the meeting?
2019-01-28 02842, 2019
ruaok
pristine_: possibly.
2019-01-28 02851, 2019
ruaok
on the backups...
2019-01-28 02807, 2019
ruaok
please take a look at the doc and at least jot down what you know of that needs backing up.
2019-01-28 02808, 2019
zas
for the rest, ask me, it's still evolving, but it runs.
2019-01-28 02820, 2019
ruaok
then it can be on zas' radar and we can work to implement it.
2019-01-28 02832, 2019
ruaok
the parts that are not complete yet are backups for postgres and influx.
2019-01-28 02836, 2019
ruaok
to be completed.
2019-01-28 02843, 2019
ruaok
fin. freso?
2019-01-28 02846, 2019
zas
backups will happen every day between 2am UTC & 8am UTC
2019-01-28 02851, 2019
Freso
And onwards to…
2019-01-28 02852, 2019
Freso
amCap1712: Feedback on OAuth login (MusicBrainz for Android)
2019-01-28 02856, 2019
ruaok
oh sorry zas.
2019-01-28 02805, 2019
zas
np ;) done
2019-01-28 02805, 2019
amCap1712
Hi everyone
2019-01-28 02809, 2019
pristine_
ruaok: okay:)
2019-01-28 02825, 2019
CatQuest
hi!
2019-01-28 02827, 2019
amCap1712
I have implemented the OAuth login in the app
2019-01-28 02842, 2019
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | Meeting agenda: Feedback on OAuth login (MusicBrainz for Android) (amCap1712), "DR": MBS-9557 - Disallow "special" characters for new accounts (Freso)
plz everyone see the video to better understand the issue
2019-01-28 02811, 2019
CatQuest
you will need to use a browser that will let you use a different app to accept the one url on mb
2019-01-28 02834, 2019
CatQuest
amCap1712 wants to. work on making that fina lstep unecessary but
2019-01-28 02836, 2019
CatQuest
amCap1712?
2019-01-28 02848, 2019
amCap1712
towards the end of video, after clicking on allow access. the phone will either redirect to default browser or ask for option to go to mb app or browser
2019-01-28 02803, 2019
amCap1712
this hijacks the ux
2019-01-28 02818, 2019
Freso
That seems fine and how other apps work too?
2019-01-28 02836, 2019
amCap1712
all other apps use custom uris
2019-01-28 02839, 2019
Freso
I wouldn't want it to use an in-app browser which doesn't have my saved password.
2019-01-28 02850, 2019
Mr_Monkey
If I stay logged in, that wouldn't bother me to do once in a while.
2019-01-28 02856, 2019
amCap1712
that allows automatic redirect
2019-01-28 02819, 2019
amCap1712
To make the last step obsolete, I need to an option to allow custom callback uri
2019-01-28 02823, 2019
Slurpee joined the channel
2019-01-28 02825, 2019
amCap1712
feature addition
2019-01-28 02832, 2019
CatQuest
my problem was that it didn't get asked to use the "confirm" url in the app, but it simply redirected me to a localhsost page in the browser
honestly I think it's kinda fun that we allow just about anything in our usernames
2019-01-28 02824, 2019
CatQuest
but I do understand that this possess a problem. so, how about we grep for a selection of punctuation to find some that is definitely *not* in use by any of our user and then ban such from now on.
2019-01-28 02851, 2019
CatQuest
so that way we can make sure han no users have theri names altered or what
2019-01-28 02805, 2019
Freso
I noticed an issue with usernames on Discourse a while back and have put this ticket in here a couple of times, but it never really got any response.
2019-01-28 02832, 2019
Freso
I noticed earlier this week that now there have also been some username concerns with ListenBrainz URL scheming.
2019-01-28 02855, 2019
code_master5
Yup, similar ticket for CB!
2019-01-28 02826, 2019
Mr_Monkey
We're implementing a follow feature and want to be able to pass usernames as url query parameters like this: `follow/user1,user2,user3`
2019-01-28 02826, 2019
michelv has quit
2019-01-28 02839, 2019
Freso
So maybe it's time to properly consider whether this is something we want to do or not. My immediate proposal, as mentioned on the ticket, is that we prevent new usernames from having whatever set of characters we deem unwanted/problematic, but grandfather old users to let them have it.
2019-01-28 02848, 2019
Mr_Monkey
Which could be a problem if a user is allowed to be called `user1,user2`
2019-01-28 02808, 2019
CatQuest
yea
2019-01-28 02814, 2019
Mr_Monkey
I think that's acceptable
2019-01-28 02824, 2019
CatQuest
my idea was then to see for some spesific punctiuation that it's sure noone has already
2019-01-28 02831, 2019
Freso
CatQuest: One of the problematic characters is ` `, which is in use by a good amount of users.
2019-01-28 02831, 2019
CatQuest
and use that and ban that fro mnow on also
2019-01-28 02837, 2019
CatQuest
yes
2019-01-28 02845, 2019
code_master5
Mr_Monkey: Usernames can be same for different accounts. Right?
2019-01-28 02811, 2019
Mr_Monkey
I was under the impression the nales were unique, but I'm not the person to ask
2019-01-28 02816, 2019
Mr_Monkey
names*
2019-01-28 02820, 2019
code_master5
That is the case with CB though!
2019-01-28 02830, 2019
Freso
I'm thinking that URL special characters and HTML/XML special characters and Unicode control characters should be not allowed.
2019-01-28 02844, 2019
Freso
MB usernames are unique.
2019-01-28 02847, 2019
CatQuest
ya
2019-01-28 02853, 2019
CatQuest
that was my idea too
2019-01-28 02859, 2019
CatQuest
sorry i pasted it in right away
2019-01-28 02815, 2019
CatQuest
but i think it's best if we find soem that is *not in use*
2019-01-28 02831, 2019
CatQuest
because if not, thne soem user will have a problem and wil ahve to be renamed
2019-01-28 02836, 2019
Freso
bitmap, yvanzo, ruaok, reosarevok, (alastairp): Thoughts from you?
2019-01-28 02855, 2019
ruaok
I don't think now is the time to open this can of worms.
2019-01-28 02857, 2019
reosarevok
Is there a point disabling these for new editors if we don't disable them for old editors?
2019-01-28 02801, 2019
Freso
I can whip up a list in put it in the ticket if we agree that it's something we want to do at all.
2019-01-28 02802, 2019
reosarevok
We'll have exactly the same issues
2019-01-28 02809, 2019
CatQuest
exactly
2019-01-28 02823, 2019
CatQuest
i mena there has got to be soem glyps not in use
2019-01-28 02827, 2019
reosarevok
If we have a good reason to change them for everyone, I would
2019-01-28 02828, 2019
ruaok
everyone is busy with other massive projects. soon we will need to move the user/OAuth stuff to the MEB domain and then I think we should address this issue.
2019-01-28 02828, 2019
Freso
reosarevok: Sure, but we won't have people intentionally making (more) weird usernames to mess with the system.
2019-01-28 02835, 2019
Mr_Monkey
It'll be harder to create usernames especially to break a new feature
2019-01-28 02844, 2019
ruaok
we gain nothing by addressing this now, except to dilute our current focus.
2019-01-28 02854, 2019
reosarevok
Agreed to look at it during MeB migration
2019-01-28 02813, 2019
reosarevok
That's also the ideal point to tell people "during this conversion, we'll ask those of you with these characters to change them" if we want
2019-01-28 02829, 2019
CatQuest
not a bad compromise maybe
2019-01-28 02834, 2019
Freso
Alright, I'll leave it hanging for now then.
2019-01-28 02843, 2019
Mr_Monkey
*backburner*
2019-01-28 02856, 2019
Freso
That's all for tonight's meeting then!
2019-01-28 02801, 2019
Freso
Thank you for your time everyone!
2019-01-28 02805, 2019
Freso
</BANG>
2019-01-28 02807, 2019
yvanzo
Thank you Freso
2019-01-28 02810, 2019
Mr_Monkey
Thanks Fresh !
2019-01-28 02818, 2019
CatQuest
thanks Freso
2019-01-28 02819, 2019
code_master5
🤣
2019-01-28 02820, 2019
amCap1712
!m Freso
2019-01-28 02820, 2019
BrainzBot
You're doing good work, Freso!
2019-01-28 02821, 2019
CatQuest
threso
2019-01-28 02831, 2019
code_master5
Thanks Freso!
2019-01-28 02818, 2019
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | Meeting agenda: Reviews
2019-01-28 02817, 2019
yvanzo
zas: I'd like to update sir/solr soon, can we schedule this?
2019-01-28 02801, 2019
zas
you mean solr cloud?
2019-01-28 02837, 2019
yvanzo
as well
2019-01-28 02845, 2019
zas
tomorrow morning?
2019-01-28 02804, 2019
yvanzo
ok
2019-01-28 02837, 2019
amCap1712
yvanzo: what is mb migration? just curious
2019-01-28 02847, 2019
ruaok
pristine_: let's talk tomorrow, ok?
2019-01-28 02859, 2019
ruaok
sorry for the delays. :(
2019-01-28 02804, 2019
yvanzo
amCap1712: meb migration
2019-01-28 02820, 2019
yvanzo
MeB stands for MetaBrainz, while MB stands for Musicbrainz
2019-01-28 02822, 2019
amCap1712
yeah, a typo
2019-01-28 02843, 2019
yvanzo
It's about migrating auth from MusicBrainz to MetaBrainz
2019-01-28 02827, 2019
pristine_
ruaok: sure :) Not a problem at all. The hack day has kept you occupied. I will wait :)
