amCap1712: Time and getting distracted, mostly. They're not stopped, they're "just" a "bit" behind.
2019-01-30 03024, 2019
amCap1712
ok.
2019-01-30 03016, 2019
amCap1712
also could somebody update this page https://musicbrainz.org/doc/Development/Priorities . As we are going to discuss gsoc ideas in the next meeting. How about setting the priorities of various projects? What say?
2019-01-30 03011, 2019
amCap1712
If possible I will then make a list from the ideas mentioned, ask everyone and then update the page.
2019-01-30 03038, 2019
Freso
amCap1712: GSoC projects will not be decided on based on current development priorities.
2019-01-30 03035, 2019
amCap1712
I know that. Just saying that I feel topics are similar :)
2019-01-30 03047, 2019
Freso
If you have questions about current dev focuses of any of the projects, best to just ask in here.
2019-01-30 03025, 2019
amCap1712
ok got it.
2019-01-30 03056, 2019
amCap1712
yvanzo, bitmap, zas, iliekcomputers, alastairp, Mr_Monkey, ruaok, kartikeyaSh: Hi guys, I am planning to update the Development Priorities wiki page, It would be great if you could list them. I can then summarize them and update the list. (Sorry, if I forgot anyone)
2019-01-30 03052, 2019
iliekcomputers
ruaok: ima be here to get the listen player branch merged today.
2019-01-30 03006, 2019
iliekcomputers
If there's still time
2019-01-30 03036, 2019
amCap1712
CatQuest: you around?
2019-01-30 03042, 2019
ruaok returns from lunch
2019-01-30 03011, 2019
ruaok
kartikeyaSh: it isn't *you* whom you need to convince that it runs as expected. you need to convince ME that it does.
2019-01-30 03030, 2019
ruaok
amCap1712: might chat with CallerNo6 before you do that. I think he had some plans.
2019-01-30 03031, 2019
kartikeyaSh
how?
2019-01-30 03053, 2019
ruaok
kartikeyaSh: I've suggested a number of ways that you could do that all throughout the summer.
2019-01-30 03000, 2019
ruaok
you never did any of them.
2019-01-30 03003, 2019
kartikeyaSh
😶
2019-01-30 03044, 2019
ruaok
iliekcomputers: let me fix the failing test on the navbar PR. then we can merge that. then we work to merge the big one, ok?
2019-01-30 03015, 2019
amCap1712
ruaok: ok. I'll talk with CallerNo6 first
2019-01-30 03026, 2019
iliekcomputers
ruaok: sure!
2019-01-30 03012, 2019
iliekcomputers will just get dinner in 15 min and be back
2019-01-30 03037, 2019
kartikeyaSh
ruaok: I did create tests, n created logs for test runs on small data too. https://gist.github.com/kartikeyaSh/b4440affa904e… I guess I forgot what else can I do. Please remind me, so that this can move forward
2019-01-30 03003, 2019
ruaok
what you need to do is to have some way of visually outputting what the algorithms are doing.
2019-01-30 03029, 2019
ruaok
if I can't see what an algorithm is doing as it is working, I don't trust it.
2019-01-30 03048, 2019
ruaok
you need to craft smaller sample data sets that you can work with in order to prove your algorithm.
2019-01-30 03009, 2019
ruaok
you can't output gigs of data and then inspect it. it doesn't work like that.
2019-01-30 03035, 2019
outsidecontext has quit
2019-01-30 03002, 2019
kartikeyaSh
okay I believe I have the data in my local machine for which the above gist is generated. I'll update the gist with that.
2019-01-30 03009, 2019
ruaok
iliekcomputers: have you started reading the listen-page branch?
2019-01-30 03016, 2019
ruaok
kartikeyaSh: I don't want to look at gists.
2019-01-30 03043, 2019
iliekcomputers
ruaok: yes.
2019-01-30 03044, 2019
ruaok
i want to run the program myself. I want to see it. I want live output. I want to run my own cases.
2019-01-30 03007, 2019
iliekcomputers
The profile.js file is all red on github for some reason
2019-01-30 03012, 2019
ruaok
iliekcomputers: great. we should address critical issues, but non critical issues should get a high priority ticket.
2019-01-30 03017, 2019
iliekcomputers
Olay
2019-01-30 03031, 2019
ruaok
almost done with fixing tests. hang on.
2019-01-30 03022, 2019
kartikeyaSh
ruaok: okay, I'll think what to do.
2019-01-30 03031, 2019
ruaok
great!
2019-01-30 03000, 2019
BestSteve has quit
2019-01-30 03044, 2019
BestSteve joined the channel
2019-01-30 03028, 2019
ruaok
iliekcomputers: is current_user.is_anonymous part of our GDPR stuff?
2019-01-30 03032, 2019
spuniun joined the channel
2019-01-30 03044, 2019
iliekcomputers
ruaok: in webserver/__init__.py? yes.
2019-01-30 03056, 2019
ruaok
being used in navbar.html
2019-01-30 03057, 2019
iliekcomputers
but otherwise it just checks if the user is logged in.
2019-01-30 03026, 2019
ruaok
I've got some test_index test cases that are failing and it isn't really clear to me how to fix them.
2019-01-30 03035, 2019
ruaok
in the interest of time, can you have a look?
2019-01-30 03049, 2019
iliekcomputers
yes, i was just gonna ask if i should.
2019-01-30 03017, 2019
ruaok
I made some fixed and just now pushed them to listen-page-player-navbar-revamp
2019-01-30 03026, 2019
ruaok
make sure to do pull before you test.
2019-01-30 03028, 2019
ruaok
thanks!
2019-01-30 03044, 2019
iliekcomputers
yokay, sure.
2019-01-30 03002, 2019
iliekcomputers
ruaok: do we only want to show the import option when the user is logged in now?
2019-01-30 03019, 2019
ruaok
unsure. what do you think?
2019-01-30 03044, 2019
iliekcomputers
right now, we show it always and it leads the user to a login page if logged out.
2019-01-30 03050, 2019
iliekcomputers
which seems like a good flow to me.
2019-01-30 03000, 2019
ruaok
ok, I'm ok with that. I wasn't sure.
2019-01-30 03027, 2019
github joined the channel
2019-01-30 03027, 2019
github
[listenbrainz-server] vansika closed pull request #487: LB-416: Change data type of auth_token from string to UUID (master...auth-token-datatype) https://git.io/fhgeb
2019-01-30 03027, 2019
github has left the channel
2019-01-30 03029, 2019
D4RK-PH0ENiX has quit
2019-01-30 03036, 2019
amCap1712
ruaok: you there
2019-01-30 03046, 2019
ruaok
on call
2019-01-30 03002, 2019
amCap1712
i had a question regarding the app features. I was going through the app it uses google backup api to backup some data (honestly i need to research a bit to find what exactly). if we want the app to be available on f-droid, we need to remove that backup api.
2019-01-30 03025, 2019
iliekcomputers
I pushed the test fixes.
2019-01-30 03042, 2019
iliekcomputers
Came across a problem in the test that we should fix in another PR, i'll open a ticket.
2019-01-30 03002, 2019
amCap1712
we can though provide backup if needed at all through different way
2019-01-30 03056, 2019
ruaok
what does it back up?
2019-01-30 03024, 2019
ruaok
iliekcomputers: ok, have you read over the the navbar PR then?
2019-01-30 03030, 2019
ruaok
we should merge that one first.
2019-01-30 03048, 2019
iliekcomputers
ruaok: yes. looks good to me.
2019-01-30 03052, 2019
ruaok
ah, reading mail. :)
2019-01-30 03016, 2019
github joined the channel
2019-01-30 03016, 2019
github
[listenbrainz-server] mayhem closed pull request #501: Revamp how the menus are organized. (listen-page-player...listen-page-player-navbar-revamp) https://git.io/fhXDD
[listenbrainz-server] mayhem opened pull request #502: Listen page player (master...listen-page-player) https://git.io/fhMg9
2019-01-30 03014, 2019
github has left the channel
2019-01-30 03022, 2019
ruaok
ok, let's jump in. :)
2019-01-30 03041, 2019
iliekcomputers
94 commits, yeah we def need to merge this. :)
2019-01-30 03055, 2019
ruaok
I think most of this code has already been reviewed, so that's nice.
2019-01-30 03057, 2019
ruaok
yes!
2019-01-30 03022, 2019
ruaok
oh, monkey and I talked about "connect your spotify account" UX changes. I can work on those tomorrow.
2019-01-30 03039, 2019
iliekcomputers
what'd I miss?
2019-01-30 03030, 2019
akhilesh
Mr_Monkey: Have you any idea about how to store data in local storage from redux state?
2019-01-30 03046, 2019
ruaok
it wasn't much -- just that we need to revamp the "connect to record listens" to "connect your spotify account for these reasons" Also, we don't look at your birthdate, you can disconnect anytime, etc.
2019-01-30 03046, 2019
Mr_Monkey
akhilesh: I've never implemented it myself in React. What does internet say?
2019-01-30 03013, 2019
akhilesh
Mr_Monkey: impliment something enhansers!
2019-01-30 03034, 2019
akhilesh
internet says
2019-01-30 03034, 2019
iliekcomputers
ruaok: other than profile.js, I don't think any other code there is unreviewed.
2019-01-30 03027, 2019
D4RK-PH0ENiX joined the channel
2019-01-30 03044, 2019
akhilesh
Enhansers can update local storage according to redux-state.
2019-01-30 03003, 2019
Sophist_UK has quit
2019-01-30 03045, 2019
Mr_Monkey
Well, I'm not that well versed in Redux, it's worth a try and seems pretty clean. If the internet says...
2019-01-30 03003, 2019
ruaok
ok, I have very little to say about the js stuffs. but I don't think either of use raised any serious issues in our comments.
2019-01-30 03008, 2019
ruaok
I'm OK to merge.
2019-01-30 03030, 2019
Mr_Monkey
"Move fast, break betas."
2019-01-30 03044, 2019
ruaok
nowhere near ready for beta. sadly.
2019-01-30 03017, 2019
Mr_Monkey
Oh good.
2019-01-30 03034, 2019
iliekcomputers
+1
2019-01-30 03052, 2019
iliekcomputers
Mr_Monkey: any idea why everything is red in the profile.js github view?
2019-01-30 03022, 2019
Mr_Monkey
iliekcomputers: Huh. No idea.
2019-01-30 03054, 2019
iliekcomputers
right okay.
2019-01-30 03000, 2019
iliekcomputers
anyways, we can look at it later.
2019-01-30 03041, 2019
ruaok
iliekcomputers: trello updated for spotify. have a look.
ruaok, iliekcomputers : With that PR merged, should I keep working on the listen-page-player branch?
2019-01-30 03014, 2019
iliekcomputers
Mr_Monkey: yeah, PRs towards master would be better
2019-01-30 03007, 2019
Mr_Monkey
Just making sure it's not on its way to the trash :)
2019-01-30 03014, 2019
ruaok
New branches towards master... Right?
2019-01-30 03029, 2019
iliekcomputers
yes.
2019-01-30 03000, 2019
Mr_Monkey
So I'm confused now :p Do you prefer if I create a new branch or keep working on the existing one?
2019-01-30 03055, 2019
iliekcomputers
Mr_Monkey: create a new branch for the stuff you're working on and then open a PR towards master once done, is what I was thinking :D
2019-01-30 03011, 2019
iliekcomputers
ruaok: did you read the annual report blurbs?
2019-01-30 03016, 2019
Mr_Monkey
In related new iliekcomputers I found the issue with the syntax highlighting on github (using wrong file extension, duh) and pushed it to listen-page-player
