18:23 PM
reosarevok
yvanzo: that for sure :)
2019-01-31 03121, 2019
18:23 PM
reosarevok
Also, edit.display_data.${edit.display_data.entity_type} - how do I do this in React? :)
2019-01-31 03130, 2019
18:23 PM
reosarevok
("nest" two variables like that)
2019-01-31 03153, 2019
18:24 PM
yvanzo
reosarevok: IIRC, bitmap has been working on diff and other stuff might still be necessary to convert edit display (?)
2019-01-31 03114, 2019
18:25 PM
alastairp
iliekcomputers: :3.6.7 is better, but doesn't reflect updates to our base images
2019-01-31 03122, 2019
18:25 PM
prajjwal
hello!!! I was setting up the local server for acoustic brainz and while running this command ./develop.sh run --rm --user `id -u`:`id -g` -e HOME=/tmp webserver npm install ..my terminal says "Run a one-off command on a service."..How do I proceed?
2019-01-31 03151, 2019
18:25 PM
yvanzo
reosarevok: By the way, do you have a Solr instance setup along with your MB server?
2019-01-31 03152, 2019
18:25 PM
alastairp
the idea is that I shouldn't be able to break listenbrainz by pushing a bad python base image
2019-01-31 03101, 2019
18:26 PM
reosarevok
yvanzo: yeah, he said I shouldn't touch stuff with diffs yet :)
2019-01-31 03106, 2019
18:26 PM
reosarevok
And no, I don't
2019-01-31 03113, 2019
18:26 PM
reosarevok
Don't have a local search server at all
2019-01-31 03134, 2019
18:26 PM
alastairp
prajjwal: mmmm, that sounds like the output from `docker-compose run`
2019-01-31 03134, 2019
18:26 PM
iliekcomputers
alastairp: yeah, i guess that makes sense.
2019-01-31 03158, 2019
18:26 PM
alastairp
prajjwal: it's possible that your terminal pasted it in two lines for some reason, causing the full command to not run
2019-01-31 03122, 2019
18:27 PM
yvanzo
2019-01-31 03123, 2019
18:27 PM
BrainzBot
MBS-8978: Schema does not include id attribute for <packaging> element of a release
2019-01-31 03149, 2019
18:27 PM
reosarevok
How does what work?
2019-01-31 03105, 2019
18:28 PM
yvanzo
Cause solr doesn't have a clue about packaging :/
2019-01-31 03154, 2019
18:28 PM
yvanzo
2019-01-31 03130, 2019
18:30 PM
pristine_
iliekcomputers : As discussed earlier, I have written a script to push statistics in RabbitMQ and then eventually in the db.
2019-01-31 03138, 2019
18:30 PM
reosarevok
I don't know enough about solr to answer this :/
2019-01-31 03141, 2019
18:30 PM
prajjwal
alastarirp: So instead of copying shall i write it?
2019-01-31 03143, 2019
18:30 PM
reosarevok
Maybe bitmap does?
2019-01-31 03154, 2019
18:30 PM
pristine_
It is just for testing purpose as of now.
2019-01-31 03158, 2019
18:31 PM
pristine_
To see how to handle data after being processed by spark.
2019-01-31 03117, 2019
18:32 PM
akhilesh
Mr_Monkey, reosarevok : Can it possible that one work exist in many editions?
2019-01-31 03124, 2019
18:32 PM
reosarevok
Yes
2019-01-31 03138, 2019
18:32 PM
reosarevok
Any Shakespeare play for example has a million editions :)
2019-01-31 03140, 2019
18:32 PM
Mr_Monkey
It's even very likely
2019-01-31 03159, 2019
18:32 PM
iliekcomputers
pristine_: nice!
2019-01-31 03105, 2019
18:34 PM
pristine_
iliekcomputers: would try to push it asap. A few changes are required.
2019-01-31 03110, 2019
18:34 PM
pristine_
Thanks :)
2019-01-31 03144, 2019
18:35 PM
iliekcomputers
no worries. :)
2019-01-31 03125, 2019
18:37 PM
iliekcomputers
pristine_: we should first discuss the format of the outputs of the queries that we will send over rmq
2019-01-31 03158, 2019
18:37 PM
pristine_
iliekcomputers: how would that be like?
2019-01-31 03145, 2019
18:38 PM
iliekcomputers
pristine_: i have no idea yet :D
2019-01-31 03128, 2019
18:39 PM
pristine_
How about constructing a dictionary from the Dataframes and then sending over after converting to JSON?
2019-01-31 03138, 2019
18:41 PM
iliekcomputers
hmm, yeah. but the dict that we send over will need to have a defined structure
2019-01-31 03130, 2019
18:44 PM
pristine_
Umm. We could have list of dicts where each dict would contain all the listen data of a user.
2019-01-31 03115, 2019
18:45 PM
reosarevok
yvanzo: did you see my question about the nested variable tingies?
2019-01-31 03118, 2019
18:45 PM
reosarevok
*thingies
2019-01-31 03157, 2019
18:45 PM
reosarevok
(edit.display_data.${edit.display_data.entity_type})
2019-01-31 03120, 2019
18:49 PM
iliekcomputers
pristine_: you should look at how we save data already using the stats module in listenbrainz
2019-01-31 03130, 2019
18:49 PM
iliekcomputers
pristine_: I'd prefer to keep it similar
2019-01-31 03140, 2019
18:50 PM
reosarevok
Nevermind, figured it out
2019-01-31 03124, 2019
18:51 PM
pristine_
iliekcomputers: okay :) I will go through it and would update you tomorrow.
2019-01-31 03105, 2019
19:05 PM
reosarevok
2019-01-31 03159, 2019
19:06 PM
bitmap
ok :)
2019-01-31 03107, 2019
19:07 PM
bitmap
alastairp: hey
2019-01-31 03139, 2019
19:08 PM
michelv has quit
2019-01-31 03139, 2019
19:15 PM
github joined the channel
2019-01-31 03139, 2019
19:15 PM
github
[critiquebrainz] FannyVieira opened pull request #243: Update database schema (master...master)
https://git.io/fhyuy
2019-01-31 03139, 2019
19:15 PM
github has left the channel
2019-01-31 03131, 2019
19:26 PM
bitmap
yvanzo: I wouldn't know how to add support for the id attribute off the top of my head, but it does currently output packaging, so it must know about it somehow?
2019-01-31 03111, 2019
19:31 PM
code_master5 joined the channel
2019-01-31 03120, 2019
19:34 PM
prajjwal
Hello! While using "./develop.sh run --rm db psql -U acousticbrainz -h db " command to load psql session, i encountered the following problem "psql: could not translate host name "db" to address: Name or service not known".Can anyone guide me what to do next?
2019-01-31 03135, 2019
19:34 PM
reosarevok
alastairp, iliekcomputers ^
2019-01-31 03114, 2019
20:00 PM
amCap1712 has quit
2019-01-31 03106, 2019
20:47 PM
CatQuest
reosarevok: still around?
2019-01-31 03158, 2019
21:15 PM
pristine_ has quit
2019-01-31 03111, 2019
21:23 PM
bukwurm has quit
2019-01-31 03100, 2019
21:29 PM
akhilesh has quit
2019-01-31 03110, 2019
21:50 PM
cats joined the channel
2019-01-31 03133, 2019
21:50 PM
cats is now known as Guest64204
2019-01-31 03115, 2019
22:33 PM
yvanzo
bitmap: it does, but not packaging id
2019-01-31 03115, 2019
22:37 PM
yvanzo
bitmap: my main doubt is that musicbrainz-server, mb-solr, and mb-rngpy (which sir depends on) rely on different versions of mmd-schema each.
2019-01-31 03147, 2019
23:00 PM
code_master5 has quit
2019-01-31 03109, 2019
23:09 PM
Guest64204 has quit
2019-01-31 03127, 2019
23:09 PM
cats joined the channel
2019-01-31 03150, 2019
23:09 PM
cats is now known as Guest21465
2019-01-31 03119, 2019
23:11 PM
samj1912
yvanzo, hey
2019-01-31 03142, 2019
23:13 PM
Nyanko-sensei joined the channel
2019-01-31 03112, 2019
23:14 PM
samj1912
2019-01-31 03155, 2019
23:14 PM
samj1912
Basically you want to take a look at the compile dependencies here and make sure the common dependencies between this and mb-solr have same versions
2019-01-31 03105, 2019
23:16 PM
Guest21465 has quit
2019-01-31 03106, 2019
23:16 PM
Guest21465 joined the channel
2019-01-31 03130, 2019
23:16 PM
Guest21465 has quit
2019-01-31 03149, 2019
23:16 PM
D4RK-PH0ENiX has quit
2019-01-31 03149, 2019
23:16 PM
catsed joined the channel
2019-01-31 03134, 2019
23:17 PM
catsed is now known as cats
2019-01-31 03154, 2019
23:17 PM
samj1912
You might have to do this a bit recursively.
2019-01-31 03114, 2019
23:18 PM
samj1912
For eg just looking over things, the version updates seem correct
2019-01-31 03141, 2019
23:18 PM
samj1912
Main culprit is slf4j generally
2019-01-31 03116, 2019
23:19 PM
samj1912
You want to keep that the same
2019-01-31 03128, 2019
23:19 PM
samj1912
2019-01-31 03147, 2019
23:19 PM
samj1912
Solr4j uses 1.7.24
2019-01-31 03133, 2019
23:20 PM
samj1912
I would also be careful about icu4j
2019-01-31 03121, 2019
23:21 PM
samj1912
2019-01-31 03126, 2019
23:21 PM
samj1912
Solr still uses 62.2
2019-01-31 03130, 2019
23:21 PM
samj1912
*62.1
2019-01-31 03155, 2019
23:25 PM
moufl joined the channel
2019-01-31 03137, 2019
23:27 PM
samj1912
2019-01-31 03116, 2019
23:29 PM
samj1912
They way I do it is simply grep the jars in the solr download tar
2019-01-31 03144, 2019
23:29 PM
yvanzo
I see, thank you.
2019-01-31 03129, 2019
23:30 PM
yvanzo
About docker-solr, is it still used?
2019-01-31 03157, 2019
23:30 PM
samj1912
Now, we can probably avoid this if we use the maven shade plugin or not use the dependencies included jar
2019-01-31 03110, 2019
23:31 PM
samj1912
Which was my plan but I never got around to it
2019-01-31 03124, 2019
23:31 PM
samj1912
The latter is the recommended way
2019-01-31 03100, 2019
23:32 PM
samj1912
2019-01-31 03109, 2019
23:32 PM
samj1912
Basically we should be using the normal jar
2019-01-31 03119, 2019
23:32 PM
samj1912
Not the one bundled with dependencies
2019-01-31 03139, 2019
23:32 PM
samj1912
Docker-solr, I still use it for Dev and testing
2019-01-31 03101, 2019
23:33 PM
samj1912
I think zas had some plans to move solr cloud setup to docker
2019-01-31 03109, 2019
23:33 PM
samj1912
It might also be useful for the vm
2019-01-31 03123, 2019
23:34 PM
yvanzo
Both dockerfile and compose file are more up-to-date in mb-solr
2019-01-31 03158, 2019
23:34 PM
samj1912
As in?
2019-01-31 03108, 2019
23:35 PM
yvanzo
I would like to push versionned images of sir and solr for use in the VM indeed.
2019-01-31 03127, 2019
23:35 PM
samj1912
Also mb solr build are failing
2019-01-31 03145, 2019
23:35 PM
samj1912
Well I last updated everything to 7.5
2019-01-31 03151, 2019
23:35 PM
samj1912
That should be good enough
2019-01-31 03106, 2019
23:36 PM
yvanzo
2019-01-31 03121, 2019
23:36 PM
samj1912
Ah!
2019-01-31 03125, 2019
23:36 PM
samj1912
Docker solr
2019-01-31 03130, 2019
23:36 PM
samj1912
Completely forgot about that
2019-01-31 03147, 2019
23:36 PM
samj1912
Yeah you can deprecate that repo
2019-01-31 03155, 2019
23:36 PM
yvanzo
I already prepared a patch about it but realized it might be not worth it.
2019-01-31 03116, 2019
23:37 PM
samj1912
I merged everything in mb-solr
2019-01-31 03126, 2019
23:37 PM
samj1912
It was getting too fragmented
2019-01-31 03140, 2019
23:37 PM
samj1912
I think I haven't touched docker solr in over an year
2019-01-31 03106, 2019
23:38 PM
yvanzo
Ok, I will just wait for zas confirmation before removing docker-solr, just in case he used it for development or something.
2019-01-31 03115, 2019
23:38 PM
samj1912
Ah no no
2019-01-31 03121, 2019
23:38 PM
samj1912
He's also using mb-solr
2019-01-31 03135, 2019
23:38 PM
samj1912
I thought you meant the dockerized solr in mb-solr
2019-01-31 03139, 2019
23:38 PM
samj1912
Not the repo
2019-01-31 03144, 2019
23:38 PM
samj1912
That repo is useless
2019-01-31 03104, 2019
23:40 PM
yvanzo
Ok
2019-01-31 03102, 2019
23:43 PM
yvanzo
samj1912: One last thing is about search indexes regarding latest changes to mmd-schema.
2019-01-31 03121, 2019
23:43 PM
samj1912
Yeah?
2019-01-31 03139, 2019
23:43 PM
samj1912
What exactly are the changes
2019-01-31 03143, 2019
23:43 PM
samj1912
I don't recall
2019-01-31 03154, 2019
23:43 PM
yvanzo
mb-rngpy refers to a one-year old version, that doesn’t matter?
2019-01-31 03149, 2019
23:44 PM
yvanzo
2019-01-31 03123, 2019
23:45 PM
yvanzo
2019-01-31 03133, 2019
23:45 PM
yvanzo
2019-01-31 03125, 2019
23:46 PM
yvanzo
2019-01-31 03136, 2019
23:46 PM
samj1912
Have these been deployed already?
2019-01-31 03142, 2019
23:46 PM
yvanzo
yes
2019-01-31 03101, 2019
23:47 PM
samj1912
Okay, so there are a couple of places thing would need to be changed
2019-01-31 03116, 2019
23:47 PM
samj1912
Mb rngpy for sir to post things correctly to solr
2019-01-31 03136, 2019
23:47 PM
samj1912
Sir.wscompat probably to popular mbrngpy classes
2019-01-31 03142, 2019
23:47 PM
samj1912
*populate
2019-01-31 03151, 2019
23:47 PM
samj1912
And mb-solr
2019-01-31 03155, 2019
23:48 PM
samj1912
2019-01-31 03158, 2019
23:48 PM
samj1912
This thing
2019-01-31 03121, 2019
23:49 PM
samj1912
And probably solr schema if anything changed with the search Schema
2019-01-31 03135, 2019
23:49 PM
samj1912
Like new fields that were added which we want indexed
2019-01-31 03143, 2019
23:49 PM
samj1912
Or others that were removed
2019-01-31 03122, 2019
23:50 PM
samj1912
This changes will also go in sir.schema
2019-01-31 03108, 2019
23:51 PM
samj1912
Also obviously jaxb bindings will need to be updated
2019-01-31 03105, 2019
23:53 PM
yvanzo
Ok, can reindex be made gradually or does it require to build and replace the whole index for related entity types?
