[Bookbrainz] I was trying to build the website using docker but its giving the error fs.js not found, which auto closes the container, any help would be appreciated as i was looking forward to contrinute to the project
Mr_Monkey: technically, in your case, it's because you decided to move to Spain and not, like, the UK :p
2019-03-08 06759, 2019
rihan_
Mr_Monkey: I am interested in undertaking 'Solr search engine' project under gsoc 2019! I have previous experience on nodejs/expressjs/mongodb but not with elasticsearch/solr. Any thoughts/suggestions ?
2019-03-08 06739, 2019
Mr_Monkey
reosarevok: True :D . Although the same thing happened to France during German occupation, moved to GMT+2 for a while.
2019-03-08 06702, 2019
Mr_Monkey
rihan_: I think that might be a hard uphill battle. I don't know much about Solr but it seemed to me to be a complicated project to set up properly.
2019-03-08 06722, 2019
Mr_Monkey
Can I get a second opinion from someone?
2019-03-08 06733, 2019
Mr_Monkey
In any case, I think the first step would be to read some Solr intros and docs
2019-03-08 06758, 2019
amCap1712
gr0uch0mars: yes
2019-03-08 06724, 2019
gr0uch0mars
hi. Yesterday I tried with the code and didn't make it work
2019-03-08 06734, 2019
amCap1712
the latest commit
2019-03-08 06755, 2019
amCap1712
in which I create new live data in the repository method
2019-03-08 06702, 2019
amCap1712
itworked
2019-03-08 06734, 2019
amCap1712
but I really feel its entirely forfeits the purpose of reactive programming
2019-03-08 06705, 2019
amCap1712
I found something on the internet to notify observer when a field in live data changes
a custom implementation of live data like singleLiveEvent
2019-03-08 06708, 2019
gr0uch0mars
yes, and I thought that maybe we could structure in some other way. I think there must be another (easier) way
2019-03-08 06708, 2019
amCap1712
yes there should be. its not that an obscure case. someone might have encountered it before
2019-03-08 06731, 2019
amCap1712
the thing is I couldn't any SO post on it.
2019-03-08 06701, 2019
gr0uch0mars
I thought of another workflow while reading on the internet. Something like I'm doing with Rx in Flutter. That may work…
2019-03-08 06709, 2019
reosarevok
Mr_Monkey: would samj1912 be able to mentor such a thing (or at least co-mentor)?
2019-03-08 06725, 2019
gr0uch0mars
If not, let's post a SO question. Maybe someone has encountered the same problem
2019-03-08 06704, 2019
Mr_Monkey
reosarevok: We approached the subject and he was receptive to it. I need to chase him down.
2019-03-08 06733, 2019
amCap1712
ok lets discuss your workflow, then we'll ask a question if it dosen't?
2019-03-08 06733, 2019
samj1912
Ssup?
2019-03-08 06739, 2019
Mr_Monkey
Hiya !
2019-03-08 06742, 2019
gr0uch0mars
amCap1712: Please take a look at this thread I've created to discuss this very specific topic. I thought it would be a good idea to share everything we find there: https://community.metabrainz.org/t/android-app-ar…
samj1912: We talked previously about you helping out to mentor a GSOC project to move BookBrainz to use Solr instead of ElasticSearch. Would you still be open to it?
2019-03-08 06739, 2019
samj1912
I can help, but I would mostly be able to do so during weekends
2019-03-08 06707, 2019
amCap1712
gr0uch0mars: yeah, sure.
2019-03-08 06750, 2019
amCap1712
i have a question. we are using a viewpager. so extra fragments are loaded off screen. That shouldn't be a problem right?
2019-03-08 06756, 2019
Mr_Monkey
Thanks samj1912 ! I think that would be fine.
2019-03-08 06734, 2019
rihan_
Mr_Monkey: Alright. I will do some reading on Solr. Btw, I came across a post from last year gsoc 2018 here https://community.metabrainz.org/t/gsoc-2018-web-…. You are repeating the project for this year as well ?
hmm never worked with viewpager, so I hadn't thought about that problem :(
2019-03-08 06729, 2019
Mr_Monkey
That's correct amCap1712 and rihan_
2019-03-08 06729, 2019
amCap1712
gr0uch0mars: ok lets try this out first
2019-03-08 06708, 2019
amCap1712
gr0uch0mars: the only problem is the onResume gets called even when we are off screen. though I found a solution to it.
2019-03-08 06718, 2019
amCap1712
create a custom page listener.
2019-03-08 06723, 2019
rihan_
amCap1712: is the same person interested in undertaking this project this year ?
2019-03-08 06745, 2019
amCap1712
rihan_: I don't know :D
2019-03-08 06746, 2019
samj1912
Mr_Monkey: it might be an uphill battle if they have very little experience with solr. Not sure if it would be doable in a single gsoc season.
2019-03-08 06749, 2019
gr0uch0mars
maybe, to exclude ViewPager from the equation, we could try a simple example with a raw activity/fragment. And investigate from easiest to hardes
2019-03-08 06713, 2019
amCap1712
I'm a student and GSoC aspirant too rihan_ :) .
2019-03-08 06731, 2019
rihan_
amCap1712: cool to hear that!
2019-03-08 06747, 2019
michelv has quit
2019-03-08 06701, 2019
amCap1712
yes gr0uch0mars thats probably the best. we can then be clear at debugging
2019-03-08 06727, 2019
Mr_Monkey
Thanks samj1912 I suspected so. I had a hard time wrapping my head around all the moving parts during the summit.
2019-03-08 06738, 2019
reosarevok
samj1912: how much of the MB setup can just be shamelessly copied? :p
2019-03-08 06718, 2019
samj1912
reosarevok: the problem is AFAIR BB doesn't have an api
2019-03-08 06729, 2019
samj1912
That might also be a blessing though
2019-03-08 06707, 2019
samj1912
We can directly use the solr json writer instead of writing our own writer
2019-03-08 06716, 2019
samj1912
That might simplify a lot of things
2019-03-08 06729, 2019
samj1912
But the last time we met, this wasn't decided
2019-03-08 06701, 2019
lollet joined the channel
2019-03-08 06703, 2019
amCap1712
gr0uch0mars: so lets start. Where to begin with?
2019-03-08 06704, 2019
Mr_Monkey
samj1912: Woudl you have some time to discuss this with me this week-end?
2019-03-08 06719, 2019
lollet has quit
2019-03-08 06727, 2019
rihan_
samj1912: Thanks for the info on Solr project. Basically, I am interested in that project but I dont have upfront knowledge about it.
2019-03-08 06732, 2019
samj1912
Sure, I can do Sunday if you are available
2019-03-08 06711, 2019
Mr_Monkey
Yes, Sunday's good. Any preferred time?
2019-03-08 06752, 2019
gr0uch0mars
amCap1712: have you read the thread? If so, I though of creating a new activity that will be the new ARtist Detail (without ViewPager, just some field to show Artist Name/ Birth date, for example) and a List below (releases). What do you think? Would it be an easy example?
2019-03-08 06712, 2019
samj1912
12 ish Barcelona time?
2019-03-08 06729, 2019
samj1912
In the afternoon
2019-03-08 06757, 2019
amCap1712
gr0uch0mars: How about moving just moving the release fragment to below artist info?
2019-03-08 06712, 2019
gr0uch0mars
yes, that would be fine too
2019-03-08 06728, 2019
gr0uch0mars
let's keep it easy at first
2019-03-08 06751, 2019
amCap1712
the viewpager gets removed and the fragment lifecycle isn't effected
2019-03-08 06753, 2019
Mr_Monkey
samj1912 12-ish is indeed "Barcelona time" :+1:
2019-03-08 06759, 2019
rihan_
Mr_Monkey: is the same person interested in implementing the 'web API project' from last gsoc 2018 ?
2019-03-08 06701, 2019
Mr_Monkey
rihan_: I haven't had news about that. If you want to start a plan for that go right ahead
I read it yesterday. I looks relevant, as it fetches de ViewModel in the adapter. But I wanted to try something “bigger”: to not need it in the adapter, and pass the final/updated list to it.
2019-03-08 06756, 2019
gr0uch0mars
Anyway, I'll paste it on the thread, to collect references for future information.
2019-03-08 06706, 2019
amCap1712
ok. I couldn't understand much of the code in the post as I was overwhelmed with Kotlin :)
2019-03-08 06738, 2019
gr0uch0mars
heheh the opposit for me with Java LOL
2019-03-08 06703, 2019
gr0uch0mars
Kotlin is more natural for me, like Swift, JS…
2019-03-08 06736, 2019
gr0uch0mars
(If I had time, I would like to make a clone of the app in Kotlin, so you can compare and see if it looks more readable)
2019-03-08 06744, 2019
amCap1712
Java is my first language. thats why
2019-03-08 06700, 2019
rihan_
Mr_Monkey: okay! I will start my plan on that project.
2019-03-08 06702, 2019
amCap1712
but definitely kotlin is more readable
2019-03-08 06742, 2019
amCap1712
i'll learn that side by side. and later we can utilize it in the project.
2019-03-08 06702, 2019
rihan_
samj1912: thats true. I am just curious and looking to explore. I will do a pet project with elasticsearch. Maybe I can make my markdown notes search with elasticsearch :) :p
2019-03-08 06718, 2019
amCap1712
gr0uch0mars: actually, the problem for us is that
2019-03-08 06735, 2019
amCap1712
we want to query only viewholder binds a release
2019-03-08 06754, 2019
amCap1712
so we need to notify the viewmodel of querying
2019-03-08 06719, 2019
amCap1712
and then the viewmodel should notify the recyclerview of the result
2019-03-08 06728, 2019
amCap1712
thats a 2 way dependency
2019-03-08 06735, 2019
rihan_
Mr_Monkey: I need clarification, here is my git log. I have forked your the BB project. I have 2 remotes setup 1. origin -> points to upstream official BB 2. fork -> points to upstream fork. The latest commit is the merge commit PR and the 2nd one is also the same. should I combine them both ? is my git setup right ? here's the gist to git log
amCap1712: something like if viewholder asks the viewModel to update release X with its cover art --> viewModel re-emits the same release list (but that release item will have URL info) --> notifies the recyclerview -> viewholder now binds an item that has URL inside on it!
2019-03-08 06732, 2019
rihan_
the 2nd commit is the fast-forward merge into local master from my topic-branch(update-readme) to issue the PR.
