#metabrainz

/

      • pristine--
        ping*
      • 2019-03-08 06728, 2019

      • ruaok
        I thin you just called iliekcomputers a pig.
      • 2019-03-08 06735, 2019

      • iliekcomputers
        🐽
      • 2019-03-08 06738, 2019

      • pristine--
        lol
      • 2019-03-08 06744, 2019

      • pristine--
        lolololol
      • 2019-03-08 06704, 2019

      • iliekcomputers
        the please review orange tag
      • 2019-03-08 06707, 2019

      • iliekcomputers
        😂
      • 2019-03-08 06737, 2019

      • ruaok
        effective no?
      • 2019-03-08 06737, 2019

      • pristine--
        what is the purpose of hdfs.client.conn.upload() and the parameters passed
      • 2019-03-08 06753, 2019

      • iliekcomputers
        ruaok: yep
      • 2019-03-08 06700, 2019

      • iliekcomputers
        pristine--: let me look it up
      • 2019-03-08 06721, 2019

      • pristine--
        okay. also the df.write
      • 2019-03-08 06732, 2019

      • pristine--
        what is the diff in their purpose
      • 2019-03-08 06740, 2019

      • pristine--
        import_dump.py
      • 2019-03-08 06755, 2019

      • iliekcomputers
      • 2019-03-08 06741, 2019

      • iliekcomputers
      • 2019-03-08 06747, 2019

      • pristine--
        so by using this i can upload a folder directly
      • 2019-03-08 06750, 2019

      • pristine--
        right?
      • 2019-03-08 06753, 2019

      • iliekcomputers
        yes
      • 2019-03-08 06702, 2019

      • iliekcomputers
        and the dataframe.write writes a dataframe
      • 2019-03-08 06722, 2019

      • Slurpee joined the channel
      • 2019-03-08 06723, 2019

      • Slurpee has quit
      • 2019-03-08 06723, 2019

      • Slurpee joined the channel
      • 2019-03-08 06730, 2019

      • pristine--
        i have a folder wih parquet files. the former will work, no?
      • 2019-03-08 06744, 2019

      • renz joined the channel
      • 2019-03-08 06732, 2019

      • iliekcomputers
        pristine--: yeah, should
      • 2019-03-08 06712, 2019

      • pristine--
        lemme test. I thought i need to specify the extension. spent so much time breaking and joining paths
      • 2019-03-08 06720, 2019

      • pristine--
        should have asked earlier :(
      • 2019-03-08 06727, 2019

      • ruaok
        Mr_Monkey: are you working on a PR for LB? just wondering if we should update beta now or wait for you.
      • 2019-03-08 06745, 2019

      • Mr_Monkey
        Not right this instant, go ahead and update :)
      • 2019-03-08 06750, 2019

      • ruaok
        k
      • 2019-03-08 06709, 2019

      • ruaok
        iliekcomputers: do you want Mr_Monkey to review your PR? its all python stuff..
      • 2019-03-08 06728, 2019

      • baniket
        Mr_Monkey: i was also interested in the user experience project(Bookbrainz) for GSoc. I was thinking of implementing it through storing the state of redux store in the database.
      • 2019-03-08 06730, 2019

      • iliekcomputers
        ruaok: no, I'm merging and will update beta.
      • 2019-03-08 06745, 2019

      • ruaok
        cool cool cool cool cool
      • 2019-03-08 06758, 2019

      • baniket
        User collection*
      • 2019-03-08 06705, 2019

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #542 (master…improve-spotify-linking-verbiage): Improve spotify linking verbiage https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-08 06703, 2019

      • Mr_Monkey
        baniket: Storing the redux state? Why?
      • 2019-03-08 06756, 2019

      • pristine-- high on fever :( feeling hot in cold. lol
      • 2019-03-08 06728, 2019

      • baniket
        I was thinking that we add a state of array book ids in the redux store, store the ids if the books a person has marked and save it to the database. Everytime a person renders the root component, an action creator can be called that queries the db and set the state for the user, in the componentDidMount method
      • 2019-03-08 06738, 2019

      • renz has quit
      • 2019-03-08 06740, 2019

      • amCap1712 joined the channel
      • 2019-03-08 06740, 2019

      • baniket
        Mr_Monkey: Or is it a bad implementation?
      • 2019-03-08 06701, 2019

      • pristine--
        if a button is working okay, but it doesn'it show any colour change or anything that makes it hard for the user to know if it worked or not.
      • 2019-03-08 06708, 2019

      • pristine--
        what can we call such a button
      • 2019-03-08 06714, 2019

      • pristine--
        unresponsive?
      • 2019-03-08 06738, 2019

      • pristine--
        I think unresponsive won't be the appropriate word
      • 2019-03-08 06743, 2019

      • pristine--
        any suggestions?
      • 2019-03-08 06728, 2019

      • CatQuest
        I remember the time html buttons looked like grey things that stood out nad whne you press they where indented
      • 2019-03-08 06750, 2019

      • CatQuest
        /re that that convo abut 4 meg drives and whatnot
      • 2019-03-08 06719, 2019

      • CatQuest
        (hey i started online in 2000, I can't inverse wang-wave about tiny spaces. i gotta work with what i can)
      • 2019-03-08 06725, 2019

      • Mr_Monkey
        baniket: Ok, that's a bit clearer :) I would recommend having a look at how we load an entity (when you visit, say, an Edition's page).
      • 2019-03-08 06725, 2019

      • Mr_Monkey
        ExpressJS hooks are used to load data from the DB and then passing that to the component-to-be-rendered. It's a bit complex with server-side rendering, but a good starting point is: https://github.com/bookbrainz/bookbrainz-site/blo…
      • 2019-03-08 06727, 2019

      • CatQuest
        first computer was 4 gigs harrive :P
      • 2019-03-08 06745, 2019

      • CatQuest
        hardrive*
      • 2019-03-08 06728, 2019

      • CatQuest
        but it had a diskette station!
      • 2019-03-08 06708, 2019

      • Mr_Monkey
        The redux store is created from that data that is loaded like this: https://github.com/bookbrainz/bookbrainz-site/blo…
      • 2019-03-08 06746, 2019

      • CatQuest
        these days you can get an usb 8gig for free :P
      • 2019-03-08 06717, 2019

      • Mr_Monkey
        And this is also relevant in that process: https://github.com/bookbrainz/bookbrainz-site/blo…
      • 2019-03-08 06719, 2019

      • CatQuest
        yo ucan't even *buy* a 8gig micro sd disc
      • 2019-03-08 06730, 2019

      • CatQuest
        smalles coems in like 16 or 34
      • 2019-03-08 06704, 2019

      • Mr_Monkey
        baniket: That's a lot to take in, I know, but it will be well worth the effort to have some understanding of how it all fits together.
      • 2019-03-08 06748, 2019

      • baniket
        Mr_Monkey: Okay, I'll sure look into this stuff and report back
      • 2019-03-08 06748, 2019

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #540 (master…refresh-tokens-endpoint): Add a new endpoint to refresh spotify tokens https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-08 06710, 2019

      • Mr_Monkey
        baniket: In short, the server fetches data from the DB, creates a redux store, passes that store to a component, renders it and sends all that as HTML to the client.
      • 2019-03-08 06737, 2019

      • outsidecontext has quit
      • 2019-03-08 06753, 2019

      • baniket
        Mr_Monkey: So is it using server side rendering?
      • 2019-03-08 06715, 2019

      • Mr_Monkey
        Correct. That's why you'll find a lot of that code in `src/server`
      • 2019-03-08 06735, 2019

      • baniket
        Yes, that makes sense, that was what i was confused about. Guess I'll have to learn server side rendering then
      • 2019-03-08 06751, 2019

      • Mr_Monkey
        Oh joy :)
      • 2019-03-08 06758, 2019

      • pristine--
      • 2019-03-08 06759, 2019

      • BrainzBot
        LB-430: Associate activity with save button on follow page
      • 2019-03-08 06708, 2019

      • pristine--
        Mr_Monkey: ^
      • 2019-03-08 06728, 2019

      • Mr_Monkey
        baniket: I think tutorials will be better suited for that than starting with th BB codebase, which is fairly complex
      • 2019-03-08 06755, 2019

      • Mr_Monkey
        Thanks for the ticket pristine-- !
      • 2019-03-08 06711, 2019

      • pristine--
        my pleasure :)
      • 2019-03-08 06733, 2019

      • iliekcomputers
        Mr_Monkey: ruaok: new beta deployed
      • 2019-03-08 06743, 2019

      • ruaok
        thank you!
      • 2019-03-08 06744, 2019

      • iliekcomputers
        so umm
      • 2019-03-08 06745, 2019

      • ruaok
        after (attempting to) use the follow page for a bit, I find the user selection component to take up too much space.
      • 2019-03-08 06756, 2019

      • iliekcomputers
        why would I want to sort by username on the recent listens page :P
      • 2019-03-08 06701, 2019

      • ruaok
        I don't use it much. I think we need to tuck it under the player.
      • 2019-03-08 06719, 2019

      • ruaok
        that is how you prioritize users, iliekcomputers!
      • 2019-03-08 06749, 2019

      • ruaok
        if you sort by users, it will prioritize playing the users near the top.
      • 2019-03-08 06710, 2019

      • iliekcomputers
        ruaok: the option is also on beta.listenbrainz.org/recent
      • 2019-03-08 06719, 2019

      • iliekcomputers
        where it doesn't make much sense imo
      • 2019-03-08 06722, 2019

      • baniket
        Mr_Monkey: okay, any tutorial that you recommend??
      • 2019-03-08 06742, 2019

      • ruaok
        iliekcomputers: yeah, I think that is a bug.
      • 2019-03-08 06746, 2019

      • iliekcomputers
        hmm
      • 2019-03-08 06716, 2019

      • iliekcomputers
        let me see if i can fix it
      • 2019-03-08 06744, 2019

      • ruaok
        Mr_Monkey and I are fully up for feedback. we're trying things, because nothing is quite obvious to us.
      • 2019-03-08 06723, 2019

      • Mr_Monkey
        baniket: None I can find in my history…
      • 2019-03-08 06750, 2019

      • Mr_Monkey
        iliekcomputers, ruaok: It wasn't a bug to have sort by username on the recent page, but I can see how it's not super obviously useful
      • 2019-03-08 06716, 2019

      • ruaok
        ah. I think we should leave it out...
      • 2019-03-08 06724, 2019

      • Mr_Monkey
        I might want ot listen to what's on the recent page, but without jumping from death metal to chiptune
      • 2019-03-08 06743, 2019

      • Mr_Monkey
        That being said, I don't mind it being removed
      • 2019-03-08 06742, 2019

      • Mr_Monkey wonders if he should find the blackest deadest metal to spam ruaok's follow page
      • 2019-03-08 06702, 2019

      • Mr_Monkey
        OK, I've got a bit of juice left, let me have a look at showing error/succes messages consistently
      • 2019-03-08 06729, 2019

      • iliekcomputers
        that would be amazing, Mr_Monkey
      • 2019-03-08 06705, 2019

      • iliekcomputers
        what did we decide on the sorting thing on the recent page? I would prefer to remove it, it is a bit weird to me.
      • 2019-03-08 06747, 2019

      • ruaok
        I'm ok with removing.
      • 2019-03-08 06705, 2019

      • ruaok
        people may want it later, but it should be easy to bring back.
      • 2019-03-08 06712, 2019

      • Mr_Monkey
        Agree
      • 2019-03-08 06720, 2019

      • iliekcomputers
        cool, i can work on that then.
      • 2019-03-08 06724, 2019

      • ruaok
        what the recents page needs is a "add this user to my follow list" button
      • 2019-03-08 06732, 2019

      • iliekcomputers
        should be simple (tm)
      • 2019-03-08 06735, 2019

      • Mr_Monkey
        So I susspose sorting options only on the follow page then
      • 2019-03-08 06735, 2019

      • iliekcomputers
        ruaok: neat
      • 2019-03-08 06752, 2019

      • iliekcomputers
        ruaok: liek if we have a follow page already open, would it add the user to that follow page?
      • 2019-03-08 06745, 2019

      • ruaok
        yerp.
      • 2019-03-08 06708, 2019

      • ruaok
        but lets not get into creeping featurism right now.
      • 2019-03-08 06723, 2019

      • ruaok
        let's get the follow page working and then do a release soon
      • 2019-03-08 06749, 2019

      • BrainzGit
        [listenbrainz-server] paramsingh opened pull request #543 (master…remove-sort-from-recent): Remove the sort option from the recent page https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-08 06757, 2019

      • iliekcomputers
        it was actually simple :D
      • 2019-03-08 06706, 2019

      • iliekcomputers
        maybe my js fu is improving
      • 2019-03-08 06750, 2019

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #543 (master…remove-sort-from-recent): Remove the sort option from the recent page https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-08 06746, 2019

      • iliekcomputers
        docker push returning 500s
      • 2019-03-08 06707, 2019

      • iliekcomputers
        working now
      • 2019-03-08 06705, 2019

      • iliekcomputers
        ruaok: hi
      • 2019-03-08 06724, 2019

      • iliekcomputers
        can you link the brainzplayer thing again :P
      • 2019-03-08 06727, 2019

      • iliekcomputers
        sorry
      • 2019-03-08 06728, 2019

      • iliekcomputers
        :P
      • 2019-03-08 06753, 2019

      • iliekcomputers
        nvm, found it.
      • 2019-03-08 06731, 2019

      • Cyna joined the channel
      • 2019-03-08 06700, 2019

      • Cyna
        The renderer for musicbrainz-server is redis-server right >
      • 2019-03-08 06701, 2019

      • Cyna
        ?
      • 2019-03-08 06708, 2019

      • yvanzo
        Hi Cyna: no, redis is used for data store/cache
      • 2019-03-08 06717, 2019

      • Cyna
        perl is used for redering ?
      • 2019-03-08 06723, 2019

      • Cyna
        *rendering
      • 2019-03-08 06700, 2019

      • yvanzo
        It is both Perl with Template Toolkit http://template-toolkit.org/ and Node.js with React/JSX https://reactjs.org
      • 2019-03-08 06720, 2019

      • yvanzo
        See root/server.js for the Node.js renderer
      • 2019-03-08 06743, 2019

      • Cyna
        yea on it
      • 2019-03-08 06708, 2019

      • yvanzo
        It receives arguments from the Perl part through socket, see lib/MusicBrainz/Server/Renderer.pm
      • 2019-03-08 06712, 2019

      • Cyna
        So we have nodejs backend as well as perl backend
      • 2019-03-08 06754, 2019

      • Cyna
        we're currently shifting templates from perl to react then we'll remove the perl right
      • 2019-03-08 06727, 2019

      • yvanzo
        The Perl rendering part at least.
      • 2019-03-08 06737, 2019

      • yvanzo
        There will still be a Perl back-end.
      • 2019-03-08 06701, 2019

      • Cyna
        Okay
      • 2019-03-08 06724, 2019

      • CallerNo6 joined the channel
      • 2019-03-08 06724, 2019

      • CallerNo6 has quit
      • 2019-03-08 06724, 2019

      • CallerNo6 joined the channel
      • 2019-03-08 06758, 2019

      • pac23 has quit
      • 2019-03-08 06717, 2019

      • amCap1712 has quit
      • 2019-03-08 06707, 2019

      • ahmedkrmn joined the channel
      • 2019-03-08 06704, 2019

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #544 (master…listens-table-sorting): Fix LB-430: Toast notifications in react components https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-08 06705, 2019

      • BrainzBot
        LB-430: Associate activity with save button on follow page https://tickets.metabrainz.org/browse/LB-430
      • 2019-03-08 06746, 2019

      • Slurpee has quit
      • 2019-03-08 06755, 2019

      • iliekcomputers
        Mr_Monkey: the indentation is off, more spaces than normal i think
      • 2019-03-08 06731, 2019

      • Mr_Monkey
        Agh, f*+%ù#ing tabs.
      • 2019-03-08 06719, 2019

      • Slurpee joined the channel