yvanzo: Where can I find the meaning of different functions like l(), qw(),etc
2019-03-09 06851, 2019
pristine--
Cyna: is it perl?
2019-03-09 06812, 2019
Cyna
I've found these functions almost everywhere
2019-03-09 06836, 2019
pristine--
You working on which project?
2019-03-09 06846, 2019
Cyna
Convertion from TT to React
2019-03-09 06850, 2019
Cyna
Musicbrainz-server
2019-03-09 06814, 2019
pristine--
I think it's perl. :)
2019-03-09 06816, 2019
pristine--
Lol
2019-03-09 06857, 2019
Cyna
Thats the thing to figure out cause if it was perl it wouldnt be there in React pages
2019-03-09 06832, 2019
Cyna
Guess found it
2019-03-09 06845, 2019
Cyna
Thanks
2019-03-09 06807, 2019
ahmedkrmn__ has quit
2019-03-09 06804, 2019
Cyna
the qw was a perl function. Still looking for the meaning of l()
2019-03-09 06809, 2019
aswinmprabhu joined the channel
2019-03-09 06813, 2019
michelv joined the channel
2019-03-09 06827, 2019
ayerhart has quit
2019-03-09 06842, 2019
yvanzo
Cyna: l is a MB defined function for localization
2019-03-09 06827, 2019
yvanzo
It uses gettext
2019-03-09 06839, 2019
yvanzo
ln and lp are variants for ngettext and pgettext, respectively
2019-03-09 06807, 2019
yvanzo
There also are l_domain variants for specific messages domain, l_attributes for instance.
2019-03-09 06839, 2019
yvanzo
qw it the Perl function that stands for “quote words”
2019-03-09 06817, 2019
yvanzo
qw is not needed in JS, but l, ln, lp, and other variants are made available in both Perl and JS.
2019-03-09 06805, 2019
yvanzo
Perl definition is in lib/MusicBrainz/Server/Translation.pm
2019-03-09 06834, 2019
yvanzo
Template Toolkit definition is in lib/MusicBrainz/Server/Plugin/Translation.pm
2019-03-09 06837, 2019
yvanzo
JavaScript definition is in root/static/scripts/common/i18n.js
2019-03-09 06854, 2019
reosarevok
zas: please see the QNAP support email
2019-03-09 06831, 2019
pulkit6559 joined the channel
2019-03-09 06844, 2019
Cyna has quit
2019-03-09 06844, 2019
rihan_ joined the channel
2019-03-09 06818, 2019
rihan_
hello everyone :)
2019-03-09 06802, 2019
yvanzo
hi rihan_!
2019-03-09 06824, 2019
aswinmprabhu has quit
2019-03-09 06841, 2019
pulkit6559 has quit
2019-03-09 06855, 2019
dolina has quit
2019-03-09 06806, 2019
dolina joined the channel
2019-03-09 06817, 2019
Prashant1223 joined the channel
2019-03-09 06840, 2019
pulkit6559 joined the channel
2019-03-09 06801, 2019
Gazooo has quit
2019-03-09 06854, 2019
Gazooo joined the channel
2019-03-09 06820, 2019
reosarevok
yvanzo: we should probably try to convert the collection page to React before we start working on the related schema changes :)
2019-03-09 06804, 2019
reosarevok
The entities-list.tt conversions I'm doing now are a big part of that, and I can also do the rest, but you'll need to review them ;) (and you can do the editing pages if you want?)
2019-03-09 06840, 2019
reosarevok
In fact, I think if we get bitmap's relationship porting merged, most entity display pages will be easy pickings
2019-03-09 06850, 2019
rihan_
Mr_Monkey: Hi there! does eslint automatically run before commit code ?
2019-03-09 06854, 2019
rihan_
on js files ?
2019-03-09 06824, 2019
Mr_Monkey
Hi rihan_ ! It does not. You can run it manually (`npm run lint`) or, what I would suggest, integrate ESLint with your code editor
2019-03-09 06800, 2019
Mr_Monkey
That being said, they are part of the continuous integration tests, so you will see eslint errors fail PR tests
2019-03-09 06802, 2019
rihan_
Mr_Monkey: I am using emacs and I fixed a bug with 1 line commit, the line is indented in my emacs but not on github(strange). I will rollback the commit and issue a new PR.
2019-03-09 06811, 2019
yvanzo
hi reosarevok: alright about converting collection pages before coding schema change stuff
2019-03-09 06837, 2019
yvanzo
but reviews could be much faster if it was made easier :)
2019-03-09 06851, 2019
yvanzo
I generally have two things in mind with commits/messages: 1. making reviews as easy as if I would have to review it (or have to reread it months later), 2. making commits/messages as explanatory as possible for newcomers to get the direction of changes.
2019-03-09 06801, 2019
reosarevok
Do you have specific suggestions? I've tried to make them clear but I'm not that good at it yet :)
2019-03-09 06835, 2019
yvanzo
reosarevok: As you mentionned it earlier, not having the same title for every commit as in 933. :)
2019-03-09 06805, 2019
reosarevok
I was thinking specifically of the entity-list ones now :)
2019-03-09 06820, 2019
reosarevok
Yeah, that one was a bit of a mess, sorry. I can rename them all again if desired, just let me know
2019-03-09 06840, 2019
yvanzo
You can batch modify commits with git rebase --exec if you feel more comfortable with shell scripting.
2019-03-09 06838, 2019
yvanzo
Now that I look back at my own commits, there are some vague messages too. :/
2019-03-09 06836, 2019
yvanzo
At least some messages are descriptive enough for URLCleanup, as regular expression changes are often uneasy to read.
2019-03-09 06834, 2019
BrainzGit
[bookbrainz-site] pv-912 opened pull request #262 (master…Troubleshoot_errors): Docs: Updated elastic search official link, added possible port error when building the application. https://github.com/bookbrainz/bookbrainz-site/pul…
2019-03-09 06829, 2019
BrainzGit
[bookbrainz-site] rihbyne opened pull request #263 (master…master): fix(core): BB-244 Error due to promise not being returned in server/helpers/middleware.js https://github.com/bookbrainz/bookbrainz-site/pul…
[bookbrainz-site] pv-912 closed pull request #262 (master…Troubleshoot_errors): Docs: Updated elastic search official link, added possible port error when building the application. https://github.com/bookbrainz/bookbrainz-site/pul…
"The seven rules of a great Git commit message" are, IMHO, great "specific suggestions" for how to write great (or at least better than standard) commit messages. :)
2019-03-09 06821, 2019
rihan_ has quit
2019-03-09 06826, 2019
BrainzGit
[bookbrainz-site] pv-912 opened pull request #264 (master…Troubleshoot_errors): docs: updated elastic search official URL and added possible port err… https://github.com/bookbrainz/bookbrainz-site/pul…
[bookbrainz-site] MonkeyDo merged pull request #264 (master…Troubleshoot_errors): docs: updated elastic search official URL and added possible port err… https://github.com/bookbrainz/bookbrainz-site/pul…
hi everyone!, i had a small doubt, how do i apply updates to the schema in AB without recreating the database
2019-03-09 06802, 2019
pulkit6559
there's an update folder inside the admin folder, containing queries to alter the database, but there are not commands in manage.py to run those scripts
2019-03-09 06827, 2019
adhawkins has quit
2019-03-09 06853, 2019
iliekcomputers
pulkit6559: hi
2019-03-09 06818, 2019
iliekcomputers
You can docker exec into the acousticbrainz web container
2019-03-09 06848, 2019
iliekcomputers
And then run psql -U acousticbrainz - h db < updatescript.sql
Mr_Monkey: I am getting an error that even typing first letter the redirects automatically during adding relationship as in this PR https://github.com/bookbrainz/bookbrainz-site/pul…. I am unable to find the main error of this. Can u please look into this
