#metabrainz

/

      • zas
        Leo_Verto[m]: there were changes, but none of those are "offficial" (like X-Rate-Limit headers)
      • Leo_Verto[m]
        thanks zas, when is new-ratelimit expected to be released?
      • zas
        but ws usage recommendations are still the same (proper UA, and reasonable use)
      • Leo_Verto[m]
        amCap1712: that's wonderful to hear, what do you want to work on?
      • amCap1712
        Leo_Verto[m]: I am working on MusicBrainz for Android.
      • Leo_Verto[m]
        ah yeah, I saw your reply to the community thread about the app needing a maintainer!
      • zas
        which new-ratelimit ? I'm not aware of anything going on, we had plans to move to an API manager (and/or so called ws/2.5) but for now nothing changed, apart the fact we are more or less deprecating XML (we recommend to use json ws, but that's not mandatory)
      • Picard uses json only now
      • Leo_Verto[m]
        you talked about some kind of adaptive rate limiting during the summit, is that part of the ws/2.5 changes?
      • zas
        Yes. Is there anything wrong with current stuff ?
      • Leo_Verto[m]
        Not at all, I've spent some time working on the Jellyfin project (which is a recent for of Emby) and been asked to review this PR https://github.com/jellyfin/jellyfin/pull/1105 so I was wondering if we were still doing everything the right way
      • zas
        does the code checks for http error codes ? in case of 503, it is recommended to delay, and try again (rather than giving up, or retrying without delay), and of course, 1 req/s (in fact you can often do faster reqs in practice, as we tolerate "bursts") but anything permanently hitting our servers above 1 req/s might be banned without notice.
      • and a user agent string allowing app identification (ideally with url or email, so we can contact people if needed)
      • Leo_Verto[m]
        Roger that, I'll relay that info
      • amCap1712
        gr0uch0mars:
      • updated the proposal. after it I felt, a lot of changes can be made. Much of everything was explained.the technical aspect are covered but it lacked as to the practical aspect.
      • as to what changes would enable us to do what.
      • alastairp
        yvanzo: no, I don't have permissions to see project settings
      • yvanzo
        neither do I for AB, bitmap might have global access
      • bitmap
        I approved the request that just came in if that helps
      • yvanzo
        Thank you, it allowed me to enable JIRA plugin for AB project on Sentry.
      • bitmap: I renamed mb-sentry to dev-sentry on JIRA, so that every project can use it.
      • bitmap
        not sure what that is :)
      • yvanzo
      • Updated credentials in MB project on Sentry too.
      • ruaok
        Mr_Monkey: did you add debuggin info to #549?
      • bitmap
        oh ok. that always confused me because I couldn't figure out who was leaving the comment
      • yvanzo
        alastairp: It is now set up for AB project on Sentry, there is a JIRA button in the toolbar when you review an issue on Sentry.
      • alastairp
        yvanzo: I see it now, thanks!
      • and just linked a ticket
      • annoying that it doesn't link to your username (the github one does)
      • Mr_Monkey
        ruaok: Afirmative. You'll have to set your browser console's level so that you see the 'debug' level
      • yvanzo
        bitmap: yeah, that’s clumsy but JIRA credentials are per-project and not per-user on Sentry.
      • aliamo has quit
      • ruaok
        great.
      • lets see if I have enough brainpower to review it.
      • aliamo joined the channel
      • Mr_Monkey
        Also this ruaok: Yes, I can get the current state of the spot player: https://developer.spotify.com/documentation/web...
      • So if we decide to go for a watchdog, we have that option
      • ruaok
        ohhh, and it does not require an HTTP call?
      • Mr_Monkey
        Correct
      • ruaok
        well, let's see what this PR brings and then we'll see further.
      • Mr_Monkey
        Well, I think it doesn't. Haven't peered at the implementation. It returns a promise, so it's possible there's an HTTP request behind it
      • iliekcomputers: With this new PR I also hope to solve the issue you were seeing with the 404s. It should recover a bit better.
      • Let me know if you see any difference
      • bitmap
        yvanzo: it's perfectly fine to me if people sign their comments :)
      • ruaok
        iliekcomputers: https://github.com/metabrainz/listenbrainz-serv... can you please throw a quick look at that?
      • iliekcomputers
        Yes, on it.
      • ruaok
        <3
      • aliamo has quit
      • yvanzo
        oh right, should do that
      • djwhitey joined the channel
      • iliekcomputers
        lgtm
      • let me merge and deploy
      • amCap1712
        can embed a video of the working instead of the mockups
      • since I have a working version, I suppose its better
      • I could upload a video to youtube and post the link in the proposal
      • CatQuest
        [16:38] <Freso> amCap1712: I changed `post edit time limit` to 120 days now; I'm open to extend it further (or disable it entirely) too,
      • ah actually that's a good idea (disable entierly) since there actually was some old instrument post I wanted to update/edit but couldn't since I couldn't edit it
      • iliekcomputers
        >npm WARN using --force I sure hope you know what you are doing.
      • amCap1712
        would that be fine ruaok or yvanzo?
      • iliekcomputers
        lol
      • ruaok
        amCap1712: can you render the film on chocolate? or somehow apply an organge filter?
      • that would most certainly help.
      • CatQuest
        amCap1712: when it comes to artist links: (or instrument, album etc) I am more interested in wikidata, bandcamp, dicogs, thna facebook spotofy or twitter
      • ruaok
        :-p
      • (yes, videos are great. working code wins. always)
      • amCap1712
        thanks ruaok. I
      • CatQuest
        also plox no "icons instead of text" type links please. it's difficult ot know what it is if it doesnt hav a text
      • iliekcomputers
      • amCap1712
        got it CatQuest
      • ruaok
        ohhh, users at the bottom. :)
      • CatQuest
        as for apparence. ou sohld als ogoo look at chhavi_'s interface ideas on the ticket tracker (with component "design" I belive) we'd want the website and the app to be congruent in apparence (thought the colours of her mockups are not set in stone)
      • ruaok
        filter mode "verbose", Mr_Monkey? I see no debug.
      • CatQuest
        for links i'd say have the name of websitte (and (also?) icon, (ther shoudl be fetchable from the mb api))
      • and on longpress the full url cna be shown
      • maybe
      • Mr_Monkey
        ruaok: Yes, verbose. Should appear in blue
      • CatQuest
        also if there are the indian streaming sites yo ushould suggest them to be auto-thingy in mb, (that way the icon cna be stored by us too)
      • reosarevok
        Your mom is verbose
      • CatQuest
        oh a separate page. then alright, the url full there
      • iliekcomputers
        we just follow each other and listen to the same stuff lol
      • Mr_Monkey and ruaok are listening to the same song.
      • Mr_Monkey
        iliekcomputers: Hah! I try to inject some new music once every couple of days :D
      • reosarevok
        Yay echo chambers :p
      • ruaok
        I wonder why.
      • iliekcomputers
        :)
      • ruaok
        I wonder if we can make it so that all of us listen to only one song. convergence.
      • 🤬
      • reosarevok
      • There, someone play some Estonian electro folk. That'll confuse them
      • iliekcomputers
        Mr_Monkey: ooooh alive 2007
      • noice
      • Mr_Monkey
        Yeah! They never did anything better, IMO
      • CatQuest
        oh i thoguht yo uwhere saying *I* was too verbose D:
      • I mea, yea that's true but
      • reosarevok: tell me these lell'o things are on bandcmap!
      • ruaok
      • so far so good, but the sort order is borked.
      • reosarevok
        CatQuest: no, but their albums are https://tradattackmusic.bandcamp.com/
      • CatQuest
        reosarevok: :D
      • iliekcomputers
        i think, initial sort order is by username and then later by timestamp.
      • not sure though
      • reosarevok
        iliekcomputers: is that the pyramid tour? I was on that tour, it was cool
      • iliekcomputers
        reosarevok: wow
      • Mr_Monkey
        Yeha, sort order is as sent by the server, which is probably what iliekcomputers describes
      • CatQuest
        ugh pages that don't allow you to scroll
      • reosarevok
        Yeah, I'm old
      • iliekcomputers
        from all i've read about it, it seems awesome.
      • lucky
      • iliekcomputers jealous
      • Mr_Monkey
        Second that
      • Mr_Monkey jealous too
      • All right, let me chuck in an initial sort by time, then, and I'll be done for the day
      • CatQuest
        reosarevok: how many songs are on that esto electro folk thing?
      • (becasue i have on idea becasue the page literally wont let me scroll)
      • reosarevok
        It's around 1h long I think?
      • iliekcomputers
        should it be fixed in the backend?
      • CatQuest
        I only get 30 secs. how many *songs*
      • reosarevok
        17 or so
      • CatQuest
        ah
      • damn this album wasn't on bandcamp
      • iliekcomputers
        hmm, there is an order by time in the query already.
      • CatQuest
        wait... that thigyo ulinked was that an album?
      • ruaok
        yes, but users get returned in batches.
      • each user is sorted.
      • iliekcomputers
        right
      • CatQuest
        ruaok: you want true shuffle right?
      • iliekcomputers
        tbh, i'd expect the entire list to be sorted by time from that query...
      • weird.
      • CatQuest would want it shuffled
      • ruaok
        iliekcomputers: look at how they are collated.
      • CatQuest: no, I want seqential sort order.
      • iliekcomputers
        oooh
      • ok.
      • right.
      • CatQuest
        ¯\_(ツ)_/¯
      • i thikn this might wary for differnt people? let users be albe to sort the list/shuffle it and tnhe jsut play liek that? idk
      • gr0uch0mars
        amCap1712: great! Now that everything is written down we can estimate each part. I would add more time to each task as a prevention, like the LiveData challenge now
      • ruaok
        we just removed the sort order -- it didn't do what we wanted.
      • we're going to keep it simple and release this.
      • people will tell us what they want.
      • gr0uch0mars
        I started a change on the code before at work, and it looked good. But I did not complete it
      • I will try to make it work and pass to you
      • amCap1712
        ok
      • iliekcomputers
        ruaok: yeah, i like that idea :)
      • ruaok
        iliekcomputers: thank you for playing something different. :)
      • iliekcomputers decided to add some Indian music in there
      • gr0uch0mars
        Besides, if we want to progress quick in the refactor part (to leave as much time as possible to Picard feature), we should focus on keeping the code clean and manageable
      • That would allow quick changes