#metabrainz

/

      • akhilesh
        Mr_Monkey: More suitable option is either express.js or koa.js. Koa.js is future of express. As I searched
      • 2019-03-19 07824, 2019

      • ferbncode has quit
      • 2019-03-19 07834, 2019

      • akhilesh
        Mr_Monkey: I wish to finalise the tech stack and auth for api use for my proposal for GSOC-2019 in API service project.
      • 2019-03-19 07835, 2019

      • alastairp
        pulkit6559: a quick question - how did you perform the udpate to https://github.com/metabrainz/acousticbrainz-serv… ? It looks like you force-pushed, but this shouldn't have been required
      • 2019-03-19 07843, 2019

      • alastairp
        did you do a rebase or similar?
      • 2019-03-19 07815, 2019

      • iliekcomputers
        alastairp: i did it
      • 2019-03-19 07820, 2019

      • iliekcomputers
        cherry-picked the commits
      • 2019-03-19 07842, 2019

      • alastairp
      • 2019-03-19 07828, 2019

      • akhilesh
        Mr_Monkey: I am waiting your initial response in my previous year proposal, as required some major changes on that. I will great help to me to prepare a good proposal.
      • 2019-03-19 07801, 2019

      • iliekcomputers
      • 2019-03-19 07813, 2019

      • alastairp
        iliekcomputers: 325 was OK this morning when I commented about the spelling mistake, and then pulkit6559 fixed it, bit it should have been a single commit that didn't require force-pushing
      • 2019-03-19 07828, 2019

      • iliekcomputers
        hmm, that wasn't me.
      • 2019-03-19 07848, 2019

      • alastairp
        yes. we should be a bit more careful about force-pushing and cherry-picking and rebasing all over the place
      • 2019-03-19 07801, 2019

      • alastairp
        it has its time, but not necessaraily all the time
      • 2019-03-19 07850, 2019

      • amCap1712
        gr0uch0mars: around
      • 2019-03-19 07806, 2019

      • gr0uch0mars
        yesss
      • 2019-03-19 07824, 2019

      • amCap1712
        we are back to square one
      • 2019-03-19 07848, 2019

      • amCap1712
        i added the viewpager and fragments back
      • 2019-03-19 07810, 2019

      • amCap1712
        still dosen't work
      • 2019-03-19 07817, 2019

      • pulkit6559
        alastairp: actually i had to force push it because i squashed 2 commits
      • 2019-03-19 07834, 2019

      • alastairp
        pulkit6559: right. what commits did you squash?
      • 2019-03-19 07806, 2019

      • alastairp
        it probably wasn't necessary, but don't worry too much
      • 2019-03-19 07824, 2019

      • gr0uch0mars
        have you debugged the reason?
      • 2019-03-19 07835, 2019

      • gr0uch0mars
        LiveData?
      • 2019-03-19 07808, 2019

      • amCap1712
        yup
      • 2019-03-19 07833, 2019

      • BrainzGit
        [listenbrainz-server] paramsingh opened pull request #562 (master…top-month-keyerror): Fix KeyError from user page https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-19 07803, 2019

      • pulkit6559
        i pulled the commits you made into my local branch, so an extra commit was was added saying something like "merged branch stats.. " so i just squashed it with the one i added
      • 2019-03-19 07823, 2019

      • pulkit6559
        it probably wasnt necessary
      • 2019-03-19 07833, 2019

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #561 (master…fix-player-direction-icon): Fix player icon for direction https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-19 07819, 2019

      • gr0uch0mars
        where have you been so far? All calls are done but LiveData is not updated in the Fragment?
      • 2019-03-19 07801, 2019

      • amCap1712
        yes
      • 2019-03-19 07813, 2019

      • pristine--
        ruaok: numpy installed?
      • 2019-03-19 07843, 2019

      • alastairp
        pulkit6559: merge commits are fine, don't worry about them
      • 2019-03-19 07829, 2019

      • iliekcomputers
        alastairp: pushed
      • 2019-03-19 07839, 2019

      • iliekcomputers
        (the LB PR)
      • 2019-03-19 07841, 2019

      • alastairp
        if you fetch/merge before you make a commit then it should do a fast-forwaed and not do theerge commit
      • 2019-03-19 07855, 2019

      • alastairp
        iliekcomputers: cool, I'm out but will look later
      • 2019-03-19 07801, 2019

      • iliekcomputers
        ok.
      • 2019-03-19 07810, 2019

      • alastairp
        I hope you abstracted it out and didn't just change the one line :)
      • 2019-03-19 07825, 2019

      • ruaok
        pristine--: do you have a new errror?
      • 2019-03-19 07835, 2019

      • iliekcomputers sheepishly goes back
      • 2019-03-19 07841, 2019

      • alastairp
        :)
      • 2019-03-19 07819, 2019

      • iliekcomputers
        wait, what do you mean by abstracted it out?
      • 2019-03-19 07829, 2019

      • alastairp
        iliekcomputers: have you heard of Postel's law?
      • 2019-03-19 07844, 2019

      • iliekcomputers
        first time, but the general principle I get.
      • 2019-03-19 07850, 2019

      • pristine--
        yeah. ruaok no module named numpy
      • 2019-03-19 07823, 2019

      • gr0uch0mars
        amCap1712: I'd remove viewpager and keep a simple page, with routes to releases_list, relationsships_list. And remove that pain in the ***
      • 2019-03-19 07846, 2019

      • ruaok
        pristine--: try now.
      • 2019-03-19 07800, 2019

      • alastairp
        mmm, you removed yearmonth?
      • 2019-03-19 07840, 2019

      • alastairp
        I mean, both artists and yearmonth use data[top month]
      • 2019-03-19 07846, 2019

      • reosarevok
      • 2019-03-19 07800, 2019

      • alastairp
        so only .get it once
      • 2019-03-19 07845, 2019

      • iliekcomputers
        the yearmonth var wasn't being used anywhere.
      • 2019-03-19 07827, 2019

      • zas
        reosarevok: not sure what to answer...
      • 2019-03-19 07806, 2019

      • spookyninja has quit
      • 2019-03-19 07837, 2019

      • yvanzo
        install windows? ;)
      • 2019-03-19 07846, 2019

      • alastairp
        right, sothe comment about code duplication is less relevant
      • 2019-03-19 07808, 2019

      • alastairp
        but yeah, we should treat all external data as suspect, always
      • 2019-03-19 07851, 2019

      • alastairp
        I see the Spotify importer failed because they return some data that doesn't include Spotify IDs in the expected place!
      • 2019-03-19 07803, 2019

      • adhawkins has quit
      • 2019-03-19 07854, 2019

      • ruaok
        pristine--: did you try twice?
      • 2019-03-19 07829, 2019

      • pristine--
        ruaok: yeah. tried.
      • 2019-03-19 07840, 2019

      • pristine--
        no error this time
      • 2019-03-19 07843, 2019

      • pristine--
        :)
      • 2019-03-19 07808, 2019

      • pristine--
        numpy is installed
      • 2019-03-19 07827, 2019

      • pristine--
        but what did you do?
      • 2019-03-19 07807, 2019

      • iliekcomputers
        the fact that spotify has bugs in their pipeline and api too makes me happy about our code. :)
      • 2019-03-19 07850, 2019

      • pristine--
        ruaok: :(
      • 2019-03-19 07822, 2019

      • pristine--
        I was wrong. numpy is not installed.
      • 2019-03-19 07841, 2019

      • pristine--
        a process took 500 sec to execute
      • 2019-03-19 07858, 2019

      • pristine--
        and then showed the error
      • 2019-03-19 07805, 2019

      • baniket has quit
      • 2019-03-19 07807, 2019

      • BrainzGit
        [listenbrainz-server] paramsingh opened pull request #563 (master…api-bug): Get latest listen correctly in the API endpoint https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-19 07830, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #974 (master…MBS-10075): MBS-10075: Fix to still display releases with no medium when sorting collection by format/no. of tracks https://github.com/metabrainz/musicbrainz-server/…
      • 2019-03-19 07831, 2019

      • BrainzBot
        MBS-10075: Release with no mediums disappears from release collection when sorting on format/no. of tracks https://tickets.metabrainz.org/browse/MBS-10075
      • 2019-03-19 07839, 2019

      • alastairp
        pristine--: can you give more information? Do you have output from python showing the error? do you know how the docker image is being loaded? did you pull the updated version that ruaok pushed?
      • 2019-03-19 07808, 2019

      • alastairp
        can you verify that numpy is in the container without running the full pipeline?
      • 2019-03-19 07845, 2019

      • pristine--
        alastairp: hi. Spark's MLlib uses numpy. SO when I run that script, I get the error. On my local machine, I included numpy installation command in dockerfile.dev and everything worked
      • 2019-03-19 07825, 2019

      • pristine--
        on leader, it notifies that numpy is not insatlled. I ran ./saprk-submit.sh and it pulled some images
      • 2019-03-19 07835, 2019

      • alastairp
        right
      • 2019-03-19 07840, 2019

      • alastairp
        you're not giving enough information
      • 2019-03-19 07855, 2019

      • pristine--
        umm, what do you want to know?
      • 2019-03-19 07810, 2019

      • alastairp
        "it notifies that numpy is not installed", I want to see this error
      • 2019-03-19 07817, 2019

      • pristine--
        a sec
      • 2019-03-19 07821, 2019

      • alastairp
        "it pulled some image", I want to see what it's pulling
      • 2019-03-19 07800, 2019

      • alastairp
        what did ruaok push for you? does your spark pipeline build the docker image during the process, or does it pull an image?
      • 2019-03-19 07830, 2019

      • alastairp
        what dockerfile did he use to build the image? if you edited Dockerfile.dev, is the same change made in Dockerfile?
      • 2019-03-19 07833, 2019

      • pristine--
      • 2019-03-19 07856, 2019

      • reosarevok
      • 2019-03-19 07822, 2019

      • travis-ci joined the channel
      • 2019-03-19 07823, 2019

      • travis-ci
        metabrainz/picard#4457 (master - 70e08b4 : Laurent Monin): The build passed.
      • 2019-03-19 07823, 2019

      • travis-ci
      • 2019-03-19 07823, 2019

      • travis-ci
      • 2019-03-19 07823, 2019

      • travis-ci has left the channel
      • 2019-03-19 07815, 2019

      • pristine--
        alastairp: unfortunately, I don't know what rob pushed. I told him about the problem, and he just asked me to try it out.
      • 2019-03-19 07812, 2019

      • alastairp
        right. I think that's the first thing to work out, because otherwise pressing buttons and hoping that it's going to work probably isn't going to be very useful :)
      • 2019-03-19 07835, 2019

      • pristine--
        i am not much familiar with leader
      • 2019-03-19 07847, 2019

      • pristine--
        he knows how build and everything works
      • 2019-03-19 07803, 2019

      • alastairp
        can you tell me more about how spark runs the pipeline? where does the error output that you pasted come from? Is that a docker image that is pulled on each worker machine?
      • 2019-03-19 07806, 2019

      • pristine--
        I did not made any changes to Dockerfile.dev on leader
      • 2019-03-19 07822, 2019

      • alastairp
        who else knows about this. iliekcomputers?
      • 2019-03-19 07826, 2019

      • pristine--
        yes
      • 2019-03-19 07854, 2019

      • alastairp
        pristine--: do you have output about it pulling images?
      • 2019-03-19 07858, 2019

      • pristine--
        the error i pasted cam after i ran a script
      • 2019-03-19 07801, 2019

      • pristine--
        a sec
      • 2019-03-19 07812, 2019

      • alastairp
        right. give the *whole* output of the script
      • 2019-03-19 07810, 2019

      • pristine--
      • 2019-03-19 07831, 2019

      • pristine--
        the other info in output is related to spark version and all
      • 2019-03-19 07839, 2019

      • pristine--
        it is not of much usage
      • 2019-03-19 07843, 2019

      • pristine--
        see, the point is
      • 2019-03-19 07800, 2019

      • alastairp
        6:02 PM <alastairp> right. give the *whole* output of the script
      • 2019-03-19 07810, 2019

      • alastairp
        please don't assume that some part of the output is not necessary
      • 2019-03-19 07820, 2019

      • pristine--
        okay
      • 2019-03-19 07851, 2019

      • baniket joined the channel
      • 2019-03-19 07856, 2019

      • pristine--
      • 2019-03-19 07820, 2019

      • yvanzo
        reosarevok: is it based on master?
      • 2019-03-19 07857, 2019

      • yvanzo
        reosarevok: it should have been fixed with gh:MBS#915
      • 2019-03-19 07858, 2019

      • BrainzBot
      • 2019-03-19 07819, 2019

      • reosarevok
        I mean, I don't think I rebased, but
      • 2019-03-19 07832, 2019

      • reosarevok
        It passed all tests before the merge, it's the merge itself that failed them for some reason
      • 2019-03-19 07851, 2019

      • adhawkins joined the channel
      • 2019-03-19 07810, 2019

      • yvanzo
        Oh, it is master build :(
      • 2019-03-19 07843, 2019

      • baniket
        Mr_Monkey: hey!! I wanted to ask what kind of functionality are you trying to get in the user collections project. What i had in mind was a add to read later and a read functionality, buttons appearing for both in edition page and maybe in the header too.
      • 2019-03-19 07851, 2019

      • alastairp
        MacBook-Air:~ alastair$ docker run -ti --rm metabrainz/listenbrainz-spark:latest python -c 'import numpy'
      • 2019-03-19 07851, 2019

      • alastairp
        MacBook-Air:~ alastair$
      • 2019-03-19 07800, 2019

      • alastairp
        pristine--: so, this image contains numpy
      • 2019-03-19 07816, 2019

      • baniket
        I ask this so that i can concentrate on understanding the components I'll have to work with
      • 2019-03-19 07834, 2019

      • alastairp
        that's good. we can remove this part from consideration, the problem must be somewhere else
      • 2019-03-19 07857, 2019

      • baniket
        And how to alter the db accordingly
      • 2019-03-19 07818, 2019

      • pristine--
        alastairp: which image? how do we know that?
      • 2019-03-19 07810, 2019

      • pristine--
        alastairp: I checked numpy on python3 terminal. It wasn't there
      • 2019-03-19 07827, 2019

      • alastairp
        pristine--: the listenbrainz-spark image. the output I pasted was from me loading numpy in python using that image
      • 2019-03-19 07837, 2019

      • alastairp
        ah! python2/python3! that could be the reason
      • 2019-03-19 07809, 2019

      • alastairp
        $ docker run -ti --rm metabrainz/listenbrainz-spark:latest python3 -c 'import numpy; print(numpy.__version__)'
      • 2019-03-19 07810, 2019

      • alastairp
        1.8.2
      • 2019-03-19 07812, 2019

      • alastairp
        works here for me
      • 2019-03-19 07854, 2019

      • ruaok
        pristine--: I pushed one image and realized I made a mistake.
      • 2019-03-19 07807, 2019

      • ruaok
        The I pushed a second image that fixed it.
      • 2019-03-19 07849, 2019

      • pristine--
        how do pull the image? i mean any specific command
      • 2019-03-19 07854, 2019

      • ruaok
        Do you remember how I talked about the `script` command?
      • 2019-03-19 07803, 2019

      • pristine--
        yes
      • 2019-03-19 07804, 2019

      • reosarevok
        baniket, Mr_Monkey: I'm not the one running the project of course, but I feel what we have in MB (a few default collections such as "attending" and "maybe attending" for events, but letting the user make as many collections of their choice as possible) would make sense
      • 2019-03-19 07816, 2019

      • alastairp
      • 2019-03-19 07823, 2019

      • reosarevok
        Then you can have just "read", but also "sci-fi books to gift your teenage daughter" or whatever
      • 2019-03-19 07825, 2019

      • ruaok
        In the future when reporting that something doesn't work, show us what exactly happened.
      • 2019-03-19 07825, 2019

      • pristine--
        running ./spark-submit is pulling images i guess
      • 2019-03-19 07833, 2019

      • alastairp
        that's the output of the image being pulled... so that should be it
      • 2019-03-19 07838, 2019

      • pristine--
        okay. would keep in mind
      • 2019-03-19 07855, 2019

      • alastairp
        when did you run the script?
      • 2019-03-19 07858, 2019

      • pristine--
        alastairp: I think the same but it doesnt work