#metabrainz

/

      • ruaok joined the channel
      • 2019-03-20 07948, 2019

      • baniket has quit
      • 2019-03-20 07949, 2019

      • yvanzo
        zas: opened PRs for borg
      • 2019-03-20 07955, 2019

      • Mr_Monkey
        And ergo not "now"
      • 2019-03-20 07904, 2019

      • yvanzo
        did not run backup yet
      • 2019-03-20 07910, 2019

      • akhilesh has quit
      • 2019-03-20 07954, 2019

      • Cyna has quit
      • 2019-03-20 07954, 2019

      • kepstin has quit
      • 2019-03-20 07916, 2019

      • LordSputnik has quit
      • 2019-03-20 07917, 2019

      • rvedotrc has quit
      • 2019-03-20 07919, 2019

      • baniket joined the channel
      • 2019-03-20 07923, 2019

      • Cyna joined the channel
      • 2019-03-20 07925, 2019

      • akhilesh joined the channel
      • 2019-03-20 07959, 2019

      • iliekcomputers
        Mr_Monkey: I don't think we're on the same page here.
      • 2019-03-20 07936, 2019

      • iliekcomputers
        right now, the playing now in the follow list component gets loaded only via websockets which come in once the page is loaded.
      • 2019-03-20 07950, 2019

      • kepstin joined the channel
      • 2019-03-20 07908, 2019

      • LordSputnik joined the channel
      • 2019-03-20 07926, 2019

      • iliekcomputers
        so if a user is playing a song, and you follow them after the playing now was sent, it won't be loaded into the follow list component
      • 2019-03-20 07924, 2019

      • iliekcomputers
        but according to LB, the user is still playing the song.
      • 2019-03-20 07929, 2019

      • Cyna has quit
      • 2019-03-20 07934, 2019

      • iliekcomputers
        so it does kinda make sense to keep it there.
      • 2019-03-20 07932, 2019

      • wizard joined the channel
      • 2019-03-20 07950, 2019

      • wizard is now known as Guest39732
      • 2019-03-20 07953, 2019

      • Guest39732 has quit
      • 2019-03-20 07953, 2019

      • Mr_Monkey
        iliekcomputers: Okay, I see.
      • 2019-03-20 07922, 2019

      • Mr_Monkey
        Then as with the recent listens endpoint a default max age would be useful I think
      • 2019-03-20 07924, 2019

      • wizard19 joined the channel
      • 2019-03-20 07902, 2019

      • alastairp
        iliekcomputers:
      • 2019-03-20 07932, 2019

      • alastairp
        are you aware of any api endpoints in LB that have an argument that is used as a flag? e.g. turn on x
      • 2019-03-20 07953, 2019

      • iliekcomputers
        Not off the top of my head
      • 2019-03-20 07917, 2019

      • iliekcomputers
        Why?
      • 2019-03-20 07910, 2019

      • alastairp
      • 2019-03-20 07914, 2019

      • alastairp
        I'm deciding about this
      • 2019-03-20 07919, 2019

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #565 (master…spotify-player-state-silent): Spotify player state silent https://github.com/metabrainz/listenbrainz-server…
      • 2019-03-20 07925, 2019

      • alastairp
        if our sentinel should be True, or 1, or yes, or true
      • 2019-03-20 07933, 2019

      • alastairp
        (or any of the above)
      • 2019-03-20 07947, 2019

      • Mr_Monkey
        alastairp: Postel's law?
      • 2019-03-20 07952, 2019

      • alastairp
        rigt
      • 2019-03-20 07906, 2019

      • alastairp
        but what about a string `False` or `0`?
      • 2019-03-20 07936, 2019

      • alastairp
        we could say "if the parameter is set, with any value, it's applied"
      • 2019-03-20 07944, 2019

      • Mr_Monkey
        They're considered explicitly setting to false?
      • 2019-03-20 07908, 2019

      • Mr_Monkey
        I suppose from a user standpoint, if I pass `false` as a flag I expect it to act accordingly
      • 2019-03-20 07917, 2019

      • Mr_Monkey
        flasy value*
      • 2019-03-20 07924, 2019

      • Mr_Monkey
        falsy, even
      • 2019-03-20 07939, 2019

      • alastairp
        so, does that mean I need a list of truthy- and falsy-looking strings?
      • 2019-03-20 07946, 2019

      • alastairp
        or only falsy-looking strings?
      • 2019-03-20 07922, 2019

      • Mr_Monkey
        I'd say only falsy strings
      • 2019-03-20 07918, 2019

      • alastairp
        ? In the context of Boolean operations, and also when expressions are used by control flow statements, the following values are interpreted as false: False, None, numeric zero of all types, and empty strings and containers
      • 2019-03-20 07925, 2019

      • alastairp
        uh
      • 2019-03-20 07948, 2019

      • alastairp
        I lost my > key
      • 2019-03-20 07957, 2019

      • Mr_Monkey
        Here it is: >
      • 2019-03-20 07959, 2019

      • alastairp
        how did I turn my keyboard into español
      • 2019-03-20 07903, 2019

      • alastairp
        ññññññ
      • 2019-03-20 07910, 2019

      • alastairp
        ççççç
      • 2019-03-20 07911, 2019

      • Mr_Monkey
        Say "por fi"
      • 2019-03-20 07916, 2019

      • alastairp
        thats easy
      • 2019-03-20 07934, 2019

      • alastairp
        better
      • 2019-03-20 07936, 2019

      • alastairp
      • 2019-03-20 07923, 2019

      • alastairp
        OK, so I just need to check for "False" "None" and "0", in the context of reading the parameter, I guess
      • 2019-03-20 07924, 2019

      • alastairp
        mmm
      • 2019-03-20 07937, 2019

      • alastairp
      • 2019-03-20 07942, 2019

      • alastairp
        I wonder what flask returns that as
      • 2019-03-20 07911, 2019

      • alastairp
        (in an HTTP query I would interpret this as "set", but if it gives me an empty string inside flask, according to boolean rules this is falsy)
      • 2019-03-20 07914, 2019

      • alastairp
        see how difficult this is
      • 2019-03-20 07939, 2019

      • Mr_Monkey
        I do.
      • 2019-03-20 07958, 2019

      • alastairp
        in other news, 4 months after bottling the black ipa, it tastes more like a stout than an ipa :(
      • 2019-03-20 07919, 2019

      • wizard19 has quit
      • 2019-03-20 07955, 2019

      • akhilesh
        Mr_Monkey: Ping!
      • 2019-03-20 07954, 2019

      • Mr_Monkey
        Hi akhilesh
      • 2019-03-20 07932, 2019

      • akhilesh
        Mr_Monkey: Are you free now?
      • 2019-03-20 07950, 2019

      • Mr_Monkey
        Closing down for the day, it's about dinnertime here
      • 2019-03-20 07958, 2019

      • Mr_Monkey
        But I can read the backlog in the morning
      • 2019-03-20 07959, 2019

      • aliamo_ has quit
      • 2019-03-20 07935, 2019

      • aliamo joined the channel
      • 2019-03-20 07949, 2019

      • akhilesh
        Mr_Monkey: I have updated the date input now, when you have time fetch once more and check all the functionality , I changed the format of date in redux store. It work fine for creator with error msg. Only design part left, I suppose your help on that.
      • 2019-03-20 07902, 2019

      • aliamo_ joined the channel
      • 2019-03-20 07946, 2019

      • aliamo has quit
      • 2019-03-20 07947, 2019

      • pristine__
        nn! Everyone
      • 2019-03-20 07948, 2019

      • Mr_Monkey
        Great akhilesh, looking forward to looking at it in the morning :)
      • 2019-03-20 07952, 2019

      • Mr_Monkey
        Night pristine__
      • 2019-03-20 07924, 2019

      • aliamo_ has quit
      • 2019-03-20 07903, 2019

      • aliamo joined the channel
      • 2019-03-20 07906, 2019

      • reosarevok
        samj1912: around by any chance?
      • 2019-03-20 07912, 2019

      • reosarevok
        Or Mineo
      • 2019-03-20 07925, 2019

      • aliamo has quit
      • 2019-03-20 07955, 2019

      • reosarevok
        Or anyone who knows how our search server works, really :D
      • 2019-03-20 07919, 2019

      • zas
        not me....
      • 2019-03-20 07939, 2019

      • zas
        i just know they don't always work
      • 2019-03-20 07903, 2019

      • SothoTalKer joined the channel
      • 2019-03-20 07955, 2019

      • Prajjwal_Jha joined the channel
      • 2019-03-20 07922, 2019

      • baniket has quit
      • 2019-03-20 07943, 2019

      • aswinmprabhu has quit
      • 2019-03-20 07954, 2019

      • Prajjwal_Jha
        alastairp: Since I could not find any active issues relating to "New machine learning infrastructure" project, shall I start writing a proposal for it? Also, what shall my proposal consist to make it strong?
      • 2019-03-20 07954, 2019

      • CatQuest
        happy holi!
      • 2019-03-20 07958, 2019

      • CatQuest
        <-- late
      • 2019-03-20 07902, 2019

      • BrainzGit
        [sir] reosarevok opened pull request #99 (master…patch-1): MBS-9789: Return the credited name for ACs https://github.com/metabrainz/sir/pull/99
      • 2019-03-20 07903, 2019

      • BrainzBot
        MBS-9789: Artist credit bug when re-using previous recording https://tickets.metabrainz.org/browse/MBS-9789
      • 2019-03-20 07900, 2019

      • Prajjwal_Jha
        Happy Holi :)
      • 2019-03-20 07958, 2019

      • reosarevok
        samj1912 or Mineo or whoever :D Can you check that, and let me know what other steps we need to take after the sir changes? :) I still don't quite understand how the whole thing works
      • 2019-03-20 07913, 2019

      • reosarevok
        culinko: found your issue ;)
      • 2019-03-20 07919, 2019

      • reosarevok
        Well, more like bitmap did, but still :D
      • 2019-03-20 07954, 2019

      • bitmap
        not really, I only saw that the search server was broken, you found out why :P
      • 2019-03-20 07935, 2019

      • reosarevok
        Fine, I guess :D
      • 2019-03-20 07935, 2019

      • amCap1712 has quit
      • 2019-03-20 07932, 2019

      • culinko
        thanks both of you :P
      • 2019-03-20 07939, 2019

      • aliamo joined the channel
      • 2019-03-20 07955, 2019

      • culinko
        so was this only an issue for recordings or could this theoretically be be observed elsewhere?
      • 2019-03-20 07927, 2019

      • gr0uch0mars has quit
      • 2019-03-20 07930, 2019

      • bitmap
        it could be observed for other entities that have artist credits, theoretically
      • 2019-03-20 07901, 2019

      • bitmap
        wherever we display data from search queries
      • 2019-03-20 07919, 2019

      • reosarevok
        And in actual search results everywhere
      • 2019-03-20 07925, 2019

      • reosarevok
        eh. Web service ones
      • 2019-03-20 07927, 2019

      • Prajjwal_Jha has quit
      • 2019-03-20 07933, 2019

      • pulkit6559 has quit
      • 2019-03-20 07954, 2019

      • code_master5 has quit
      • 2019-03-20 07948, 2019

      • moufl joined the channel
      • 2019-03-20 07951, 2019

      • Dr-Flay joined the channel
      • 2019-03-20 07907, 2019

      • Dr-Flay has left the channel
      • 2019-03-20 07940, 2019

      • moinmoi has quit
      • 2019-03-20 07936, 2019

      • akhilesh has quit