So you sometimes need to use direct search (which queries the database directly) instead
2019-03-21 08045, 2019
yvanzo
Cyna: This search page returned artist not existing in your local database because your server is set to perform indexed search using musicbrainz.org search server rather than a local server.
2019-03-21 08027, 2019
Cyna
Well I've bounced that hurdle
2019-03-21 08030, 2019
Cyna
Fell into another
2019-03-21 08032, 2019
yvanzo
(And it’s better like that for now, since you don’t code search pages anyway)
2019-03-21 08002, 2019
Cyna
I cant edit an entity without verifying my email
2019-03-21 08041, 2019
Cyna
and I cant verify the user's email because Im running development server
reosarevok: I guess there's no easy way of getting track lengths when browsing release by recordingid
2019-03-21 08002, 2019
yvanzo
reosarevok: because it still fails for selenium and selenium
2019-03-21 08007, 2019
reosarevok
Oh
2019-03-21 08038, 2019
yvanzo
and selenium and perl-and-pgtap too
2019-03-21 08051, 2019
reosarevok
What about selenium?
2019-03-21 08057, 2019
yvanzo
fails
2019-03-21 08031, 2019
reosarevok
And selenium?
2019-03-21 08040, 2019
reosarevok
Anyway, ok, gotcha
2019-03-21 08011, 2019
Cyna
I propose an extra option as `preview` when the voting area for edits is shown
2019-03-21 08017, 2019
yvanzo
fiasl
2019-03-21 08059, 2019
Cyna
Clicking on that option, the same page would open just with the changes that would be made when the edits are submitted
2019-03-21 08010, 2019
Cyna
Is this the Project's main aim ?
2019-03-21 08023, 2019
Cyna
the creation on `preview` option
2019-03-21 08048, 2019
yvanzo
not really, voting means the edit has been submitted already
2019-03-21 08002, 2019
yvanzo
as in 'submitted to vote'
2019-03-21 08012, 2019
Cyna
You want the user to preview the edits he makes then ?
2019-03-21 08026, 2019
yvanzo
Cyna: edit a release and see the last tab
2019-03-21 08037, 2019
yvanzo
Yes
2019-03-21 08059, 2019
yvanzo
We want the last tab of release editor for every other entity editor
2019-03-21 08027, 2019
Cyna
currently the last tab is edit, so after the user has made the certain edits you want the user to be able to preview the changes before he presses the submit edit, right ?
2019-03-21 08022, 2019
yvanzo
Cyna: no the last tab under 'edit' tab in edit page
2019-03-21 08041, 2019
yvanzo
oops, yes, that’s right
2019-03-21 08022, 2019
yvanzo
(last statement is right, but first statement is not: the last tab is 'edit note')
2019-03-21 08050, 2019
Cyna
Ohh I identify that as a section, nevermind. I understand the project statement
2019-03-21 08054, 2019
yvanzo
'Edit Note' should actually be reworded to 'Edit Summary' or something as it displays both edits preview and edit note form.
2019-03-21 08043, 2019
yvanzo
don't mix 'edit note' tab with 'edit note' section it contains though :)
2019-03-21 08018, 2019
Cyna
I was thinking out adding a button with text like `Preview` somewhere near the `Enter edit` option and the preview buttom would lead to a page with the changes applied for the user to preview
2019-03-21 08043, 2019
yvanzo
Cyna: Ah, do you mean preview of the resulting entity?
2019-03-21 08055, 2019
Cyna
Yea I guess so
2019-03-21 08014, 2019
yvanzo
Yeah, but that would be yet another feature.
2019-03-21 08046, 2019
Cyna
I'm currently playing around my editing Kanye West
2019-03-21 08050, 2019
Cyna
*\by
2019-03-21 08055, 2019
Cyna
So as far as I understand, once a user had made the changes he wanted to, he can click on `Enter edit` to submit it for review with a review statement and an optional mark to allow it for voting
2019-03-21 08005, 2019
yvanzo
That’s mostly the feature requested in MBS-9265 but it is much more complicated than just edits preview which we want anyway.
So as preview comes to my mind, I was thinking is to have a preview button in the `Edit Note` section that actually shows the same page but with the requested changes
2019-03-21 08041, 2019
Cyna
thats what I understood of edit previews 😅
2019-03-21 08034, 2019
Cyna
( Im still trying to understand the project statement )
2019-03-21 08039, 2019
yvanzo
Cyna: did you edit a release already?
2019-03-21 08044, 2019
Cyna
I edited an Artist
2019-03-21 08049, 2019
yvanzo
Go editing a release, change as many fields as you can, and go to the 'Edit Note' tab and look at edits preview :)
Cyna: direct search works, as I said - I usually just direct search for "a" or something and use whatever comes up
2019-03-21 08000, 2019
reosarevok
Actual SQL queries work too, of course
2019-03-21 08003, 2019
alastairp
oh, I didn't see inc=recordings
2019-03-21 08006, 2019
yvanzo
Cyna: sure, the database :) there is no page listing all entities because there are too many, even in sample database
2019-03-21 08014, 2019
reosarevok
Nine Inch Nails, Chopin and Liszt are also there, if you want a bit bigger ones
2019-03-21 08020, 2019
alastairp
cool, that's the last thing that the thread poster was after
2019-03-21 08048, 2019
reosarevok
I'll answer
2019-03-21 08009, 2019
alastairp
thanks!
2019-03-21 08025, 2019
alastairp
waiting for /ws/4
2019-03-21 08018, 2019
yvanzo
can someone please keep alastairp fed and alive til then?
2019-03-21 08026, 2019
reosarevok
I think that's the university's job
2019-03-21 08005, 2019
akhilesh
Mr_Monkey: As I discussed with iliekcomputers, All MetaBrainz projects have different section of code in repo who have methods to play with database, That method are used for both Website and API. But BB does not have such section in repo that we can use from both. This may lead code duplication. What is your opinion on that.
2019-03-21 08059, 2019
akhilesh
Mr_Monkey: Am I clear to you?
2019-03-21 08053, 2019
reosarevok
Something like /static/scripts/utilities would match what we use in MB
Theoretically, it should not break anything - even git remotes will just redirect
2019-03-21 08008, 2019
reosarevok
I've only done it a couple times though (for small personal projects I transferred to wikimediaeesti)
2019-03-21 08022, 2019
akhilesh
Mr_Monkey: This is a big work to separate the common code, that why I am thinking that, I should include this work in my GSoC proposal. When we will implement API endpoint we will write the common code in separate section entity by entity. How is this plan?
2019-03-21 08042, 2019
Mr_Monkey
akhilesh: If the api code is in the same bookbrainz-site repo (I see the naming issue), it's easy to have `src/server`, `src/api` and `scr/common`.
2019-03-21 08000, 2019
Mr_Monkey
akhilesh: As you find cases for code duplication while writing the api code, the code will be moved to some common folder. Is that what you're proposing?
baniket: An "add to collection" button there definitely a good idea. I would go for only one button, and clicking on it would open a component to let you choose which collection to add to or optionally create a new one.
2019-03-21 08043, 2019
baniket
Mr_Monkey: I thought of that too, but i figured that the most selected collections will be read and read later, so they should be kept visible at all times so that the user does not have to do extra steps, the others being accessible by the third button
2019-03-21 08013, 2019
Mr_Monkey
I think it complicates the UI to have all those buttons, but I agree the most selected collections should be the most obvious in the additional component.
