the problem ther is that yo uant al lthe releases. (release groups) but for osme this is a mad thing (eg bethoven)
2019-03-22 08146, 2019
CatQuest
the problem there is that you do want all the releases. (release groups) but for some this is a mad thing (eg beethoven)
2019-03-22 08110, 2019
CatQuest
uh
2019-03-22 08117, 2019
amCap1712
we could find a way in the middle something if mb api allows it
2019-03-22 08117, 2019
gr0uch0mars
yes, that's why I thought of presenting x number of releases/releases group and, if you want more, go to the full list
2019-03-22 08128, 2019
Mr_Monkey
akhilesh: Let me check
2019-03-22 08137, 2019
amCap1712
how about the paging library in architecture components
2019-03-22 08149, 2019
CatQuest
90% i want ot go to the full lsit though having a "filter/search" would be a good idea(
2019-03-22 08116, 2019
amCap1712
yeah, we could add filters once all pages are dones\
2019-03-22 08134, 2019
CatQuest
the first? "release" page is pretty useless. it's a sideways sort of scrolling with 3-4 entries?
2019-03-22 08154, 2019
CatQuest
i mena have al sit of al releases. and op top have the "filter" mecanism for mthe website
2019-03-22 08106, 2019
CatQuest
i say releases but i do mean release groups
2019-03-22 08112, 2019
gr0uch0mars
but that could not be on the same page as artist info
2019-03-22 08121, 2019
Mr_Monkey
CatQuest: I just hate having pictures of me around on internet, so i end up using whatever I have at hand. That was a pic from a restaurant in Amsterdam: https://boiboi.com/
2019-03-22 08133, 2019
CatQuest
artist info is not as interesting as release(groups) imho
2019-03-22 08110, 2019
CatQuest
Mr_Monkey: absolutely same. it's why i use re "cat Quest" cat toy picture :D
2019-03-22 08111, 2019
CatQuest
but I thouht a happy monkey better :P
2019-03-22 08116, 2019
CatQuest
neat logo though
2019-03-22 08153, 2019
aliamo has quit
2019-03-22 08108, 2019
amCap1712
For now we can just re arrange as we move forward we can further work on it
Mr_Monkey, akhilesh: About those date fields, I'd prefer to have hyphens separate the date parts to double down on the date component being listed in ISO 8601 format. Looks a bit weird to me to use /'s – unless you plan to make it localisable, so people with en_US can enter it as MM/DD/YYYY…
2019-03-22 08132, 2019
bluefantail joined the channel
2019-03-22 08150, 2019
Mr_Monkey
Good point. No plan for localisation yet, so dashes it is
2019-03-22 08127, 2019
yvanzo
fwiw mb uses dashes too
2019-03-22 08101, 2019
akhilesh
Mr_Monkey: localisation means?
2019-03-22 08143, 2019
Mr_Monkey
akhilesh: Meaning different date formats depending on locale (language and other factors)
2019-03-22 08115, 2019
bluefantail
Hey all!
2019-03-22 08150, 2019
reosarevok
Hi bluefantail
2019-03-22 08152, 2019
yvanzo
amCap1712: not yet
2019-03-22 08155, 2019
bluefantail
I've been kicking around for a bit looking into the ListenBrainz API - you might remember me asking some questions about it a few weeks back. I'm back to make a plug for it again, and just put up a ticket about it here - https://tickets.metabrainz.org/browse/LB-439
2019-03-22 08155, 2019
BrainzBot
LB-439: Allow cross domain requests on public GET endpoints which don't require auth
2019-03-22 08110, 2019
reosarevok
iliekcomputers: ^
2019-03-22 08114, 2019
bluefantail
Hey that's a neat bot.
2019-03-22 08121, 2019
yvanzo
amCap1712: only xml ws supports submitting data afaik
2019-03-22 08125, 2019
Mr_Monkey
Hi bluefantail
2019-03-22 08103, 2019
bluefantail
Anyway, I've made this change locally to see what it would take, I think it's a simple 2 or so line change, borrowed some thinking from the PR linked in that ticket.
2019-03-22 08143, 2019
amCap1712
ok thanks yvanzo
2019-03-22 08145, 2019
bluefantail
Thought I'd just canvas thoughts on it here again, I'm happy to submit a pull request for it if it's a simple decision, otherwise figured a good start might be to just create a ticket to capture a discussion about it?
2019-03-22 08154, 2019
bluefantail
Nice work on the recent release btw :)
2019-03-22 08100, 2019
eharris has quit
2019-03-22 08136, 2019
amCap1712
gr0uch0mars: couldn't understand the comment on live data
2019-03-22 08116, 2019
D4RK-PH0ENiX has quit
2019-03-22 08117, 2019
reosarevok
bluefantail: my suggestion (but I'm MB not LB) would be to submit a PR, and if someone has a problem they can say it on the PR
2019-03-22 08158, 2019
samj1912 has quit
2019-03-22 08159, 2019
bluefantail
I did consider just opening one, but figured it'd be nice to have the proper decision trail logged in Jira anyway :)
2019-03-22 08110, 2019
samj1912 joined the channel
2019-03-22 08120, 2019
akhilesh has quit
2019-03-22 08127, 2019
akhilesh joined the channel
2019-03-22 08139, 2019
bluefantail
But sounds good, thanks!
2019-03-22 08140, 2019
reosarevok
If it's really a very small change and you can be bothered
2019-03-22 08140, 2019
reosarevok
I mean, it's not going to get merged if the team doesn't agree, so there's no issue there - just the chance that they don't and it was time wasted. But if you already have the code ready anyway :)
2019-03-22 08145, 2019
amCap1712
gr0uch0mars: also how about using data binding, I would love to explore it. What do you suggest
yvanzo: do you have some time. I have a doubt about GSoC proposals
2019-03-22 08151, 2019
yvanzo
amCap1712: yup, which doubt?
2019-03-22 08158, 2019
amCap1712
yvanzo: While evaluating proposals will mentors be taken account of or only MeB team members
2019-03-22 08125, 2019
yvanzo
only mentors
2019-03-22 08144, 2019
amCap1712
so gr0uch0mars 's feedback will be taken in my case
2019-03-22 08131, 2019
eharris joined the channel
2019-03-22 08103, 2019
yvanzo
sure, he’s been accepted already :)
2019-03-22 08132, 2019
Ahmed joined the channel
2019-03-22 08145, 2019
gr0uch0mars
yvanzo: I read GSoC dates and there are some weeks of student work before sending mentor's feedback in August
2019-03-22 08155, 2019
Ahmed is now known as Guest8957
2019-03-22 08120, 2019
amCap1712
Oh great. I just wanted to know this because I wanted to get an idea of technical details I should go in depth while explaining my proposal since there is no one on the team familiar with android. So I wanted to estimate whether it is worthwhile to go into long details of implementation
2019-03-22 08122, 2019
gr0uch0mars
I wanted to take a trip in those dates, but I don't know if amCap1712 would be fine with it
2019-03-22 08101, 2019
gr0uch0mars
amCap1712: I thought of pushing the app these months before GSoC so you could spend most of the GSoC with Picard functionality
2019-03-22 08111, 2019
amCap1712
I don't have any issues. THere are 3 evaluations through out the GSoC period.
2019-03-22 08134, 2019
amCap1712
One in june the second in july and the third in August
2019-03-22 08158, 2019
gr0uch0mars
great. The trip would be after the evalutaion of July and before the one in August
2019-03-22 08110, 2019
yvanzo
gr0uch0mars: you can probably be backed with a co-mentor if needed.
amCap1712: I've not read about needing to clear the repo after the viewmodel
2019-03-22 08149, 2019
Guest8957
I really should change my name but I really have no idea how haha anyways have anyone here looked into MusicBrainz projects
2019-03-22 08130, 2019
amCap1712
gr0uch0mars: NOTSPAM and NOTSPAM
2019-03-22 08147, 2019
amCap1712
password and username, IIRC from GCI-17
2019-03-22 08157, 2019
Mr_Monkey
akhilesh: for the datepicker button, lineHeight of 1.75 will get rid of the bit of spacing left under the button (for my screen at least). The '/' in the Addons should be replaced by '-' as mentioned earlier. I think that's all for styling !
gr0uch0mars: I too didn't read about it thats the issue
2019-03-22 08100, 2019
akhilesh
Mr_Monkey: Thanks!
2019-03-22 08151, 2019
amCap1712
gr0uch0mars: I just found it when exploring the example. And during debugging I had found the issue was all with the repository persistence.
2019-03-22 08111, 2019
gr0uch0mars
because it was not sending the livedata again, or what?
2019-03-22 08139, 2019
gr0uch0mars
(the part I'm struggling with in the architecture demo is the UseCases, which is in the middle between the ViewModel and Repository)
2019-03-22 08151, 2019
amCap1712
the livedatas are stored in the repo and just retrieved by the viewmodel
2019-03-22 08125, 2019
amCap1712
in most cases they are observed by the viewmodel and transformed but thats when we use rxJava
2019-03-22 08110, 2019
Mr_Monkey
akhilesh: I noticed that when writing in the inputs, the year/month/day is set as string, but when using the datepicker they are set as numbers. It doesn't seems to be creating any issue, but I think it would be better to transform into number
2019-03-22 08116, 2019
amCap1712
gr0uch0mars: So when the activity is destroyed, we should reset the live datas.
2019-03-22 08147, 2019
amCap1712
But currently it dosen't haapen. as repostitory is a singleton.
2019-03-22 08122, 2019
gr0uch0mars
it's a workaround, yes
2019-03-22 08131, 2019
kartikeyaSh joined the channel
2019-03-22 08133, 2019
amCap1712
So I destroy the instance of the repostitory when the viewmodel/actvity gets destroyed in that way
2019-03-22 08135, 2019
Guest8957
So I am very interested about the "Improve the UX of voting for edits of the MusicBrainz database" in the MusicBrainz ideas but I dont know if my knowledge makes me eligible enough for it, I have been learning React for over the last 3 months and I am very comfortable with it's environment now especially after building my first large scale project but my knowledge with Perl is just very minimum would that be a problem in the lo
2019-03-22 08129, 2019
amCap1712
gr0uch0mars: that would be a proper way to do things also since its the recommended way in the sample.
2019-03-22 08129, 2019
gr0uch0mars
Maybe the userCase/Viewmodel should subscribe to the reposutory and, if it's the artist it expects, use it. Get new artist info, if not
2019-03-22 08106, 2019
gr0uch0mars
yes, it's only that I didn't read about giving the Activity the responsibility over the Repository, as they are different layers and should be decoupled
2019-03-22 08128, 2019
gr0uch0mars
That's my worry. But again, maybe when we explore Clean Architecture more in depth we can improve it
2019-03-22 08141, 2019
gr0uch0mars
So we learn along the way, not everything at the same time :)
2019-03-22 08155, 2019
amCap1712
yeah you're right
2019-03-22 08141, 2019
amCap1712
the problem is it is very hard to find advanced or edge case tutorials with examples on architecture components
2019-03-22 08127, 2019
amCap1712
there are a lot of beginner examples but not of the practical usage problems
2019-03-22 08150, 2019
amCap1712
yvanzo or reosarevok : may answer what you're looking for Guest8957
Guest8957: most people's knowledge of Perl is minimal nowadays, so that shouldn't necessarily be a huge deal.
2019-03-22 08152, 2019
reosarevok
UX stuff should mostly require frontendy changes, so JavaScript
2019-03-22 08156, 2019
reosarevok
So as long as you're up for trying to figure out some small Perl bits and asking if you get stuck, I don't think you need to run away just because of that :)
