CatQuest: My initial though was to put edits preview just above 'Edit Note' section.
2019-03-23 08240, 2019
CatQuest
why people hate to scroll just al ittle is beyond me. instead they want a huge ass image taking up the screen to scroll instead \_/
2019-03-23 08248, 2019
CatQuest
uh
2019-03-23 08258, 2019
CatQuest
why not use soem of the right pae isntead?
2019-03-23 08202, 2019
CatQuest
space*
2019-03-23 08251, 2019
yvanzo
Ok, yet another topic :)
2019-03-23 08206, 2019
CatQuest
men herligheten da
2019-03-23 08240, 2019
yvanzo
Changing the page layout is a longer term project :)
2019-03-23 08257, 2019
yvanzo
It will start with implementing Design tickets you participated to.
2019-03-23 08243, 2019
yvanzo
But it only applies to data display first, data editing redesign will come after. :)
2019-03-23 08238, 2019
Khalifa
Hmm so basically we add this react "Edit Preview" component just above the Edit Note section?
2019-03-23 08239, 2019
yvanzo
(Actually I just looked at some design tickets again and it contains some editing features too.)
2019-03-23 08257, 2019
yvanzo
Khalifa: yup
2019-03-23 08227, 2019
Khalifa
Oh well thats interesting, so what comes to my mind is since we are like going to use this component in multiple areas with different ways we could simply reuse it by adding different props each time with different datasources
2019-03-23 08203, 2019
yvanzo
yup, it actually implies converting edit data display to React, that will be used for editing history too.
Listen information is now shared (not anonymously) on the recent listens page.
2019-03-23 08247, 2019
Khalifa
Oh I see, Excuse my knowledge in react tho, its not that much. but I assume we are going to have to use State Management/ Redux in order to detect those changes and move them to this component of ours?
2019-03-23 08241, 2019
rdswift
Also, anybody can follow a user and find out their personal listening habits (including day and time) now.
2019-03-23 08227, 2019
rdswift
Perhaps LB should have an account setting to allow (or disallow) showing the user name on the recent listens page.
2019-03-23 08219, 2019
yvanzo
Khalifa: Yes to detect changes, no to compute edits, these are actually queried to the Perl back-end.
2019-03-23 08240, 2019
rdswift
Also, perhaps a follow request should be approved by the person to be followed before it is activated.
2019-03-23 08206, 2019
yvanzo
Khalifa: So you don’t have to worry about computing edits client-side, you just have to communicate with the server.
2019-03-23 08224, 2019
Khalifa
yvanzo oh so we are only communicating with the backend when the user has reviewed his edits and actually decided to "POST" those changes to the backend? Thats when Perl comes into play?
2019-03-23 08228, 2019
rdswift
Right now, if a person wanted to contribute their listen information for overall aggregate analysis and recommendation engine, but not have the information made publicly available with their name attached, they couldn't.
2019-03-23 08237, 2019
Khalifa
yvanzo oh so we are only communicating with the backend when the user has reviewed his edits and actually decided to "POST" those changes to the backend? Thats when Perl comes into play?
2019-03-23 08211, 2019
yvanzo
Khalifa: Sorry if I confused you, edits preview doesn’t have to wait that the form is submitted, that would not be previewing anymore.
2019-03-23 08232, 2019
Khalifa
yvanzo you didn't confuse me at all :) but that sounds like something I'd want to dive into tho, do you recommend any resource to read into or explore that might be beneficial to that area?
Alright will do, that has to do with REST I suppose? aha
2019-03-23 08218, 2019
yvanzo
:)
2019-03-23 08242, 2019
Khalifa
Haha I could imagine you right now with that face haha okay got it it :P
2019-03-23 08212, 2019
Cyna joined the channel
2019-03-23 08221, 2019
CatQuest
[19:12] <rdswift> Perhaps LB should have an account setting to allow (or disallow) showing the user name on the recent listens page. that seems logical
2019-03-23 08234, 2019
CatQuest
also this would dissalow the "follow" ability i think maybe
2019-03-23 08248, 2019
CatQuest
or atleast a setting "allow peopl ot ollow me/not" is logical
2019-03-23 08246, 2019
rdswift
But there might be some people I want to be able to follow me but others not. That's why I suggested each follow request be approved or denied separately.
2019-03-23 08257, 2019
rdswift
Perhaps a setting like "Allow Following: Yes / No / Ask"?
2019-03-23 08248, 2019
CatQuest
rdswift: following is "who can lsiten to my listens" not "freindsship" reuests.. though
2019-03-23 08205, 2019
CatQuest
also they are on the listen playlist. not i na "people i know" list
2019-03-23 08257, 2019
Cyna
hi yvanzo can you tell me what are the development priorities at the current stage ?
Yup. I understand the first part, but not the second.
2019-03-23 08217, 2019
CatQuest
"follow" on listenbrainz is "listen to this persons music"
2019-03-23 08227, 2019
rdswift
Right.
2019-03-23 08228, 2019
CatQuest
and adding thme you cna dd them to a list yo ucreate
2019-03-23 08238, 2019
rdswift
Right
2019-03-23 08255, 2019
CatQuest
before that the "follow" command was literally something oyu did on the page and it wasn't sotred anywhere
2019-03-23 08213, 2019
CatQuest
i don't understnad how much it works, you will aks ruaok and iliekcomputers which wokred on this
2019-03-23 08203, 2019
rdswift
But what if I don't want you to follow me (for example), but I'm okay with ileikcomputers following me?
2019-03-23 08240, 2019
CatQuest
but "follow" is a missnomer. what is happening is that the music you play is beign played by iliekcomputers just that one time in his palylist
2019-03-23 08259, 2019
CatQuest
i could.. uh listen to iliekcomputers litens as he listens to yours. teoretically
2019-03-23 08212, 2019
rdswift
Ore perhaps more appropriately I'm okay with pretty much anybody following me except "mr_stalker".
2019-03-23 08230, 2019
CatQuest
right
2019-03-23 08250, 2019
CatQuest
so a better aproach is to "band "mr_stalker" from "following" you?
2019-03-23 08217, 2019
rdswift
But if someone is following me, they are seeing a list of everything I play along with day and time. That way they might discern when I am awake (or asleep), and perhaps what part of the world I live in (or at least what hours I keep).
2019-03-23 08219, 2019
CatQuest
erh. *ban*
2019-03-23 08249, 2019
CatQuest
alright. they 'll be able to see that without "following" you thoguh. that's right ther on the userpage
2019-03-23 08213, 2019
rdswift
Ban could work, but right now there's no way for me to find out who is following me.
2019-03-23 08218, 2019
CatQuest
"follow" isn't doing anything special afaik
2019-03-23 08232, 2019
CatQuest
yea.. i ask iliekcomputers and ruaok about this srsly
2019-03-23 08235, 2019
CatQuest
i don't know the details at all :(
2019-03-23 08228, 2019
iliekcomputers
All the stuff you're talking about can be done anyways
2019-03-23 08235, 2019
CatQuest
hi iliekcomputers !
2019-03-23 08253, 2019
iliekcomputers
Everything submitted to LB is open.
2019-03-23 08257, 2019
rdswift
Nor do I. Personally, I don't really care, but I wonder if this has privacy implications.
2019-03-23 08252, 2019
rdswift
Including who listened to what?
2019-03-23 08256, 2019
CatQuest
exactly. i surmised rdswift didn't care, but was wondering about privacy issues :D
2019-03-23 08256, 2019
iliekcomputers
So Mr_stalker could just go to your profile or use the API to get the listens.
bleh that mr stalker guy. we should banz0r him from the internet :DD
2019-03-23 08226, 2019
rdswift
:-)
2019-03-23 08236, 2019
iliekcomputers
I guess we could talk with ruaok about how privacy comes into play with the "public store of history" aspect of LB, but rn, we're just making a feature that anybody else could feasibly build.
2019-03-23 08205, 2019
CatQuest
it's not a "buddy system"
2019-03-23 08209, 2019
iliekcomputers
Yeah, it isn't the traditional social media follow per se
2019-03-23 08225, 2019
iliekcomputers
More like temporarily play what this person is playing
2019-03-23 08228, 2019
CatQuest
exactly!
2019-03-23 08238, 2019
CatQuest
temporarily. that's the word I was needing
2019-03-23 08249, 2019
rdswift
I just re-read the goals. They're a bit "fuzzy" and can be interpreted a couple of different ways.
2019-03-23 08231, 2019
Lotheric has quit
2019-03-23 08254, 2019
CatQuest
hy!
2019-03-23 08255, 2019
CatQuest
hey!
2019-03-23 08201, 2019
CatQuest
i'm still logged into lb!
2019-03-23 08203, 2019
CatQuest
woo hoo!!!!
2019-03-23 08216, 2019
rdswift
Nowhere does it clearly say that my listen history is going to be made publicly available with my user id attached. That 'sn't required for any of the goals.
2019-03-23 08232, 2019
CatQuest
hm
2019-03-23 08234, 2019
CatQuest
"To make data dumps of this listen history available for download. We want everyone who is interested in this data to have access to the data and to use it in any manner they wish."
2019-03-23 08242, 2019
CatQuest
i do assume this is "anonymised" but
2019-03-23 08218, 2019
rdswift
Not from what iliekcomputers just said about the api.
2019-03-23 08254, 2019
iliekcomputers
It isn't.
2019-03-23 08204, 2019
iliekcomputers
>As we build out our sharing features, building a private listen store will become possible, but that is not part of our goals
2019-03-23 08211, 2019
iliekcomputers
This is from anti goals.
2019-03-23 08259, 2019
iliekcomputers
Maybe we need to think about our stance on privacy and anonymization more, especially if users want more privacy features.
2019-03-23 08231, 2019
Khalifa has quit
2019-03-23 08244, 2019
sbodin joined the channel
2019-03-23 08256, 2019
iliekcomputers
However as it is, there is no anonymization and all data submitted to LB is compiled into data dumps that anyone can download and use (with user ids attached)
2019-03-23 08219, 2019
rdswift
It could be argued that is "personal information", but wouldn't matter if they knew it could be made publicly available when they uploaded it. (My guess. I'm an engineer, not a lawyer.)
I guess it depends on whether you consider my account / logon id to be private information from my user profile.
2019-03-23 08224, 2019
rdswift
My question is really one of whether including my user id with the information is really necessary for the stated goals? It may be, but I don't see it.
2019-03-23 08230, 2019
rdswift
Anyway, like I said earlier, I'm not sure I care if my listen history includes my user id. Others more paranoid than me might.
2019-03-23 08226, 2019
Khalifa joined the channel
2019-03-23 08222, 2019
Khalifa
yvanzo I did clone the repo but I have no idea what "/ws/js/edit/preview" is? is it like a path in the repo or is it a way to communicate with Perl. Please excuse my lack of knowledge I am trying to wrap my head around things
2019-03-23 08253, 2019
yvanzo
Khalifa: It is an href to communicate with the server written in Perl.
Cyna: For MB, top priority is rewriting UI (root/) to React.
2019-03-23 08245, 2019
yvanzo
And we started with converting data display pages, then pages for editing data.
2019-03-23 08251, 2019
Cyna
Is there any other thing that I can do ?
2019-03-23 08212, 2019
Khalifa
so I imagine MB.edit is a way to execute whatever action was created?
2019-03-23 08223, 2019
yvanzo
Documentation back-end is a big chunk (two ideas already about it).
2019-03-23 08214, 2019
Cyna
I have a PR for converting of attributes waiting for review. So I haven't progressed further
2019-03-23 08251, 2019
Cyna
If possible could you please review it yvanzo
2019-03-23 08201, 2019
Gazooo has quit
2019-03-23 08250, 2019
Gazooo joined the channel
2019-03-23 08245, 2019
yvanzo
Khalifa: MB.edit is mostly for everything that happens within editing forms.
2019-03-23 08225, 2019
yvanzo
Cyna: no time right now sorry, reosarevok will probably continue reviewing it on tomorrow :)
2019-03-23 08243, 2019
Khalifa
oh and btw do you also get to preview changes to ReleaseGroup? as of now I mean
2019-03-23 08215, 2019
yvanzo
Cyna: Also, the Internet Archive idea is very much wanted too.
2019-03-23 08233, 2019
yvanzo
Khalifa: sorry, I have to go, but maybe bitmap or reosarevok will be able to answer instead, just read chat logs if you have to log out: https://musicbrainz.org/doc/Communication/IRC
2019-03-23 08227, 2019
Khalifa
Alright cool have a good evening then or morning wherever you are haha
2019-03-23 08229, 2019
reosarevok
yvanzo: I was hoping bitmap and you would review it, that's why it's up with you two requested for review :p
2019-03-23 08239, 2019
reosarevok
(I've already been checking but want other eyes on it as well)
2019-03-23 08236, 2019
reosarevok
Khalifa: you only preview changes when editing the release (but those include other changes made while editing the release, like recording and release group changes)
2019-03-23 08248, 2019
reosarevok
You don't get a preview if you edit them directly though, outside the release editor
2019-03-23 08229, 2019
Khalifa
Ohh I understand
2019-03-23 08242, 2019
Khalifa
I imagine a possible fix would make things independent on each other, so release edit would only result in a preview of the release edits while for example a recording edit would result in a preview or recording edits
2019-03-23 08211, 2019
amCap1712 has quit
2019-03-23 08222, 2019
moinmoi has quit
2019-03-23 08228, 2019
DjSlash has quit
2019-03-23 08220, 2019
DjSlash joined the channel
2019-03-23 08214, 2019
DjSlash has quit
2019-03-23 08216, 2019
DjSlash joined the channel
2019-03-23 08250, 2019
pristine__
CatQuest: yay to login!
2019-03-23 08253, 2019
Khalifa has quit
2019-03-23 08200, 2019
Lotheric joined the channel
2019-03-23 08210, 2019
Khalifa joined the channel
2019-03-23 08210, 2019
Khalifa
Hello guys
2019-03-23 08234, 2019
Khalifa
Should you also show an Edit preview when you are removing or creating an entity? or is it strictly to editing
2019-03-23 08219, 2019
Khalifa
and based on https://tickets.metabrainz.org/browse/MBS-8609 I understand you are trying to migrate to React but can I ask are there any examples of react components that are already implemented and what do you mean by "Templates"
