#metabrainz

morn morn!

$TIME_OF_DAY

morning CatQuest

morning

Morning guys

.

good idea from bluefantail

.

yvanzo: https://beta.musicbrainz.org/release/c9bd4868-5... - do you think it'd make sense to somehow linewrap those urls? Or would it be too weird?

Those = the absurdly long ones that distort the page

Mr_Monkey: you might like https://open.spotify.com/album/70nWQd39oEZErvVm... ?

Moin moin!

reosarevok: It looks like a bug which I cannot reproduce with my browser.

samj1912: pwong

Hey yvanzo

Left some comments on the PRs

What's the purpose of sluggifying them?

And that too in the ws output?

It doesn't affect the search at all

samj1912: Thanks, I have been mislead with gender being lowercased. I did not see it affect WS output and thought it was about writing advanced query with search field.

I should instead remove lowercasing gender.

That was there to match the existing ws search output

It has been that way since the beginning

Maybe when writing the old search server someone did this and it's there for compatibility reasons

samj1912: Except the browse & lookup queries don’t lowercase gender.

Well sir's goal was to match the old search server output

There are lots of other inconsistencies that I fixed

Maybe it has been changed in MBS without making the same change in SOLR.

Maybe this is one of them

Sure :)

Anyway, let's remove the lower casing

see <gender in https://musicbrainz.org/ws/2/artist?recording=0...

and in http://musicbrainz.org/ws/2/artist/?query=mbid:...

speaking of absurdly long urls..

yvanzo: how do you see the rateyourmusic url there?

reosarevok: auto-wrapped

it's annoying when copy pasting from an edit https://beta.musicbrainz.org/edit/60266227 for example, that urls are copy pasted as "someurlthatistoloongohnoo...." and not the full thing

yvanzo: how does that work? :) a screenshot would be awesome

CatQuest: IT IS :(

reosarevok: you first :)

huh

reosarevok: https://s.nimbusweb.me/share/2693306/8d5urh5p87...

mb in french :o

wait. what is going n with you 8th track???

also you guys have hell tall screens :P

hella*

yvanzo: what browser

CatQuest: No, it is just a glitch from screenshot extension trying to capture full page whereas my screen only display half of it.

hm

Huh!

CatQuest: it has a firefox user agent at the bottom, so FF too ;9

* ;)

So I guess it's a Chrome issue

I'll look into it a bit then

reosarevok: uh.. idk? how do you even see that on yvanzo pic?

Under the pic, "User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0"

reosarevok: I can reproduce this bug with Google Chrome.

I'm looking at https://s.nimbusweb.me/attachment/2693306/8d5ur... i guess

Oh, yeah, you can't see it on the image itself :)

yvanzo: ok, good to know. will look into it after I finish fixing subscription stuff

so in like 3 years?

samj1912: so, only the slug part has to be removed from sir PRs, right?

Well yes and you need to address my other comments

If you want search-able fields

And add packaging to mbsssss

Ok, but it won’t stop solr to work even if it ignore it for now?

Huh?

Solr should be compatible with new field additions

Anyway I am not sure how you plan on deploying and reindexing all these changes

It will depend on that

I think I will just postpone the whole thing until every component have versionned releases that somehow match each other.

(which I was originally working towards)

[sir] yvanzo closed pull request #101 (master…solr-106): SOLR-106: Slugify values for searchable fields gender and medium format https://github.com/metabrainz/sir/pull/101

SOLR-106: Cannot search release by medium format with special characters https://tickets.metabrainz.org/browse/SOLR-106

reosarevok: left some comments for your PR as well

Thanks

Lmk if it makes sense

Sounds sensible - I guess we don't yet have any examples of that, samj1912 ? :)

It's called here - https://github.com/metabrainz/sir/blob/master/s...

The compatconverter here is the top level convert function

I'd say just call the to_etree method and call tostring on top of that and compare it with the webservice output

And by top level convert function I mean https://github.com/metabrainz/sir/blob/master/s...

But each mbrngpy model has a to_etree method defined.

I hope that makes sense

The idea makes sense for sure, just need to figure out how to do it :) (still a newbieish python user)

But I'll manage

24 hours left before GSoC application period starts.

Yep :)

[sir] yvanzo merged pull request #100 (master…sec-2): SEC-2: Update requests to 2.21.0 (latest) https://github.com/metabrainz/sir/pull/100

yvanzo: I've rebased my PR, if possible please review it today 😅

Cyna: will do :)

https://github.com/metabrainz/musicbrainz-serve... Here is the PR

yvanzo: Does MB have any kind of authentication on lookup, browse and search requests via api?

akhilesh: when requesting user-genres, user-tags, user-ratings (which return the specific ones for that user)

Cyna: this ticket is too big to be addressed at once, can you determine workable subtasks?

yvanzo: IMO the current PR is the first of those workable subtasks :) (that's why I suggested to do those three files for now)

I agree

That’s why it would be more clear to have separate ticket for each subtask to refer to.

reosarevok: Why does MB not have any api endpoint to submit new entity? but have only for tag , rating and collection

akhilesh: it is intended to include that is ws4

yvanzo: sure :)

Might be more reasonable for us to do that separation though, since we know more about what amount makes sense

akhilesh: basically, because we wanted to make people go through the website and disliked the idea of bots throwing tons of new entities at us

That's my understanding, anyway - this is from before my time :)

[musicbrainz-server] yvanzo opened pull request #985 (master…mbs-10084-cdbaby-percent): MBS-10084: Allow percent encoding in CD Baby URLs https://github.com/metabrainz/musicbrainz-serve...

MBS-10084: Unable to add CDBaby URL containing "ï" https://tickets.metabrainz.org/browse/MBS-10084

ok.

So should I create subtask in the Jira ?

akhilesh: IMHO priority had been given to ensuring metadata quality with voting system and all, but submitting entity is planned with ws/4 This is planned with ws/4.

This is from before my time too :)

Cyna: please make a subtask for what is being addressed in that PR at least.

OKay