reosarevok: It looks like a bug which I cannot reproduce with my browser.
2019-03-24 08357, 2019
yvanzo
samj1912: pwong
2019-03-24 08317, 2019
samj1912
Hey yvanzo
2019-03-24 08325, 2019
samj1912
Left some comments on the PRs
2019-03-24 08335, 2019
samj1912
What's the purpose of sluggifying them?
2019-03-24 08354, 2019
samj1912
And that too in the ws output?
2019-03-24 08301, 2019
samj1912
It doesn't affect the search at all
2019-03-24 08354, 2019
yvanzo
samj1912: Thanks, I have been mislead with gender being lowercased. I did not see it affect WS output and thought it was about writing advanced query with search field.
2019-03-24 08316, 2019
yvanzo
I should instead remove lowercasing gender.
2019-03-24 08342, 2019
samj1912
That was there to match the existing ws search output
2019-03-24 08351, 2019
adhawkins has quit
2019-03-24 08351, 2019
samj1912
It has been that way since the beginning
2019-03-24 08315, 2019
samj1912
Maybe when writing the old search server someone did this and it's there for compatibility reasons
2019-03-24 08332, 2019
yvanzo
samj1912: Except the browse & lookup queries don’t lowercase gender.
2019-03-24 08359, 2019
samj1912
Well sir's goal was to match the old search server output
2019-03-24 08313, 2019
samj1912
There are lots of other inconsistencies that I fixed
2019-03-24 08315, 2019
yvanzo
Maybe it has been changed in MBS without making the same change in SOLR.
yvanzo: how do you see the rateyourmusic url there?
2019-03-24 08342, 2019
yvanzo
reosarevok: auto-wrapped
2019-03-24 08357, 2019
CatQuest
it's annoying when copy pasting from an edit https://beta.musicbrainz.org/edit/60266227 for example, that urls are copy pasted as "someurlthatistoloongohnoo...." and not the full thing
2019-03-24 08317, 2019
reosarevok
yvanzo: how does that work? :) a screenshot would be awesome
2019-03-24 08321, 2019
reosarevok
CatQuest: IT IS :(
2019-03-24 08332, 2019
adhawkins joined the channel
2019-03-24 08354, 2019
yvanzo
reosarevok: you first :)
2019-03-24 08310, 2019
CatQuest also does see no sidescrolling on https://beta.musicbrainz.org/release/c9bd4868-55dc-42d1-bd30-90c10a3cac81
yvanzo: ok, good to know. will look into it after I finish fixing subscription stuff
2019-03-24 08341, 2019
CatQuest
so in like 3 years?
2019-03-24 08329, 2019
yvanzo
samj1912: so, only the slug part has to be removed from sir PRs, right?
2019-03-24 08305, 2019
samj1912
Well yes and you need to address my other comments
2019-03-24 08317, 2019
samj1912
If you want search-able fields
2019-03-24 08331, 2019
samj1912
And add packaging to mbsssss
2019-03-24 08351, 2019
yvanzo
Ok, but it won’t stop solr to work even if it ignore it for now?
2019-03-24 08305, 2019
samj1912
Huh?
2019-03-24 08331, 2019
samj1912
Solr should be compatible with new field additions
2019-03-24 08357, 2019
samj1912
Anyway I am not sure how you plan on deploying and reindexing all these changes
2019-03-24 08305, 2019
samj1912
It will depend on that
2019-03-24 08334, 2019
yvanzo
I think I will just postpone the whole thing until every component have versionned releases that somehow match each other.
2019-03-24 08344, 2019
yvanzo
(which I was originally working towards)
2019-03-24 08306, 2019
BrainzGit
[sir] yvanzo closed pull request #101 (master…solr-106): SOLR-106: Slugify values for searchable fields gender and medium format https://github.com/metabrainz/sir/pull/101
akhilesh: IMHO priority had been given to ensuring metadata quality with voting system and all, but submitting entity is planned with ws/4 This is planned with ws/4.
2019-03-24 08326, 2019
yvanzo
This is from before my time too :)
2019-03-24 08352, 2019
adhawkins joined the channel
2019-03-24 08348, 2019
yvanzo
Cyna: please make a subtask for what is being addressed in that PR at least.
