TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | New GSoC students start here: https://goo.gl/7jsjG2 | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda (Europe will have entered DST, so time will be 17:00 UTC): Reviews
2019-03-28 08712, 2019
reosarevok
Oh no. DST.
2019-03-28 08713, 2019
alastairp
europe has entered the room
2019-03-28 08725, 2019
reosarevok
alastairp: more like europe has left the room, given the recent vote :p
2019-03-28 08741, 2019
alastairp
well, the important parts of europe are still here
2019-03-28 08750, 2019
alastairp
did David get back to you?
2019-03-28 08707, 2019
aliamo joined the channel
2019-03-28 08711, 2019
aliamo_ joined the channel
2019-03-28 08711, 2019
aliamo has quit
2019-03-28 08720, 2019
reosarevok
Not yet
2019-03-28 08729, 2019
reosarevok
But I assume he has more stuff to do too
2019-03-28 08727, 2019
Mr_Monkey
akhilesh: Maybe make it a secondary goal. I think having the auth mechanism in place would allow for some flexibility, for example with our rate-limiting policy, and for future POST endpoints.
2019-03-28 08710, 2019
reosarevok
I mean, MB wants to eventually require auth for everything FWIW
2019-03-28 08713, 2019
reosarevok
(and tokens)
2019-03-28 08710, 2019
akhilesh
Mr_Monkey: You mean optional goal, if we will have remaining?
2019-03-28 08729, 2019
Mr_Monkey
Correct.
2019-03-28 08700, 2019
akhilesh
But it will require some schema changes because we should not varify every request by sending one more request to MB. Mr_Monkey
akhilesh: We'll definitely be using MB to authenticate rather than store tokens ourselves. I'll leave it to the pros to think about how to implement it for the various MetaBrainz projects. Having the mechanism in place for an auth request to MB would be a good first step. I'm thinking for example in the near future using the API to submit user collections .
2019-03-28 08749, 2019
akhilesh
Mr_Monkey: When we will implement submit user collection, Think if we will store token of that user at MB and if the user will not be registered at BB, then MB verify that user correct, but BB will not know that user. Then how will handle that situation?
akhilesh: the BB web server currently uses tokens from MB validated by a passport strategy (https://github.com/LordSputnik/passport-musicbrai…) and checking the user with its own editor table. I think that would work for the API as well (as a first step)
Is there someone here who is experience on creating dockerfile ??
2019-03-28 08752, 2019
akhilesh
Mr_Monkey: ok, I am thinking about it.
2019-03-28 08728, 2019
amCap1712
cyna: yvanzo perhaps
2019-03-28 08729, 2019
yvanzo
Cyna: what for?
2019-03-28 08728, 2019
Cyna
I'm trying to make work easy by dockerizing musicbrainz-server
2019-03-28 08718, 2019
Cyna
I've made great progress but have some issues to face
2019-03-28 08706, 2019
Cyna
I've created dockerfile for both musicbrainz-server and the db to be used and created builds for the same
2019-03-28 08716, 2019
Cyna
problem here is whenever I bind mount a directory its replacing the original contents in the container with the empty folder on my machine path specified
2019-03-28 08744, 2019
Cyna
Is there a way to prevent the over writing due to superiority ?
2019-03-28 08730, 2019
reosarevok
Isn't there already a docker version of mbs?
2019-03-28 08749, 2019
Cyna
there is musicbrainz-docker if you are speaking of it
2019-03-28 08703, 2019
aliamo_ has quit
2019-03-28 08711, 2019
Cyna
its weird working with that setup... It has a lot built into it
2019-03-28 08706, 2019
aliamo joined the channel
2019-03-28 08709, 2019
alastairp
Cyna: what's your final goal? why do you want musicbrainz in docker?
2019-03-28 08730, 2019
BhaskarSing joined the channel
2019-03-28 08753, 2019
Cyna
I want to be able to work on any machine by just deploying the container as to what docker is meant for
2019-03-28 08718, 2019
BhaskarSing has quit
2019-03-28 08730, 2019
alastairp
are you working on musicbrainz-server?
2019-03-28 08748, 2019
Cyna
My current setup is using docker but its a bit complex for someone who has no experience in working with one, so Im trying to make it much easier
2019-03-28 08753, 2019
Cyna
yes
2019-03-28 08712, 2019
alastairp
what folder are you connecting as a volume?
2019-03-28 08723, 2019
BhaskarSingh joined the channel
2019-03-28 08741, 2019
alastairp
the behaviour that you describe is correct for how docker works, there are a few solutions depending on your need
MBS-10089: Don't show "named after" relationships on artist works page
2019-03-28 08753, 2019
akhilesh
reosarevok: yvanzo : How can I authenticate user via postman for submitting request to API sever as in docs at https://beta.musicbrainz.org/doc/Development/XML_… ? Could you give an example of real post request so that I can check via postman please?
I won’t review/merge other PRs but contribs, I’m quite busy with JIRA anyway.
2019-03-28 08749, 2019
reosarevok
Please, please, please, let's merge the relationships code
2019-03-28 08712, 2019
reosarevok
There's a lot of other stuff that depends on that before it can be worked on
2019-03-28 08732, 2019
yvanzo
We have been delaying release for too long, I mostly selected PRs which are finishing parts of other already merged issues.
2019-03-28 08735, 2019
yvanzo
The milestone just points to PRs still missing for release, it is not a restrictive list of what will be released.
2019-03-28 08717, 2019
reosarevok
Well sure, and I don't really even care that much whether we release the rels thing
2019-03-28 08726, 2019
reosarevok
Just want it merged to work on top of properly :)
2019-03-28 08744, 2019
yvanzo
But it doesn’t work at the moment :D
2019-03-28 08707, 2019
reosarevok
It doesn't? It seemed to work yesterday for me
2019-03-28 08717, 2019
reosarevok
What broke? (did you flush redis?)
2019-03-28 08700, 2019
akhilesh
reosarevok & yvanzo : I am waiting to your response, for above msg
2019-03-28 08722, 2019
yvanzo
akhilesh: sorry, never used postman before and did not find ready example, doc is terribly lacking examples :(
2019-03-28 08752, 2019
yvanzo
reosarevok: relationship-editor doesn’t load for me at least, and yes I flushed it all.
2019-03-28 08753, 2019
Cyna
reosarevok: Yea so I was wondering about those issues with required entity attributes I spoke to you last time
2019-03-28 08727, 2019
reosarevok
yvanzo: ... sigh, I might have forgotten to check that :p
2019-03-28 08746, 2019
yvanzo
reosarevok: it seems to be just a small issue though, the rest I checked seems to be fine.
2019-03-28 08700, 2019
CallerNo6
akhilesh, I didn't understand your question. do you want to see what a web service call w/ authorization looks like? or were you asking about how postman works?
2019-03-28 08712, 2019
reosarevok
Cyna: that is a mess and needs a lot of work, but I don't have the time for it atm. Maybe tomorrow I can try to look
2019-03-28 08755, 2019
akhilesh
CallerNo6: want to see what a web service call w/ authorization looks like?
2019-03-28 08702, 2019
Cyna
sure thanks... I'll try understanding the code base for GSoC project then
2019-03-28 08710, 2019
yvanzo
reosarevok: while you are waiting for rels PR, you may want to improve ws doc instead ;)
2019-03-28 08723, 2019
reosarevok
I'm trying to fix a bug with a rels query rn
2019-03-28 08741, 2019
reosarevok
Unrelated to that PR
2019-03-28 08714, 2019
akhilesh
CallerNo6: How does I put username and password with api request?
2019-03-28 08731, 2019
reosarevok
yvanzo, bitmap: am I being dense or is this ultra borked?
This does JOIN $target ON $target_id = ${target}.id (L168)
2019-03-28 08748, 2019
CallerNo6
akhilesh, authorization info goes in the header of the request. you can use programs like python's requests to insert it.
2019-03-28 08738, 2019
reosarevok
But if you have, say, l_artist_artist, that'll just join on entity0 and won't check entity1 at all since $target_id = 'entity0'; in L148
2019-03-28 08701, 2019
CallerNo6
(which would look something like requests.get(url, auth=HTTPDigestAuth('user', 'pass'))
2019-03-28 08756, 2019
CallerNo6
^ unlike query parameters, you don't pass it in the url itself
2019-03-28 08744, 2019
akhilesh
CallerNo6: Ok, Thanks :)
2019-03-28 08743, 2019
CallerNo6
akhilesh, does that make sense? you could use curl or whatever program makes sense in your context.
2019-03-28 08723, 2019
Cyna
yvanzo: is there any way where I can change the path for redis server ? from localhost:6378 to redis:6379 ?
2019-03-28 08708, 2019
yvanzo
Cyna: yes in lib/DBDefs.pm
2019-03-28 08706, 2019
Cyna
I've made changes there
2019-03-28 08710, 2019
Cyna
But it didnt work
2019-03-28 08732, 2019
Cyna
I composed down, made the changes and composed up
2019-03-28 08749, 2019
Cyna
and it doesnt rebuild the images
2019-03-28 08702, 2019
yvanzo
I’m not sure what you changed and how you compose these, so...
2019-03-28 08706, 2019
Cyna
I guess that is the issue
2019-03-28 08728, 2019
Cyna
Ill try pruning images and starting the compose again
2019-03-28 08722, 2019
akhilesh
CallerNo6, yvanzo: One another question, Does MB have any method so that we can verify user with his username and password programmatically? mean without opening GUI like https://beta.musicbrainz.org/login?uri=%2F
