#metabrainz

/

      • bitmap
        yvanzo: oh nice, that's much more documentation than I thought we had

        • 2019-04-01 09133, 2019

      • bitmap
        is it linked from transifex?

        • 2019-04-01 09121, 2019

      • bitmap
        it can probably clarify that you shouldn't translate the variable name or add spaces

        • 2019-04-01 09159, 2019

      • akhilesh
        Mr_Monkey: You did lots of work in https://github.com/bookbrainz/bookbrainz-site/pul…, I will also spend some time in this PR. Thanks for this work. It remove our confusion over entity names.

        • 2019-04-01 09101, 2019

      • Mr_Monkey
        akhilesh: all of them

        • 2019-04-01 09132, 2019

      • Mr_Monkey
        akhilesh: Agreed. I had put it on the side for a while, but it was well time to finish it.

        • 2019-04-01 09154, 2019

      • antlarr joined the channel

        • 2019-04-01 09125, 2019

      • CatQuest
        ping?

        • 2019-04-01 09140, 2019

      • CatQuest
        ...

        • 2019-04-01 09101, 2019

      • reosarevok
        CatQuest: pong

        • 2019-04-01 09110, 2019

      • CatQuest
        oh god

        • 2019-04-01 09112, 2019

      • akhilesh
        Mr_Monkey: But in case of your `inc` point, my idea was to cache all data of an entity, and use this cached date both side website server as well api server according to parameter. Like most of the time website requires all the information of an entity.

        • 2019-04-01 09122, 2019

      • CatQuest
        i though i was dissconnect invisibly again

        • 2019-04-01 09135, 2019

      • CatQuest
        like during the meeting i replied and psoted my stuff

        • 2019-04-01 09147, 2019

      • CatQuest
        and thne freso said "well no catquest"

        • 2019-04-01 09152, 2019

      • CatQuest
        i was like "but wait what??"

        • 2019-04-01 09109, 2019

      • CatQuest
        ...

        • 2019-04-01 09151, 2019

      • akhilesh
        Mr_Monkey: we will cache all information with key like `entity/bbid`. If request from website server, it will return all linked data, which is necessary for web page. but if this request will come form api server, cache will provide data with linked information, then we filter that information according to `inc`. I am clear to you. This make sense for me for efficient caching.

        • 2019-04-01 09149, 2019

      • CatQuest
        does anyone own "musicbrianz.org" ?

        • 2019-04-01 09157, 2019

      • bitmap
        yvanzo: nvm, I see it's linked as the Translation Instructions URL. but not sure where that's shown besides this microscopic invisible menu

        • 2019-04-01 09106, 2019

      • antlarr has quit

        • 2019-04-01 09117, 2019

      • CatQuest
        (aside fro mbeign a very nughtyboy joke, it might be a good idea to own typo-domains)

        • 2019-04-01 09119, 2019

      • spellew joined the channel

        • 2019-04-01 09123, 2019

      • CatQuest
        (if it's not user expensive)

        • 2019-04-01 09127, 2019

      • kepstin
        CatQuest: looks like it's available right now

        • 2019-04-01 09154, 2019

      • kepstin
        not owned by a squatter or anything, so it should be regular .org pricing

        • 2019-04-01 09112, 2019

      • CatQuest
        (it's potentially the sort of thing a scammer could buy and fetch inloggining details on becasue peopel could misstype)

        • 2019-04-01 09113, 2019

      • antlarr joined the channel

        • 2019-04-01 09102, 2019

      • CatQuest
        kepstin: :D

        • 2019-04-01 09100, 2019

      • CatQuest
        oh come on

        • 2019-04-01 09125, 2019

      • CatQuest has quit

        • 2019-04-01 09128, 2019

      • reosarevok
        akhilesh: do you need all the data for all pages?

        • 2019-04-01 09155, 2019

      • CatQuest joined the channel

        • 2019-04-01 09156, 2019

      • reosarevok
        (for example in MusicBrainz there are some tabs of an artist page that load some data, and some that load other data, so loading them in chunks could still be useful)

        • 2019-04-01 09104, 2019

      • bitmap
        yvanzo: so the i18n issue in the account profile PR is just due to .po files being outdated https://github.com/metabrainz/musicbrainz-server/…

        • 2019-04-01 09153, 2019

      • CatQuest
        wait

        • 2019-04-01 09157, 2019

      • CatQuest
        am i onlien or what HALP

        • 2019-04-01 09158, 2019

      • yvanzo
        kudos bitmap!

        • 2019-04-01 09136, 2019

      • CatQuest
        ¯\_(ツ)_/¯

        • 2019-04-01 09156, 2019

      • yvanzo
        CatQuest: on the fishing line today :)

        • 2019-04-01 09157, 2019

      • CatQuest
        I get I'm spamming right now but because I'm invisibly offline I don't know guys

        • 2019-04-01 09101, 2019

      • HorusHorrendus has quit

        • 2019-04-01 09134, 2019

      • CatQuest
        traceroute to mb is all * * * after ex9k3.dc8.fsn1.hetzner.com (213.239.229.138) 34.029 ms

        • 2019-04-01 09137, 2019

      • CatQuest
        :(

        • 2019-04-01 09156, 2019

      • CatQuest
        and the chatlog updates with my text..

        • 2019-04-01 09107, 2019

      • CatQuest
        exept it doesnt

        • 2019-04-01 09112, 2019

      • CatQuest
        ARG this is so frustrating!!!

        • 2019-04-01 09126, 2019

      • CatQuest
        !

        • 2019-04-01 09134, 2019

      • CatQuest
        !m BrainzBot say something

        • 2019-04-01 09134, 2019

      • BrainzBot
        You're doing good work, BrainzBot say something!

        • 2019-04-01 09138, 2019

      • CatQuest
        wooooooooooooooooooooooooooooooooooooo

        • 2019-04-01 09147, 2019

      • CatQuest
        if the bot replies i *have* to be online,.. right?

        • 2019-04-01 09107, 2019

      • CatQuest
        .. right?

        • 2019-04-01 09110, 2019

      • CatQuest
        BrainzBot: blup

        • 2019-04-01 09117, 2019

      • CatQuest
        !m BrainzBot hello

        • 2019-04-01 09117, 2019

      • BrainzBot
        You're doing good work, BrainzBot hello!

        • 2019-04-01 09120, 2019

      • CatQuest
        hm

        • 2019-04-01 09131, 2019

      • CatQuest
        !remember hello=hello

        • 2019-04-01 09131, 2019

      • BrainzBot
        I will remember "hello" for you CatQuest.

        • 2019-04-01 09137, 2019

      • CatQuest
        !forget hello

        • 2019-04-01 09137, 2019

      • BrainzBot
        What was "hello" all about?

        • 2019-04-01 09156, 2019

      • CatQuest
        hello good bye ♫♪♬

        • 2019-04-01 09125, 2019

      • CatQuest
        !remember hello=♫♪♬ you say hello, I say goodbye ♫♪♬

        • 2019-04-01 09125, 2019

      • BrainzBot
        I will remember "hello" for you CatQuest.

        • 2019-04-01 09132, 2019

      • CatQuest
        !recall hello

        • 2019-04-01 09132, 2019

      • BrainzBot
        ♫♪♬ you say hello, I say goodbye ♫♪♬

        • 2019-04-01 09159, 2019

      • CatQuest
        atleast BrainzBot is my friend T__T

        • 2019-04-01 09103, 2019

      • akhilesh
        Mr_Monkey: most of the time, web pages needs all linked data, that's why I am saying that concept. It is easy to filter data according to api requirement instead of new query to the database.

        • 2019-04-01 09108, 2019

      • CatQuest
        hi akhilesh !!!

        • 2019-04-01 09127, 2019

      • CatQuest
        akhilesh!

        • 2019-04-01 09129, 2019

      • CatQuest
        hi!

        • 2019-04-01 09142, 2019

      • akhilesh
        CatQuest: hello :)

        • 2019-04-01 09145, 2019

      • CatQuest
        yaay!

        • 2019-04-01 09148, 2019

      • antlarr has quit

        • 2019-04-01 09153, 2019

      • CatQuest
        !recall compiling

        • 2019-04-01 09153, 2019

      • BrainzBot
        I'm sorry, I don't remember "compiling", are you sure I should know about it?

        • 2019-04-01 09157, 2019

      • CatQuest
        hm

        • 2019-04-01 09140, 2019

      • CatQuest
        !remember compiling=https://www.xkcd.com/303/

        • 2019-04-01 09140, 2019

      • BrainzBot
        I will remember "compiling" for you CatQuest.

        • 2019-04-01 09145, 2019

      • CatQuest
        !recall compiling

        • 2019-04-01 09145, 2019

      • BrainzBot
        https://www.xkcd.com/303/

        • 2019-04-01 09158, 2019

      • antlarr joined the channel

        • 2019-04-01 09131, 2019

      • antlarr has quit

        • 2019-04-01 09134, 2019

      • antlarr joined the channel

        • 2019-04-01 09107, 2019

      • akhilesh
        Mr_Monkey: MB have different kind of entity page layouts. Like all linked information of one entity shows in different tabs in same page. If over aim is to redesign the entity pages same as MB. New request for linked data might be useful.

        • 2019-04-01 09153, 2019

      • antlarr has quit

        • 2019-04-01 09146, 2019

      • Slurpee has quit

        • 2019-04-01 09105, 2019

      • antlarr joined the channel

        • 2019-04-01 09158, 2019

      • antlarr has quit

        • 2019-04-01 09157, 2019

      • Gazooo joined the channel

        • 2019-04-01 09137, 2019

      • yokel has quit

        • 2019-04-01 09107, 2019

      • antlarr joined the channel

        • 2019-04-01 09150, 2019

      • yokel joined the channel

        • 2019-04-01 09134, 2019

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #984 (master…MBS-6895): MBS-6895: Enable tags and genres for release browse https://github.com/metabrainz/musicbrainz-server/…

        • 2019-04-01 09134, 2019

      • BrainzBot
        MBS-6895: Cannot inc=tags when browsing releases https://tickets.metabrainz.org/browse/MBS-6895

        • 2019-04-01 09102, 2019

      • reosarevok
        bitmap: next tiny one: https://github.com/metabrainz/musicbrainz-server/…

        • 2019-04-01 09114, 2019

      • bitmap
        it's kinda unfortunate we have to do that in 4 different places now

        • 2019-04-01 09153, 2019

      • bitmap
        though the edits don't even use WorkLanguage so I'm not sure how to generalize it

        • 2019-04-01 09112, 2019

      • dolina has quit

        • 2019-04-01 09102, 2019

      • reosarevok
        It is, but it probably makes sense to do it for now

        • 2019-04-01 09119, 2019

      • reosarevok
        https://github.com/metabrainz/musicbrainz-server/… is updated now (so are the others you commented on, but that's probably the easiest to review of those)

        • 2019-04-01 09127, 2019

      • reosarevok
        https://github.com/metabrainz/musicbrainz-server/… is also tiny

        • 2019-04-01 09129, 2019

      • reosarevok
        yvanzo: ^ that one should probably be merged before beta since it fixes a bug in the existing merged code

        • 2019-04-01 09151, 2019

      • reosarevok
        Well, to be fair: there was already a bug, it's just that the code we merged recently makes it more visible and more likely to get reported etc

        • 2019-04-01 09124, 2019

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #966 (master…MBS-10063): MBS-10063: Create and edit work edits should display [No lyrics] for zxx https://github.com/metabrainz/musicbrainz-server/…

        • 2019-04-01 09125, 2019

      • BrainzBot
        MBS-10063: Create and edit work edits should display [No lyrics] for zxx https://tickets.metabrainz.org/browse/MBS-10063

        • 2019-04-01 09155, 2019

      • bitmap
        the lastUpdated in lib/MusicBrainz/Server/Controller/Role/Details.pm doesn't use datetime_to_iso8601 either. so is the same bug present on /details pages?

        • 2019-04-01 09134, 2019

      • gr0uch0mars has quit

        • 2019-04-01 09135, 2019

      • bitmap
        possibly not since in this case it comes from the search server

        • 2019-04-01 09128, 2019

      • yokel has quit

        • 2019-04-01 09115, 2019

      • yokel joined the channel

        • 2019-04-01 09133, 2019

      • bitmap
        or maybe yes (just checked a few /details pages and see Last updated: Invalid date on all of them)

        • 2019-04-01 09148, 2019

      • culinko joined the channel

        • 2019-04-01 09148, 2019

      • culinko has quit

        • 2019-04-01 09148, 2019

      • culinko joined the channel

        • 2019-04-01 09128, 2019

      • reosarevok
        lol

        • 2019-04-01 09136, 2019

      • reosarevok
        Ok, I guess I'll add that to the same PR?

        • 2019-04-01 09114, 2019

      • dolina joined the channel

        • 2019-04-01 09105, 2019

      • spellew has quit

        • 2019-04-01 09153, 2019

      • reosarevok
        bitmap: heh, that's actually $VAR1 = '2019-03-19 11:17:52.497654+00';

        • 2019-04-01 09102, 2019

      • reosarevok
        So it's a different bug! But related

        • 2019-04-01 09130, 2019

      • dolina has quit

        • 2019-04-01 09151, 2019

      • HorusHorrendus joined the channel

        • 2019-04-01 09112, 2019

      • antfoo has quit

        • 2019-04-01 09123, 2019

      • reosarevok
        bitmap: can you tell me wtf this 497654 actually is?

        • 2019-04-01 09106, 2019

      • antfoo joined the channel

        • 2019-04-01 09154, 2019

      • reosarevok
        I assume it's some sort of miliseconds, but I have no clue what to do with them

        • 2019-04-01 09103, 2019

      • dolina joined the channel

        • 2019-04-01 09146, 2019

      • reosarevok
        Heh

        • 2019-04-01 09119, 2019

      • bitmap
        reosarevok: yeah it's sub-seconds and I think that's pg's datetime format

        • 2019-04-01 09124, 2019

      • reosarevok
        Yeah

        • 2019-04-01 09131, 2019

      • reosarevok
        I can fix it by doing this

        • 2019-04-01 09133, 2019

      • bitmap
        so you may need DateTime::Format::Pg's parse_datetime

        • 2019-04-01 09143, 2019

      • reosarevok
        https://www.irccloud.com/pastebin/CBAQfcJr/

        • 2019-04-01 09157, 2019

      • reosarevok
        Normally that's done via package MusicBrainz::Server::Entity::Role::LastUpdate;

        • 2019-04-01 09109, 2019

      • reosarevok
        Not sure why this specific one has the string instead

        • 2019-04-01 09131, 2019

      • bitmap
        hmm

        • 2019-04-01 09104, 2019

      • bitmap
        I guess 'cause it's passing lastUpdated => $entity->{last_updated}, as a separate prop and not reading the one off entity

        • 2019-04-01 09139, 2019

      • bitmap
        $entity is the Moose entity so $entity->{last_updated} is not the fixed version

        • 2019-04-01 09110, 2019

      • bitmap
        in the JS, entity.last_updated is probably already correct though

        • 2019-04-01 09138, 2019

      • reosarevok
        so just don't pass last_updated, and use the entity one on JS=

        • 2019-04-01 09142, 2019

      • reosarevok
        *?

        • 2019-04-01 09112, 2019

      • bitmap
        I think so

        • 2019-04-01 09102, 2019

      • yokel has quit

        • 2019-04-01 09148, 2019

      • yokel joined the channel

        • 2019-04-01 09103, 2019

      • reosarevok
        Ok!

        • 2019-04-01 09131, 2019

      • yokel has quit

        • 2019-04-01 09142, 2019

      • dolina has quit

        • 2019-04-01 09126, 2019

      • yokel joined the channel

        • 2019-04-01 09127, 2019

      • reosarevok
        Updated that PR, bitmap