but I can't see anything in the docker-python setup scripts that add this file
2019-04-02 09220, 2019
iliekcomputers
i'm pushing a new 3.6 image just to make sure we're on the correct consul version.
2019-04-02 09233, 2019
iliekcomputers
consul-template-base version.
2019-04-02 09243, 2019
yvanzo
iliekcomputers: v0.16 or v0.19.4?
2019-04-02 09252, 2019
iliekcomputers
v0.16
2019-04-02 09253, 2019
alastairp
0.16
2019-04-02 09254, 2019
iliekcomputers
ruaok: can you try deploying again?
2019-04-02 09204, 2019
iliekcomputers
with the latest 3.6 image
2019-04-02 09246, 2019
ruaok
k
2019-04-02 09256, 2019
alastairp
I just tried to start that image and it failed with the same error
2019-04-02 09204, 2019
Freso
Darkloke: If your local metadata archive has MBIDs (which I really hope it does!), then you could make a script that iterates over that and opens musicbrainz.org web pages with the information you want to add (including a good edit note!). Then all you have to do is look over the edit page, verify that it’s correct, and click the "Enter edit" button. It’s still going to be a bunch of clicks, but it’s going to be far less
2019-04-02 09204, 2019
Freso
clicks then manually finding each entity, opening the entity page, opening its edit page, copy/pasting the information, entering the e
2019-04-02 09208, 2019
alastairp
and I don't see anything in the metabrainz Dockerfile which adds consul-template.conf
2019-04-02 09214, 2019
alastairp
so I suspect it'll fail again
2019-04-02 09232, 2019
Freso
.. entering the edit note, and then clicking the "Enter edit" button.
2019-04-02 09242, 2019
ruaok
agreed. but that wasn't needed before. what changed? what should be there?
2019-04-02 09208, 2019
alastairp
I can only speculate that something was different in the 3.6-1 image, but I guess we removed it
2019-04-02 09212, 2019
ruaok
we have /etc/consul-template-uwsgi.conf
2019-04-02 09212, 2019
yvanzo
was 3.6-1 based on another version of consul-template-base?
2019-04-02 09230, 2019
alastairp
yvanzo: mmm, possible?
2019-04-02 09210, 2019
ruaok
redeployed, same error.
2019-04-02 09212, 2019
yvanzo
could be worth pushing a new 3.6-1 with v0.19.4 or v0.18.5?
2019-04-02 09219, 2019
ruaok
let me copy the -uwsgi file there and try
2019-04-02 09252, 2019
alastairp
it's true that the config file looks like a normal config file
2019-04-02 09222, 2019
Darkloke
That's a good idea, Freso, but regretfully i am not a scriptwriter.
iliekcomputers: it's likely that this is the kind of setup that we'd have to do on other brainzes to work with the new base image, then. I guess this is what we were missing when we built the new python images
2019-04-02 09203, 2019
alastairp
-> good to see the value in writing descriptive commit messages!
2019-04-02 09223, 2019
ruaok
iliekcomputers: let me know when the image is pushed.
2019-04-02 09220, 2019
iliekcomputers
pushed
2019-04-02 09218, 2019
ruaok
wait. it is currently fixed, even though I saw errors.
2019-04-02 09223, 2019
ruaok
let me investigate.
2019-04-02 09235, 2019
ruaok dislikes it when things fix themselves
2019-04-02 09208, 2019
ruaok
the site is up despite the continued error message of "./run: 3: exec: run-consul-template: not found"
but the faulty container is still running if you want to inspect it.
2019-04-02 09259, 2019
iliekcomputers
hmm, config seems ok
2019-04-02 09236, 2019
alastairp
(which config? config.py or consul_config.py?) is flask in metabrainz set up to loop until it finds consul_config like LB?
2019-04-02 09202, 2019
alastairp
ah, yes it is
2019-04-02 09205, 2019
alastairp
never mind then
2019-04-02 09208, 2019
iliekcomputers
the config file which is rendered from consul_config.py.ctmpl
2019-04-02 09231, 2019
iliekcomputers
i was thinking that it might have some keys missing because of keyOrDefault being mentioned in the error
2019-04-02 09203, 2019
slc joined the channel
2019-04-02 09232, 2019
ruaok
I'll restart with the 3.6-1 image when it finishes pushing, ok?
2019-04-02 09215, 2019
iliekcomputers
ok.
2019-04-02 09239, 2019
ruaok
running error free. thanks iliekcomputers.
2019-04-02 09219, 2019
ruaok
any tips on how to fix this permanently for the new images?
2019-04-02 09220, 2019
slc
gotta music brainz install question. Following the dots from install.md. Ubuntu 18.04. I have git cloned into /home/musicbrainz-server. If that was a good idea I am up to set MB_SERVER_ROOT in DBDefs.pm. Can anyone help with that pls?
3.7 didn't work either -- since I am messing with base images, I'll move to 3.7. anything else to consider?
2019-04-02 09229, 2019
adhawkins
Hi all. Had a 502 trying to download a replication packet about 50 minutes ago. It'll retry in 10 mins or so, but just thought I'd mention it in case it points to a wider issue.
2019-04-02 09248, 2019
ruaok
adhawkins: that is what all the chatter was about the last 45 minutes. but thanks for the heads up.
2019-04-02 09249, 2019
alastairp
ruaok: right, all python images are running consul 0.16
2019-04-02 09209, 2019
adhawkins
ruaok: Ok. That'll teach me not to read back in the channel before typing :)
2019-04-02 09214, 2019
ruaok
:)
2019-04-02 09249, 2019
alastairp
so as iliekcomputers says we should adjust all other pythonbrainz's to use the same startup process that metabrainz.org uses, then we can upgrade all python images to use the consul .18 base
2019-04-02 09217, 2019
alastairp
(this ties in pretty closely with our discussion about SEC and versioning)
2019-04-02 09218, 2019
ruaok
right then. a project for a different day.
2019-04-02 09222, 2019
alastairp
yes
2019-04-02 09239, 2019
ruaok
today I really just wanted to send quarterly invoices, not start a site-wide melt-down.
2019-04-02 09222, 2019
aliamo_ joined the channel
2019-04-02 09223, 2019
alastairp
as a retrospective to say "what went wrong", I'd focus on us deleting images from docker hub without checking if they were used in other places first
2019-04-02 09245, 2019
ruaok
yes, good point.
2019-04-02 09250, 2019
aliamo has quit
2019-04-02 09256, 2019
alastairp
perhaps that can be written down somwhere (where no one will read it and where it'll become quickly out of date ;)
2019-04-02 09208, 2019
aliamo_ has quit
2019-04-02 09220, 2019
aliamo joined the channel
2019-04-02 09222, 2019
alastairp
anyone else get spotify's DiscoCover weekly this week?
2019-04-02 09255, 2019
slc
not feeling like a noobie channel, but will carry on: i guess DBDefs.pm is a perl file, so the line # sub MB_SERVER_ROOT {"/home/..."} should be uncommented and changed?
2019-04-02 09236, 2019
aliamo has quit
2019-04-02 09252, 2019
alastairp
slc: sorry, we were in the middle of some stuff, we didn't mean to ignore you
2019-04-02 09214, 2019
aliamo joined the channel
2019-04-02 09204, 2019
alastairp
sure, you can uncomment and set this value to the location of the source code
2019-04-02 09207, 2019
slc
not a problem. looked a little hairy. am just editing a perl file for the first time
2019-04-02 09207, 2019
slc
i found sub WEB_SERVER uncommented, so i think i am on the right track
2019-04-02 09232, 2019
alastairp
perhaps the documentation could be improved here - from what I understand, the value for MB_SERVER_ROOT has a default, so you might not have to set it
2019-04-02 09236, 2019
alastairp
even though INSTALL.md recommends it
2019-04-02 09247, 2019
alastairp
perhaps yvanzo or bitmap can commend on that
2019-04-02 09257, 2019
yvanzo
hi slc: sure, uncommenting and changing MB_SERVER_ROOT is the way to go :)
2019-04-02 09231, 2019
slc
I see...it says something about defaults, its commented: uses the path of lib/DBDefs/Default.pm minus /lib/DBDefsDefault.pm. Sounds like good magic to me. Will leave it commented
2019-04-02 09222, 2019
alastairp
yvanzo: yeah, it seems like if you don't set it then it will automatically select the right value
2019-04-02 09229, 2019
yvanzo
slc: yes, default should do.
2019-04-02 09232, 2019
yvanzo
alastairp: Exactly, but in some rare cases (e.g. symbolic links), you might need to change that.
2019-04-02 09247, 2019
alastairp
right
2019-04-02 09208, 2019
slc
thanks all, will go with commented first. And WEB_SERVER - sub WEB_SERVER {"..."} will localhost work? does it matter I am on a VM - does the Url have to exist?
2019-04-02 09210, 2019
alastairp
perhaps we could update INSTALL.md to say that in most cases this doesn't have to be changed (currently it explicitly says to change it)
2019-04-02 09252, 2019
antlarr has quit
2019-04-02 09227, 2019
antlarr joined the channel
2019-04-02 09209, 2019
slc
just a note on install.md. It does say to specifically change 2 values, and the file itself says commented values should work. So, not knowing perl (yet!) I was guessing if it was going to work. and the tree on ubuntu is different etc
2019-04-02 09246, 2019
alastairp
yeah, thanks for pointing that out. We should change install.md
2019-04-02 09255, 2019
yvanzo
alastairp: oh right, this line is outdated, since setting MB_SERVER_ROOT was changed few months after.
2019-04-02 09207, 2019
alastairp
do you want me to open a ticket?
2019-04-02 09211, 2019
slc
yeh. just moving the pot plant around after you built the building. All going fine though. Especially that crazy sudo apt-intall business. v. cool
2019-04-02 09228, 2019
yvanzo
alastairp: not necessary, I’ll just open a PR.
2019-04-02 09235, 2019
alastairp
yvanzo: perfect, thanks
2019-04-02 09216, 2019
HorusHorrendus joined the channel
2019-04-02 09236, 2019
dolina joined the channel
2019-04-02 09206, 2019
slc
a small note: I had to hunt and find Replication_Type. Its got good commentary, but maybe uncomment it for RT_STANDALONE cos its probably what new installs will want. I get its hard to change, but if i dont know what i am doing i probably should not select RT_Master...
