#metabrainz

/

      • D4RK-PH0ENiX has quit
      • 2019-04-03 09329, 2019

      • aliamo joined the channel
      • 2019-04-03 09331, 2019

      • aliamo has quit
      • 2019-04-03 09344, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-03 09303, 2019

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #934 (master…MBS-9909-pt-15): MBS-9909: Change reports to use React (15 - final improvements) https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-03 09304, 2019

      • BrainzBot
        MBS-9909: Convert report templates to React/JSX https://tickets.metabrainz.org/browse/MBS-9909
      • 2019-04-03 09334, 2019

      • MusicbrainzB0T joined the channel
      • 2019-04-03 09333, 2019

      • MusicbrainzB0T1 has quit
      • 2019-04-03 09337, 2019

      • bluefantail has quit
      • 2019-04-03 09352, 2019

      • bluefantail joined the channel
      • 2019-04-03 09315, 2019

      • BrainzGit has quit
      • 2019-04-03 09320, 2019

      • Slurpee joined the channel
      • 2019-04-03 09320, 2019

      • Slurpee has quit
      • 2019-04-03 09320, 2019

      • Slurpee joined the channel
      • 2019-04-03 09351, 2019

      • Nyanko-sensei joined the channel
      • 2019-04-03 09334, 2019

      • Nyanko-sensei has quit
      • 2019-04-03 09354, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-03 09328, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-03 09359, 2019

      • modwizcode_ joined the channel
      • 2019-04-03 09325, 2019

      • modwizcode has quit
      • 2019-04-03 09322, 2019

      • modwizcode_ has quit
      • 2019-04-03 09325, 2019

      • modwizcode joined the channel
      • 2019-04-03 09358, 2019

      • dolina has quit
      • 2019-04-03 09320, 2019

      • dolina joined the channel
      • 2019-04-03 09336, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-03 09305, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-03 09339, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-03 09315, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-03 09356, 2019

      • Cyna
        Hi reosarevok , have you looked into the issue with the forms I reported last time
      • 2019-04-03 09359, 2019

      • Cyna
        which repository does the test.musicbrainz use for deployment? it it the musicbrianz-server master ?
      • 2019-04-03 09335, 2019

      • H-Lo[m] joined the channel
      • 2019-04-03 09301, 2019

      • H-Lo[m]
        hello, everyone.. I have a few questions about the BigQuery ListenBrainz dataset, am i in the right place?
      • 2019-04-03 09348, 2019

      • ruaok
        moiin everyone!
      • 2019-04-03 09354, 2019

      • ruaok
        H-Lo[m]: yep, what'cha got?
      • 2019-04-03 09354, 2019

      • H-Lo[m]
        (sorry im just getting the hang of this riot.im thingy xD)
      • 2019-04-03 09317, 2019

      • H-Lo[m]
        anyway my question is whether there are known issues in the way data gets to the BQ dataset, because iḿ getting fewer recirds than expected on most queries
      • 2019-04-03 09306, 2019

      • H-Lo[m]
        iḿ comparing results against a proper data dump
      • 2019-04-03 09329, 2019

      • yvanzo
        mo’’in’
      • 2019-04-03 09342, 2019

      • ruaok
        H-Lo[m]: actually this link is now outdated: https://console.cloud.google.com/marketplace/deta…
      • 2019-04-03 09300, 2019

      • ruaok
        we had a bit of a snafu with bigquery, so we had to start a new data set. let me dig out a link.
      • 2019-04-03 09346, 2019

      • ruaok
        hmmm. that dataset doesn't seem to be updating either from what I can tell.
      • 2019-04-03 09314, 2019

      • ruaok
        H-Lo[m]: the best thing to do is to use the data dumps -- those are up to date and the latest dump should be only about 3 days old.
      • 2019-04-03 09340, 2019

      • H-Lo[m]
        Yup, I figured as much...
      • 2019-04-03 09306, 2019

      • H-Lo[m]
        I'd like to try my hand at fixing that, any advise on where to start? (Besides the architecture docs hehe, I'm in the middle of those)
      • 2019-04-03 09354, 2019

      • outsidecontext joined the channel
      • 2019-04-03 09304, 2019

      • reosarevok
        Cyna: I think test.mb doesn't automatically use a repo but it's built by yvanzo or something
      • 2019-04-03 09302, 2019

      • Cyna
        If possible please check about the issues with attributes form
      • 2019-04-03 09333, 2019

      • Cyna
        There was issue with the required and non required values in attributes
      • 2019-04-03 09341, 2019

      • yvanzo
        It is built against the branch 'test'
      • 2019-04-03 09351, 2019

      • reosarevok
        yvanzo: oh, ok, good to know
      • 2019-04-03 09310, 2019

      • reosarevok
        Cyna: I will fix that part when I find some time. You can just convert the frontendy part
      • 2019-04-03 09323, 2019

      • reosarevok
        If it works the same as now, then it's well converted :)
      • 2019-04-03 09335, 2019

      • reosarevok
        bitmap: you had code for https://tickets.metabrainz.org/browse/MBS-9413 right? Remember to submit it! :)
      • 2019-04-03 09335, 2019

      • BrainzBot
        MBS-9413: An older edit can't be loaded
      • 2019-04-03 09311, 2019

      • Cyna
        Cool... I'll start the conversions as soon as I get done with college stuff
      • 2019-04-03 09322, 2019

      • bitmap
        reosarevok: indeed, thanks for the reminder
      • 2019-04-03 09351, 2019

      • reosarevok
        I'll start looking at all those PR comments :)
      • 2019-04-03 09318, 2019

      • Darkloke joined the channel
      • 2019-04-03 09339, 2019

      • ruaok
        H-Lo[m]: I think this is mostly a production fix on our end. there isn't anything you can really do to fix that.
      • 2019-04-03 09356, 2019

      • ruaok
        iliekcomputers: you around today?
      • 2019-04-03 09304, 2019

      • iliekcomputers
        Not right now, but yes. In a few hours.
      • 2019-04-03 09350, 2019

      • ruaok
        ok, it would be good to touch base and move a couple of things along. ping me.
      • 2019-04-03 09303, 2019

      • iliekcomputers
        Sure.
      • 2019-04-03 09328, 2019

      • H-Lo[m]
        <ruaok "H-Lo: I think this is mostly a p"> got it...
      • 2019-04-03 09340, 2019

      • reosarevok
        bitmap: what was the word for taking two pieces of almost-the-same-code and making them one reusable component?
      • 2019-04-03 09353, 2019

      • reosarevok
        (need it for the commit title :p )
      • 2019-04-03 09331, 2019

      • reosarevok just goes with extract, hopefully it's understandable enough :D
      • 2019-04-03 09317, 2019

      • bitmap
        makes sense, if there's another word I can't remember it either :)
      • 2019-04-03 09314, 2019

      • yvanzo
        messinalaroundarisation?
      • 2019-04-03 09307, 2019

      • yvanzo
        generalization?
      • 2019-04-03 09301, 2019

      • yvanzo
        deduplication?
      • 2019-04-03 09326, 2019

      • yvanzo
        …ation?
      • 2019-04-03 09330, 2019

      • Nyanko-sensei joined the channel
      • 2019-04-03 09335, 2019

      • yvanzo
        anyway, should match '\w' :)
      • 2019-04-03 09302, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-03 09310, 2019

      • bitmap
        oh yea, dedupe I've probably used
      • 2019-04-03 09308, 2019

      • reosarevok
        Hmm
      • 2019-04-03 09359, 2019

      • reosarevok
        Is there any reason we don't show begin/end dates on most artists lists?
      • 2019-04-03 09359, 2019

      • reosarevok is looking to do some messinallaroundarisation with artist lists too
      • 2019-04-03 09336, 2019

      • bitmap
        I'd guess not, prob was just deemed non-essential info to whoever was writing the code
      • 2019-04-03 09344, 2019

      • reosarevok
        I mean, it is
      • 2019-04-03 09352, 2019

      • reosarevok
        Since this is not even used for artist merges
      • 2019-04-03 09325, 2019

      • reosarevok
        Maybe we should change that though, and have artist merges show info about the artist rather than just the name
      • 2019-04-03 09331, 2019

      • reosarevok shrugs
      • 2019-04-03 09342, 2019

      • reosarevok
        Dates sound like they could be useful there
      • 2019-04-03 09346, 2019

      • Nyanko-sensei has quit
      • 2019-04-03 09322, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-03 09322, 2019

      • Mr_Monkey
        Mo-oin !
      • 2019-04-03 09335, 2019

      • Mr_Monkey
        reosarevok: Were you looking for the word "refactoring"?
      • 2019-04-03 09350, 2019

      • reosarevok
        Mr_Monkey: not quite - isn't refactoring much more general?
      • 2019-04-03 09348, 2019

      • Mr_Monkey
        I suppose.
      • 2019-04-03 09327, 2019

      • travis-ci joined the channel
      • 2019-04-03 09328, 2019

      • travis-ci
        Project bookbrainz-data-js build #1004: passed in 4 min 3 sec: https://travis-ci.org/bookbrainz/bookbrainz-data-…
      • 2019-04-03 09328, 2019

      • travis-ci has left the channel
      • 2019-04-03 09352, 2019

      • travis-ci joined the channel
      • 2019-04-03 09353, 2019

      • travis-ci
        Project bookbrainz-data-js build #1005: failed in 0 min 50 sec: https://travis-ci.org/bookbrainz/bookbrainz-data-…
      • 2019-04-03 09353, 2019

      • travis-ci has left the channel
      • 2019-04-03 09312, 2019

      • reosarevok
        bitmap: still around?
      • 2019-04-03 09322, 2019

      • reosarevok
        (if so, why, as usual, but)
      • 2019-04-03 09333, 2019

      • reosarevok
        In either case. bitmap, yvanzo: is static/scripts/common/components really the right place for WorkListEntry? Or would it make more sense in root/components?
      • 2019-04-03 09348, 2019

      • reosarevok
        yvanzo: https://github.com/metabrainz/musicbrainz-server/… does this actually get auto-replaced in MD?
      • 2019-04-03 09325, 2019

      • yvanzo
        reosarevok: no
      • 2019-04-03 09347, 2019

      • reosarevok
        I'm not sure it's less confusing then :D
      • 2019-04-03 09327, 2019

      • yvanzo
        previous instruction required to replaced 'x' three times to be usable, this one is directly usable.
      • 2019-04-03 09308, 2019

      • yvanzo
        and if you need another version, you just have to change version in a single place.
      • 2019-04-03 09330, 2019

      • reosarevok
        Wait, how is it directly usable if MD doesn't auto-replace it?
      • 2019-04-03 09341, 2019

      • reosarevok
        Oh, because *bash* will replace it?
      • 2019-04-03 09350, 2019

      • reosarevok
        (if so that works for me too)
      • 2019-04-03 09309, 2019

      • gr0uch0mars joined the channel
      • 2019-04-03 09301, 2019

      • Gazooo has quit
      • 2019-04-03 09308, 2019

      • pristine__
      • 2019-04-03 09317, 2019

      • pristine__
        ruaok: iliekcomputers ^^
      • 2019-04-03 09307, 2019

      • yvanzo
        reosarevok: not sure about WorkListEntry, the only potential concern to check here is localization.
      • 2019-04-03 09340, 2019

      • reosarevok
        Why would that matter with where it's located
      • 2019-04-03 09346, 2019

      • yvanzo
        Bundles are packed using root/static mostly, if a component is rendered/updated client-side with localization, then it needs to be under root/static.
      • 2019-04-03 09323, 2019

      • yvanzo
        See MBS-9817 for example.
      • 2019-04-03 09323, 2019

      • BrainzBot
        MBS-9817: Regression: Client-side rendered components are not localized https://tickets.metabrainz.org/browse/MBS-9817
      • 2019-04-03 09316, 2019

      • reosarevok
        Oh. Ok
      • 2019-04-03 09336, 2019

      • reosarevok
        https://github.com/metabrainz/musicbrainz-server/… and https://github.com/metabrainz/musicbrainz-server/… are now ready for review btw (both small, both were depending on the reports porting)
      • 2019-04-03 09340, 2019

      • yvanzo
        The related PR is more clear about localization issue: https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-03 09321, 2019

      • HorusHorrendus joined the channel
      • 2019-04-03 09339, 2019

      • yvanzo
        both reviewed and added to milestone
      • 2019-04-03 09306, 2019

      • Darkloke has quit
      • 2019-04-03 09346, 2019

      • reosarevok
        !m yvanzo
      • 2019-04-03 09346, 2019

      • BrainzBot
        You're doing good work, yvanzo!
      • 2019-04-03 09342, 2019

      • aliamo joined the channel
      • 2019-04-03 09331, 2019

      • Freso
        reosarevok: I swear I’m not trying to take over support@. :|
      • 2019-04-03 09321, 2019

      • CatQuest
        deduplication
      • 2019-04-03 09314, 2019

      • CatQuest
        [09:50] <reosarevok> Dates sound like they could be useful there
      • 2019-04-03 09314, 2019

      • CatQuest
        I totally agree with that aldo + more infor on merges!
      • 2019-04-03 09352, 2019

      • CatQuest
        [10:54] <yvanzo> previous instruction required to replaced 'x' three times to be usable,
      • 2019-04-03 09353, 2019

      • CatQuest
        beetlejuice...
      • 2019-04-03 09357, 2019

      • Cyna has quit
      • 2019-04-03 09323, 2019

      • pristine__
        ruaok: we can have a window, maybe a month or something, the listens collected in these months shall be added to the data frame deleting some listens of the past and then training the model again. In this way we train the model less often. Just a thought.
      • 2019-04-03 09329, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-03 09333, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-03 09317, 2019

      • iliekcomputers
        ruaok: ping.
      • 2019-04-03 09300, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-03 09355, 2019

      • ruaok
        iliekcomputers: pong.
      • 2019-04-03 09300, 2019

      • ruaok
        how'ya holding up?
      • 2019-04-03 09321, 2019

      • iliekcomputers
        i'm good.
      • 2019-04-03 09346, 2019

      • pristine__
      • 2019-04-03 09327, 2019

      • pristine__
        ruaok: I am sure it the format can be improved. Ping me whenever you're free :) tc
      • 2019-04-03 09339, 2019

      • ruaok
        much better.
      • 2019-04-03 09306, 2019

      • ruaok
        now we at least need some artist names to make it really useful.
      • 2019-04-03 09322, 2019

      • iliekcomputers
        artist names would be helpful too
      • 2019-04-03 09340, 2019

      • ruaok
        iliekcomputers: should we do an LB release to get some of the bug fixes out?
      • 2019-04-03 09304, 2019

      • iliekcomputers
        ruaok: yes, sure. sounds good.
      • 2019-04-03 09312, 2019

      • iliekcomputers
        pristine__: lots of justin timberlake :) :)
      • 2019-04-03 09327, 2019

      • ruaok
        k, when should we do that?