letaiv_: I'll try and give some more detailed feedback today or tomorrow. If you can't give all links for your references, perhaps you could put the proposal in a google doc and link to that? I'd like to see some of the references. It'd be nice to see some basic design outlines, for example for the search api endpoint (example of how the endpoint might look, what a possible UI for the endpoint could be)
2019-04-05 09503, 2019
alastairp
the update mechanism of the offline index is quite important, I understand that part of the project will be to design it, but it'd be good to see an initial outline/description of what this mechanism could look like (you've included file format, but I'm interested in knowing how you might go about building it (for 5m or 10m items)
we can't do it at a global level because we can't redirect the submission endpoint (it'll break the POST)
2019-04-05 09559, 2019
alastairp
however we could do the redirect in the flask code, or do the redirect on all but 1 endpoint
2019-04-05 09537, 2019
alastairp
I think we could even enable hsts, because this would be a browser thing, not something that a client responds to
2019-04-05 09511, 2019
Cyna joined the channel
2019-04-05 09521, 2019
letaiv_
alastairp : thanks, I've added a link to google doc
2019-04-05 09504, 2019
letaiv_
alastairp : got it, I'll add more implementation details about api endpoint
2019-04-05 09532, 2019
letaiv_ is now known as letaiv
2019-04-05 09546, 2019
letaiv has quit
2019-04-05 09540, 2019
aliamo joined the channel
2019-04-05 09530, 2019
letaiv joined the channel
2019-04-05 09501, 2019
aliamo has quit
2019-04-05 09525, 2019
letaiv has quit
2019-04-05 09541, 2019
pristine__
iliekcomputers: around?
2019-04-05 09558, 2019
iliekcomputers
pristine__: yep
2019-04-05 09519, 2019
pristine__
I was wondering if we should remove all . collect statements where they are not needed. We used them to monitor time since spark is lazy but if we getting some output for a query or any other line of code then it means that some action has been called and the time is accurate.
For instance, we have used predictions.collect() in compute_rmse which is not required I guess, reduce on predictions is an action which is enough to invoke an action.
2019-04-05 09520, 2019
iliekcomputers
pristine__: sounds good to me, let's remove them if they're not needed.
2019-04-05 09530, 2019
pristine__
:)
2019-04-05 09540, 2019
iliekcomputers
alastairp: the lowlevel dump has started but is pretty slow
2019-04-05 09551, 2019
iliekcomputers
should be 12M rows, i guess?
2019-04-05 09529, 2019
outsidecontext has quit
2019-04-05 09545, 2019
alastairp
iliekcomputers: great, thanks. the ll one will be pretty slow
2019-04-05 09559, 2019
alastairp
it took many hours, or maybe days the last time I did it
2019-04-05 09521, 2019
alastairp
the db was smaller then, but maybe the server it's on is more powerful too
2019-04-05 09501, 2019
ZaphodBeeblebrox is now known as CatQuest
2019-04-05 09557, 2019
luks joined the channel
2019-04-05 09518, 2019
Cyna
reosarevok: convertion of all template toolkit pages will be done by the start of GSoC right ?
2019-04-05 09533, 2019
aduuna has quit
2019-04-05 09507, 2019
aliamo joined the channel
2019-04-05 09527, 2019
aliamo has quit
2019-04-05 09552, 2019
yvanzo
zas: ping
2019-04-05 09500, 2019
zas
pooong
2019-04-05 09517, 2019
yvanzo
Cyna: no
2019-04-05 09516, 2019
yvanzo
zas: please put maintenance page up again from the gateway, but don’t change DNS for now.
2019-04-05 09548, 2019
zas
any timeframe ?
2019-04-05 09523, 2019
zas
soon...
2019-04-05 09553, 2019
Cyna
So basically converting all the remaining Entities edit page could also be GSoC potential targets right ?
2019-04-05 09531, 2019
yvanzo
zas: yes like right now
2019-04-05 09543, 2019
yvanzo
:D
2019-04-05 09545, 2019
yvanzo
Cyna: indeed, edits preview implies converting some stuff to react
2019-04-05 09507, 2019
akhilesh joined the channel
2019-04-05 09556, 2019
yvanzo
Cyna: that's why I mentioned alias editing to start with because aliases editing pages are almost converted to react already
2019-04-05 09526, 2019
Cyna
Im currently exploring how the preview is shown in the release
2019-04-05 09543, 2019
Cyna
if you have some time, could you point me in the right direction 😅
2019-04-05 09552, 2019
aliamo joined the channel
2019-04-05 09533, 2019
iliekcomputers
Mr_Monkey: ping. does the create_dumps.sh script you linked dump private data as well?
2019-04-05 09550, 2019
iliekcomputers
i mean, can we release dumps created by it to ftp etc?
And it would be actually easier to start with implementing edits preview for alias editing.
2019-04-05 09546, 2019
yvanzo
Cyna: Is that more clear? :)
2019-04-05 09546, 2019
Cyna
I dont see any folder or file names aliases in root/
2019-04-05 09532, 2019
yvanzo
Cyna: There are some, type find root/ -iname '*alias*'
2019-04-05 09505, 2019
Cyna
I found root/components/aliases
2019-04-05 09510, 2019
Cyna
is this the one ?
2019-04-05 09534, 2019
yvanzo
See root/entity/Aliases.js and root/components/Aliases/
2019-04-05 09531, 2019
yvanzo
Yes, it is for aliases display.
2019-04-05 09547, 2019
yvanzo
Aliases editing form is still TT/jquery: root/entity/alias/edit_form.tt
2019-04-05 09515, 2019
yvanzo
This form seems to be quite manageable to convert to ReactJS.
2019-04-05 09548, 2019
aliamo joined the channel
2019-04-05 09510, 2019
Cyna
I was checking out the release folder in root.. Any idea why there is an edit subfolder there
2019-04-05 09552, 2019
Cyna
I guessed It would have been for previewing but that would require the file to be in React and it was actually in .tt
2019-04-05 09524, 2019
aliamo has quit
2019-04-05 09527, 2019
yvanzo
No, root/edit is mostly about edit display, not preview.
2019-04-05 09507, 2019
madmouser1_ has quit
2019-04-05 09505, 2019
pristine__
iliekcomputers: is rob afk today?
2019-04-05 09520, 2019
iliekcomputers
i think so, yes.
2019-04-05 09531, 2019
yvanzo
Cyna: Check root/static/scripts/release-editor/edits.js for JS-side of current release editor edits preview
2019-04-05 09516, 2019
Cyna
Will do. According to the project statement, knockout.js is used for previewing
2019-04-05 09504, 2019
pristine__
iliekcomputers: oh. I was thinking if we should move on with adding tables (that will store recommemdations for users) on server side. Since we have minimal recommendation generation script.
2019-04-05 09513, 2019
aliamo joined the channel
2019-04-05 09518, 2019
aliamo has quit
2019-04-05 09533, 2019
yvanzo
Cyna: Yes and we want to get rid of it as well.
2019-04-05 09529, 2019
Cyna
yvanzo: so basically the current approach is to check every attribute of an entity and if the data is changed. then render the previous and changed value right ?
2019-04-05 09517, 2019
Cyna
The changes data is received from the form input and previous data is received from the catalyst context. right ?
2019-04-05 09519, 2019
iliekcomputers
pristine__: weren't we planning on adding artists to the output and some more changes first?
2019-04-05 09504, 2019
Cyna
I have less idea from where the previous data is retrieved, guessed it would have been from the database via catalyst
2019-04-05 09543, 2019
Cyna
Is there a file named knockout.js or does it use the framework KnockoutJs ??
code_master5: around? Not really. Quarter awake after 13.5 hours in the air. Another 1.5 to come. What's up?
2019-04-05 09519, 2019
code_master5
ruaok: Then I guess it's not the right time! 😅 Just wanted to discuss something important..
2019-04-05 09547, 2019
code_master5
But it can wait.
2019-04-05 09520, 2019
Mr_Monkey
iliekcomputers: consider the dumps made from that script to be public. I have a migration script to run to remove user birth dates that I'll run when we switch BB over, other data is fine.
2019-04-05 09545, 2019
ruaok
pristine__: yes, Let's make sure the bare bones recommenation script is clear and useable before we move on.
considering preview.js be my preview component. and index.js be my component where my forms exist. Better tags for the state would be saved and unsaved or something like that
2019-04-05 09507, 2019
spookyninja has quit
2019-04-05 09524, 2019
yvanzo
Cyna: as I tried to explain to Khalifa, previews are actually not computed client-side, these are computed by the server, thus the above link.
2019-04-05 09538, 2019
Cyna
Just wanted to know where client-side rendering is preferred or server side. thanks :)
2019-04-05 09557, 2019
Cyna
now I can explore it better
2019-04-05 09532, 2019
yvanzo
zas: almost there, let me know when you are full :)
2019-04-05 09527, 2019
ruaok
yvanzo: do you need DNS changes?
2019-04-05 09539, 2019
yvanzo
ruaok: yes
2019-04-05 09528, 2019
yvanzo
ruaok: there currently is a redirect from tickets to a maintenance page, it should point to the new jira VM instead.
2019-04-05 09501, 2019
Gazooo has quit
2019-04-05 09521, 2019
zas
i'm back
2019-04-05 09526, 2019
yvanzo
yay!
2019-04-05 09547, 2019
ruaok
Ok, zas allí yours then.
2019-04-05 09500, 2019
yvanzo
ready to wreak havoc!
2019-04-05 09513, 2019
zas
yvanzo: ok, i switch to new server ?
2019-04-05 09519, 2019
ruaok
I'll keep being entertained by the utter CDG shit show.
