#metabrainz

code_master5: ah, that makes sense.

mo’’in’

moin

Cyna: शुभ प्रभात 🙏

moin code_master5

Cyna: You based in India?

Yea

code_master5: Same here! 👋

Cyna: ^

😆

lol

reosarevok: Can you please review changes to relationship types for localization? https://gist.github.com/yvanzo/53127710949b4791...

Project bookbrainz-data-js build #1016: passed in 1 min 38 sec: https://travis-ci.org/bookbrainz/bookbrainz-dat...

yvanzo: define review. See if they make sense? See if I realize something is missing?

reosarevok: yeah, for typos mostly

reosarevok: I found "'" could be replaced with "’" in some places.

Oh. Hmm. The SecondHandSongs strings (both old and new) have "its corresponding page in SecondHandSongs database"

reosarevok: I know that these values are edited through separate forms, thus it also helps to review consistency.

I should probably change it to "in the", but that'll break existing translations :p

Hi, do you mind if I work on AB-148?

AB-148: Submitting a dataset for evaluation should ignore non-submitted Recording MBIDs https://tickets.metabrainz.org/browse/AB-148

Changed it anyway

And yeah, fixed those two apostrophes

yvanzo: it seems right otherwise, can you regenerate?

yup

reosarevok: still 4 undue occurrrrences of '

Oh, in older strings?

Oh, no

Now I saw those

Duh

Ok, on it

for inspired rels

Fixed those too

mooo'oiiin!

mooo’oiiin

reosarevok: updated gist, seems fine, thank you

Surely

:p

np

reosarevok: just in case you find it useful, I updated gist with full diff of flattened messages

yvanzo: well there's a ton of apostrophes that could be changed, but that'd break all translations, right?

right

Sigh. Then guess better not :)

Not right now at least :)

It’d be great if we had a way to update the source strings in translation files without changing the translated strings. It’s “easy” with raw .po(t), but I guess Transifex has no way to do this?

Mr_Monkey: Hi.

Hi akhilesh

Mr_Monkey: Could you try to add an entity form from rename branch?

I got submission error on the same

in case of publisher, I got this:

akhilesh: Try running the sql/scripts/create_triggers.sql script

Using psql

And then try again, see if that solved the issue

Ok

Mr_Monkey: thanks its working now :)

Great

Mr_Monkey: Could you create sort note on, how to up and down the db for current changes, step wise please?

akhilesh: I can add a couple of lines somewhere in the documentation. It's not a very usual case.

It will help to go back on the previous schema, and again forward to current schema to check the sql migration and other scripts.

Mr_Monkey: I am talking about something this, Help for go back to previous schema > https://gist.github.com/akhilesh26/2a3cf5a2127b...

akhilesh: Do you mean adding that to the PR?

Mr_Monkey: No, It is only for check.

I don't understand. Do you mean I should add some documentation to the PR, or to the repo documentation?

I mean, it is only for me, or anyone who want to check this PR works fine. You may provide this link with the PR so that any anyone can run this branch without your help. Am I clear to you now?

Mr_Monkey: ^

Yep, thank

akhilesh: I updated the PR description

ruaok: Just a heads - up I've finally found some time to write up thoughts on that LB privacy thread of mine.

Mr_Monkey: thanks, It will very helpful to me.