#metabrainz

/

      • D4RK-PH0ENiX has quit
      • 2019-04-25 11550, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-25 11521, 2019

      • Nyanko-sensei joined the channel
      • 2019-04-25 11500, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-25 11526, 2019

      • Nyanko-sensei has quit
      • 2019-04-25 11500, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-25 11550, 2019

      • amCap1712 joined the channel
      • 2019-04-25 11553, 2019

      • bitmap
        reosarevok: looks like https://sentry.metabrainz.org/metabrainz/musicbra… is from your cjs patch, if you wanna take a look
      • 2019-04-25 11531, 2019

      • amCap1712 has quit
      • 2019-04-25 11538, 2019

      • BrainzGit
        [musicbrainz-server] mwiencek opened pull request #1035 (schema-change-2019-q2…mbs-5387): MBS-5387: Show edits pending on artist credits https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-25 11539, 2019

      • BrainzBot
        MBS-5387: ACs being edited aren't marked as having pending edits on the aliases tab https://tickets.metabrainz.org/browse/MBS-5387
      • 2019-04-25 11503, 2019

      • bitmap
        yvanzo: your sortable collections stuff depends on the -list.tt conversion prs too, right? can you review/approve those?
      • 2019-04-25 11531, 2019

      • bitmap
        reosarevok needs them for his ui work too
      • 2019-04-25 11505, 2019

      • yvanzo
        bitmap: yes, will do
      • 2019-04-25 11538, 2019

      • bitmap
        👍👍
      • 2019-04-25 11539, 2019

      • yvanzo
        can you also review gh:MBS#1033 which fixes a display bug in beta?
      • 2019-04-25 11539, 2019

      • BrainzBot
        MBS-10136: Properly display descriptions with HTML: https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-25 11521, 2019

      • bitmap
        lgtm
      • 2019-04-25 11534, 2019

      • yvanzo
        Ok, we are all set to release a new version of MBS today!
      • 2019-04-25 11522, 2019

      • bitmap
        I think guess feat. buttons are broken on beta (see the sentry link above) but reo can prob look into that pretty quickly
      • 2019-04-25 11505, 2019

      • bitmap will look into the event art archive comments in the morning :)
      • 2019-04-25 11528, 2019

      • iliekcomputers
        ferbncode: CB PR merged
      • 2019-04-25 11543, 2019

      • iliekcomputers
        i'll deploy once I fix SEC-3 and SEC-4
      • 2019-04-25 11545, 2019

      • BrainzBot
        SEC-3: Upgrade Jinja2 to version 2.10.1 or later. https://tickets.metabrainz.org/browse/SEC-3
      • 2019-04-25 11545, 2019

      • BrainzBot
        SEC-4: Upgrade SQLAlchemy to version 1.3.0 or later https://tickets.metabrainz.org/browse/SEC-4
      • 2019-04-25 11551, 2019

      • ferbncode
        iliekcomputers: cool, thanks :)
      • 2019-04-25 11532, 2019

      • yvanzo
        ’night!
      • 2019-04-25 11538, 2019

      • yvanzo
        mo’’in’
      • 2019-04-25 11550, 2019

      • reosarevok
        Oh no. I knew the feat buttons didn't work.... I just thought it was a userscript!!!!
      • 2019-04-25 11513, 2019

      • reosarevok
        Will check. And gn bitmap
      • 2019-04-25 11510, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1033 (beta…MBS-10136): MBS-10136: Properly display descriptions with HTML https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-25 11512, 2019

      • BrainzBot
        MBS-10136: Beta: relationship descriptions with HTML not expanded in [?] popup https://tickets.metabrainz.org/browse/MBS-10136
      • 2019-04-25 11528, 2019

      • yokel has quit
      • 2019-04-25 11548, 2019

      • -- BotBot disconnected, possible missing messages --
      • 2019-04-25 11517, 2019

      • BrainzBot joined the channel
      • 2019-04-25 11509, 2019

      • reosarevok
        yvanzo, bitmap: fixed that actual error (that's easy) but the feat button still doesn't update the actual AC displayed. I can look into that later, breakfast now though.
      • 2019-04-25 11543, 2019

      • CatQuest
        morn morn
      • 2019-04-25 11512, 2019

      • CatQuest
        today and in the weekend it fill finaly rain here!
      • 2019-04-25 11520, 2019

      • CatQuest
        hasn't rained for a month :(
      • 2019-04-25 11528, 2019

      • CatQuest
        over a*
      • 2019-04-25 11552, 2019

      • CatQuest
        I like sun. but tha's not right. epecially this: it's 10 to 17 degrees here ..
      • 2019-04-25 11556, 2019

      • CatQuest
        it's stil APRIL
      • 2019-04-25 11514, 2019

      • CatQuest
      • 2019-04-25 11557, 2019

      • amCap1712 joined the channel
      • 2019-04-25 11557, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1036 (beta…name-guessFeat-function): Name guessFeat function so it can be called in the same file https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-25 11515, 2019

      • reosarevok
        yvanzo, bitmap ^ this should fix the new regressions included in beta
      • 2019-04-25 11546, 2019

      • reosarevok
        There's a related bug in prod, https://tickets.metabrainz.org/browse/MBS-10137 - I'm not sure how to fix that one, so maybe one of you two can look into it eventually
      • 2019-04-25 11547, 2019

      • BrainzBot
        MBS-10137: Guess feat button doesn't change AC on recording pages
      • 2019-04-25 11500, 2019

      • reosarevok
        But since it's already broken in prod, we don't need to fix it before releasing beta, so yay I guess?
      • 2019-04-25 11533, 2019

      • reosarevok
        CatQuest: no rain here yet. Just sun, sun, sun forever
      • 2019-04-25 11543, 2019

      • reosarevok
        yvanzo, bitmap: only that tests are failing, sigh :p
      • 2019-04-25 11549, 2019

      • reosarevok
        It worked locally, wonder wtf
      • 2019-04-25 11543, 2019

      • yvanzo
        tests are failing for a good reason, yay!
      • 2019-04-25 11553, 2019

      • reosarevok
        yvanzo: how did I run a specific js test?
      • 2019-04-25 11558, 2019

      • reosarevok
        yvanzo: I want to run root/static/scripts/tests/guessFeat.js locally
      • 2019-04-25 11515, 2019

      • reosarevok
        From the CLI
      • 2019-04-25 11527, 2019

      • reosarevok
      • 2019-04-25 11534, 2019

      • reosarevok just pushes the thing for now and lets jenkins test it
      • 2019-04-25 11534, 2019

      • CatQuest
        reosarevok: D:
      • 2019-04-25 11544, 2019

      • CatQuest
        do you have drought and foresfire warnings?
      • 2019-04-25 11557, 2019

      • reosarevok
        Not yet
      • 2019-04-25 11521, 2019

      • reosarevok
        We do get the warnings every summer, but we haven't gotten them so far
      • 2019-04-25 11543, 2019

      • reosarevok
        yvanzo: seems it passed fine now :p
      • 2019-04-25 11501, 2019

      • CatQuest
        we are now at orange warning levle :/
      • 2019-04-25 11504, 2019

      • CatQuest
        level*
      • 2019-04-25 11509, 2019

      • CatQuest
      • 2019-04-25 11537, 2019

      • CatQuest
        ... "Wednesday April 24, 2019 at 1 pm - The father is increasing"
      • 2019-04-25 11541, 2019

      • CatQuest
        oh no
      • 2019-04-25 11544, 2019

      • CatQuest
        it's a dadpuns
      • 2019-04-25 11559, 2019

      • CatQuest
        (faren means both danger and the father)
      • 2019-04-25 11508, 2019

      • CatQuest
        also wtf translating our 24h clock to am/pm nonnsense
      • 2019-04-25 11517, 2019

      • yvanzo
        tests are passing, yay!
      • 2019-04-25 11555, 2019

      • CatQuest
        hi yvanzo !
      • 2019-04-25 11511, 2019

      • yvanzo
        hi
      • 2019-04-25 11508, 2019

      • letaiv joined the channel
      • 2019-04-25 11549, 2019

      • Gazooo joined the channel
      • 2019-04-25 11536, 2019

      • ruaok
        mooooin!
      • 2019-04-25 11546, 2019

      • ruaok
        Mr_Monkey: fancy lunch? I'm finally ready for chinese food. :)
      • 2019-04-25 11505, 2019

      • Mr_Monkey
        Moin ruaok ! Yeah, I could be tempted. Still @ home currently, but I'll be over @OfficeBrainz before spanish lunchtime
      • 2019-04-25 11517, 2019

      • ruaok
        sweet
      • 2019-04-25 11516, 2019

      • letaiv has quit
      • 2019-04-25 11538, 2019

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #276 (master…hetzner-migration): Consul: Beta and test container configurations https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2019-04-25 11508, 2019

      • travis-ci joined the channel
      • 2019-04-25 11508, 2019

      • travis-ci
        Project bookbrainz-site build #2128: passed in 3 min 44 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2019-04-25 11508, 2019

      • travis-ci has left the channel
      • 2019-04-25 11536, 2019

      • Freso
        yvanzo (and cc: reosarevok): I never received an e-mail about https://tickets.metabrainz.org/browse/PICARD-1506 :( Only saw zas’ response because I checked “manually”.
      • 2019-04-25 11537, 2019

      • BrainzBot
        PICARD-1506: Picard’s tests fail based on configuration in $HOME
      • 2019-04-25 11508, 2019

      • CatQuest
        hi Freso!
      • 2019-04-25 11533, 2019

      • amCap1712 has quit
      • 2019-04-25 11508, 2019

      • Nyanko-sensei joined the channel
      • 2019-04-25 11532, 2019

      • Nyanko-sensei has quit
      • 2019-04-25 11537, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-25 11509, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-25 11515, 2019

      • gr0uch0mars joined the channel
      • 2019-04-25 11531, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-25 11510, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-25 11545, 2019

      • D4RK-PH0ENiX has quit
      • 2019-04-25 11520, 2019

      • Cyna joined the channel
      • 2019-04-25 11547, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-04-25 11504, 2019

      • yvanzo
        Freso, reosarevok: Ok, I disabled batching email notifications, seems buggy.
      • 2019-04-25 11518, 2019

      • rsh7
        hi alastairp!
      • 2019-04-25 11558, 2019

      • reosarevok
        yvanzo: thanks, let's see how it works :)
      • 2019-04-25 11551, 2019

      • ruaok
        iliekcomputers: you'd be very helpful to me if you could look at https://github.com/metabrainz/metabrainz.org/pull…
      • 2019-04-25 11558, 2019

      • ruaok
        that lets me get on with my tasks for the afternoon.
      • 2019-04-25 11559, 2019

      • reosarevok
        " # get rid of some really pesky warning. Remove this in April 2020, when it shouldn't be needed anymore." lol
      • 2019-04-25 11542, 2019

      • iliekcomputers
        ruaok: oh i thought i approved it.
      • 2019-04-25 11515, 2019

      • iliekcomputers
        Did you make any other changes other than the docstring
      • 2019-04-25 11523, 2019

      • iliekcomputers
        Feel free to merge
      • 2019-04-25 11525, 2019

      • ruaok
        not really.
      • 2019-04-25 11528, 2019

      • ruaok
        thanks!
      • 2019-04-25 11546, 2019

      • letaiv joined the channel
      • 2019-04-25 11518, 2019

      • BrainzGit
        [metabrainz.org] mayhem merged pull request #319 (master…add-top-token-stats): Add top token stats https://github.com/metabrainz/metabrainz.org/pull…
      • 2019-04-25 11508, 2019

      • Lotheric
        Question, is MBS-8393 something we can work on after schema change this spring? Or is it not planned for the upcoming schema change?
      • 2019-04-25 11509, 2019

      • BrainzBot
        MBS-8393: Extend dynamic attributes to all entities https://tickets.metabrainz.org/browse/MBS-8393
      • 2019-04-25 11532, 2019

      • reosarevok
        Lotheric: it's already schema changed
      • 2019-04-25 11540, 2019

      • reosarevok
        Needs UI, so it can worked on wherever
      • 2019-04-25 11542, 2019

      • reosarevok
        *whenever
      • 2019-04-25 11547, 2019

      • reosarevok
        Well, wherever too I guess :p
      • 2019-04-25 11545, 2019

      • Lotheric
        aah, I saw "schema change" linked to the ticket. Didn't know it was already changed :)
      • 2019-04-25 11502, 2019

      • CatQuest
        [12:44] <yvanzo> Freso, reosarevok: Ok, I disabled batching email notifications, seems buggy.
      • 2019-04-25 11503, 2019

      • CatQuest
        :O
      • 2019-04-25 11509, 2019

      • CatQuest
        (lo y no ping me abotu this :PP)
      • 2019-04-25 11542, 2019

      • CatQuest
        anyway YES
      • 2019-04-25 11544, 2019

      • CatQuest
        reosarevok pong
      • 2019-04-25 11524, 2019

      • Freso
        Lotheric: It was part of the last schema change (like… 2 years ago?), but the UI was never finished… :|
      • 2019-04-25 11528, 2019

      • Freso
        yvanzo: Thanks! And yes, let’s. Already one more notifications I should have gotten that I didn’t, but that was a bit too close to when you changed it to say anything definite. I’ll keep an eye out to see how if I miss more mails. :)
      • 2019-04-25 11543, 2019

      • reosarevok
        We just created an instrument ticket
      • 2019-04-25 11552, 2019

      • CatQuest
        I am definitly more happy about non-grouped emails from jira
      • 2019-04-25 11555, 2019

      • reosarevok
        Haven't gotten notified so far
      • 2019-04-25 11509, 2019

      • reosarevok
        But let's wait a bit
      • 2019-04-25 11541, 2019

      • CatQuest
        reosarevok: also remember ot edit it
      • 2019-04-25 11555, 2019

      • reosarevok
        "it"?
      • 2019-04-25 11505, 2019

      • Freso
        The ticket.
      • 2019-04-25 11510, 2019

      • reosarevok
        The ticket? We should get notified of creation, that's how it used to work
      • 2019-04-25 11510, 2019

      • CatQuest
        yus
      • 2019-04-25 11512, 2019

      • Freso
        (I assume.)
      • 2019-04-25 11515, 2019

      • CatQuest
        yes
      • 2019-04-25 11527, 2019

      • Freso
        reosarevok: It also used to work with notifying on edits.
      • 2019-04-25 11537, 2019

      • CatQuest
        yes isntead of making one
      • 2019-04-25 11551, 2019

      • CatQuest
        well i got a "reosarevok created a" tambora ticket
      • 2019-04-25 11555, 2019

      • CatQuest
        notification
      • 2019-04-25 11554, 2019

      • reosarevok
        Huh, I didn't maybe it's because it was me
      • 2019-04-25 11558, 2019

      • gr0uch0mars has quit
      • 2019-04-25 11559, 2019

      • reosarevok
        But I haven't gotten an email yet
      • 2019-04-25 11512, 2019

      • reosarevok
        (I used to get them for my own tickets too IIRC)
      • 2019-04-25 11514, 2019

      • CatQuest
        hmm i don't usualyl get emails for tickets i create myself tho
      • 2019-04-25 11519, 2019

      • Freso
        reosarevok: I mean, you usually don’t get e-mails from changes you make yourself.
      • 2019-04-25 11522, 2019

      • Freso
        Ah.
      • 2019-04-25 11522, 2019

      • CatQuest
        shrug
      • 2019-04-25 11525, 2019

      • reosarevok
        Huh, maybe not then.