5s cache on /api/ only, i'll wait few minutes to see if it has any impact (unlikely), then i'll raise duration a bit
2019-05-15 13510, 2019
alastairp
ok
2019-05-15 13543, 2019
alastairp
I'd be really interested to see what the histogram of inter-interval requests is
2019-05-15 13552, 2019
alastairp
how frequently the most popular mbids are requested
2019-05-15 13530, 2019
zas
alastairp: what are /<uuid>/(low|high)-level queries vs /api/v1/<uuid> , website vs web service ?
2019-05-15 13545, 2019
alastairp
old-style API vs new API
2019-05-15 13517, 2019
zas
hmmm; and no redirect ?
2019-05-15 13530, 2019
alastairp
not yet, we just serve the same from both endpoints
2019-05-15 13544, 2019
alastairp
we could start to deprecate it. add a redirect as a first point
2019-05-15 13553, 2019
zas
ok, first ones are not as easy to match (lack of a prefix)
2019-05-15 13524, 2019
alastairp
the thing is, as it's accessed by api clients and not browsers, they're almost certainly not going to cache redirects, even permanent ones
2019-05-15 13544, 2019
alastairp
mm, right. so if we add a redirect then it's little work for the python server, but then makes caching easier
2019-05-15 13547, 2019
alastairp
I'll open a ticket
2019-05-15 13537, 2019
zas
ok, for now, i'll cache more widely and for a longer time, if we want to measure any effect
2019-05-15 13534, 2019
zas
Mr_Monkey: where are you atm ? Rob & I are heading out to find something to eat, are you in ?
2019-05-15 13556, 2019
aidanlw17
alastairp: hey, for the bulk high level get, I've been writing a similar single query to the low level one
2019-05-15 13515, 2019
aidanlw17
But I have a question about raising exceptions for no data found
2019-05-15 13502, 2019
aidanlw17
The load_high_level function https://github.com/metabrainz/acousticbrainz-serv… raises no data found if the row is none or if there isn't any metadata, just a placeholder when the hl calculation failed
2019-05-15 13539, 2019
aidanlw17
I was just wondering whether you think I should raise an exception if this is the case in the bulk get case, or if we should just skip the row altogether so that we can still return the high level data for the remaining (mbid, offset) pairs
2019-05-15 13538, 2019
ruaok
iliekcomputers: did you get near finishing the review for the ratelimiter?
2019-05-15 13509, 2019
Mr_Monkey
zas: having lunch at home in the end. Had some stuff to do in the house
2019-05-15 13521, 2019
alastairp
hi aidanlw17
2019-05-15 13503, 2019
alastairp
for bulk get, we should raise no errors if there is no highlevel data for a given mbid
2019-05-15 13522, 2019
alastairp
regardless of the error (doesn't exist, or only a hl row and no data rows)
2019-05-15 13522, 2019
alastairp
like bulk get lowlevel, we just skip mbids if they don't exist (otherwise a user would have to make a request to see if each mbid exists before doing a bulk get... that removes all benefit from doing a bulk get in the first place
2019-05-15 13505, 2019
aidanlw17
Thanks alastairp. After thinking about it a bit more I changed it to skip like that. One other question, when we skip a row I was thinking that it might be beneficial to have a way of alerting the user that one of their recordings was not returned
2019-05-15 13533, 2019
alastairp
we decided to not do that - the idea is that they know what mbids they requested. If the id isn't in the response, it means it doesn't exist
2019-05-15 13558, 2019
alastairp
you're right, we could have added a "missing" field, but we decided not to
2019-05-15 13549, 2019
aidanlw17
Okay I see, thanks for clarifying that
2019-05-15 13547, 2019
ferbncode
spellew: ping (how did your finals go? :) o/ )
2019-05-15 13531, 2019
Mr_Monkey
zas, ruaok: Is either one of you at Rob's? Can I come over?
2019-05-15 13540, 2019
zas
we are right now
2019-05-15 13512, 2019
zas
and yes, i think you can come over, we just came back from lunch
which means that perhaps it should be fixed sooner rather than later
2019-05-15 13503, 2019
Mr_Monkey
reosarevok: ¯\_(ツ)_/¯
2019-05-15 13508, 2019
reosarevok
alastairp: do you remember how you decided for just /collection without a specified username on pymbngs?
2019-05-15 13509, 2019
alastairp
oh, I see that it's mentioned that the bindings use it. Interesting, why did we use the wrong endpoint?
2019-05-15 13510, 2019
Mr_Monkey
I suppose so
2019-05-15 13519, 2019
alastairp
reosarevok: yeah, good question
2019-05-15 13541, 2019
alastairp
perhaps "I tried it and it worked, so I left it as-is"
2019-05-15 13542, 2019
reosarevok
I mean, maybe that was originally going to be the right endpoint, it was later changed, and that's why it's not documented?
2019-05-15 13550, 2019
reosarevok
Since Picard does the same
2019-05-15 13519, 2019
alastairp
You can also perform a get request on the collection list, which will present you an of collections for the currently authenticated user, with the amount of releases in each collection:
ZoeB: well, the genre one being missing I did wrong, so eh :D
2019-05-15 13510, 2019
ZoeB
So we're even? :D
2019-05-15 13537, 2019
ZoeB
Implementing genres was an impressive and wonderful change, thank you all! I've been looking forward to this for ages.
2019-05-15 13537, 2019
ruaok
you'd to have to screw up a lot more to be even with reosarevok, ZoeB.
2019-05-15 13546, 2019
yvanzo
zas: can we temporarily disable it for /ws/2/collection only?
2019-05-15 13500, 2019
yvanzo
zas: and /ws/2/collection/
2019-05-15 13515, 2019
zas
yes, i'll do that
2019-05-15 13540, 2019
yvanzo
Thanks, I did not find any code change possibly causing it either.
2019-05-15 13500, 2019
ZoeB
Yeah, there are the tag files, thank you!
2019-05-15 13509, 2019
yvanzo
np :)
2019-05-15 13505, 2019
zas
yvanzo: done
2019-05-15 13511, 2019
yvanzo
zas: thank you, asking for feedback on community
2019-05-15 13525, 2019
ZoeB has left the channel
2019-05-15 13531, 2019
Lotheric has quit
2019-05-15 13535, 2019
yvanzo
zas: just checked bug history, it’s been first reported on 12th May on #musicbrainz, that is the day before schema change release.
2019-05-15 13538, 2019
zas
first caching changes started on 11th, so it might be it. Since i changed minor things, that may have affect the behavior. I think I'll disable this stuff completly before re-introducing it more cleanly. It's rather interesting, but it needs to be tuned, per service.
