It seems to be the entire diff, not one side of it?
2019-05-27 14704, 2019
reosarevok
Or oh, no, ok, it's one side
2019-05-27 14718, 2019
reosarevok
But then it's confusing :D
2019-05-27 14735, 2019
bitmap
yeah, I think I just used the TT names
2019-05-27 14748, 2019
reosarevok
Wouldn't it be easier to have the old and new be one thing, instead of passing the stuff twice one with DELETE and one with INSERT?
2019-05-27 14702, 2019
bitmap
I don't remember, will have to check :) pretty sure that's how the TT does it though
2019-05-27 14734, 2019
bitmap
also it's memorial day here so everyone is slacking off & I might be afk during the meeting today
2019-05-27 14705, 2019
Gore|work has quit
2019-05-27 14738, 2019
reosarevok
haha
2019-05-27 14745, 2019
reosarevok had to go search what that was. Some military thing. Ok then! It still feels a bit weird to an European to have a specific holiday for that but :D (make sure to send Freso something if you are away ;) )
2019-05-27 14757, 2019
Mr_Monkey
Hi akhilesh !
2019-05-27 14727, 2019
alastairp
iliekcomputers: ready when you are
2019-05-27 14757, 2019
spellew
Hi o/
2019-05-27 14758, 2019
spellew
ferbncode: I do have a few questions
2019-05-27 14726, 2019
spellew
I'm a bit confused about works, and the difference between a work and a recording. Especially when a work is a song.
2019-05-27 14751, 2019
spellew
Is there enough distinction to write reviews?
2019-05-27 14738, 2019
pristine__
iliekcomputers: hey
2019-05-27 14745, 2019
pristine__
let me know when you're up?
2019-05-27 14727, 2019
pristine__
I am facing some problem, since ruaok is afk maybe we can try to debug.
2019-05-27 14712, 2019
aidanlw17
alastairp: After setting up the database with the dumps, I get `ERROR: permission denied for relation x` when querying unless I use super user. Any idea how I can correct this?
2019-05-27 14731, 2019
ferbncode
spellew: A work could be a novel, play, poem or essay, later recorded as an oratory or audiobook. (From https://musicbrainz.org/doc/Work) For example: https://musicbrainz.org/work/65f77aa0-d805-4798-9… is a work of type prose. I think there is a good line that we want to support review for work. IIUC, A work of type song might be completely different from a original recording by the same artist.
because you ran the import as the postgres user to correctly install all of the extensions, for some reason it seems to have left all of the tables owned by the postgres user
2019-05-27 14740, 2019
alastairp
so the regular user can't read them
2019-05-27 14751, 2019
alastairp
so you can change all of them, using something like the linked answer
2019-05-27 14749, 2019
aidanlw17
alastairp: thanks I'll check that out. Do you know why `GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA public TO acousticbrainz;` does not give us the result?
2019-05-27 14718, 2019
spellew
ferbncode: I get it now, thanks.
2019-05-27 14740, 2019
amCap1712
hi all
2019-05-27 14705, 2019
pristine__
amCap1712: hey :)
2019-05-27 14739, 2019
amCap1712
hi pristine__
2019-05-27 14740, 2019
alastairp
good question, I'm not sure from the back of my head
2019-05-27 14746, 2019
amCap1712
how are you doing
2019-05-27 14721, 2019
iliekcomputers
alastairp: hi, sorry, i'm here.
2019-05-27 14736, 2019
iliekcomputers
pristine__: yep, sure, as soon as I'm done with AB stuff.
2019-05-27 14754, 2019
alastairp
OK. so where are we at? I see a tag from v-2019-03-05.0. is that our last release?
2019-05-27 14715, 2019
iliekcomputers
alastairp: yes, that fixed the SEC issues
2019-05-27 14719, 2019
iliekcomputers
as far as I remember.
2019-05-27 14731, 2019
alastairp
I don't think so. I think that was from much earlier
2019-05-27 14741, 2019
alastairp
the previous SEC fixes we made haven't been merged yet
one thing that's missing is we still don't have `psql` in the web container
2019-05-27 14702, 2019
alastairp
the script to run is a one-liner, so maybe we can run it some other way? Otherwise I'm happy to put it back into the image if this works best for how you deploy/manage the app
2019-05-27 14708, 2019
iliekcomputers
that should not be a big problem.
2019-05-27 14714, 2019
iliekcomputers
i can run it inside the postgres container.
2019-05-27 14738, 2019
alastairp
OK
2019-05-27 14751, 2019
alastairp
so do you want to tag + build?
2019-05-27 14718, 2019
iliekcomputers
one sec, i was just looking for the schema change script.
should I do the schema change before deploying the new container or after?
2019-05-27 14718, 2019
alastairp
ah, sorry - I don't think you're up to date with how we did this patch
2019-05-27 14720, 2019
alastairp
it's in 3 parts
2019-05-27 14737, 2019
alastairp
first part adds the table, and has a script to populate it. nothing read/writes this column
2019-05-27 14701, 2019
alastairp
second part we will do a small downtime and run the script one last time before deploying, then submissions will start to write this column
2019-05-27 14706, 2019
alastairp
last part will read from the column
2019-05-27 14751, 2019
iliekcomputers
ah. okay.
2019-05-27 14752, 2019
alastairp
so for now, let's release with minimal downtime. it doesn't matter if we run the migration script after the deploy
2019-05-27 14758, 2019
iliekcomputers
so it doesn't matter right now
2019-05-27 14702, 2019
alastairp
yep
2019-05-27 14704, 2019
iliekcomputers
hmm, great minds :)
2019-05-27 14715, 2019
iliekcomputers
i'll do the schema change first then.
2019-05-27 14721, 2019
alastairp
merging the second part will have a small downtime while we populate any missing values (but this should be very short as we can run it one last time while AB is still up before we do the deploy)
akhilesh: I think as we discussed previously, you should start by outlining and setting up the general structure of the project (seeing what parts of the code you will be reusing/refactoring from the sebsite code), and start writing test outlines (only the description for the test) for one entity endpoint.
akhilesh: Yes, start a new branch and open a W.I.P PR. Eventually it will get merged into master. We may also consider closing that PR and opening new ones if there are clear standalon units of work, but we'll see when we get to it.
2019-05-27 14758, 2019
pristine__
ummm.....but I somehow managed
2019-05-27 14709, 2019
pristine__
see you at the meeting :)
2019-05-27 14741, 2019
alastairp
iliekcomputers: whoops, missed your messages
2019-05-27 14743, 2019
alastairp
thanks
2019-05-27 14754, 2019
alastairp
we have some new features, I'll tweet when i get home
