#metabrainz

bitmap, reosarevok: I finished converting edit_alias.tt. Tested it too

Im not raising a PR as bitmap hasnt merged his PR with addition of Diff, FullChangeDiff components

What should I get on with next ?

amCap1712: it'll return a 401 saying the credentials could not be verified

thanks bitmap

Cyna: well we'll need to convert the alias add/edit forms to React, under root/entity/alias/

then implement a preview component that displays the edits you converted

Hmm... I'll get on the conversion tomorrow after my Practicals

what is script_manifest(...) ?

it looks up a script and returns the public, versioned URL for it

dont understand

(and outputs a <script> tag for it)

it takes a file name relative to root/static/scripts/, so that refers to root/static/scripts/edit.js

this is the entry point for a webpack bundle

the actual bundle file as served to the public will have a hash added for caching, and a URL, in this case on https://staticbrainz.org/MB/

so its basically `publicUrl + something`

something is derived from the script

right ?

basically

the "manifest" is https://staticbrainz.org/MB/rev-manifest.json

bitmap: if the authorization header is set to empty that is also considered inavlid access token

that has scripts/edit.js: "scripts/edit-4da2c51e9d.js"

so it knows the edit bundle will be named like scripts/edit-4da2c51e9d.js at the public url

and it's a hash of the file contents, so if the bundle changes, so will the hash (and clients will download the new copy instead of the old, since it has a different name)

ferbncode: iliekcomputers: I've opened the draft pr

amCap1712: it also returns a 401, but with a different message ("You are not authorized to access this resource.")

ok thanks again

is there any other documentation on Oauth other than https://musicbrainz.org/doc/Development/OAuth2

I don't think so

okay, i asked because i couldn't find any info or error codes there

edit.js in /root/static/server/ is a bunch of import commands and nothing else

edit_form.tt runs the script manifest command on edit.js

hows does it get reflected on add alias form page ?

amCap1712: the error code are based on standards right ? https://www.tutorialspoint.com/http/http_status...

spellew: thanks. :)

it's not including or running that file directly - edit.js is the entry point for a webpack bundle

webpack is run via ./script/compile_resources.sh and the bundles go to root/static/build/

script_manifest simply looks up edit.js in the manifest and outputs a <script> tag pointing to the bundle url

Ohh so its basically converting the js file to a script tag and placing it there ?

cyna: yes, i meant like the error messages to be specific like bitmap told above about 401 for two scenarios but different error msg to distinguish

ohh

well it doesn't convert the file there, that's done by ./script/compile_resources.sh

How do I put it in react file then 🤔

it's taking the js file *name* and outputting a script tag

those utilities have already been converted to JS at root/static/manifest.js

git grep -F manifest.js

thanks

Will check it out

spellew: thanks :)

just in case someone is using docker for anything :p https://seclists.org/oss-sec/2019/q2/131

SothoTalKer: thanks ;)

"<pristine__> any user must have listened to a song that involves various artists, we can then get similar artists from the histogram project and recommend songs from a pool which belong to these related artists" I think the VA based histogram project is very cool, but I also feel like this approach (of using VA albums as a base for artist similarity) may exclude a lot of smaller and newer or just straight up less mainstream (with

"mainstream" meaning "mainstream in Western mostly-English locales") artists. Both based on bias of more mainstrain = on more compilations (incl. on compilations at all!) and also of the bias in the data available/the historical userbase. It also excludes artists that aren’t following the typical Release workflow, but only does standalone recordings on SoundCloud or YouTube etc. I'd rather get recommended smaller, less mainstreamy

artists than artists that happen to have been on dozens of compilations.

Anyway, I also realize that this is a difficult problem, so I’m not saying to drop this approach; I just really hope all the downfalls of this approach won’t be forgotten once there is something Good Enough™ in place. :) (And I’m sure you and Rob have thought about these limitations, I just didn’t see either of you express them here in the channel.)

oh definitly.

I'm thinking about Mash-upers like who have a lot of standalone recordings